@jskit-ai/shell-web 0.1.79 → 0.1.81

package/package.descriptor.mjs

@@ -1,7 +1,7 @@
 export default Object.freeze({
   packageVersion: 1,
   packageId: "@jskit-ai/shell-web",
-  version: "0.1.79",
+  version: "0.1.81",
   kind: "runtime",
   description: "Web shell layout runtime with outlet-based placement contributions.",
   dependsOn: [],
@@ -291,7 +291,7 @@ export default Object.freeze({
     dependencies: {
       runtime: {
         "@mdi/js": "^7.4.47",
-        "@jskit-ai/kernel": "0.1.80"
+        "@jskit-ai/kernel": "0.1.82"
       },
       dev: {}
     },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jskit-ai/shell-web",
-  "version": "0.1.79",
+  "version": "0.1.81",
   "type": "module",
   "scripts": {
     "test": "node --test"
@@ -26,7 +26,7 @@
   },
   "dependencies": {
     "@mdi/js": "^7.4.47",
-    "@jskit-ai/kernel": "0.1.80"
+    "@jskit-ai/kernel": "0.1.82"
   },
   "peerDependencies": {
     "pinia": "^3.0.4",

package/src/client/lib/menuIcons.js

@@ -1,4 +1,3 @@
-import * as mdiIcons from "@mdi/js";
 import {
   mdiAccountCircleOutline,
   mdiAccountCogOutline,
@@ -27,6 +26,24 @@ const SURFACE_SWITCH_ICON_BY_ID = Object.freeze({
   console: mdiConsoleNetworkOutline
 });
 
+const SUPPORTED_EXPLICIT_MDI_ICON_BY_NAME = Object.freeze({
+  "mdi-account-circle-outline": mdiAccountCircleOutline,
+  "mdi-account-cog-outline": mdiAccountCogOutline,
+  "mdi-account-group-outline": mdiAccountGroupOutline,
+  "mdi-arrow-right-circle-outline": mdiArrowRightCircleOutline,
+  "mdi-clipboard-list-outline": mdiClipboardListOutline,
+  "mdi-cog-outline": mdiCogOutline,
+  "mdi-console-network-outline": mdiConsoleNetworkOutline,
+  "mdi-folder-outline": mdiFolderOutline,
+  "mdi-home-variant-outline": mdiHomeVariantOutline,
+  "mdi-login": mdiLogin,
+  "mdi-logout": mdiLogout,
+  "mdi-robot-outline": mdiRobotOutline,
+  "mdi-shield-crown-outline": mdiShieldCrownOutline,
+  "mdi-view-dashboard-outline": mdiViewDashboardOutline,
+  "mdi-view-list-outline": mdiViewListOutline
+});
+
 function resolveExplicitIconValue(explicitIcon = "") {
   const normalizedExplicitIcon = normalizeText(explicitIcon);
   if (!normalizedExplicitIcon) {
@@ -37,13 +54,7 @@ function resolveExplicitIconValue(explicitIcon = "") {
     return normalizedExplicitIcon;
   }
 
-  const iconKey = normalizedExplicitIcon
-    .slice("mdi-".length)
-    .split("-")
-    .map((segment) => segment.charAt(0).toUpperCase() + segment.slice(1))
-    .join("");
-  const exportName = `mdi${iconKey}`;
-  const resolvedIcon = mdiIcons[exportName];
+  const resolvedIcon = SUPPORTED_EXPLICIT_MDI_ICON_BY_NAME[normalizedExplicitIcon];
   return typeof resolvedIcon === "string" && resolvedIcon ? resolvedIcon : normalizedExplicitIcon;
 }
 

package/test/menuIcons.test.js

@@ -0,0 +1,37 @@
+import assert from "node:assert/strict";
+import path from "node:path";
+import test from "node:test";
+import { readFile } from "node:fs/promises";
+import { fileURLToPath } from "node:url";
+import {
+  mdiCogOutline,
+  mdiConsoleNetworkOutline,
+  mdiViewListOutline
+} from "@mdi/js";
+import {
+  resolveMenuLinkIcon,
+  resolveSurfaceSwitchIcon
+} from "../src/client/lib/menuIcons.js";
+
+const TEST_DIRECTORY = path.dirname(fileURLToPath(import.meta.url));
+const PACKAGE_DIR = path.resolve(TEST_DIRECTORY, "..");
+
+test("shell-web resolves supported explicit mdi metadata icons from a finite map", () => {
+  assert.equal(resolveMenuLinkIcon({ icon: "mdi-view-list-outline" }), mdiViewListOutline);
+  assert.equal(resolveMenuLinkIcon({ icon: "mdi-cog-outline" }), mdiCogOutline);
+  assert.equal(
+    resolveSurfaceSwitchIcon("home", "mdi-console-network-outline"),
+    mdiConsoleNetworkOutline
+  );
+});
+
+test("shell-web leaves unknown explicit mdi metadata icons unchanged", () => {
+  assert.equal(resolveMenuLinkIcon({ icon: "mdi-not-a-real-supported-icon" }), "mdi-not-a-real-supported-icon");
+});
+
+test("shell-web menu icon resolution does not import the full mdi namespace", async () => {
+  const source = await readFile(path.join(PACKAGE_DIR, "src", "client", "lib", "menuIcons.js"), "utf8");
+
+  assert.doesNotMatch(source, /import\s+\*\s+as\s+mdiIcons\s+from\s+["']@mdi\/js["']/);
+  assert.doesNotMatch(source, /mdiIcons\[/);
+});