@jskit-ai/shell-web 0.1.128 → 0.1.130

package/package.descriptor.mjs

@@ -1,7 +1,7 @@
 export default Object.freeze({
   packageVersion: 1,
   packageId: "@jskit-ai/shell-web",
-  version: "0.1.128",
+  version: "0.1.130",
   kind: "runtime",
   description: "Web shell layout runtime with outlet-based placement contributions.",
   dependsOn: [],
@@ -311,7 +311,7 @@ export default Object.freeze({
     dependencies: {
       runtime: {
         "@mdi/js": "^7.4.47",
-        "@jskit-ai/kernel": "0.1.127"
+        "@jskit-ai/kernel": "0.1.129"
       },
       dev: {
         "@playwright/test": "1.61.1"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jskit-ai/shell-web",
-  "version": "0.1.128",
+  "version": "0.1.130",
   "type": "module",
   "scripts": {
     "test": "node --test"
@@ -28,7 +28,7 @@
   },
   "dependencies": {
     "@mdi/js": "^7.4.47",
-    "@jskit-ai/kernel": "0.1.127"
+    "@jskit-ai/kernel": "0.1.129"
   },
   "peerDependencies": {
     "pinia": "^3.0.4",

package/src/client/components/ShellLayout.vue

@@ -490,6 +490,11 @@ function touchListIncludesActiveTouch(touchList) {
   min-width: 0;
 }
 
+.shell-layout__nav-toggle {
+  min-height: 48px;
+  min-width: 48px;
+}
+
 .shell-layout__top-right {
   max-width: min(45vw, 18rem);
   overflow: hidden;

package/src/test/adaptiveShellSmoke.js

@@ -68,6 +68,48 @@ async function isElementVisibleInViewport(page, testId) {
   });
 }
 
+async function runAdaptiveShellSmokeCase({
+  page,
+  expect,
+  smokePath = DEFAULT_SMOKE_PATH,
+  viewport
+} = {}) {
+  if (!page || !expect || !viewport) {
+    throw new Error("runAdaptiveShellSmokeCase requires page, expect, and viewport.");
+  }
+
+  await page.setViewportSize({ width: viewport.width, height: viewport.height });
+  await page.goto(smokePath);
+  await expect(page.locator("body")).toBeVisible();
+  await expectGeneratedScreenContract(page, expect);
+  await expectNoHorizontalOverflow(page, expect);
+
+  if (viewport.name === "compact") {
+    let bootstrapRequests = 0;
+    await page.route("**/api/bootstrap**", async (route) => {
+      bootstrapRequests += 1;
+      await route.continue();
+    });
+    const bootstrapRequestsBeforePull = bootstrapRequests;
+
+    await expect(page.getByTestId("jskit-shell-bottom-nav")).toBeVisible();
+    expect(await isElementVisibleInViewport(page, "jskit-shell-drawer")).toBe(false);
+
+    const navButtonHeights = await page.getByTestId("jskit-shell-bottom-nav").locator(".v-btn").evaluateAll((buttons) =>
+      buttons.map((button) => button.getBoundingClientRect().height)
+    );
+    expect(navButtonHeights.length).toBeGreaterThan(0);
+    for (const height of navButtonHeights) {
+      expect(height).toBeGreaterThanOrEqual(48);
+    }
+
+    await pullToRefresh(page, expect);
+    await expect.poll(() => bootstrapRequests).toBeGreaterThan(bootstrapRequestsBeforePull);
+  } else {
+    await expect(page.getByTestId("jskit-shell-drawer")).toBeVisible();
+  }
+}
+
 function runAdaptiveShellSmoke({
   test,
   expect,
@@ -81,39 +123,10 @@ function runAdaptiveShellSmoke({
   test.describe("generated adaptive shell smoke", () => {
     for (const viewport of viewports) {
       test(`${viewport.name} layout has reachable navigation and no horizontal overflow`, async ({ page }) => {
-        await page.setViewportSize({ width: viewport.width, height: viewport.height });
-        await page.goto(smokePath);
-        await expect(page.locator("body")).toBeVisible();
-        await expectGeneratedScreenContract(page, expect);
-        await expectNoHorizontalOverflow(page, expect);
-
-        if (viewport.name === "compact") {
-          let bootstrapRequests = 0;
-          await page.route("**/api/bootstrap**", async (route) => {
-            bootstrapRequests += 1;
-            await route.continue();
-          });
-          const bootstrapRequestsBeforePull = bootstrapRequests;
-
-          await expect(page.getByTestId("jskit-shell-bottom-nav")).toBeVisible();
-          expect(await isElementVisibleInViewport(page, "jskit-shell-drawer")).toBe(false);
-
-          const navButtonHeights = await page.getByTestId("jskit-shell-bottom-nav").locator(".v-btn").evaluateAll((buttons) =>
-            buttons.map((button) => button.getBoundingClientRect().height)
-          );
-          expect(navButtonHeights.length).toBeGreaterThan(0);
-          for (const height of navButtonHeights) {
-            expect(height).toBeGreaterThanOrEqual(48);
-          }
-
-          await pullToRefresh(page, expect);
-          await expect.poll(() => bootstrapRequests).toBeGreaterThan(bootstrapRequestsBeforePull);
-        } else {
-          await expect(page.getByTestId("jskit-shell-drawer")).toBeVisible();
-        }
+        await runAdaptiveShellSmokeCase({ page, expect, smokePath, viewport });
       });
     }
   });
 }
 
-export { DEFAULT_VIEWPORTS, runAdaptiveShellSmoke };
+export { DEFAULT_VIEWPORTS, runAdaptiveShellSmoke, runAdaptiveShellSmokeCase };

package/templates/tests/e2e/adaptive-shell.spec.ts

@@ -1,4 +1,10 @@
 import { expect, test } from "@playwright/test";
-import { runAdaptiveShellSmoke } from "@jskit-ai/shell-web/test/adaptiveShellSmoke";
+import { DEFAULT_VIEWPORTS, runAdaptiveShellSmokeCase } from "@jskit-ai/shell-web/test/adaptiveShellSmoke";
 
-runAdaptiveShellSmoke({ test, expect });
+test.describe("generated adaptive shell smoke", () => {
+  for (const viewport of DEFAULT_VIEWPORTS) {
+    test(`${viewport.name} layout has reachable navigation and no horizontal overflow`, async ({ page }) => {
+      await runAdaptiveShellSmokeCase({ page, expect, viewport });
+    });
+  }
+});

package/test/settingsPlacementContract.test.js

@@ -77,6 +77,7 @@ test("shell-web shell layout registers navigation at the app layout level", asyn
   assert.match(source, /<ShellRouteTransition>[\s\S]*<slot \/>[\s\S]*<\/ShellRouteTransition>/);
   assert.match(source, /data-testid="jskit-shell-app-bar"/);
   assert.match(source, /:density="isCompactLayout \? 'compact' : 'comfortable'"/);
+  assert.match(source, /\.shell-layout__nav-toggle\s*\{[\s\S]*min-height:\s*48px;[\s\S]*min-width:\s*48px;/);
   assert.match(source, /shell-layout__surface-label/);
   assert.doesNotMatch(source, /shell-layout__surface-chip/);
   assert.doesNotMatch(source, /<v-chip[^>]*resolvedSurfaceLabel/);
@@ -140,7 +141,10 @@ test("shell-web installs generated adaptive shell Playwright smoke coverage", as
     profile: "responsive-smoke",
     sourceName: "adaptiveShellSmoke.js"
   });
-  assert.match(source, /runAdaptiveShellSmoke/);
+  assert.match(source, /DEFAULT_VIEWPORTS, runAdaptiveShellSmokeCase/);
+  assert.match(source, /test\(`/);
+  assert.match(source, /runAdaptiveShellSmokeCase\(\{ page, expect, viewport \}\)/);
+  assert.doesNotMatch(source, /runAdaptiveShellSmoke\(\{/);
   assert.match(source, /@jskit-ai\/shell-web\/test\/adaptiveShellSmoke/);
   assert.match(helperSource, /generated adaptive shell smoke/);
   assert.match(helperSource, /390/);