@jskit-ai/jskit-cli 0.2.89 → 0.2.90
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +4 -4
- package/src/server/commandHandlers/session.js +173 -142
- package/src/server/core/argParser.js +0 -4
- package/src/server/core/commandCatalog.js +47 -35
- package/src/server/sessionRuntime/constants.js +125 -348
- package/src/server/sessionRuntime/io.js +2 -2
- package/src/server/sessionRuntime/preconditions.js +39 -143
- package/src/server/sessionRuntime/promptRenderer.js +2 -15
- package/src/server/sessionRuntime/prompts/app_blueprint.md +2 -7
- package/src/server/sessionRuntime/prompts/{automated_checks.md → automated_checks_run.md} +2 -17
- package/src/server/sessionRuntime/prompts/{update_blueprint.md → blueprint_updated.md} +2 -11
- package/src/server/sessionRuntime/prompts/{deep_ui_check.md → deep_ui_check_run.md} +2 -19
- package/src/server/sessionRuntime/prompts/final_report_created.md +44 -0
- package/src/server/sessionRuntime/prompts/issue_created.md +26 -0
- package/src/server/sessionRuntime/prompts/issue_prompt_rendered.md +1 -0
- package/src/server/sessionRuntime/prompts/{plan_issue.md → make_plan.md} +8 -37
- package/src/server/sessionRuntime/prompts/{execute_plan.md → plan_executed.md} +4 -29
- package/src/server/sessionRuntime/prompts/{prepare_pr_merge.md → pr_merge_prepared.md} +3 -3
- package/src/server/sessionRuntime/prompts/{resolve_deslop_findings.md → review_changes_accepted_resolve.md} +2 -6
- package/src/server/sessionRuntime/prompts/{review_changes.md → review_prompt_rendered.md} +3 -28
- package/src/server/sessionRuntime/prompts/{user_check.md → user_check_completed.md} +1 -11
- package/src/server/sessionRuntime/responses.js +431 -292
- package/src/server/sessionRuntime.js +1201 -926
- package/src/server/sessionRuntime/prompts/issue_details.md +0 -49
- package/src/server/sessionRuntime/prompts/new_issue.md +0 -46
|
@@ -4,24 +4,14 @@ GitHub issue: {{issue_url}}
|
|
|
4
4
|
Issue number: {{issue_number}}
|
|
5
5
|
Issue title: {{issue_title}}
|
|
6
6
|
Issue body file: {{issue_file}}
|
|
7
|
-
Issue details file (`issue_details.md`): {{issue_details_file}}
|
|
8
|
-
Plan file: {{plan_file}}
|
|
9
7
|
Worktree: {{worktree}}
|
|
10
8
|
|
|
11
|
-
|
|
12
|
-
|
|
13
|
-
{{issue_details_text}}
|
|
14
|
-
|
|
15
|
-
Approved plan:
|
|
16
|
-
|
|
17
|
-
{{plan_text}}
|
|
18
|
-
|
|
19
|
-
Implement the plan in the session worktree. Keep the change scoped to the issue, confirmed issue details, and approved plan.
|
|
9
|
+
Implement the plan that was just reviewed in this Codex conversation. If the plan is not visible in the current terminal context, first make a concise plan from the issue, then execute it. Keep the change scoped to the issue.
|
|
20
10
|
|
|
21
11
|
Implementation rules:
|
|
22
12
|
|
|
23
13
|
- Inspect the current app before editing. App setup has already passed; if required JSKIT app files are missing, report setup failure rather than inventing recovery work.
|
|
24
|
-
- Follow
|
|
14
|
+
- Follow `{{issue_file}}`. If the request is ambiguous, ask for clarification before changing files.
|
|
25
15
|
- Before implementing JSKIT app structure, generators, CRUD, surfaces, placements, app setup, package-owned workflows, or UI verification paths, read the relevant JSKIT agent docs. Start with `node_modules/@jskit-ai/agent-docs/DISTR_AGENT.md`, `node_modules/@jskit-ai/agent-docs/guide/agent/index.md`, and `node_modules/@jskit-ai/agent-docs/patterns/INDEX.md` when present. If working inside the JSKIT monorepo or a devlinked sibling, use `packages/agent-docs/...` as the source-tree equivalent.
|
|
26
16
|
- Read specific pattern docs before touching their lane, such as CRUD scaffolding/repository mapping, page scaffolding, surfaces, placements, client requests, live actions, generated UI contract tracking, and UI testing. Prefer these docs and package descriptors over reverse-engineering framework rules from source files.
|
|
27
17
|
- Read `.jskit/helper-map.md` when it exists before creating helpers, composables, service functions, maps, or package glue.
|
|
@@ -34,7 +24,7 @@ Implementation rules:
|
|
|
34
24
|
- Keep direct knex exceptional and minimal. Prefer internal json-rest-api seams outside generated CRUD packages and explicit weird-custom feature lanes.
|
|
35
25
|
- Keep runtime, UI, and data concerns separated.
|
|
36
26
|
- Avoid accidental scope expansion.
|
|
37
|
-
- Do not create `.jskit/WORKBOARD.md`; the session files
|
|
27
|
+
- Do not create `.jskit/WORKBOARD.md`; the session files are the workflow record.
|
|
38
28
|
- If user-facing UI changes, bring the screen to Material Design and Vuetify quality before calling it done. Include coherent responsive layout, loading, empty, error, disabled, and success states where relevant.
|
|
39
29
|
- If verification needs login, use the app's local development auth bootstrap path rather than a live external auth login.
|
|
40
30
|
|
|
@@ -44,21 +34,6 @@ After making changes:
|
|
|
44
34
|
- Run the smallest relevant checks you can run safely in the worktree.
|
|
45
35
|
- For changed user-facing UI, run or clearly identify the Playwright verification path. When possible, record UI verification with `npx --no-install jskit app verify-ui --command "<playwright command>" --feature "<label>" --auth-mode <mode>`.
|
|
46
36
|
- `npx --no-install jskit app verify-ui` does not start the app server. Before using it for Playwright, make sure the app is reachable. If a local server is needed, inspect `.jskit/config/testrun_command` when present and use the app's documented server command, or start the server explicitly and wait for it before invoking `verify-ui`. Do not first run a bare Playwright command against a stopped server.
|
|
47
|
-
- Summarize changed files and
|
|
48
|
-
- If implementation deviated from the approved plan, generator choices, package ownership, helper reuse, UI verification path, or data ownership, include concise decision entries with reasons in this exact marker block:
|
|
49
|
-
|
|
50
|
-
```text
|
|
51
|
-
[agent_decisions]
|
|
52
|
-
<implementation decisions or "No new decisions.">
|
|
53
|
-
[/agent_decisions]
|
|
54
|
-
```
|
|
37
|
+
- Summarize changed files, checks run, and any important implementation decisions or verification gaps in the terminal.
|
|
55
38
|
|
|
56
39
|
Do not create commits, branches, issues, pull requests, merges, or worktree cleanup yourself. JSKIT session will handle those steps.
|
|
57
|
-
|
|
58
|
-
At the very end, include this completion block so Studio knows the step is complete:
|
|
59
|
-
|
|
60
|
-
[jskit_step_result]
|
|
61
|
-
status: complete
|
|
62
|
-
step: plan_executed
|
|
63
|
-
summary: Short summary of what changed and what was checked.
|
|
64
|
-
[/jskit_step_result]
|
|
@@ -7,9 +7,9 @@ Branch: {{branch}}
|
|
|
7
7
|
Base branch: {{base_branch}}
|
|
8
8
|
Pull request: {{pr_url}}
|
|
9
9
|
Issue: {{issue_url}}
|
|
10
|
-
|
|
10
|
+
Pull request file: {{pull_request_file}}
|
|
11
11
|
|
|
12
|
-
Your job is to get the pull request into a state where the user can
|
|
12
|
+
Your job is to do whatever is needed, within the session scope, to get the pull request into a state where the user can press the JSKIT Merge button.
|
|
13
13
|
|
|
14
14
|
Required boundaries:
|
|
15
15
|
|
|
@@ -17,6 +17,6 @@ Required boundaries:
|
|
|
17
17
|
- Resolve merge conflicts or failing checks if the fix is clear and in scope.
|
|
18
18
|
- Commit and push any preparation changes to the session branch.
|
|
19
19
|
- Do not merge the pull request.
|
|
20
|
-
- Do not remove the worktree, archive the session, update the local base branch, or write JSKIT
|
|
20
|
+
- Do not remove the worktree, archive the session, update the local base branch, or write JSKIT session state. JSKIT owns deterministic cleanup after the user decides.
|
|
21
21
|
|
|
22
22
|
When you are done, summarize what you checked, what changed, and whether you believe the PR is ready for the user to merge.
|
|
@@ -1,13 +1,9 @@
|
|
|
1
|
-
Resolve the
|
|
1
|
+
Resolve the important findings from the latest deslop review in this conversation.
|
|
2
2
|
|
|
3
|
-
Fix only
|
|
3
|
+
Fix only those findings. Keep scope tight. Do not create commits, branches, issues, pull requests, merges, or worktree cleanup.
|
|
4
4
|
|
|
5
5
|
Use existing JSKIT helpers, generators, package seams, and app-local helpers where they fit. Do not introduce helper churn or unrelated refactors while resolving these findings.
|
|
6
6
|
|
|
7
|
-
[resolve_deslop_findings]
|
|
8
|
-
{{findings}}
|
|
9
|
-
[/resolve_deslop_findings]
|
|
10
|
-
|
|
11
7
|
When finished:
|
|
12
8
|
|
|
13
9
|
- Summarize the exact findings fixed.
|
|
@@ -6,9 +6,9 @@ Changed files in the current session worktree:
|
|
|
6
6
|
|
|
7
7
|
{{changed_files}}
|
|
8
8
|
|
|
9
|
-
Review the current worktree changes, but do not silently fix everything you find unless
|
|
9
|
+
Review the current worktree changes, but do not silently fix everything you find unless the user explicitly sends the resolve deslop prompt.
|
|
10
10
|
|
|
11
|
-
|
|
11
|
+
Inspect the worktree and produce a short, prioritized list of important findings. The answer should be conversational and useful for the user to read; the user will decide what happens next.
|
|
12
12
|
|
|
13
13
|
Use priorities this way:
|
|
14
14
|
|
|
@@ -16,7 +16,7 @@ Use priorities this way:
|
|
|
16
16
|
- `medium`: maintainability, meaningful duplication, missing required state, weak JSKIT reuse, important verification gap, or visible UI quality issue inside the requested scope.
|
|
17
17
|
- `low`: polish, optional cleanup, copy tuning, minor test expansion, or judgment-call improvements the user should decide on.
|
|
18
18
|
|
|
19
|
-
If
|
|
19
|
+
If the user later sends the resolve deslop prompt, fix the important findings from this deslop review in the current worktree. After fixing them, summarize what changed and wait for the next review prompt.
|
|
20
20
|
|
|
21
21
|
If there are no important findings, say so explicitly and do not make cosmetic churn.
|
|
22
22
|
|
|
@@ -59,28 +59,3 @@ Use four passes:
|
|
|
59
59
|
Do not create commits, branches, pull requests, merges, or worktree cleanup yourself. JSKIT session owns those steps.
|
|
60
60
|
|
|
61
61
|
When finished, report the findings considered, fixes made during this pass if any, changed files, checks run, and anything still unverified. If there are no important findings, say so explicitly and list residual risk.
|
|
62
|
-
|
|
63
|
-
At the very end of each review answer, include this block. Keep it plain text, not JSON:
|
|
64
|
-
|
|
65
|
-
[deslop_result]
|
|
66
|
-
priority: high | medium | low
|
|
67
|
-
category: bug | maintainability | jskit | ui | verification | content | other
|
|
68
|
-
title: Short finding title
|
|
69
|
-
files:
|
|
70
|
-
- path/to/file
|
|
71
|
-
reason: Why this matters
|
|
72
|
-
recommended_action: What should be done
|
|
73
|
-
|
|
74
|
-
priority: low
|
|
75
|
-
category: other
|
|
76
|
-
title: Another optional finding
|
|
77
|
-
files:
|
|
78
|
-
- path/to/file
|
|
79
|
-
reason: Why this is optional
|
|
80
|
-
recommended_action: What the user may choose to do
|
|
81
|
-
[/deslop_result]
|
|
82
|
-
|
|
83
|
-
If there are no findings, return an empty result block:
|
|
84
|
-
|
|
85
|
-
[deslop_result]
|
|
86
|
-
[/deslop_result]
|
|
@@ -1,21 +1,11 @@
|
|
|
1
|
-
|
|
1
|
+
Complete user check for session {{session_id}}.
|
|
2
2
|
|
|
3
3
|
Issue: {{issue_url}}
|
|
4
4
|
Issue title: {{issue_title}}
|
|
5
5
|
Issue body file: {{issue_file}}
|
|
6
|
-
Issue details file (`issue_details.md`): {{issue_details_file}}
|
|
7
|
-
Plan file: {{plan_file}}
|
|
8
6
|
|
|
9
7
|
The code should already be built or runnable according to the implementation instructions.
|
|
10
8
|
|
|
11
|
-
Confirmed issue details:
|
|
12
|
-
|
|
13
|
-
{{issue_details_text}}
|
|
14
|
-
|
|
15
|
-
Approved plan:
|
|
16
|
-
|
|
17
|
-
{{plan_text}}
|
|
18
|
-
|
|
19
9
|
Ask the user to test the changed behavior in the app and report whether it works as intended. Be specific about the user-visible behavior, route, command, or workflow to inspect.
|
|
20
10
|
|
|
21
11
|
If the user finds a problem, diagnose the root cause and fix it in this worktree. Keep the fix scoped. Reuse JSKIT helpers, generated seams, and package workflows where they apply.
|