@jskit-ai/crud-server-generator 0.1.66 → 0.1.67

package/package.descriptor.mjs

@@ -1,7 +1,7 @@
 export default Object.freeze({
   packageVersion: 1,
   packageId: "@jskit-ai/crud-server-generator",
-  version: "0.1.66",
+  version: "0.1.67",
   kind: "generator",
   description: "CRUD server generator with routes, actions, and persistence scaffolding.",
   options: {
@@ -152,14 +152,14 @@ export default Object.freeze({
   mutations: {
     dependencies: {
       runtime: {
-        "@jskit-ai/auth-core": "0.1.57",
-        "@jskit-ai/crud-core": "0.1.66",
-        "@jskit-ai/database-runtime": "0.1.58",
-        "@jskit-ai/http-runtime": "0.1.57",
-        "@jskit-ai/json-rest-api-core": "0.1.3",
-        "@jskit-ai/kernel": "0.1.58",
-        "@jskit-ai/realtime": "0.1.57",
-        "@jskit-ai/resource-crud-core": "0.1.3",
+        "@jskit-ai/auth-core": "0.1.58",
+        "@jskit-ai/crud-core": "0.1.67",
+        "@jskit-ai/database-runtime": "0.1.59",
+        "@jskit-ai/http-runtime": "0.1.58",
+        "@jskit-ai/json-rest-api-core": "0.1.4",
+        "@jskit-ai/kernel": "0.1.59",
+        "@jskit-ai/realtime": "0.1.58",
+        "@jskit-ai/resource-crud-core": "0.1.4",
         "@local/${option:namespace|kebab}": "file:packages/${option:namespace|kebab}"
       },
       dev: {}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jskit-ai/crud-server-generator",
-  "version": "0.1.66",
+  "version": "0.1.67",
   "type": "module",
   "scripts": {
     "test": "node --test"
@@ -13,12 +13,12 @@
   },
   "dependencies": {
     "@babel/parser": "^7.29.2",
-    "@jskit-ai/crud-core": "0.1.66",
-    "@jskit-ai/database-runtime": "0.1.58",
-    "@jskit-ai/http-runtime": "0.1.57",
-    "@jskit-ai/json-rest-api-core": "0.1.3",
-    "@jskit-ai/kernel": "0.1.58",
-    "@jskit-ai/resource-crud-core": "0.1.3",
+    "@jskit-ai/crud-core": "0.1.67",
+    "@jskit-ai/database-runtime": "0.1.59",
+    "@jskit-ai/http-runtime": "0.1.58",
+    "@jskit-ai/json-rest-api-core": "0.1.4",
+    "@jskit-ai/kernel": "0.1.59",
+    "@jskit-ai/resource-crud-core": "0.1.4",
     "recast": "^0.23.11"
   }
 }

package/templates/src/local-package/server/repository.js

@@ -90,7 +90,7 @@ function createRepository({ api, knex } = {}) {
         createJsonRestContext(options?.context || null)
       );
 
-      return true;
+      return null;
     });
   }
 

package/templates/src/local-package/server/service.js

@@ -43,11 +43,10 @@ function createService({ ${option:namespace|camel}Repository } = {}) {
   }
 
   async function deleteDocumentById(recordId, options = {}) {
-    return404IfNotFound(await ${option:namespace|camel}Repository.deleteDocumentById(recordId, {
+    return ${option:namespace|camel}Repository.deleteDocumentById(recordId, {
       trx: options?.trx || null,
       context: options?.context || null
-    }));
-    return null;
+    });
   }
 
   return Object.freeze({

package/test/buildTemplateContext.test.js

@@ -1040,6 +1040,9 @@ test("crud service template preserves JSON:API output and emits entity ids from
   assert.match(templateSource, /returnJsonApiDocument\(await \$\{option:namespace\|camel\}Repository\.queryDocuments\(query, \{/);
   assert.match(templateSource, /async function patchDocumentById\(recordId, payload = \{\}, options = \{\}\)/);
   assert.match(templateSource, /returnJsonApiDocument\(return404IfNotFound\(await \$\{option:namespace\|camel\}Repository\.patchDocumentById\(recordId, payload, \{/);
+  assert.match(templateSource, /async function deleteDocumentById\(recordId, options = \{\}\)/);
+  assert.match(templateSource, /return \$\{option:namespace\|camel\}Repository\.deleteDocumentById\(recordId, \{/);
+  assert.doesNotMatch(templateSource, /return404IfNotFound\(await \$\{option:namespace\|camel\}Repository\.deleteDocumentById/);
   assert.match(templateSource, /return Object\.freeze\(\{/);
   assert.match(templateSource, /export \{ createService \};/);
 });

package/test/crudServerGuards.test.js

@@ -117,6 +117,50 @@ test("template createRepository builds mutable JSON:API input documents for writ
   });
 });
 
+test("template createRepository returns null for successful deletes", async () => {
+  const calls = [];
+  const api = {
+    resources: {
+      customers: {
+        async delete(params, context) {
+          calls.push({ params, context });
+        }
+      }
+    }
+  };
+  const knex = {
+    async transaction(work) {
+      return work("trx");
+    }
+  };
+
+  const repository = createRepository({ api, knex });
+  const result = await repository.deleteDocumentById("7", {
+    trx: "trx-1",
+    context: {
+      visibilityContext: {
+        visibility: "workspace",
+        scopeOwnerId: "7"
+      }
+    }
+  });
+
+  assert.equal(result, null);
+  assert.deepEqual(calls[0], {
+    params: {
+      id: "7",
+      transaction: "trx-1",
+      simplified: false
+    },
+    context: {
+      visibilityContext: {
+        visibility: "workspace",
+        scopeOwnerId: "7"
+      }
+    }
+  });
+});
+
 test("template createService turns missing resource records into 404 errors", async () => {
   const service = createService({
     customersRepository: {
@@ -139,6 +183,45 @@ test("template createService turns missing resource records into 404 errors", as
   );
 });
 
+test("template createService returns delete results unchanged", async () => {
+  const service = createService({
+    customersRepository: {
+      async deleteDocumentById(recordId, options) {
+        return {
+          recordId,
+          options,
+          deleted: true
+        };
+      }
+    }
+  });
+
+  assert.deepEqual(
+    await service.deleteDocumentById("7", {
+      trx: "trx-1",
+      context: {
+        visibilityContext: {
+          visibility: "workspace",
+          scopeOwnerId: "7"
+        }
+      }
+    }),
+    {
+      recordId: "7",
+      options: {
+        trx: "trx-1",
+        context: {
+          visibilityContext: {
+            visibility: "workspace",
+            scopeOwnerId: "7"
+          }
+        }
+      },
+      deleted: true
+    }
+  );
+});
+
 test("template createActions requires namespaced CRUD permissions by default", () => {
   const actions = createActions({ surface: "admin" });
 

package/test/crudService.test.js

@@ -30,7 +30,7 @@ test("crudService exposes the explicit JSON:API CRUD service contract", async ()
     },
     async deleteDocumentById(recordId, options) {
       calls.push(["deleteDocumentById", recordId, options]);
-      return true;
+      return null;
     }
   };
 
@@ -131,9 +131,42 @@ test("crudService throws 404 when a document is missing", async () => {
     () => service.patchDocumentById(9, { textField: "Changed" }, {}),
     (error) => error?.status === 404 && error?.message === "Document not found."
   );
+});
 
-  await assert.rejects(
-    () => service.deleteDocumentById(9, {}),
-    (error) => error?.status === 404 && error?.message === "Document not found."
-  );
+test("crudService returns delete results unchanged", async () => {
+  const service = createService({
+    customersRepository: {
+      async deleteDocumentById(recordId, options) {
+        return {
+          recordId,
+          options,
+          deleted: true
+        };
+      }
+    }
+  });
+
+  const result = await service.deleteDocumentById(9, {
+    trx: "trx-1",
+    context: {
+      visibilityContext: {
+        visibility: "workspace",
+        scopeOwnerId: "7"
+      }
+    }
+  });
+
+  assert.deepEqual(result, {
+    recordId: 9,
+    options: {
+      trx: "trx-1",
+      context: {
+        visibilityContext: {
+          visibility: "workspace",
+          scopeOwnerId: "7"
+        }
+      }
+    },
+    deleted: true
+  });
 });