@jskit-ai/assistant-runtime 0.2.45 → 0.2.46

package/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- A Set or Resume goal that the server refuses after its message already appeared in the conversation shows the server's reason (for example that Claude's goal attachment is not available yet) instead of only `jskit.assistant.runtime.goal.changeFailed` ("Could not change the goal."): the transcript turn settled the optimistic message first, so the failure's own text was dropped with it.
 - The saved-conversations list (`GET /api/assistant/:surfaceId/conversations`, and its workspace form) answers 200 again instead of 500 ("metadata is required!") once a person has a conversation: the route still serialized each item with the conversation's read schema, which requires `metadata`, after list items stopped carrying it. It serializes them with assistant-core's `assistantConversationListItemOutputValidator`, the item of `assistantContract`'s `conversationsList`. `conversationsListRoute.test.js` lists a saved conversation over HTTP through the real route, actions and SQL repositories.
 - Each conversation request authenticates once: the route's access check and the action's request context share one sign-in lookup instead of each asking again.
 - **Breaking.** Conversation list items no longer carry `metadata`: the conversations repository's `listForActorScope` reads only the fields a list shows, as `assistantContract`'s `conversationsList` now answers them. Upgrading: code that read `metadata` from a list item reads the conversation instead, with `findByIdForActorScope` or the conversation's messages read, which still answer it.

package/fixtures/canonical-conversation/vite.config.mjs

@@ -156,6 +156,10 @@ export default defineConfig({
             state.queuedGoal = input;
             return json(receipt);
           }
+          // The engine received the command, but the server could not confirm its goal.
+          if (receipt && mode === "goal-refused") {
+            return json({ error: "Claude did not confirm the goal in time.", code: "fixture_goal_unconfirmed" }, 503);
+          }
           changeGoal(state, input);
           const result = receipt || state.goal || null;
           return json(result, result === null ? 204 : 200);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jskit-ai/assistant-runtime",
-  "version": "0.2.45",
+  "version": "0.2.46",
   "type": "module",
   "scripts": {
     "test": "jskit test"
@@ -15,16 +15,16 @@
     "./locales/en.json": "./locales/en.json"
   },
   "dependencies": {
-    "@jskit-ai/assistant-core": "0.2.43",
+    "@jskit-ai/assistant-core": "0.2.44",
     "@jskit-ai/resource-core": "0.1.211",
     "json-rest-schema": "^1.0.20"
   },
   "peerDependencies": {
     "@jskit-ai/http-runtime": "0.2.20",
-    "@jskit-ai/http-web": "0.2.31",
+    "@jskit-ai/http-web": "0.2.32",
     "@jskit-ai/kernel": "0.2.20",
-    "@jskit-ai/realtime": "0.2.29",
-    "@jskit-ai/shell-web": "0.2.26",
+    "@jskit-ai/realtime": "0.2.30",
+    "@jskit-ai/shell-web": "0.2.27",
     "@tanstack/vue-query": "^5.90.5",
     "vue": "^3.5.13",
     "vuetify": "^4.0.0",

package/src/client/composables/conversationRuntime.js

@@ -504,6 +504,10 @@ function createConversationRuntime({ identity, api, socket, actorKey, placement,
       // Delivery keeps its exact authored payload until an explicit receipt check.
       if (prepare) return { ok: false, status: "uncertain", error: failureMessage(failure),
         ...(failure.code ? { code: failure.code } : {}) };
+      // A goal command's transcript turn can settle its message before the
+      // server answers; the server's refusal still says why the goal did not change.
+      if (payload.goalRequest) return { ok: false, error: failureMessage(failure),
+        ...(failure.code ? { code: failure.code } : {}) };
       return false;
     } finally {
       if (!pending.started && pendingMessages.get(messageId) === pending) pendingMessages.delete(messageId);

package/test/assistantConversationBinding.browser.test.js

@@ -519,6 +519,46 @@ test("Cancel stays available while a Resume waits behind the running turn and en
   assert.deepEqual(commands.map(request => request.input.action), ["set", "pause", "resume", "cancel"]);
 });
 
+test("a Resume the server refuses after its message reached the chat shows the server's reason", options, async t => {
+  const f = await fixture(t);
+  await f.command("goals", { id: "chat:1", budgets: false, commands: {
+    set: { delivery: "message", interruptsTurn: false }, resume: { delivery: "message", interruptsTurn: false },
+    pause: { delivery: "control", interruptsTurn: false }
+  } });
+  await f.notify("chat:1");
+  const control = name => f.primary.getByRole("button", { name, exact: true });
+  const menu = name => f.page.getByRole("button", { name, exact: true });
+  await control("Set goal").click();
+  await f.page.getByRole("textbox", { name: "Goal objective" }).fill("Refused after its message arrived");
+  await f.page.locator(".assistant-goal__form button[type=submit]").click();
+  await expect(control("Goal running")).toHaveAttribute("aria-expanded", "false");
+  await control("Goal running").click();
+  await menu("Pause goal").click();
+  await expect(control("Goal paused")).toBeVisible();
+  await f.command("finish", { id: "chat:1" });
+  await f.notify("chat:1");
+  // The server records the Resume's message, and its refusal arrives only after
+  // the chat has shown that message.
+  await f.command("mode", { mode: "goal-refused" });
+  const answer = Promise.withResolvers();
+  let resumes = 0;
+  await f.page.route("**/conversations/*/goal", async route => {
+    if (route.request().method() !== "POST") return route.continue();
+    resumes += 1;
+    const response = await route.fetch();
+    await answer.promise;
+    await route.fulfill({ response });
+  });
+  await menu("Resume goal").click();
+  await expect.poll(() => resumes).toBe(1);
+  await f.notify("chat:1");
+  await expect.poll(() => f.page.evaluate(() => window.conversationFixture.current().delivery.state.messages.length)).toBe(0);
+  answer.resolve();
+  await expect(f.page.getByRole("alert").filter({ hasText: "Claude did not confirm the goal in time." })).toBeVisible();
+  await expect(menu("Resume goal")).toBeEnabled();
+  assert.equal(resumes, 1);
+});
+
 test("a supplied goal view keeps its pinned target and refreshes through the retained binding without polling", options, async t => {
   const f = await fixture(t);
   const goal = { id: "retained-goal", objective: "The plain product objective", status: "paused",