@jskit-ai/assistant-runtime 0.2.26 → 0.2.28

package/test/conversation.browser.test.js

@@ -2,7 +2,8 @@ import assert from "node:assert/strict";
 import { mkdir } from "node:fs/promises";
 import { fileURLToPath } from "node:url";
 import test from "node:test";
-import { chromium, expect } from "@playwright/test";
+import { chromium } from "@playwright/test";
+import { expect } from "../../../tooling/testUtils/browserExpect.mjs";
 import { createChromiumLaunchOptions, startViteFixture, stopProcess } from "../../../tooling/testUtils/browserFixture.mjs";
 
 const fixtureRoot = fileURLToPath(new URL("../fixtures/conversation/", import.meta.url));
@@ -10,9 +11,11 @@ const fixtureRoot = fileURLToPath(new URL("../fixtures/conversation/", import.me
 test("ready-made assistant preserves streaming, drafts, scope and compact conversation access", {
   skip: process.env.JSKIT_ASSISTANT_RUNTIME_BROWSER_INTEGRATION !== "1",
   timeout: 180_000
-}, async () => {
+}, async (t) => {
   const vite = await startViteFixture({ fixtureRoot });
+  t.after(() => stopProcess(vite));
   const browser = await chromium.launch(createChromiumLaunchOptions());
+  t.after(() => browser.close());
   const page = await browser.newPage({ viewport: { width: 1280, height: 800 } });
   const errors = [];
   page.on("pageerror", (error) => errors.push(error.message));
@@ -138,18 +141,17 @@ test("ready-made assistant preserves streaming, drafts, scope and compact conver
     assert.deepEqual(errors, []);
   } catch (error) {
     throw new Error(`${error.message}\nPage errors: ${JSON.stringify(errors)}\n${vite.readOutput()}`, { cause: error });
-  } finally {
-    await browser.close();
-    await stopProcess(vite);
   }
 });
 
 test("history restores preserve new typing and reject obsolete pages and failed automatic restores", {
   skip: process.env.JSKIT_ASSISTANT_RUNTIME_BROWSER_INTEGRATION !== "1",
   timeout: 60_000
-}, async () => {
+}, async (t) => {
   const vite = await startViteFixture({ fixtureRoot });
+  t.after(() => stopProcess(vite));
   const browser = await chromium.launch(createChromiumLaunchOptions());
+  t.after(() => browser.close());
   const page = await browser.newPage();
   const input = page.getByRole("textbox", { name: "Message AI assistant" });
   const send = page.getByRole("button", { name: "Send message", exact: true });
@@ -220,92 +222,89 @@ test("history restores preserve new typing and reject obsolete pages and failed
     assert.equal(failedRequests, 1, "A failed automatic restore must require explicit selection to retry");
   } finally {
     release?.();
-    await browser.close();
-    await stopProcess(vite);
   }
 });
 
 test("page assistant bounds long history in a document layout and preserves drafts when workspace metadata arrives", {
   skip: process.env.JSKIT_ASSISTANT_RUNTIME_BROWSER_INTEGRATION !== "1",
   timeout: 60_000
-}, async () => {
+}, async (t) => {
   const vite = await startViteFixture({ fixtureRoot });
+  t.after(() => stopProcess(vite));
   const browser = await chromium.launch(createChromiumLaunchOptions());
+  t.after(() => browser.close());
   const page = await browser.newPage();
-  try {
-    await page.goto(`${vite.baseURL}/?page=1`);
-    await page.getByRole("button", { name: "Conversations", exact: true }).click();
-    await page.getByRole("dialog", { name: "Conversations", exact: true }).getByText("Saved conversation", { exact: true }).click();
-    await expect(page.getByText("Saved 1 message 70.", { exact: false })).toBeVisible();
-    const input = page.getByRole("textbox", { name: "Message AI assistant" });
-    for (const viewport of [{ width: 390, height: 844 }, { width: 800, height: 800 }, { width: 1280, height: 600 }]) {
-      await page.setViewportSize(viewport);
-      await expect.poll(async () => {
-        const bounds = await input.boundingBox();
-        return bounds.y + bounds.height;
-      }).toBeLessThanOrEqual(viewport.height);
-      assert.ok(await page.getByLabel("Conversation messages", { exact: true }).evaluate(element => element.scrollHeight > element.clientHeight));
-    }
-    await input.fill("Keep this draft while workspace details load.");
-    await input.evaluate(element => { element.focus(); element.setSelectionRange(5, 9); });
-    await page.getByRole("button", { name: "Load workspace metadata" }).evaluate(element => element.click());
-    await expect(input).toHaveValue("Keep this draft while workspace details load.");
-    await expect(input).toBeFocused();
-    assert.deepEqual(await input.evaluate(element => [element.selectionStart, element.selectionEnd]), [5, 9]);
-    await expect(page.getByText("Saved 1 message 70.", { exact: false })).toBeVisible();
-  } finally {
-    await browser.close();
-    await stopProcess(vite);
+  await page.goto(`${vite.baseURL}/?page=1`);
+  await page.getByRole("button", { name: "Conversations", exact: true }).click();
+  await page.getByRole("dialog", { name: "Conversations", exact: true }).getByText("Saved conversation", { exact: true }).click();
+  await expect(page.getByText("Saved 1 message 70.", { exact: false })).toBeVisible();
+  const input = page.getByRole("textbox", { name: "Message AI assistant" });
+  for (const viewport of [{ width: 390, height: 844 }, { width: 800, height: 800 }, { width: 1280, height: 600 }]) {
+    await page.setViewportSize(viewport);
+    await expect.poll(async () => {
+      const bounds = await input.boundingBox();
+      return bounds.y + bounds.height;
+    }).toBeLessThanOrEqual(viewport.height);
+    assert.ok(await page.getByLabel("Conversation messages", { exact: true }).evaluate(element => element.scrollHeight > element.clientHeight));
   }
+  await input.fill("Keep this draft while workspace details load.");
+  await input.evaluate(element => { element.focus(); element.setSelectionRange(5, 9); });
+  await page.getByRole("button", { name: "Load workspace metadata" }).evaluate(element => element.click());
+  await expect(input).toHaveValue("Keep this draft while workspace details load.");
+  await expect(input).toBeFocused();
+  assert.deepEqual(await input.evaluate(element => [element.selectionStart, element.selectionEnd]), [5, 9]);
+  await expect(page.getByText("Saved 1 message 70.", { exact: false })).toBeVisible();
 });
 
 
 test("the ready-made UI streams from the real chat service with selected AI connections and files", {
   skip: process.env.JSKIT_ASSISTANT_RUNTIME_BROWSER_INTEGRATION !== "1", timeout: 90_000
-}, async () => {
+}, async (t) => {
   const vite = await startViteFixture({ fixtureRoot });
+  t.after(() => stopProcess(vite));
   const browser = await chromium.launch(createChromiumLaunchOptions());
+  t.after(() => browser.close());
   const page = await browser.newPage({ viewport: { width: 1100, height: 800 } });
-  try {
-    await page.request.get(`${vite.baseURL}/fixture/service`);
-    await page.goto(`${vite.baseURL}/?files=1`);
-    const input = page.getByRole("textbox", { name: "Message AI assistant" });
-    await expect(input).toBeEnabled();
-    await page.getByRole("button", { name: "Choose AI", exact: true }).click();
-    await page.getByRole("button", { name: "Deep model", exact: true }).click();
-    await page.getByRole("button", { name: "Apply", exact: true }).click();
-    await page.locator('input[type="file"]').setInputFiles({ name: "notes.txt", mimeType: "text/plain", buffer: Buffer.from("notes") });
-    await expect(page.getByText("notes.txt", { exact: true })).toBeVisible();
-    await input.fill("Read the notes");
-    await input.press("Enter");
-    await expect(page.getByText("Assistant is working…", { exact: true }).last()).toBeVisible();
-    await expect(page.getByLabel("Message attachments")).toHaveCount(0);
-    await expect(page.getByLabel("Attached files")).toBeVisible();
-    await input.fill("My next draft");
-    await input.evaluate(element => element.setSelectionRange(3, 7));
-    await page.request.get(`${vite.baseURL}/fixture/next`);
-    await expect(page.getByText("Partial answer", { exact: true })).toBeVisible();
-    await expect(input).toHaveValue("My next draft");
-    assert.deepEqual(await input.evaluate(element => [element.selectionStart, element.selectionEnd]), [3, 7]);
-    let state = await (await page.request.get(`${vite.baseURL}/fixture/state`)).json();
-    assert.equal(state.requests[0].integrationId, "deep");
-    assert.deepEqual(state.requests[0].attachmentIds, ["fixture-file"]);
-    assert.equal(state.transcript.filter(message => message.role === "assistant").length, 0);
-    await page.request.get(`${vite.baseURL}/fixture/next?finish=1`);
-    await expect(page.getByText("Partial answer completed.", { exact: true })).toHaveCount(1);
-    await expect(page.getByText("Assistant is working…", { exact: true })).toHaveCount(0);
-    state = await (await page.request.get(`${vite.baseURL}/fixture/state`)).json();
-    assert.deepEqual(state.transcript[0].metadata.attachments, [{ attachmentId: "fixture-file", fileName: "notes.txt", size: 5 }]);
-    assert.equal(state.transcript.filter(message => message.role === "assistant").length, 1);
-  } finally { await browser.close(); await stopProcess(vite); }
+  await page.request.get(`${vite.baseURL}/fixture/service`);
+  await page.goto(`${vite.baseURL}/?files=1`);
+  const input = page.getByRole("textbox", { name: "Message AI assistant" });
+  await expect(input).toBeEnabled();
+  await page.getByRole("button", { name: "Choose AI", exact: true }).click();
+  await page.getByRole("button", { name: "Deep model", exact: true }).click();
+  await page.getByRole("button", { name: "Apply", exact: true }).click();
+  await page.locator('input[type="file"]').setInputFiles({ name: "notes.txt", mimeType: "text/plain", buffer: Buffer.from("notes") });
+  await expect(page.getByText("notes.txt", { exact: true })).toBeVisible();
+  await input.fill("Read the notes");
+  await input.press("Enter");
+  await expect(page.getByText("Assistant is working…", { exact: true }).last()).toBeVisible();
+  await expect(page.getByLabel("Message attachments")).toHaveCount(0);
+  await expect(page.getByLabel("Attached files")).toBeVisible();
+  await input.fill("My next draft");
+  await input.evaluate(element => element.setSelectionRange(3, 7));
+  await page.request.get(`${vite.baseURL}/fixture/next`);
+  await expect(page.getByText("Partial answer", { exact: true })).toBeVisible();
+  await expect(input).toHaveValue("My next draft");
+  assert.deepEqual(await input.evaluate(element => [element.selectionStart, element.selectionEnd]), [3, 7]);
+  let state = await (await page.request.get(`${vite.baseURL}/fixture/state`)).json();
+  assert.equal(state.requests[0].integrationId, "deep");
+  assert.deepEqual(state.requests[0].attachmentIds, ["fixture-file"]);
+  assert.equal(state.transcript.filter(message => message.role === "assistant").length, 0);
+  await page.request.get(`${vite.baseURL}/fixture/next?finish=1`);
+  await expect(page.getByText("Partial answer completed.", { exact: true })).toHaveCount(1);
+  await expect(page.getByText("Assistant is working…", { exact: true })).toHaveCount(0);
+  state = await (await page.request.get(`${vite.baseURL}/fixture/state`)).json();
+  assert.deepEqual(state.transcript[0].metadata.attachments, [{ attachmentId: "fixture-file", fileName: "notes.txt", size: 5 }]);
+  assert.equal(state.transcript.filter(message => message.role === "assistant").length, 1);
 });
 
 test("pending delivery appears immediately and retries the original request without replacing a newer draft", {
   skip: process.env.JSKIT_ASSISTANT_RUNTIME_BROWSER_INTEGRATION !== "1",
   timeout: 60_000
-}, async () => {
+}, async (t) => {
   const vite = await startViteFixture({ fixtureRoot });
+  t.after(() => stopProcess(vite));
   const browser = await chromium.launch(createChromiumLaunchOptions());
+  t.after(() => browser.close());
   const page = await browser.newPage({ viewport: { width: 390, height: 844 } });
   const held = Promise.withResolvers();
   const requests = [];
@@ -345,7 +344,5 @@ test("pending delivery appears immediately and retries the original request with
     assert.deepEqual(errors, []);
   } finally {
     held.resolve();
-    await browser.close();
-    await stopProcess(vite);
   }
 });

package/test/lazyAppConfig.test.js

@@ -178,7 +178,7 @@ test("registerRoutes forwards the resolved host surface through every direct act
           params: {
             conversationId: "conversation_1",
             surfaceId: "admin",
-            workspaceSlug: "dogandgroom"
+            workspaceSlug: "acme"
           },
           query: {
             limit: 20
@@ -233,7 +233,7 @@ test("registerRoutes builds workspace action input from explicit config and scop
       },
       input: {
         params: {
-          workspaceSlug: "dogandgroom",
+          workspaceSlug: "acme",
           surfaceId: "admin"
         },
         query: {
@@ -259,7 +259,7 @@ test("registerRoutes builds workspace action input from explicit config and scop
   assert.equal(reply.statusCode, 200);
   assert.equal(capturedAction?.surface, "admin");
   assert.equal(capturedAction?.input?.targetSurfaceId, "admin");
-  assert.equal(capturedAction?.input?.workspaceSlug, "dogandgroom");
+  assert.equal(capturedAction?.input?.workspaceSlug, "acme");
 });
 
 test("registerRoutes returns clear AppError payload for pre-stream assistant failures", async () => {
@@ -306,7 +306,7 @@ test("registerRoutes returns clear AppError payload for pre-stream assistant fai
       },
       input: {
         params: {
-          workspaceSlug: "dogandgroom",
+          workspaceSlug: "acme",
           surfaceId: "admin"
         },
         body: {
@@ -330,7 +330,7 @@ test("registerRoutes returns clear AppError payload for pre-stream assistant fai
   });
   assert.deepEqual(capturedInput, {
     targetSurfaceId: "admin",
-    workspaceSlug: "dogandgroom",
+    workspaceSlug: "acme",
     messageId: "msg_1",
     input: "hello"
   });
@@ -349,7 +349,7 @@ test("registerRoutes returns clear AppError payload for pre-stream assistant fai
     await route.handler({
       raw: { on() {}, off() {} },
       headers: { "x-jskit-surface": "admin" },
-      input: { params: { workspaceSlug: "dogandgroom", surfaceId: "admin" }, body: { messageId: "msg_2", input: "hello" } },
+      input: { params: { workspaceSlug: "acme", surfaceId: "admin" }, body: { messageId: "msg_2", input: "hello" } },
       executeAction: async () => { throw failure; }
     }, reply);
     assert.equal(reply.statusCode, status);
@@ -389,7 +389,7 @@ test("chat service uses explicit app config when conversations are listed", asyn
     {
       input: {
         targetSurfaceId: "admin",
-        workspaceSlug: "dogandgroom"
+        workspaceSlug: "acme"
       },
       context: {
         actor: {
@@ -398,14 +398,14 @@ test("chat service uses explicit app config when conversations are listed", asyn
         },
         workspace: {
           id: 7,
-          slug: "dogandgroom"
+          slug: "acme"
         }
       }
     }
   );
 
   assert.equal(response.assistantSurface.targetSurfaceId, "admin");
-  assert.equal(response.workspace.slug, "dogandgroom");
+  assert.equal(response.workspace.slug, "acme");
 });
 
 test("chat service rejects workspace-scoped assistant surfaces when workspace support is unavailable", async () => {
@@ -435,7 +435,7 @@ test("chat service rejects workspace-scoped assistant surfaces when workspace su
         {
           input: {
             targetSurfaceId: "admin",
-            workspaceSlug: "dogandgroom"
+            workspaceSlug: "acme"
           },
           context: {
             actor: {

package/test/sqlConversationStorage.test.js

@@ -5,6 +5,7 @@ import { tmpdir } from "node:os";
 import path from "node:path";
 import knex from "knex";
 import { AppError } from "@jskit-ai/kernel/server/runtime";
+import { silentLogger } from "@jskit-ai/kernel/server/runtime/logger";
 import { createConversationTranscript } from "@jskit-ai/assistant-core/server/conversation";
 import { verifyConversationStorageContract } from "@jskit-ai/assistant-core/testing/conversation-storage";
 import transcriptsMigration from "../migrations/assistant_transcripts_initial.cjs";
@@ -17,8 +18,12 @@ import { createSqlConversationStorage } from "../src/server/sqlConversationStora
 import { createAssistantConversationRuntime } from "../src/server/createAssistantRuntime.js";
 import { createTranscriptService } from "../src/server/services/transcriptService.js";
 import { createChatService } from "../src/server/services/chatService.js";
+import { NO_PERSON_CONTEXT, createPersonContextPrompt } from "../src/server/support/personContext.js";
 import { createScriptedModel } from "./support/scriptedModel.js";
 
+// The chat service of an application that supplies no facts about the person.
+const NO_FACTS = createPersonContextPrompt({ personContext: NO_PERSON_CONTEXT, logger: silentLogger });
+
 async function fixture(t) {
   const directory = await mkdtemp(path.join(tmpdir(), "assistant-sql-runtime-"));
   const clients = [];
@@ -178,6 +183,7 @@ test("the SQL facade uses common inference and durable tool rows, and the model'
   const dependencies = { conversationRuntime: runtime, aiClientFactory, serviceToolCatalog: catalog,
     transcriptService: createTranscriptService(f), turnRequests: createTurnRequestsRepository(f.db),
     assistantConfigService: { resolveSystemPrompt: async () => "Retained SQL instructions" },
+    personContextPrompt: NO_FACTS,
     appConfig: { surfaceDefinitions: { assistant: { enabled: true, requiresWorkspace: false } },
       assistantSurfaces: { assistant: { settingsSurfaceId: "assistant", configScope: "global" } } } };
   const service = createChatService(dependencies);
@@ -234,6 +240,7 @@ test("the SQL facade replays historical inspection failures with their exact pub
   const dependencies = { conversationRuntime: runtime, aiClientFactory, serviceToolCatalog: catalog,
     transcriptService: createTranscriptService(f), turnRequests,
     assistantConfigService: { resolveSystemPrompt: async () => "Read the supplied context" },
+    personContextPrompt: NO_FACTS,
     appConfig: { surfaceDefinitions: { assistant: { enabled: true, requiresWorkspace: false } },
       assistantSurfaces: { assistant: { settingsSurfaceId: "assistant", configScope: "global" } } } };
   const input = { targetSurfaceId: "assistant", conversationId: conversation.id,
@@ -344,6 +351,7 @@ for (const shape of ["orphan-output", "orphan-tool-result", "unconfirmed-tool"])
     const dependencies = { conversationRuntime: runtime, aiClientFactory, serviceToolCatalog: catalog,
       transcriptService: createTranscriptService(f), turnRequests,
       assistantConfigService: { resolveSystemPrompt: async () => "Read only the admitted request" },
+      personContextPrompt: NO_FACTS,
       workspaceScopeSupport: { resolveWorkspace: context => context.requestMeta.resolvedWorkspaceContext.workspace },
       appConfig: { surfaceDefinitions: {
         assistant: { enabled: true, requiresWorkspace: true }, other: { enabled: true, requiresWorkspace: true }

package/test/support/memoryAssistantRows.js

@@ -1,8 +1,8 @@
 /** Repository fixture for the original chat-service unit cases. The production
  * SQL adapter and common runtime run unchanged over these transactional rows.
  */
-export function createMemoryAssistantRows({ id = "conversation_1", surfaceId = "assistant", messages = [] } = {}) {
-  let state = { conversation: { id, workspaceId: null, createdByUserId: "1", surfaceId,
+export function createMemoryAssistantRows({ id = "conversation_1", surfaceId = "assistant", workspaceId = null, messages = [] } = {}) {
+  let state = { conversation: { id, workspaceId, createdByUserId: "1", surfaceId,
     title: "New conversation", status: "active", messageCount: 0, metadata: {} }, transcript: { revision: "", summary: null }, messages: [] };
   let pending = Promise.resolve();
   const read = options => options?.trx || state;

package/test/turnRequests.test.js

@@ -6,7 +6,9 @@ import path from "node:path";
 import knex from "knex";
 import migration from "../migrations/assistant_turn_requests.cjs";
 import { createRepository } from "../src/server/repositories/turnRequestsRepository.js";
+import { silentLogger } from "@jskit-ai/kernel/server/runtime/logger";
 import { createChatService } from "../src/server/services/chatService.js";
+import { NO_PERSON_CONTEXT, createPersonContextPrompt } from "../src/server/support/personContext.js";
 import { createAssistantConversationRuntime } from "../src/server/createAssistantRuntime.js";
 import { createMemoryAssistantRows } from "./support/memoryAssistantRows.js";
 import { createScriptedModel } from "./support/scriptedModel.js";
@@ -59,6 +61,7 @@ function service(repository, { provider, transcript = [] } = {}) {
     serviceToolCatalog: { limits: { maxToolArgumentBytes: 64 * 1024 }, resolveToolSet: () => ({ tools: [] }),
       toOpenAiToolSchema: tool => ({ type: "function", function: tool }) },
     assistantConfigService: { resolveSystemPrompt: async () => "Answer." },
+    personContextPrompt: createPersonContextPrompt({ personContext: NO_PERSON_CONTEXT, logger: silentLogger }),
     appConfig: {
       surfaceDefinitions: { assistant: { id: "assistant", enabled: true, requiresWorkspace: false, accessPolicyId: "public" } },
       assistantSurfaces: { assistant: { settingsSurfaceId: "assistant", configScope: "global" } }