@jskit-ai/assistant-runtime 0.2.23 → 0.2.24

package/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- The assistant surface pattern's icon is `$smartToy`, and the fixtures render with `@jskit-ai/material-web`.
 - Changing an assistant's instructions needs `assistant.settings.update` on a settings surface that requires neither a workspace nor the console owner (it needed only a signed-in user), still `workspace.settings.update` on a workspace surface and the console owner on a console-owner surface. `assistantServer.<surface>.settingsUpdatePermission` names another permission, or `{ require: "authenticated" }` to keep the old behaviour. A refusal is `assistant.runtime.settings.updateForbidden` (403).
 
 ### New message keys (1)

package/fixtures/canonical-conversation/main.js

@@ -3,8 +3,9 @@ import { createRouter, createWebHistory } from "vue-router";
 import { createVuetify } from "vuetify";
 import * as components from "vuetify/components";
 import * as directives from "vuetify/directives";
-import { aliases, mdi } from "vuetify/iconsets/mdi-svg";
 import "vuetify/styles";
+import "@jskit-ai/material-web/client/material.css";
+import { createMaterialVuetifyOptions } from "@jskit-ai/material-web/client";
 import App from "./App.vue";
 import { createWebPlacementRuntime } from "../../../shell-web/src/client/placement/runtime.js";
 import { createFixtureSocket } from "./socket.js";
@@ -69,7 +70,6 @@ if (new URLSearchParams(window.location.search).has("applicationDefaults")) {
 app.provide("jskit.shell-web.runtime.web-placement.client", placement);
 app.provide("jskit.realtime.runtime.client.socket", socket);
 app.provide("fixture", { placement, socket });
-app.use(router).use(createVuetify({ theme: { defaultTheme: "light" }, components, directives,
-  icons: { defaultSet: "mdi", aliases, sets: { mdi } } }));
+app.use(router).use(createVuetify({ components, directives, ...createMaterialVuetifyOptions() }));
 await router.isReady();
 app.mount("#app");

package/fixtures/conversation/main.js

@@ -4,8 +4,9 @@ import { VueQueryPlugin } from "@tanstack/vue-query";
 import { createVuetify } from "vuetify";
 import * as components from "vuetify/components";
 import * as directives from "vuetify/directives";
-import { aliases, mdi } from "vuetify/iconsets/mdi-svg";
 import "vuetify/styles";
+import "@jskit-ai/material-web/client/material.css";
+import { createMaterialVuetifyOptions } from "@jskit-ai/material-web/client";
 import App from "./App.vue";
 import { createWebPlacementRuntime } from "../../../shell-web/src/client/placement/runtime.js";
 import { silentLogger } from "@jskit-ai/kernel/shared/support/silentLogger";
@@ -27,6 +28,6 @@ placement.setContext({ user: { id: "1" }, surfaceConfig: {
 app.provide("jskit.shell-web.runtime.web-placement.client", placement);
 app.provide("jskit.workspaces.web.scope-support", { readRouteScope: ({ route }) => ({ workspaceSlug: route.query.workspace || "alpha" }) });
 app.use(router).use(VueQueryPlugin, { queryClientConfig: { defaultOptions: { queries: { retry: false } } } });
-app.use(createVuetify({ theme: { defaultTheme: "light" }, components, directives, icons: { defaultSet: "mdi", aliases, sets: { mdi } } }));
+app.use(createVuetify({ components, directives, ...createMaterialVuetifyOptions() }));
 await router.isReady();
 app.mount("#app");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jskit-ai/assistant-runtime",
-  "version": "0.2.23",
+  "version": "0.2.24",
   "type": "module",
   "scripts": {
     "test": "node --test --test-concurrency=1"
@@ -14,19 +14,19 @@
     "./locales/en.json": "./locales/en.json"
   },
   "dependencies": {
-    "@jskit-ai/assistant-core": "0.2.21",
+    "@jskit-ai/assistant-core": "0.2.22",
     "json-rest-schema": "^1.0.17"
   },
   "peerDependencies": {
-    "@jskit-ai/http-runtime": "0.2.9",
-    "@jskit-ai/http-web": "0.2.15",
-    "@jskit-ai/kernel": "0.2.9",
-    "@jskit-ai/realtime": "0.2.13",
-    "@jskit-ai/shell-web": "0.2.10",
+    "@jskit-ai/http-runtime": "0.2.10",
+    "@jskit-ai/http-web": "0.2.16",
+    "@jskit-ai/kernel": "0.2.10",
+    "@jskit-ai/realtime": "0.2.14",
+    "@jskit-ai/shell-web": "0.2.11",
     "@tanstack/vue-query": "^5.90.5",
     "vue": "^3.5.13",
     "vuetify": "^4.0.0",
-    "@jskit-ai/database-runtime": "0.1.258"
+    "@jskit-ai/database-runtime": "0.1.259"
   },
   "description": "Capability-based assistant runtime with per-surface chat, transcripts, settings, and action tools.",
   "jskit": {
@@ -126,5 +126,8 @@
     "@jskit-ai/database-runtime": {
       "optional": true
     }
+  },
+  "devDependencies": {
+    "@jskit-ai/material-web": "0.1.0"
   }
 }

package/patterns/assistant-surface/example/src/placement.js

@@ -11,7 +11,7 @@ addPlacement({
   order: 140,
   props: {
     label: "Assistant",
-    icon: "mdi-creation-outline",
+    icon: "$smartToy",
     surface: "admin",
     scopedSuffix: "/assistant",
     unscopedSuffix: "/assistant"

package/test/assistantConversationBinding.browser.test.js

@@ -146,10 +146,15 @@ test("optional goal controls follow declared command semantics and budgets witho
     await f.notify("chat:1");
     await f.primary.getByRole("button", { name: "Set goal", exact: true }).click();
     const objective = budgets ? "Finish with a bounded budget" : "Finish without a budget";
-    await f.page.getByRole("textbox", { name: "Goal objective" }).fill(objective);
+    const objectiveField = f.page.getByRole("textbox", { name: "Goal objective" });
     const budget = f.page.getByRole("spinbutton", { name: "Token budget (optional)" });
-    if (budgets) await budget.fill("1000");
+    // The second round's Set goal button is already there, so wait until the notified commands reach the form (its
+    // budget field follows them) before typing: a reread landing mid-typing remounts the form.
+    await expect(objectiveField).toBeVisible();
+    if (budgets) await expect(budget).toBeVisible();
     else await expect(budget).toHaveCount(0);
+    await objectiveField.fill(objective);
+    if (budgets) await budget.fill("1000");
     const start = f.page.getByRole("button", { name: "Start goal", exact: true });
     await expect(start).toBeEnabled();
     await start.click();
@@ -199,7 +204,11 @@ test("a paused goal stays cancellable while a message is sending or its delivery
     await f.primary.getByRole("button", { name: "Set goal", exact: true }).click();
     await f.page.getByRole("textbox", { name: "Goal objective" }).fill(objective);
     await f.page.getByRole("button", { name: "Start goal", exact: true }).click();
-    await f.primary.getByRole("button", { name: "Goal running", exact: true }).click();
+    // As in the commands test: the running goal can show before Start has closed its menu, so wait for it to close.
+    const running = f.primary.getByRole("button", { name: "Goal running", exact: true });
+    await expect(running).toBeVisible();
+    await expect(running).toHaveAttribute("aria-expanded", "false");
+    await running.click();
     await f.page.getByRole("button", { name: "Pause goal", exact: true }).click();
     await expect(f.primary.getByRole("button", { name: "Goal paused", exact: true })).toBeVisible();
     await f.page.keyboard.press("Escape");
@@ -459,7 +468,9 @@ test("a Start accepted behind the running turn stays Starting… until its goal
   // A Start the conversation finishes without says so and keeps its objective.
   await control("Goal running").click();
   await f.page.getByRole("button", { name: "Cancel goal", exact: true }).click();
-  await expect(control("Set goal")).toBeVisible();
+  // A successful Cancel closes the menu, as Start does; Set goal opens it again.
+  await expect(control("Set goal")).toHaveAttribute("aria-expanded", "false");
+  await control("Set goal").click();
   await objective.fill("Never takes effect");
   await start.click();
   await expect.poll(async () => (await starts()).length).toBe(2);
@@ -1653,6 +1664,10 @@ test("canonical model controls use the supplied reactive owner and disappear wit
   assert.deepEqual(await f.page.evaluate(() => window.conversationFixture.modelState()), {
     selected: "large", applied: "large", saving: false, selections: ["large"]
   });
+  // A finished Apply closes the menu. Reopen it once it has finished closing: Vuetify 4.3 ignores a click on the
+  // activator while the menu's close transition still runs.
+  await expect(choose).toHaveAttribute("aria-expanded", "false");
+  await expect(f.page.locator(".assistant-model-control")).toBeHidden();
   await choose.click();
   await f.page.evaluate(() => window.conversationFixture.modelError("Reconnect the application catalogue."));
   await expect(f.page.getByText("Reconnect the application catalogue.", { exact: true })).toBeVisible();