@jskit-ai/assistant-runtime 0.1.208 → 0.1.210

package/fixtures/canonical-conversation/vite.config.mjs

@@ -155,6 +155,7 @@ export default defineConfig({
             return json({ ok: true, delivered: true, messageId: input.messageId }, 202);
           }
           if (mode === "rejected") return json({ error: "The message was rejected before admission.", code: "ACTION_VALIDATION_FAILED" }, 400);
+          if (mode === "unadmitted") return json({ error: "Request failed with status 503." }, 503);
           if (mode === "uncertain") {
             state.status = "unconfirmed";
             state.pendingRequest = { messageId: input.messageId, text: input.text, origin: "user",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jskit-ai/assistant-runtime",
-  "version": "0.1.208",
+  "version": "0.1.210",
   "type": "module",
   "scripts": {
     "test": "node --test --test-concurrency=1"
@@ -12,19 +12,19 @@
     "./server": "./src/server/index.js"
   },
   "dependencies": {
-    "@jskit-ai/assistant-core": "0.1.215",
+    "@jskit-ai/assistant-core": "0.1.217",
     "json-rest-schema": "^1.0.17"
   },
   "peerDependencies": {
-    "@jskit-ai/http-runtime": "0.1.235",
-    "@jskit-ai/http-web": "0.1.82",
-    "@jskit-ai/kernel": "0.1.237",
-    "@jskit-ai/realtime": "0.1.234",
-    "@jskit-ai/shell-web": "0.1.241",
+    "@jskit-ai/http-runtime": "0.1.237",
+    "@jskit-ai/http-web": "0.1.84",
+    "@jskit-ai/kernel": "0.1.239",
+    "@jskit-ai/realtime": "0.1.236",
+    "@jskit-ai/shell-web": "0.1.243",
     "@tanstack/vue-query": "^5.90.5",
     "vue": "^3.5.13",
     "vuetify": "^4.0.0",
-    "@jskit-ai/database-runtime": "0.1.237"
+    "@jskit-ai/database-runtime": "0.1.239"
   },
   "description": "Capability-based assistant runtime with per-surface chat, transcripts, settings, and action tools.",
   "jskit": {

package/src/client/composables/useAssistantConversation.js

@@ -117,7 +117,8 @@ function createConversation(identity, { api, socket, actorKey, placement, reader
   const queueing = computed(() => queueWhileSending !== false && (steerable.value || workingPolicy.value.deferWhileWorking || workingPolicy.value.admitWhileWorking));
   const canSubmit = computed(() => available.value && (snapshot.value.status === "ready" || steerable.value || (workingPolicy.value.deferWhileWorking || workingPolicy.value.admitWhileWorking) && snapshot.value.status === "working") &&
     (queueWhileSending !== false || !delivery.state.sending) &&
-    !delivery.state.messages.some(message => message.status === "uncertain"));
+    !delivery.state.messages.some(message => message.status === "uncertain" &&
+      (snapshot.value.status !== "ready" || !message.payload || text(message.payload.draft ?? message.payload.message) === text(draft))));
   const savedDraft = toValue(draftStorage);
   if (savedDraft && (typeof savedDraft.key !== "string" || !savedDraft.key ||
       !["getItem", "setItem", "removeItem"].every(name => typeof savedDraft.storage?.[name] === "function"))) {
@@ -340,8 +341,6 @@ function createConversation(identity, { api, socket, actorKey, placement, reader
     for (const pending of pendingMessages.values()) pending.controller.abort();
     pendingMessages.clear();
     goalReadController?.abort();
-    globalThis.removeEventListener?.("focus", refreshVisibleGoal);
-    globalThis.document?.removeEventListener("visibilitychange", refreshVisibleGoal);
     delivery.reset();
   });
 
@@ -350,6 +349,8 @@ function createConversation(identity, { api, socket, actorKey, placement, reader
     if (retry?.status === "failed" && retry.payload.goalRequest) return changeGoal(retry.payload.goalRequest.action, {}, { messageId });
     if (!canSubmit.value) return false;
     if (retry && retry.status !== "failed") return false;
+    if (delivery.state.messages.some(message => message.status === "uncertain" &&
+        text(message.payload?.message) === text((retry?.payload || payload).message))) return false;
     const request = retry?.payload?.request || payload.request;
     const requestedSteering = request?.steer === true;
     if (requestedSteering && snapshot.value.capabilities?.steering !== true) return false;
@@ -572,11 +573,6 @@ function createConversation(identity, { api, socket, actorKey, placement, reader
     goalRead = job;
     return job;
   }
-  function refreshVisibleGoal() {
-    if (!globalThis.document?.hidden) void refreshGoal();
-  }
-  globalThis.addEventListener?.("focus", refreshVisibleGoal);
-  globalThis.document?.addEventListener("visibilitychange", refreshVisibleGoal);
   async function changeGoal(action, input = {}, { messageId = crypto.randomUUID() } = {}) {
     const view = goalView.value;
     const target = view?.target;
@@ -665,9 +661,16 @@ function createConversation(identity, { api, socket, actorKey, placement, reader
       if (!current.value) return false;
       if (receipt.status === "accepted") delivery.accept(messageId);
       else if (receipt.status === "not-sent" && receipt.messageId === messageId) delivery.rejectUnsent(messageId, receipt.error);
+      else if (receipt.status === "unknown" && message?.status === "uncertain") {
+        message.error = "Delivery is still unknown. Retry to check again.";
+      }
       subscription?.reload();
       return receipt;
-    } catch (failure) { receiveError(failure); return false; }
+    } catch (failure) {
+      if (current.value && message?.status === "uncertain") message.error = failure.message || "Delivery could not be checked.";
+      receiveError(failure);
+      return false;
+    }
     finally { if (message) message.checking = false; }
   }
 

package/test/assistantConversationBinding.browser.test.js

@@ -51,7 +51,7 @@ test("inspecting a restored no-admission request releases Send while preserving
   await f.command("mode", { mode: "uncertain" });
   await f.input.fill("Original unadmitted words");
   await f.input.press("Enter");
-  const check = f.primary.getByRole("button", { name: "Check delivery", exact: true });
+  const check = f.primary.getByRole("button", { name: "Retry delivery check", exact: true });
   await expect(check).toBeVisible();
   const [original] = await f.sent();
   await f.input.fill("A separate newer draft");
@@ -62,7 +62,7 @@ test("inspecting a restored no-admission request releases Send while preserving
   await attach();
   await expect(f.input).toHaveValue("A separate newer draft");
   const send = f.primary.getByRole("button", { name: "Send message", exact: true });
-  await expect(send).toBeDisabled();
+  await expect(send).toBeEnabled();
   await f.page.evaluate(() => window.conversationFixture.attachments(true));
   await f.primary.locator("input[type=file]").setInputFiles({ name: "newer.txt", mimeType: "text/plain", buffer: Buffer.from("Keep this upload") });
   const uploads = () => f.page.evaluate(() => window.conversationFixture.attachmentState());
@@ -222,7 +222,7 @@ test("a lost goal receipt uses the same inspection-only ledger and never starts
   await expect(start).toBeEnabled();
   await start.click();
   await f.input.click();
-  const check = f.primary.getByRole("button", { name: "Check delivery", exact: true });
+  const check = f.primary.getByRole("button", { name: "Retry delivery check", exact: true });
   await expect(check).toBeVisible();
   await expect(f.primary.getByText("Finish the uncertain goal", { exact: true })).toHaveCount(1);
   const requests = async () => (await f.state()).requests.filter(request => request.suffix === "/goal" && request.method === "POST");
@@ -288,7 +288,9 @@ test("a supplied goal view keeps its pinned target and refreshes through the ret
   await expect.poll(() => reads).toBeGreaterThan(beforeReconnect);
   const beforeFocus = reads;
   await f.page.evaluate(() => window.dispatchEvent(new Event("focus")));
-  await expect.poll(() => reads).toBeGreaterThan(beforeFocus);
+  await f.page.evaluate(() => document.dispatchEvent(new Event("visibilitychange")));
+  await f.page.waitForTimeout(100);
+  assert.equal(reads, beforeFocus, "Focus and visibility do not request goal state");
   await expect.poll(() => f.page.evaluate(() => window.conversationFixture.current().goalState.value.pending)).toBe(false);
   failedRead = true;
   await f.page.evaluate(() => window.conversationFixture.current().refreshGoal());
@@ -389,7 +391,7 @@ test("explicit delivery inspection acknowledges uncertain attachments without cl
   await f.command("mode", { mode: "uncertain" });
   await f.input.fill("Inspect this file.");
   await f.input.press("Enter");
-  const check = f.primary.getByRole("button", { name: "Check delivery", exact: true });
+  const check = f.primary.getByRole("button", { name: "Retry delivery check", exact: true });
   await expect(check).toBeVisible();
   assert.deepEqual((await attachments()).acknowledged, []);
   await files.setInputFiles({ name: "newer.txt", mimeType: "text/plain", buffer: Buffer.from("Keep this newer file") });
@@ -620,7 +622,7 @@ test("canonical receipts settle a held response and uncertain delivery stays ins
   await f.command("mode", { mode: "uncertain" });
   await f.input.fill("Keep this exact uncertain request");
   await f.input.press("Enter");
-  const check = f.primary.getByRole("button", { name: "Check delivery", exact: true });
+  const check = f.primary.getByRole("button", { name: "Retry delivery check", exact: true });
   await expect(check).toBeVisible();
   await expect(f.primary.getByText("Keep this exact uncertain request", { exact: true })).toHaveCount(1);
   await expect(f.primary.getByRole("button", { name: /^(Retry|Edit|Cancel)$/u })).toHaveCount(0);
@@ -717,7 +719,7 @@ for (const status of ["uncertain", "pending", "accepted", "failed", "unrecognise
     assert.equal((await f.sent()).length, 1, "restoration never dispatches a saved request");
     assert.equal(await f.page.evaluate(() => window.savedBinding.runtime.value.canSubmit.value), !unconfirmed);
     if (unconfirmed) {
-      const check = f.primary.getByRole("button", { name: "Check delivery", exact: true });
+      const check = f.primary.getByRole("button", { name: "Retry delivery check", exact: true });
       try { await expect(check).toBeEnabled(); }
       catch (failure) {
         t.diagnostic(JSON.stringify(await f.page.evaluate(() => {
@@ -750,7 +752,7 @@ for (const status of ["uncertain", "pending", "accepted", "failed", "unrecognise
       await expect(check).toHaveCount(0);
       assert.equal((await f.sent()).length, 1, "only the actual canonical receipt settles the original identity");
     } else {
-      await expect(f.primary.getByRole("button", { name: "Check delivery", exact: true })).toHaveCount(0);
+      await expect(f.primary.getByRole("button", { name: "Retry delivery check", exact: true })).toHaveCount(0);
       await expect(f.primary.getByRole("button", { name: "Retry", exact: true })).toHaveCount(status === "failed" ? 1 : 0);
     }
   });
@@ -779,7 +781,7 @@ test(`an explicit pre-admission rejection retains original retry identity and th
   assert.equal((await f.sent()).length, 1, "a definite rejection never silently resubmits steering as new work");
   assert.equal(await f.page.evaluate(id => window.conversationFixture.current().delivery.find(id).status, rejected.input.messageId), "failed");
   assert.equal(await f.page.evaluate(() => window.conversationFixture.current().canSubmit.value), true);
-  await expect(f.primary.getByRole("button", { name: "Check delivery", exact: true })).toHaveCount(0);
+  await expect(f.primary.getByRole("button", { name: "Retry delivery check", exact: true })).toHaveCount(0);
   if (code === "conversation_not_steerable") {
     assert.equal(rejected.input.steer, true);
   }
@@ -924,7 +926,7 @@ test("authored application data stays captured across retry, a lost receipt and
   await f.input.fill("Keep the newer typed draft");
   await f.command("mode", { mode: "uncertain" });
   await f.primary.getByRole("button", { name: "Retry", exact: true }).click();
-  const check = f.primary.getByRole("button", { name: "Check delivery", exact: true });
+  const check = f.primary.getByRole("button", { name: "Retry delivery check", exact: true });
   await expect(check).toBeVisible();
   assert.deepEqual((await f.sent())[1].input, original.input);
   assert.deepEqual(await f.page.evaluate(() => window.conversationFixture.current().delivery.state.messages[0].payload.request.data), originalData);
@@ -1066,7 +1068,7 @@ test("canonical questions retry their exact formatted reply and uncertain delive
   await f.input.fill("A separate newer thought.");
   await f.command("mode", { mode: "uncertain" });
   await f.primary.getByRole("button", { name: "Retry", exact: true }).click();
-  const check = f.primary.getByRole("button", { name: "Check delivery", exact: true });
+  const check = f.primary.getByRole("button", { name: "Retry delivery check", exact: true });
   await expect(check).toBeVisible();
   const requests = await f.sent();
   assert.equal(requests.length, 2);
@@ -1312,7 +1314,7 @@ test("accepted draft identity survives voice retention and lost receipts without
   await expect(f.input).toHaveValue("Keep the typed capture.");
   await f.command("mode", { mode: "uncertain" });
   await f.input.press("Enter");
-  const check = f.primary.getByRole("button", { name: "Check delivery", exact: true });
+  const check = f.primary.getByRole("button", { name: "Retry delivery check", exact: true });
   await expect(check).toBeVisible();
   assert.deepEqual((await f.sent())[2].input, typed.input);
   await expect(f.input).toHaveValue("Keep the typed capture.");
@@ -1414,7 +1416,7 @@ test("a voice preview cannot acknowledge sending or uncertain delivery and dedup
   await f.command("mode", { mode: "uncertain" });
   await f.input.fill("Keep this uncertain request.");
   await f.input.press("Enter");
-  const check = f.primary.getByRole("button", { name: "Check delivery", exact: true });
+  const check = f.primary.getByRole("button", { name: "Retry delivery check", exact: true });
   await expect(check).toBeVisible();
   const second = (await f.sent())[1].input.messageId;
   await preview(second, "An uncertain preview is not an acknowledgement.");
@@ -1450,7 +1452,7 @@ test("an interim reply stays on its exact turn without acknowledging delivery an
   await f.command("mode", { mode: "uncertain" });
   await f.input.fill("Check the project before answering.");
   await f.input.press("Enter");
-  const check = f.primary.getByRole("button", { name: "Check delivery", exact: true });
+  const check = f.primary.getByRole("button", { name: "Retry delivery check", exact: true });
   await expect(check).toBeVisible();
   const [{ input: { messageId } }] = await f.sent();
   const reply = { id: "native-ack", outputId: "native-ack-output", turnId: messageId,
@@ -2497,7 +2499,7 @@ test("an exact host pre-admission receipt preserves one manual retry and actor a
   await expect(f.primary.getByText("Failed: The host refused this message before native admission.", { exact: true })).toBeVisible();
   const [original] = await f.sent();
   assert.equal(await f.page.evaluate(id => window.conversationFixture.current().delivery.find(id).status, original.input.messageId), "failed");
-  await expect(f.primary.getByRole("button", { name: "Check delivery", exact: true })).toHaveCount(0);
+  await expect(f.primary.getByRole("button", { name: "Retry delivery check", exact: true })).toHaveCount(0);
   await f.input.fill("Keep my newer draft");
   await f.page.evaluate(() => window.conversationFixture.data({ originId: "newer-tab", choice: "newer" }));
   assert.equal((await f.sent()).length, 1, "a rejection never retries automatically");
@@ -2532,7 +2534,7 @@ for (const kind of ["mismatched-id", "malformed-status", "missing-marker", "post
     });
     await f.input.fill("Do not resubmit unknown work");
     await f.input.press("Enter");
-    const check = f.primary.getByRole("button", { name: "Check delivery", exact: true });
+    const check = f.primary.getByRole("button", { name: "Retry delivery check", exact: true });
     await expect(check).toBeVisible();
     const [original] = await f.sent();
     await check.click();
@@ -2663,7 +2665,7 @@ test("application admission keeps unknown delivery inspection-only and rejects c
   await f.command("mode", { mode: "uncertain" });
   await f.input.fill("Do not repeat unknown work");
   await f.input.press("Enter");
-  const check = f.primary.getByRole("button", { name: "Check delivery", exact: true });
+  const check = f.primary.getByRole("button", { name: "Retry delivery check", exact: true });
   await expect(check).toBeVisible();
   const [original] = await f.sent();
   await f.input.fill("Keep my newer draft");
@@ -2892,3 +2894,47 @@ test("changing the observed native segment blocks cached goal controls until the
     releaseRead?.();
   }
 });
+
+
+test("unknown delivery reports its current result and allows different idle input without replaying the old message", options, async t => {
+  const f = await fixture(t, 390);
+  await f.command("mode", { mode: "unadmitted" });
+  await f.input.fill("Original uncertain request");
+  await f.input.press("Enter");
+  const check = f.primary.getByRole("button", { name: "Retry delivery check", exact: true });
+  const send = f.primary.getByRole("button", { name: "Send message", exact: true });
+  await expect(check).toBeVisible();
+  const bubble = f.primary.locator(".assistant-transcript__message--user").filter({ hasText: "Original uncertain request" });
+  await expect(bubble.getByRole("button", { name: "Retry delivery check", exact: true })).toHaveCount(1);
+  await expect(bubble).not.toHaveClass(/assistant-transcript__message--unconfirmed/u);
+  const recovery = bubble.locator(".assistant-transcript__optimistic-failure");
+  assert.ok(await recovery.evaluate(el => parseFloat(getComputedStyle(el).fontSize) < 14));
+  await expect(check).toHaveClass(/v-btn--variant-text/u);
+  await expect(f.primary.locator(".assistant-transcript__system")).toHaveCount(0);
+  await expect(bubble.getByText("Request failed with status 503.", { exact: true })).toBeVisible();
+  await f.input.fill("Original uncertain request");
+  await expect(send).toBeDisabled();
+  await f.input.fill("A different message");
+  await expect(send).toBeEnabled();
+  await check.click();
+  await expect(f.primary.getByText("Delivery is still unknown.", { exact: false })).toBeVisible();
+  await expect(f.input).toHaveValue("A different message");
+  await expect(bubble.getByText("Request failed with status 503.", { exact: true })).toHaveCount(0);
+  const screenshots = process.env.JSKIT_ASSISTANT_SCREENSHOTS;
+  for (const width of [390, 1280]) {
+    await f.page.setViewportSize({ width, height: 900 });
+    await expect(bubble.getByRole("button", { name: "Retry delivery check", exact: true })).toBeVisible();
+    assert.ok(await f.page.evaluate(() => document.documentElement.scrollWidth <= innerWidth));
+    if (screenshots) await f.page.screenshot({ path: `${screenshots}/delivery-attached-${width}.png` });
+  }
+  assert.equal((await f.sent()).length, 1);
+  await f.command("mode", { mode: "product-accepted" });
+  await send.click();
+  await expect.poll(async () => (await f.sent()).length).toBe(2);
+  const [old, next] = await f.sent();
+  assert.notEqual(old.input.messageId, next.input.messageId);
+  assert.equal(next.input.text, "A different message");
+  await expect(check).toBeVisible();
+  assert.equal(await f.page.evaluate(id => window.conversationFixture.current().delivery.find(id).status,
+    old.input.messageId), "uncertain");
+});