@jskit-ai/assistant-core 0.1.243 → 0.2.0

package/src/server/lib/ndjson.js

@@ -27,6 +27,23 @@ function endNdjson(reply) {
   reply.raw.end();
 }
 
+function isRecord(value) {
+  return Boolean(value) && typeof value === "object" && !Array.isArray(value);
+}
+
+// The client renders code, params or messageCode in the user's language and
+// falls back to message, like an HTTP error response.
+function streamMessageFields(error, hidden) {
+  if (hidden) {
+    return { params: {}, messageCode: "assistant.stream.failed", messageParams: {} };
+  }
+  const params = isRecord(error?.params) ? error.params : {};
+  if (error?.messageCode) {
+    return { params, messageCode: String(error.messageCode), messageParams: isRecord(error.messageParams) ? error.messageParams : {} };
+  }
+  return error?.message ? { params } : { params, messageCode: "assistant.stream.requestFailed", messageParams: {} };
+}
+
 function mapStreamError(error) {
   const status = Number(error?.status || error?.statusCode || 500);
   const safeStatus = Number.isInteger(status) && status >= 400 && status <= 599 ? status : 500;
@@ -34,7 +51,8 @@ function mapStreamError(error) {
   return Object.freeze({
     code: String(error?.code || "assistant_stream_failed").trim() || "assistant_stream_failed",
     message: safeStatus >= 500 ? "Assistant stream failed." : String(error?.message || "Request failed."),
-    status: safeStatus
+    status: safeStatus,
+    ...streamMessageFields(error, safeStatus >= 500)
   });
 }
 

package/src/server/lib/providers/common.js

@@ -58,7 +58,7 @@ function normalizeOptionalHttpUrl(value, { context = "assistant baseUrl" } = {})
 
 function createDisabledClient({ provider = DEFAULT_AI_PROVIDER, model = "" } = {}) {
   const disabledError = () => {
-    throw new AppError(503, "Assistant provider is not configured.");
+    throw new AppError(503, "Assistant provider is not configured.", { code: "assistant.provider.notConfigured" });
   };
 
   return Object.freeze({
@@ -80,9 +80,14 @@ function createProviderRequestError({ status = 500, code = "assistant_provider_f
   const normalizedCode = normalizeText(code) || "assistant_provider_failed";
   const normalizedMessage =
     normalizeText(message) || (safeStatus >= 500 ? "Assistant provider request failed." : "Request failed.");
+  // A provider's own message is shown as sent; JSKIT's fallback sentences are named.
+  const fallbackMessage = normalizeText(message) ? {} : safeStatus >= 500
+    ? { messageCode: "assistant.provider.requestFailed" }
+    : { messageCode: "assistant.provider.requestRejected" };
 
   return new AppError(safeStatus, normalizedMessage, {
-    code: normalizedCode
+    code: normalizedCode,
+    ...fallbackMessage
   });
 }
 

package/src/shared/conversation/numberedQuestionSugar.js

@@ -264,6 +264,10 @@ function numberedQuestionSugarForMessageInput({
   return parseNumberedQuestionPrompt(message);
 }
 
+// requiredMessage stays English; a client shows it in the active language with
+// serverMessage({ message: requiredMessage, messageCode: requiredMessageCode, messageParams: requiredMessageParams }).
+const ANSWER_REQUIRED = Object.freeze({ messageCode: "assistant.questions.answerRequired" });
+
 function numberedQuestionInputFields(questions = [], options = {}) {
   const autocomplete = String(options?.autocomplete || "").trim();
   const density = String(options?.density || "").trim();
@@ -274,7 +278,9 @@ function numberedQuestionInputFields(questions = [], options = {}) {
     label: question.label,
     name: question.name,
     required: true,
-    requiredMessage: `Answer question ${question.number}.`
+    requiredMessage: `Answer question ${question.number}.`,
+    requiredMessageCode: ANSWER_REQUIRED.messageCode,
+    requiredMessageParams: { number: question.number }
   }));
 }
 

package/src/shared/conversation/turns.js

@@ -9,6 +9,13 @@ export function conversationTurnMessages(turn) {
   ].filter(Boolean);
 }
 
+// A finished turn without text shows its status. The English stays in text; textCode
+// lets a client show it in the user's language.
+const STATUS_TEXTS = Object.freeze({
+  interrupted: Object.freeze({ text: "Stopped.", messageCode: "assistant.turn.stopped" }),
+  failed: Object.freeze({ text: "Assistant stopped with an error.", messageCode: "assistant.turn.failed" })
+});
+
 /** Adapt ordered messages to the transcript's turn model without changing their metadata. */
 export function conversationTurnsFromMessages(messages = []) {
   const turns = [];
@@ -30,8 +37,9 @@ export function conversationTurnsFromMessages(messages = []) {
       for (const [progressIndex, progress] of (message.progressUpdates || []).entries()) {
         current.messages.push({ ...progress, role: progress.role || "thinking", messageId: `${message.messageId}:progress:${progress.id || progressIndex}` });
       }
-      if (!message.text && ["failed", "interrupted"].includes(message.status)) {
-        message.text = message.status === "interrupted" ? "Stopped." : "Assistant stopped with an error.";
+      if (!message.text && Object.hasOwn(STATUS_TEXTS, message.status)) {
+        message.text = STATUS_TEXTS[message.status].text;
+        message.textCode = STATUS_TEXTS[message.status].messageCode;
       }
       current.assistant = message;
     }

package/test/i18nCatalog.test.js

@@ -0,0 +1,22 @@
+import assert from "node:assert/strict";
+import path from "node:path";
+import test from "node:test";
+import { fileURLToPath } from "node:url";
+import { evaluateI18nCatalogContract } from "../../../tooling/test-support/i18nCatalogContract.mjs";
+
+const TEST_DIRECTORY = path.dirname(fileURLToPath(import.meta.url));
+const REPO_ROOT = path.resolve(TEST_DIRECTORY, "..", "..", "..");
+
+test("assistant-core English catalog matches its source", () => {
+  const { problems } = evaluateI18nCatalogContract({
+    repoRoot: REPO_ROOT,
+    packageDir: path.join(REPO_ROOT, "packages", "assistant-core"),
+    // runOpenCodeConversationTurn builds these codes as `assistant_opencode_turn_${reason}`.
+    externalCodes: [
+      "assistant_opencode_turn_thread_mismatch",
+      "assistant_opencode_turn_fresh_thread_required",
+      "assistant_opencode_turn_unrelated_history"
+    ]
+  });
+  assert.deepEqual(problems, []);
+});

package/test/openCodeProcess.test.js

@@ -3,7 +3,7 @@ import { access, mkdtemp, rm } from "node:fs/promises";
 import os from "node:os";
 import path from "node:path";
 import test from "node:test";
-import { createOpenCodeServerProcess } from "../src/server/conversation/openCodeProcess.js";
+import { createOpenCodeServerProcess, openCodeProcessEnvironment } from "../src/server/conversation/openCodeProcess.js";
 
 async function fixture(t, options = {}) {
   const workdir = await mkdtemp(path.join(os.tmpdir(), "jskit-opencode-process-"));
@@ -175,3 +175,17 @@ test("production stop retains failure for retry and keeps the complete confirmed
   assert.equal(attempt, 3);
   await assert.rejects(access(f.config.privateRoot), { code: "ENOENT" });
 });
+
+test("a server that needs no packages makes OpenCode's plugin install fail at once", () => {
+  const installing = openCodeProcessEnvironment({}, { cacheRoot: "/cache" });
+  assert.equal(installing.npm_config_cache, "/cache/npm");
+  assert.equal(installing.npm_config_prefer_offline, "true");
+  assert.equal(installing.npm_config_offline, undefined);
+  // A real OpenCode 1.18.31 catalogue server stopped mid-install ignored SIGTERM
+  // for the whole systemd stop timeout; offline from an empty cache it stopped in
+  // under 50 ms and returned the same providers and agents.
+  const offline = openCodeProcessEnvironment({}, { cacheRoot: "/cache", packageInstalls: false });
+  assert.equal(offline.npm_config_offline, "true");
+  assert.equal(offline.npm_config_cache, "/cache/npm-offline");
+  assert.equal(offline.npm_config_prefer_offline, undefined);
+});