@jskit-ai/assistant-core 0.1.239 → 0.1.240

package/examples/conversation/package.json

@@ -8,14 +8,14 @@
     "build": "vite build"
   },
   "dependencies": {
-    "@jskit-ai/assistant-core": "0.1.239",
+    "@jskit-ai/assistant-core": "0.1.240",
     "@jskit-ai/http-runtime": "0.1.243",
     "@jskit-ai/kernel": "0.1.245",
     "@mdi/js": "^7.4.47",
     "vue": "^3.5.13",
     "vuetify": "^4.0.0",
     "@jskit-ai/connectors-core": "0.1.62",
-    "@jskit-ai/connectors-catalog": "0.1.63"
+    "@jskit-ai/connectors-catalog": "0.1.64"
   },
   "devDependencies": {
     "@vitejs/plugin-vue": "^6.0.7",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jskit-ai/assistant-core",
-  "version": "0.1.239",
+  "version": "0.1.240",
   "type": "module",
   "scripts": {
     "test": "node --test --test-concurrency=1"

package/src/server/conversation/claudeTurn.js

@@ -893,6 +893,14 @@ export function createClaudeConversationOwner({
     return { status: "available", threadId: entry.id, goal: await entry.goals.read(history), goalCommandId: history.goalCommandId || null };
   }
 
+  // A native Set, Resume or Cancel supersedes a retained Pause or blocker.
+  async function releaseRetainedGoal(entry) {
+    if (!entry.pausedGoal && !entry.blockedGoal) return;
+    entry.pausedGoal = null;
+    entry.blockedGoal = null;
+    await store.save(entry);
+  }
+
   async function updateGoal(entry, input, operations) {
     await bindAccount(entry);
     const call = applicationCall.getStore();
@@ -928,7 +936,7 @@ export function createClaudeConversationOwner({
       for (;;) {
         const history = await readHistory(entry);
         if (history.goalCommandId === claudeNativeMessageId(messageId)) {
-          if (entry.pausedGoal || entry.blockedGoal) { entry.pausedGoal = null; entry.blockedGoal = null; await store.save(entry); }
+          await releaseRetainedGoal(entry);
           result = { status: "available", threadId: entry.id, goal: await entry.goals.read(history), goalCommandId: history.goalCommandId };
           break;
         }
@@ -1124,7 +1132,7 @@ export function createClaudeConversationOwner({
     if (!binding) return { value: delivered.value };
   }
 
-  return Object.freeze({ applicationToolsSupported: true, entries, closingSessions, get closing() { return closing; }, createAccountQueries, open, acquire, createConversation, snapshot, readRetainedTurn, readFinalAssistantResult, readHistory, ensureReady, ensureProcess, readContextUsage, compactContext, stopForTerminal, prepareTerminal, send, startTurn,
+  return Object.freeze({ applicationToolsSupported: true, entries, closingSessions, get closing() { return closing; }, createAccountQueries, open, acquire, createConversation, snapshot, readRetainedTurn, readFinalAssistantResult, readHistory, ensureReady, ensureProcess, readContextUsage, compactContext, releaseRetainedGoal, stopForTerminal, prepareTerminal, send, startTurn,
     interrupt, read, inspectAdmission, hasActiveTemporaryConversation, hasActiveConversation, retireConversationHistory, reconcileSessions, restoreSessionEntries, closeSession, closeProject, invalidateRuntimes, drain, forget, close, deleteConversation, recover, stopSelected, wait, stopConversation,
     readGoal, updateGoal, renewal, run, steer, cancel });
 }

package/src/server/conversation/codexGoalCommands.js

@@ -117,7 +117,7 @@ export function createCodexGoalCommands({
       params: { goal: result.goal }
     });
     await publish(sessionId, { reason: "codex-goal", nativeGoal: { threadId, goal: result.goal || null } });
-    return { ok: true, status: "available", goal: result.goal || null };
+    return { ok: true, status: "available", threadId, goal: result.goal || null };
   }
 
 

package/src/server/conversation/providers/claudeDriver.js

@@ -170,6 +170,8 @@ export function createClaudeConversationDriver({ connections, host = {}, limits
         if (event.type === "message") await current.onMessage({ ...event.message, transient: !event.message.complete });
         else if (event.type === "message-complete") await current.onEvent(event);
         else if ((event.type === "admitted" && current.goal) || event.type === "settled") {
+          // Claude has the authored /goal command; it now owns the goal state.
+          if (event.type === "admitted" && current.goal.action !== "pause") await standalone.releaseRetainedGoal(entry);
           await current.onEvent({ type: "goal", goal: claudeGoalValue(await entry.goals.read(), entry.id) });
         } else if (event.type === "phase") await current.onEvent({ type: "phase", phase: ["compacting", "background"].includes(event.phase) ? event.phase : "working" });
       }

package/src/server/conversation/providers/codexDriver.js

@@ -933,7 +933,7 @@ export function createCodexConversationDriver({ connections, host = {}, limits =
                   createdAt: goal?.createdAt, objective: input.action === "set" ? input.objective : goal?.objective };
               }
               result = await owner.updateGoal(sessionId, command, {
-                context: nativeContext, signal: context.signal, prepareConversation: () => goalContext(configuration, context, undefined, { prepareThread: true })
+                context: nativeContext, signal: context?.signal, prepareConversation: () => goalContext(configuration, context, undefined, { prepareThread: true })
               });
               if (result.ok !== false) binding.goal = result.goal || null;
             } finally { admission.release(); }
@@ -957,7 +957,7 @@ export function createCodexConversationDriver({ connections, host = {}, limits =
           if ((goalValue(goal)?.id || null) !== (input.expectedGoalId || null)) throw new Error("The native goal changed. Read it again before changing it.");
           const result = await owner.updateGoal(sessionId, { ...input, threadId: binding.threadId,
             createdAt: goal?.createdAt, objective: input.action === "set" ? input.objective : goal?.objective }, {
-            context: nativeContext, signal: context.signal,
+            context: nativeContext, signal: context?.signal,
             prepareConversation: () => goalContext(configuration, context, signal, { prepareThread: true, tools })
           });
           if (result.ok === false) throw new Error(result.error);

package/test/assistantScroll.browser.test.js

@@ -13,6 +13,19 @@ import {
 const TEST_DIRECTORY = path.dirname(fileURLToPath(import.meta.url));
 const FIXTURE_ROOT = path.resolve(TEST_DIRECTORY, "../fixtures/responsive-assistant");
 const RUN_BROWSER_TEST = process.env.JSKIT_ASSISTANT_CORE_BROWSER_INTEGRATION === "1";
+// Turns use content-visibility estimates. Moving the reader materializes rows
+// near the new position, and Chromium's scroll anchoring then shifts scrollTop
+// to keep the same content in view. Hold a reading position only once that
+// layout has settled, so later checks measure the conversation, not the estimates.
+async function settleReaderAt(body, scrollTop) {
+  await expect.poll(() => body.evaluate(async (element, top) => {
+    element.scrollTop = top;
+    const height = element.scrollHeight;
+    await new Promise(resolve => requestAnimationFrame(() => requestAnimationFrame(resolve)));
+    return element.scrollTop === top && element.scrollHeight === height;
+  }, scrollTop)).toBe(true);
+}
+
 const VIEWPORTS = Object.freeze([
   Object.freeze({ name: "phone", width: 390, height: 844 }),
   Object.freeze({ name: "compact", width: 800, height: 900 }),
@@ -405,6 +418,14 @@ test("upward scrolling loads older history once and preserves retry and selectio
       await expect(page.getByText("Conversation line 70:", { exact: false })).toBeVisible();
       await expect(requests).toHaveText("History requests: 3");
       await external("Exhaust history");
+      // Removing the history control re-anchors the scroller, which would
+      // cancel a keyboard scroll already in flight; press Home once it settles.
+      await expect(page.getByRole("button", { name: "Load older messages", exact: true })).toHaveCount(0);
+      await expect.poll(() => body.evaluate(async element => {
+        const height = element.scrollHeight;
+        await new Promise(resolve => requestAnimationFrame(() => requestAnimationFrame(resolve)));
+        return element.scrollHeight === height;
+      })).toBe(true);
       await expect.poll(async () => {
         await body.focus();
         return body.evaluate(element => document.activeElement === element);
@@ -412,7 +433,6 @@ test("upward scrolling loads older history once and preserves retry and selectio
       await body.press("Home");
       await expect.poll(() => body.evaluate(element => element.scrollTop)).toBe(0);
       await expect(requests).toHaveText("History requests: 3");
-      await expect(page.getByRole("button", { name: "Load older messages", exact: true })).toHaveCount(0);
       assert.ok(await page.evaluate(() => document.documentElement.scrollWidth <= innerWidth));
       assert.deepEqual(errors, []);
       await page.close();
@@ -1235,15 +1255,18 @@ test("connection warnings keep avatar controls and Reload reachable without repl
       await body.hover();
       await page.mouse.wheel(0, -1000);
       await expect.poll(() => body.evaluate(element => element.scrollHeight - element.clientHeight - element.scrollTop)).toBeGreaterThan(50);
-      await body.evaluate(element => { element.scrollTop = 420; window.errorAvatarBody = element; });
-      await expect.poll(() => body.evaluate(element => element.scrollTop)).toBe(420);
+      await settleReaderAt(body, 420);
+      await body.evaluate(element => { window.errorAvatarBody = element; });
       const history = await body.locator(".assistant-transcript__turn").allTextContents();
       let reloads = 0;
       for (const size of ["standard", "large", "hidden"]) {
         await page.getByRole("combobox", { name: "Avatar preference", exact: true }).selectOption(size);
-        // Establish the reading position after changing the fixture-only avatar preference.
-        await body.evaluate(element => { element.scrollTop = 420; });
-        await expect.poll(() => body.evaluate(element => element.scrollTop)).toBe(420);
+        // Establish the reading position after changing the fixture-only avatar
+        // preference. A reader's own wheel detaches the view from the latest
+        // message even if a slow initial bottom scroll resumed following.
+        await body.hover();
+        await page.mouse.wheel(0, -200);
+        await settleReaderAt(body, 420);
         await external("Show update error");
         await expect(conversation).toHaveClass(/assistant-conversation--error/u);
         await expect(avatar).toHaveCSS("position", "absolute");

package/test/claudeConversationSession.test.js

@@ -320,7 +320,13 @@ async function fixture(t, options = {}) {
           attachment: { type: "goal_status", condition, sentinel: true, met: condition === "clear" } });
         if (process.env.TEST_GOAL_LOST_ACK) return;
         emit(frame);
-        if (condition === "clear") emit({ type: "result", subtype: "success", result: "" });
+        if (condition === "clear") {
+          // Claude 2.1.289 saves the clear's local-command receipt and ends it
+          // with a result naming the command and the authored message.
+          record({ type: "system", subtype: "local_command", uuid: frame.uuid + "-clear", parentUuid: frame.uuid,
+            commandRun: { command: "goal", args: "clear" }, content: "<local-command-stdout>Goal cleared: prior goal</local-command-stdout>" });
+          emit({ type: "result", subtype: "success", result: "", local_command: "goal", user_message_uuid: frame.uuid });
+        }
         return;
       }
       emit(frame);
@@ -1167,8 +1173,9 @@ test("Claude native goal commands use ordinary admission, pause retains the goal
   assert.equal(events.filter(event => event.type === "accepted").length, 3);
   assert.equal(events.some(event => event.type === "goal" && event.goal === null), true);
   const trace = await f.trace();
+  // Resume starts a new process, which first suspends the retained paused checker.
   assert.deepEqual(trace.filter(row => row.frame?.type === "user").map(row => row.frame.message.content),
-    ["/goal Tests pass", "/goal Tests pass", "/goal clear"]);
+    ["/goal Tests pass", "/goal clear", "/goal Tests pass", "/goal clear"]);
   const starts = trace.filter(row => row.args?.includes("--print"));
   assert.equal(starts.length, 3);
   assert.equal(starts[1].args.includes("--resume"), true);

package/test/codexConversationSession.test.js

@@ -1229,7 +1229,9 @@ async function fixture(t, options = {}) {
   t.after(async () => {
     try { for (const runtime of runtimes) await runtime.close(); }
     finally {
-      if (!options.execution) await execution.close();
+      // A supplied execution host is closed here too (its test may close it
+      // again): its native processes must stop before their folder is removed.
+      await execution.close();
       await rm(directory, { recursive: true, force: true });
     }
   });