@jsenv/test 3.4.0 → 3.4.1

package/dist/js/v8_coverage.js

@@ -301,7 +301,7 @@ const resolveAssociations = (associations, baseUrl) => {
         let patternResolved;
         try {
           patternResolved = String(new URL(pattern, baseUrl));
-        } catch (e) {
+        } catch {
           // it's not really an url, no need to perform url resolution nor encoding
           patternResolved = pattern;
         }

package/dist/jsenv_test.js

@@ -1887,7 +1887,7 @@ const validateDirectoryUrl = (value) => {
     } else {
       try {
         urlString = String(new URL(value));
-      } catch (e) {
+      } catch {
         return {
           valid: false,
           value,
@@ -1895,6 +1895,12 @@ const validateDirectoryUrl = (value) => {
         };
       }
     }
+  } else if (
+    value &&
+    typeof value === "object" &&
+    typeof value.href === "string"
+  ) {
+    value = value.href;
   } else {
     return {
       valid: false,
@@ -1937,7 +1943,7 @@ const validateFileUrl = (value, baseUrl) => {
     } else {
       try {
         urlString = String(new URL(value, baseUrl));
-      } catch (e) {
+      } catch {
         return {
           valid: false,
           value,
@@ -2048,7 +2054,7 @@ const baseUrlFallback = fileSystemPathToUrl(process.cwd());
 const ensureWindowsDriveLetter = (url, baseUrl) => {
   try {
     url = String(new URL(url));
-  } catch (e) {
+  } catch {
     throw new Error(`absolute url expect but got ${url}`);
   }
 
@@ -2058,7 +2064,7 @@ const ensureWindowsDriveLetter = (url, baseUrl) => {
 
   try {
     baseUrl = String(new URL(baseUrl));
-  } catch (e) {
+  } catch {
     throw new Error(
       `absolute baseUrl expect but got ${baseUrl} to ensure windows drive letter on ${url}`,
     );
@@ -3314,8 +3320,6 @@ const composeTwoV8Coverages = (firstV8Coverage, secondV8Coverage) => {
   if (secondV8Coverage.result.length === 0) {
     return firstV8Coverage;
   }
-
-  // eslint-disable-next-line import/no-unresolved
   const { mergeProcessCovs } = importWithRequire("@c88/v8-coverage");
   // "mergeProcessCovs" do not preserves source-map-cache during the merge
   // so we store sourcemap cache now
@@ -5550,7 +5554,6 @@ const startServerUsingCommand = async (
 
   const startedPromise = (async () => {
     const logScale = [100, 250, 500];
-    // eslint-disable-next-line no-constant-condition
     while (true) {
       if (errorReceived) {
         break;
@@ -7332,7 +7335,7 @@ ${webServer.rootDirectoryUrl}`);
     if (memoryUsageAPIAvailable) {
       const getMemoryUsage = async () => {
         const memoryUsage = await page.evaluate(
-          /* eslint-env browser */
+          /* eslint-disable no-undef */
           /* istanbul ignore next */
           async () => {
             const { performance } = window;
@@ -7355,7 +7358,7 @@ ${webServer.rootDirectoryUrl}`);
             }
             return null;
           },
-          /* eslint-env node */
+          /* eslint-enable no-undef */
         );
         return memoryUsage;
       };
@@ -7374,7 +7377,7 @@ ${webServer.rootDirectoryUrl}`);
     if (collectPerformance) {
       callbackSet.add(async () => {
         const performance = await page.evaluate(
-          /* eslint-env browser */
+          /* eslint-disable no-undef */
           /* istanbul ignore next */
           () => {
             const { performance } = window;
@@ -7393,7 +7396,7 @@ ${webServer.rootDirectoryUrl}`);
               measures,
             };
           },
-          /* eslint-env node */
+          /* eslint-enable no-undef */
         );
         result.performance = performance;
       });
@@ -7466,7 +7469,7 @@ ${webServer.rootDirectoryUrl}`);
               try {
                 await page.goto(fileServerUrl, { timeout: 0 });
                 const returnValue = await page.evaluate(
-                  /* eslint-env browser */
+                  /* eslint-disable no-undef */
                   /* istanbul ignore next */
                   async () => {
                     if (!window.__supervisor__) {
@@ -7481,7 +7484,7 @@ ${webServer.rootDirectoryUrl}`);
                         executionResultFromJsenvSupervisor.executionResults,
                     };
                   },
-                  /* eslint-env node */
+                  /* eslint-enable no-undef */
                 );
                 cb(returnValue);
               } catch (e) {
@@ -7652,7 +7655,6 @@ const extractTextFromConsoleMessage = (consoleMessage) => {
   // ensure we use a string so that istanbul won't try
   // to put any coverage statement inside it
   // ideally we should use uneval no ?
-  // eslint-disable-next-line no-new-func
   //   const functionEvaluatedBrowserSide = new Function(
   //     "value",
   //     `if (value instanceof Error) {
@@ -8037,7 +8039,7 @@ const killProcessTree = async (
   descendantProcessIds.forEach((descendantProcessId) => {
     try {
       process.kill(descendantProcessId, signal);
-    } catch (error) {
+    } catch {
       // ignore
     }
   });
@@ -8057,7 +8059,7 @@ const killProcessTree = async (
       try {
         process.kill(remainingId, 0);
         return true;
-      } catch (e) {
+      } catch {
         return false;
       }
     });

package/dist/node_child_process_controlled.mjs

@@ -29,7 +29,7 @@ const ACTIONS_AVAILABLE = {
       const filePath = fileURLToPath(fileUrl);
       const require = createRequire(fileUrl);
       result.timings.start = Date.now();
-      // eslint-disable-next-line import/no-dynamic-require
+      // eslint-disable-next-line import-x/no-dynamic-require
       const namespace = require(filePath);
       const namespaceResolved = {};
       await Promise.all(

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/test",
-  "version": "3.4.0",
+  "version": "3.4.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -39,9 +39,9 @@
     "@c88/v8-coverage": "0.1.1",
     "@jsenv/abort": "4.3.0",
     "@jsenv/ast": "6.2.16",
-    "@jsenv/exception": "1.1.1",
-    "@jsenv/filesystem": "4.10.1",
-    "@jsenv/github-check-run": "0.1.31",
+    "@jsenv/exception": "1.1.2",
+    "@jsenv/filesystem": "4.10.2",
+    "@jsenv/github-check-run": "0.1.32",
     "@jsenv/humanize": "1.2.8",
     "@jsenv/plugin-supervisor": "1.5.18",
     "@jsenv/sourcemap": "1.2.23",

package/src/coverage/v8_coverage_composition.js

@@ -4,8 +4,6 @@ export const composeTwoV8Coverages = (firstV8Coverage, secondV8Coverage) => {
   if (secondV8Coverage.result.length === 0) {
     return firstV8Coverage;
   }
-
-  // eslint-disable-next-line import/no-unresolved
   const { mergeProcessCovs } = importWithRequire("@c88/v8-coverage");
   // "mergeProcessCovs" do not preserves source-map-cache during the merge
   // so we store sourcemap cache now

package/src/execution/web_server/start_using_command.js

@@ -1,6 +1,5 @@
 import { Abort } from "@jsenv/abort";
 import { spawn, spawnSync } from "node:child_process";
-
 import { pingServer } from "../../helpers/ping_server.js";
 
 export const startServerUsingCommand = async (
@@ -96,7 +95,6 @@ export const startServerUsingCommand = async (
 
   const startedPromise = (async () => {
     const logScale = [100, 250, 500];
-    // eslint-disable-next-line no-constant-condition
     while (true) {
       if (errorReceived) {
         break;

package/src/runtime_browsers/using_playwright.js

@@ -3,7 +3,6 @@ import { createDetailedMessage } from "@jsenv/humanize";
 import { urlIsInsideOf } from "@jsenv/urls";
 import { memoize } from "@jsenv/utils/src/memoize/memoize.js";
 import { readFileSync, writeFileSync } from "node:fs";
-
 import { composeTwoFileByFileIstanbulCoverages } from "../coverage/istanbul_coverage_composition.js";
 import { filterV8Coverage } from "../coverage/v8_coverage.js";
 import { WEB_URL_CONVERTER } from "../helpers/web_url_converter.js";
@@ -275,7 +274,7 @@ ${webServer.rootDirectoryUrl}`);
     if (memoryUsageAPIAvailable) {
       const getMemoryUsage = async () => {
         const memoryUsage = await page.evaluate(
-          /* eslint-env browser */
+          /* eslint-disable no-undef */
           /* istanbul ignore next */
           async () => {
             const { performance } = window;
@@ -298,7 +297,7 @@ ${webServer.rootDirectoryUrl}`);
             }
             return null;
           },
-          /* eslint-env node */
+          /* eslint-enable no-undef */
         );
         return memoryUsage;
       };
@@ -317,7 +316,7 @@ ${webServer.rootDirectoryUrl}`);
     if (collectPerformance) {
       callbackSet.add(async () => {
         const performance = await page.evaluate(
-          /* eslint-env browser */
+          /* eslint-disable no-undef */
           /* istanbul ignore next */
           () => {
             const { performance } = window;
@@ -336,7 +335,7 @@ ${webServer.rootDirectoryUrl}`);
               measures,
             };
           },
-          /* eslint-env node */
+          /* eslint-enable no-undef */
         );
         result.performance = performance;
       });
@@ -409,7 +408,7 @@ ${webServer.rootDirectoryUrl}`);
               try {
                 await page.goto(fileServerUrl, { timeout: 0 });
                 const returnValue = await page.evaluate(
-                  /* eslint-env browser */
+                  /* eslint-disable no-undef */
                   /* istanbul ignore next */
                   async () => {
                     if (!window.__supervisor__) {
@@ -424,7 +423,7 @@ ${webServer.rootDirectoryUrl}`);
                         executionResultFromJsenvSupervisor.executionResults,
                     };
                   },
-                  /* eslint-env node */
+                  /* eslint-enable no-undef */
                 );
                 cb(returnValue);
               } catch (e) {
@@ -595,7 +594,6 @@ const extractTextFromConsoleMessage = (consoleMessage) => {
   // ensure we use a string so that istanbul won't try
   // to put any coverage statement inside it
   // ideally we should use uneval no ?
-  // eslint-disable-next-line no-new-func
   //   const functionEvaluatedBrowserSide = new Function(
   //     "value",
   //     `if (value instanceof Error) {

package/src/runtime_node/kill_process_tree.js

@@ -1,4 +1,5 @@
 import { importWithRequire } from "../helpers/import_with_require.js";
+
 // see also https://github.com/sindresorhus/execa/issues/96
 export const killProcessTree = async (
   processId,
@@ -19,7 +20,7 @@ export const killProcessTree = async (
   descendantProcessIds.forEach((descendantProcessId) => {
     try {
       process.kill(descendantProcessId, signal);
-    } catch (error) {
+    } catch {
       // ignore
     }
   });
@@ -39,7 +40,7 @@ export const killProcessTree = async (
       try {
         process.kill(remainingId, 0);
         return true;
-      } catch (e) {
+      } catch {
         return false;
       }
     });

package/src/runtime_node/node_child_process_controlled.mjs

@@ -26,7 +26,7 @@ const ACTIONS_AVAILABLE = {
       const filePath = fileURLToPath(fileUrl);
       const require = createRequire(fileUrl);
       result.timings.start = Date.now();
-      // eslint-disable-next-line import/no-dynamic-require
+      // eslint-disable-next-line import-x/no-dynamic-require
       const namespace = require(filePath);
       const namespaceResolved = {};
       await Promise.all(