@jsenv/snapshot 2.3.0 → 2.3.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/snapshot",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "description": "Snapshot testing",
   "license": "MIT",
   "author": {

package/src/function_side_effects/function_side_effects_collector.js

@@ -3,15 +3,13 @@ import { replaceFluctuatingValues } from "../replace_fluctuating_values.js";
 
 const RETURN_PROMISE = {};
 
-let executing = false;
+let functionExecutingCount = 0;
+
 export const collectFunctionSideEffects = (
   fn,
   sideEffectDetectors,
   { rootDirectoryUrl },
 ) => {
-  if (executing) {
-    throw new Error("collectFunctionSideEffects already running");
-  }
   const sideEffects = [];
   const addSideEffect = (sideEffect) => {
     sideEffects.push(sideEffect);
@@ -23,6 +21,13 @@ export const collectFunctionSideEffects = (
       uninstall();
     });
   }
+  if (functionExecutingCount) {
+    console.warn(
+      `collectFunctionSideEffects called while other function(s) side effects are collected`,
+    );
+  }
+  functionExecutingCount++;
+
   const onCatch = (valueThrow) => {
     sideEffects.push({
       type: "throw",
@@ -73,7 +78,7 @@ export const collectFunctionSideEffects = (
     });
   };
   const onFinally = () => {
-    executing = false;
+    functionExecutingCount--;
     for (const finallyCallback of finallyCallbackSet) {
       finallyCallback();
     }

package/src/function_side_effects/function_side_effects_snapshot.js

@@ -11,8 +11,6 @@ import { renderSideEffects } from "./function_side_effects_renderer.js";
 import { spyConsoleCalls } from "./spy_console_calls.js";
 import { spyFilesystemCalls } from "./spy_filesystem_calls.js";
 
-let filesystemSideEffectInstalled;
-
 export const snapshotFunctionSideEffects = (
   fn,
   fnFileUrl,
@@ -79,12 +77,6 @@ export const snapshotFunctionSideEffects = (
     {
       name: "filesystem",
       install: (addSideEffect) => {
-        if (filesystemSideEffectInstalled) {
-          throw new Error(
-            "cannot collect filesystem side effects concurrently (already collecting side effect for an other function)",
-          );
-        }
-        filesystemSideEffectInstalled = true;
         const fsSideEffectDirectoryUrl = ensurePathnameTrailingSlash(
           new URL(filesystemEffectsDirectory, sideEffectDirectoryUrl),
         );
@@ -112,7 +104,9 @@ export const snapshotFunctionSideEffects = (
                   type: "fs:write_file",
                   value: { relativeUrl, content },
                   label: `write file "${relativeUrl}"`,
-                  text: content,
+                  text: `--- content ---
+${content}
+---------------`,
                 });
               }
             },
@@ -132,7 +126,6 @@ export const snapshotFunctionSideEffects = (
         );
         return () => {
           filesystemSpy.restore();
-          filesystemSideEffectInstalled = false;
         };
       },
     },