@jsenv/server 12.5.7 → 12.6.0

package/README.md

@@ -1,4 +1,4 @@
-# server [![npm package](https://img.shields.io/npm/v/@jsenv/server.svg?logo=npm&label=package)](https://www.npmjs.com/package/@jsenv/server) [![github workflow](https://github.com/jsenv/server/workflows/main/badge.svg)](https://github.com/jsenv/server/actions?workflow=main) [![codecov coverage](https://codecov.io/gh/jsenv/server/branch/main/graph/badge.svg)](https://codecov.io/gh/jsenv/server)
+# server [![npm package](https://img.shields.io/npm/v/@jsenv/server.svg?logo=npm&label=package)](https://www.npmjs.com/package/@jsenv/server)
 
 `@jsenv/server` helps to write flexible server code with a declarative API.
 
@@ -7,7 +7,6 @@ import { startServer } from "@jsenv/server"
 
 await startServer({
   protocol: "http",
-  ip: "127.0.0.1",
   port: 8080,
   requestToResponse: () => {
     return {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/server",
-  "version": "12.5.7",
+  "version": "12.6.0",
   "description": "Write your Node.js server using pure functions",
   "license": "MIT",
   "author": {

package/src/internal/colorizeResponseStatus.js

@@ -11,22 +11,21 @@ const cyan = "\x1b[36m"
 
 export const colorizeResponseStatus = (status) => {
   const statusType = statusToType(status)
-
   if (statusType === "information") return `${cyan}${status}${close}`
   if (statusType === "success") return `${green}${status}${close}`
   if (statusType === "redirection") return `${magenta}${status}${close}`
-  if (statusType === "client-error") return `${yellow}${status}${close}`
-  if (statusType === "server-error") return `${red}${status}${close}`
+  if (statusType === "client_error") return `${yellow}${status}${close}`
+  if (statusType === "server_error") return `${red}${status}${close}`
   return status
 }
 
 // https://developer.mozilla.org/en-US/docs/Web/HTTP/Status
-const statusToType = (status) => {
+export const statusToType = (status) => {
   if (statusIsInformation(status)) return "information"
   if (statusIsSuccess(status)) return "success"
   if (statusIsRedirection(status)) return "redirection"
-  if (statusIsClientError(status)) return "client-error"
-  if (statusIsServerError(status)) return "server-error"
+  if (statusIsClientError(status)) return "client_error"
+  if (statusIsServerError(status)) return "server_error"
   return "unknown"
 }
 

package/src/internal/getServerOrigins.js

@@ -2,43 +2,37 @@ import { networkInterfaces } from "os"
 import { URL } from "url"
 
 export const getServerOrigins = ({ protocol, ip, port }) => {
+  const isInternalIp = ip === "127.0.0.1"
+  const internalOrigin = createServerOrigin({
+    protocol,
+    hostname: "localhost",
+    port,
+  })
+  if (isInternalIp) {
+    return { internal: internalOrigin }
+  }
+  const isAnyIp = !ip || ip === "::" || ip === "0.0.0.0"
   return {
-    main: createServerOrigin({ protocol, ip, port }),
-    external: createServerOrigin({ protocol, ip: getExternalIp(ip), port }),
+    internal: internalOrigin,
+    external: createServerOrigin({
+      protocol,
+      hostname: isAnyIp ? getExternalIp(ip) : ip,
+      port,
+    }),
   }
 }
 
-const createServerOrigin = ({ protocol, ip, port }) => {
+const createServerOrigin = ({ protocol, hostname, port }) => {
   const url = new URL("https://127.0.0.1:80")
-
   url.protocol = protocol
-  url.hostname = ipToHostname(ip)
+  url.hostname = hostname
   url.port = port
-
   return url.origin
 }
 
-const ipToHostname = (
-  ip,
-  {
-    preferLocalhost = true,
-    preferLocalIp = false,
-    preferExternalIp = false,
-  } = {},
-) => {
-  if (ip === "0.0.0.0" || !ip) {
-    if (preferLocalhost) return "localhost"
-    if (preferLocalIp) return "127.0.0.1"
-    if (preferExternalIp) return getExternalIp(ip) || "0.0.0.0"
-    return "0.0.0.0"
-  }
-  return ip
-}
-
 const getExternalIp = () => {
   const networkInterfaceMap = networkInterfaces()
   let internalIPV4NetworkAddress
-
   Object.keys(networkInterfaceMap).find((key) => {
     const networkAddressArray = networkInterfaceMap[key]
     return networkAddressArray.find((networkAddress) => {
@@ -48,6 +42,5 @@ const getExternalIp = () => {
       return true
     })
   })
-
   return internalIPV4NetworkAddress ? internalIPV4NetworkAddress.address : null
 }

package/src/internal/listen.js

@@ -20,7 +20,6 @@ const listen = async ({
         ip,
       })
     }
-
     listeningOperation.throwIfAborted()
     port = await startListening({ server, port, ip })
     listeningOperation.addAbortCallback(() => stopListening(server))
@@ -43,7 +42,6 @@ export const findFreePort = async (
   } = {},
 ) => {
   const findFreePortOperation = Abort.startOperation()
-
   try {
     findFreePortOperation.addAbortSignal(signal)
     findFreePortOperation.throwIfAborted()
@@ -61,7 +59,6 @@ export const findFreePort = async (
       }
       return testUntil(nextPort, ip)
     }
-
     const freePort = await testUntil(initialPort, ip)
     return freePort
   } finally {

package/src/internal/populateNodeResponse.js

@@ -44,6 +44,34 @@ export const populateNodeResponse = async (
   }
 
   await new Promise((resolve) => {
+    const observable = bodyMethods.asObservable()
+    const subscription = observable.subscribe({
+      next: (data) => {
+        try {
+          responseStream.write(data)
+        } catch (e) {
+          // Something inside Node.js sometimes puts stream
+          // in a state where .write() throw despites nodeResponse.destroyed
+          // being undefined and "close" event not being emitted.
+          // I have tested if we are the one calling destroy
+          // (I have commented every .destroy() call)
+          // but issue still occurs
+          // For the record it's "hard" to reproduce but can be by running
+          // a lot of tests against a browser in the context of @jsenv/core testing
+          if (e.code === "ERR_HTTP2_INVALID_STREAM") {
+            return
+          }
+          responseStream.emit("error", e)
+        }
+      },
+      error: (value) => {
+        responseStream.emit("error", value)
+      },
+      complete: () => {
+        responseStream.end()
+      },
+    })
+
     raceCallbacks(
       {
         abort: (cb) => {
@@ -104,34 +132,6 @@ export const populateNodeResponse = async (
         raceEffects[winner.name](winner.data)
       },
     )
-
-    const observable = bodyMethods.asObservable()
-    const subscription = observable.subscribe({
-      next: (data) => {
-        try {
-          responseStream.write(data)
-        } catch (e) {
-          // Something inside Node.js sometimes puts stream
-          // in a state where .write() throw despites nodeResponse.destroyed
-          // being undefined and "close" event not being emitted.
-          // I have tested if we are the one calling destroy
-          // (I have commented every .destroy() call)
-          // but issue still occurs
-          // For the record it's "hard" to reproduce but can be by running
-          // a lot of tests against a browser in the context of @jsenv/core testing
-          if (e.code === "ERR_HTTP2_INVALID_STREAM") {
-            return
-          }
-          responseStream.emit("error", e)
-        }
-      },
-      error: (value) => {
-        responseStream.emit("error", value)
-      },
-      complete: () => {
-        responseStream.end()
-      },
-    })
   })
 }
 

package/src/startServer.js

@@ -16,7 +16,10 @@ import {
   applyRedirectionToRequest,
 } from "./internal/request_factory.js"
 import { populateNodeResponse } from "./internal/populateNodeResponse.js"
-import { colorizeResponseStatus } from "./internal/colorizeResponseStatus.js"
+import {
+  statusToType,
+  colorizeResponseStatus,
+} from "./internal/colorizeResponseStatus.js"
 import { getServerOrigins } from "./internal/getServerOrigins.js"
 import { listen, stopListening } from "./internal/listen.js"
 import { composeTwoResponses } from "./internal/response_composition.js"
@@ -37,6 +40,7 @@ import {
 export const startServer = async ({
   signal = new AbortController().signal,
   logLevel,
+  startLog = true,
   serverName = "server",
 
   protocol = "http",
@@ -44,7 +48,8 @@ export const startServer = async ({
   http1Allowed = true,
   redirectHttpToHttps,
   allowHttpRequestOnHttps = false,
-  ip = "0.0.0.0", // will it work on windows ? https://github.com/nodejs/node/issues/14900
+  listenAnyIp = false,
+  ip = listenAnyIp ? undefined : "127.0.0.1",
   port = 0, // assign a random available port
   portHint,
   privateKey,
@@ -204,7 +209,7 @@ export const startServer = async ({
 
   status = "opened"
   const serverOrigins = getServerOrigins({ protocol, ip, port })
-  const serverOrigin = serverOrigins.main
+  const serverOrigin = serverOrigins.internal
 
   const removeConnectionErrorListener = listenServerConnectionError(
     nodeServer,
@@ -676,8 +681,15 @@ export const startServer = async ({
           onRequestHandled(requestNode)
         },
         onHeadersSent: ({ status, statusText }) => {
+          const statusType = statusToType(status)
           addRequestLog(requestNode, {
-            type: "info",
+            type: {
+              information: "info",
+              success: "info",
+              redirection: "info",
+              client_error: "warn",
+              server_error: "error",
+            }[statusType],
             value: `${colorizeResponseStatus(status)} ${
               responseProperties.statusMessage || statusText
             }`,
@@ -724,9 +736,11 @@ export const startServer = async ({
   // ensure we don't try to handle new requests while server is stopping
   stopCallbackList.add(removeRequestListener)
 
-  logger.info(
-    `${serverName} started at ${serverOrigin} (${serverOrigins.external})`,
-  )
+  if (startLog) {
+    logger.info(
+      `${serverName} started at ${serverOrigin} (${serverOrigins.external})`,
+    )
+  }
 
   const addEffect = (callback) => {
     const cleanup = callback()
@@ -738,6 +752,7 @@ export const startServer = async ({
   return {
     getStatus: () => status,
     origin: serverOrigin,
+    origins: serverOrigins,
     nodeServer,
     stop,
     stoppedPromise,