@jsenv/server 12.3.2 → 12.3.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/server",
-  "version": "12.3.2",
+  "version": "12.3.3",
   "description": "Write your Node.js server using pure functions",
   "license": "MIT",
   "author": {

package/src/internal/nodeStreamToObservable.js

@@ -1,12 +1,17 @@
 // https://github.com/jamestalmage/stream-to-observable/blob/master/index.js
 import { Readable } from "node:stream"
-
 import { createObservable } from "./observable.js"
 
 const readableStreamLifetimeInSeconds = 120
 
 export const nodeStreamToObservable = (nodeStream) => {
   const observable = createObservable(({ next, error, complete }) => {
+    if (nodeStream.isPaused()) {
+      nodeStream.resume()
+    } else if (nodeStream.complete) {
+      complete()
+      return null
+    }
     const cleanup = () => {
       nodeStream.removeListener("data", next)
       nodeStream.removeListener("error", error)
@@ -14,13 +19,17 @@ export const nodeStreamToObservable = (nodeStream) => {
       nodeStream.removeListener("close", cleanup)
       nodeStream.destroy()
     }
-
     // should we do nodeStream.resume() in case the stream was paused ?
     nodeStream.once("error", error)
-    nodeStream.on("data", next)
-    nodeStream.once("close", cleanup)
-    nodeStream.once("end", complete)
-
+    nodeStream.on("data", (data) => {
+      next(data)
+    })
+    nodeStream.once("close", () => {
+      cleanup()
+    })
+    nodeStream.once("end", () => {
+      complete()
+    })
     return cleanup
   })
 

package/src/startServer.js

@@ -230,6 +230,10 @@ export const startServer = async ({
   })
 
   const requestCallback = async (nodeRequest, nodeResponse) => {
+    // pause the stream to let a chance to "requestToResponse"
+    // to call "requestRequestBody". Without this the request body readable stream
+    // might be closed when we'll try to attach "data" and "end" listeners to it
+    nodeRequest.pause()
     if (!nagle) {
       nodeRequest.connection.setNoDelay(true)
     }
@@ -309,7 +313,6 @@ export const startServer = async ({
 
       visitRequestNodeToLog(rootRequestNode, 0)
     }
-
     nodeRequest.on("error", (error) => {
       if (error.message === "aborted") {
         addRequestLog(rootRequestNode, {
@@ -683,6 +686,7 @@ export const startServer = async ({
       const responseProperties = await handleRequest(request, {
         requestNode: rootRequestNode,
       })
+      nodeRequest.resume()
       if (receiveRequestOperation.signal.aborted) {
         return
       }