@jsenv/plugin-bundling 2.7.25 → 2.8.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/plugin-bundling",
-  "version": "2.7.25",
+  "version": "2.8.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -20,13 +20,14 @@
   "files": [
     "/src/"
   ],
+  "sideEffects": false,
   "dependencies": {
-    "@jsenv/humanize": "1.2.8",
-    "@jsenv/url-meta": "8.5.3",
-    "@jsenv/urls": "2.6.0",
-    "@jsenv/sourcemap": "1.2.30",
-    "lightningcss": "1.29.1",
-    "rollup": "4.31.0"
+    "@jsenv/humanize": "1.3.1",
+    "@jsenv/url-meta": "8.5.4",
+    "@jsenv/urls": "2.6.2",
+    "@jsenv/sourcemap": "1.3.1",
+    "lightningcss": "1.29.2",
+    "rollup": "4.35.0"
   },
   "peerDependencies": {
     "@jsenv/core": "*"

package/src/js_module/bundle_js_modules.js

@@ -1,8 +1,10 @@
+import { lookupPackageDirectory } from "@jsenv/filesystem";
 import { createDetailedMessage } from "@jsenv/humanize";
+import { isSpecifierForNodeBuiltin } from "@jsenv/node-esm-resolution/src/node_builtin_specifiers.js";
 import { sourcemapConverter } from "@jsenv/sourcemap";
 import { URL_META } from "@jsenv/url-meta";
-import { isFileSystemPath } from "@jsenv/urls";
-
+import { fileSystemPathToUrl, isFileSystemPath } from "@jsenv/urls";
+import { readFileSync } from "node:fs";
 import { fileUrlConverter } from "../file_url_converter.js";
 
 export const bundleJsModules = async (
@@ -35,15 +37,59 @@ export const bundleJsModules = async (
   }
 
   let manualChunks;
-  if (Object.keys(chunks).length) {
+  if (chunks) {
+    if (chunks.vendors) {
+      chunks.vendors = {
+        "file:///**/node_modules/": true,
+        ...chunks.vendors,
+      };
+    } else {
+      chunks.vendors = {
+        "file:///**/node_modules/": true,
+      };
+    }
+    const packageDirectoryUrl = lookupPackageDirectory(rootDirectoryUrl);
+    if (packageDirectoryUrl) {
+      try {
+        const packageFileContent = readFileSync(
+          new URL("package.json", packageDirectoryUrl),
+          "utf8",
+        );
+        const packageJSON = JSON.parse(packageFileContent);
+        const workspaces = packageJSON.workspaces;
+        if (workspaces) {
+          const workspacePatterns = {};
+          for (const workspace of workspaces) {
+            const workspacePattern = new URL(
+              workspace.endsWith("/*") ? workspace.slice(0, -1) : workspace,
+              packageDirectoryUrl,
+            ).href;
+            workspacePatterns[workspacePattern] = true;
+          }
+          if (chunks.workspaces) {
+            chunks.workspaces = {
+              ...workspacePatterns,
+              ...chunks.workspaces,
+            };
+          } else {
+            chunks.workspaces = workspacePatterns;
+          }
+        }
+      } catch {}
+    }
+
     const associations = URL_META.resolveAssociations(chunks, rootDirectoryUrl);
-    manualChunks = (id) => {
+    manualChunks = (id, manualChunksApi) => {
       if (rollupOutput.manualChunks) {
-        const manualChunkName = rollupOutput.manualChunks(id);
+        const manualChunkName = rollupOutput.manualChunks(id, manualChunksApi);
         if (manualChunkName) {
           return manualChunkName;
         }
       }
+      const moduleInfo = manualChunksApi.getModuleInfo(id);
+      if (moduleInfo.isEntry || moduleInfo.dynamicImporters.length) {
+        return null;
+      }
       const url = fileUrlConverter.asFileUrl(id);
       const urlObject = new URL(url);
       urlObject.search = "";
@@ -52,8 +98,12 @@ export const bundleJsModules = async (
         url: urlWithoutSearch,
         associations,
       });
-      const chunkName = Object.keys(meta).find((key) => meta[key]);
-      return chunkName || null;
+      for (const chunkNameCandidate of Object.keys(meta)) {
+        if (meta[chunkNameCandidate]) {
+          return chunkNameCandidate;
+        }
+      }
+      return undefined;
     };
   }
 
@@ -91,6 +141,18 @@ export const bundleJsModules = async (
             // ideally we should disable only for jsenv files
             return;
           }
+          if (
+            warning.code === "INVALID_ANNOTATION" &&
+            warning.loc.file.includes("/node_modules/")
+          ) {
+            return;
+          }
+          if (
+            warning.code === "EMPTY_BUNDLE" &&
+            warning.names.join("") === "vendors"
+          ) {
+            return;
+          }
           logger.warn(String(warning));
         },
         ...rollupInput,
@@ -126,6 +188,7 @@ export const bundleJsModules = async (
 const rollupPluginJsenv = ({
   // logger,
   rootDirectoryUrl,
+  buildDirectoryUrl,
   graph,
   jsModuleUrlInfos,
   sourcemaps,
@@ -163,16 +226,18 @@ const rollupPluginJsenv = ({
   }
 
   const getOriginalUrl = (rollupFileInfo) => {
-    const { facadeModuleId } = rollupFileInfo;
-    if (facadeModuleId) {
-      return fileUrlConverter.asFileUrl(facadeModuleId);
+    if (rollupFileInfo.isEntry) {
+      const { facadeModuleId } = rollupFileInfo;
+      if (facadeModuleId) {
+        return fileUrlConverter.asFileUrl(facadeModuleId);
+      }
     }
     if (rollupFileInfo.isDynamicEntry) {
       const { moduleIds } = rollupFileInfo;
       const lastModuleId = moduleIds[moduleIds.length - 1];
       return fileUrlConverter.asFileUrl(lastModuleId);
     }
-    return new URL(rollupFileInfo.fileName, rootDirectoryUrl).href;
+    return new URL(rollupFileInfo.fileName, buildDirectoryUrl).href;
   };
 
   return {
@@ -180,13 +245,13 @@ const rollupPluginJsenv = ({
     async buildStart() {
       _rollupEmitFile = (...args) => this.emitFile(...args);
       let previousNonEntryPointModuleId;
-      jsModuleUrlInfos.forEach((jsModuleUrlInfo) => {
+      for (const jsModuleUrlInfo of jsModuleUrlInfos) {
         const id = jsModuleUrlInfo.url;
         if (jsModuleUrlInfo.isEntryPoint) {
           emitChunk({
             id,
           });
-          return;
+          continue;
         }
         let preserveSignature;
         if (strictExports) {
@@ -218,8 +283,10 @@ const rollupPluginJsenv = ({
             : null,
           preserveSignature,
         });
-        previousNonEntryPointModuleId = id;
-      });
+        if (jsModuleUrlInfo.originalUrl.startsWith("file:")) {
+          previousNonEntryPointModuleId = id;
+        }
+      }
     },
     async generateBundle(outputOptions, rollupResult) {
       _rollupEmitFile = (...args) => this.emitFile(...args);
@@ -291,16 +358,32 @@ const rollupPluginJsenv = ({
           remapReference:
             specifierToUrlMap.size > 0
               ? (reference) => {
-                  // rollup generate specifiers only for static and dynamic imports
-                  // other references (like new URL()) are ignored
-                  // there is no need to remap them back
                   if (
-                    reference.type === "js_import" &&
-                    reference.subtype !== "import_meta_resolve"
+                    preserveDynamicImport &&
+                    reference.subtype === "dynamic_import"
+                  ) {
+                    // when dynamic import are preserved, no need to remap them
+                    return reference.specifier;
+                  }
+                  if (
+                    reference.type !== "js_import" ||
+                    reference.subtype === "import_meta_resolve"
                   ) {
-                    return specifierToUrlMap.get(reference.specifier);
+                    // rollup generate specifiers only for static and dynamic imports
+                    // other references (like new URL()) are ignored
+                    // there is no need to remap them back
+                    return reference.specifier;
                   }
-                  return reference.specifier;
+                  const specifierBeforeRollup = specifierToUrlMap.get(
+                    reference.specifier,
+                  );
+                  if (!specifierBeforeRollup) {
+                    console.warn(
+                      `cannot remap "${reference.specifier}" back to specifier before rollup, this is unexpected.`,
+                    );
+                    return reference.specifier;
+                  }
+                  return specifierBeforeRollup;
                 }
               : undefined,
         };
@@ -308,11 +391,19 @@ const rollupPluginJsenv = ({
 
       const jsModuleBundleUrlInfos = {};
       const fileNames = Object.keys(rollupResult);
+      const originalUrlSet = new Set();
       for (const fileName of fileNames) {
         const rollupFileInfo = rollupResult[fileName];
         // there is 3 types of file: "placeholder", "asset", "chunk"
         if (rollupFileInfo.type === "chunk") {
           const jsModuleInfo = createBundledFileInfo(rollupFileInfo);
+          const originalUrl = jsModuleInfo.originalUrl;
+          if (originalUrlSet.has(originalUrl)) {
+            throw new Error(
+              `duplicate bundle info, cannot override ${originalUrl}`,
+            );
+          }
+          originalUrlSet.add(originalUrl);
           jsModuleBundleUrlInfos[jsModuleInfo.originalUrl] = jsModuleInfo;
         }
       }
@@ -335,37 +426,45 @@ const rollupPluginJsenv = ({
           return `[name].js`;
         },
         chunkFileNames: (chunkInfo) => {
+          if (chunkInfo.isEntry) {
+            const originalFileUrl = getOriginalUrl(chunkInfo);
+            const jsModuleUrlInfo = jsModuleUrlInfos.find(
+              (candidate) => candidate.url === originalFileUrl,
+            );
+            if (jsModuleUrlInfo && jsModuleUrlInfo.filenameHint) {
+              return jsModuleUrlInfo.filenameHint;
+            }
+          }
           return `${chunkInfo.name}.js`;
         },
       });
     },
     // https://rollupjs.org/guide/en/#resolvedynamicimport
     resolveDynamicImport: (specifier, importer) => {
-      if (preserveDynamicImport) {
-        let urlObject;
-        if (specifier[0] === "/") {
-          urlObject = new URL(specifier.slice(1), rootDirectoryUrl);
-        } else {
-          if (isFileSystemPath(importer)) {
-            importer = fileUrlConverter.asFileUrl(importer);
-          }
-          urlObject = new URL(specifier, importer);
-        }
-        const searchParamsToAdd =
-          augmentDynamicImportUrlSearchParams(urlObject);
-        if (searchParamsToAdd) {
-          Object.keys(searchParamsToAdd).forEach((key) => {
-            const value = searchParamsToAdd[key];
-            if (value === undefined) {
-              urlObject.searchParams.delete(key);
-            } else {
-              urlObject.searchParams.set(key, value);
-            }
-          });
+      if (!preserveDynamicImport) {
+        return null;
+      }
+      let urlObject;
+      if (specifier[0] === "/") {
+        urlObject = new URL(specifier.slice(1), rootDirectoryUrl);
+      } else {
+        if (isFileSystemPath(importer)) {
+          importer = fileUrlConverter.asFileUrl(importer);
         }
-        return { external: true, id: urlObject.href };
+        urlObject = new URL(specifier, importer);
+      }
+      const searchParamsToAdd = augmentDynamicImportUrlSearchParams(urlObject);
+      if (searchParamsToAdd) {
+        Object.keys(searchParamsToAdd).forEach((key) => {
+          const value = searchParamsToAdd[key];
+          if (value === undefined) {
+            urlObject.searchParams.delete(key);
+          } else {
+            urlObject.searchParams.set(key, value);
+          }
+        });
       }
-      return null;
+      return { external: true, id: urlObject.href };
     },
     resolveId: (specifier, importer = rootDirectoryUrl) => {
       if (isFileSystemPath(importer)) {
@@ -388,7 +487,7 @@ const rollupPluginJsenv = ({
         // happen when excluded by referenceAnalysis.include
         return { id: url, external: true };
       }
-      if (urlInfo.url.startsWith("ignore:")) {
+      if (url.startsWith("ignore:")) {
         return { id: url, external: true };
       }
       const filePath = fileUrlConverter.asFilePath(url);
@@ -419,8 +518,83 @@ const applyRollupPlugins = async ({
     const rollupModule = await import("rollup");
     rollup = rollupModule.rollup;
   }
+
+  const packageSideEffectsCacheMap = new Map();
+  const readClosestPackageJsonSideEffects = (url) => {
+    const packageDirectoryUrl = lookupPackageDirectory(url);
+    if (!packageDirectoryUrl) {
+      return undefined;
+    }
+    const fromCache = packageSideEffectsCacheMap.get(packageDirectoryUrl);
+    if (fromCache) {
+      return fromCache.value;
+    }
+    try {
+      const packageFileContent = readFileSync(
+        new URL("./package.json", packageDirectoryUrl),
+        "utf8",
+      );
+      const packageJSON = JSON.parse(packageFileContent);
+      const value = packageJSON.sideEffects;
+      if (Array.isArray(value)) {
+        const sideEffectPatterns = {};
+        for (const v of value) {
+          sideEffectPatterns[v] = true;
+        }
+        const associations = URL_META.resolveAssociations(
+          { sideEffects: sideEffectPatterns },
+          packageDirectoryUrl,
+        );
+        const isMatching = (url) => {
+          const meta = URL_META.applyAssociations({ url, associations });
+          return meta.sideEffects || false;
+        };
+        packageSideEffectsCacheMap.set(packageDirectoryUrl, {
+          value: isMatching,
+        });
+      } else {
+        packageSideEffectsCacheMap.set(packageDirectoryUrl, { value });
+      }
+      return value;
+    } catch {
+      packageSideEffectsCacheMap.set(packageDirectoryUrl, { value: undefined });
+      return undefined;
+    }
+  };
+
   const rollupReturnValue = await rollup({
     ...rollupInput,
+    treeshake: {
+      ...rollupInput.treeshake,
+      moduleSideEffects: (id, external) => {
+        if (id.startsWith("ignore:node:")) {
+          return false;
+        }
+        if (isSpecifierForNodeBuiltin(id)) {
+          return false;
+        }
+        if (id.startsWith("ignore:")) {
+          return null;
+        }
+        const url = id.startsWith("file:") ? id : fileSystemPathToUrl(id);
+        const closestPackageJsonSideEffects =
+          readClosestPackageJsonSideEffects(url);
+        if (closestPackageJsonSideEffects !== undefined) {
+          if (typeof closestPackageJsonSideEffects === "function") {
+            return closestPackageJsonSideEffects(url);
+          }
+          return closestPackageJsonSideEffects;
+        }
+        const moduleSideEffects = rollupInput.treeshake?.moduleSideEffects;
+        if (moduleSideEffects) {
+          if (typeof moduleSideEffects === "function") {
+            return moduleSideEffects(id, external);
+          }
+          return moduleSideEffects;
+        }
+        return null;
+      },
+    },
     plugins: rollupPlugins,
   });
   const rollupOutputArray = await rollupReturnValue.generate(rollupOutput);