@jsenv/performance-impact 2.2.8 → 2.2.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/performance-impact",
-  "version": "2.2.8",
+  "version": "2.2.11",
   "description": "Report pull request impacts on performance metrics",
   "license": "MIT",
   "author": {
@@ -34,7 +34,6 @@
   ],
   "scripts": {
     "eslint": "npx eslint . --ext=.js,.mjs",
-    "importmap": "node ./script/importmap/importmap.mjs",
     "snapshot": "node ./test/comment_snapshot/generate_comment_snapshot_file.mjs",
     "test": "node ./script/test/test.mjs",
     "test-with-coverage": "npm run test -- --coverage",
@@ -42,20 +41,10 @@
   },
   "dependencies": {
     "@jsenv/dynamic-import-worker": "1.0.1",
-    "@jsenv/filesystem": "2.7.1",
-    "@jsenv/github-pull-request-impact": "1.6.10",
+    "@jsenv/filesystem": "3.1.0",
+    "@jsenv/github-pull-request-impact": "1.6.11",
     "@jsenv/logger": "4.0.1",
     "bytes": "3.1.1",
     "humanize-duration": "3.27.1"
-  },
-  "devDependencies": {
-    "@jsenv/assert": "2.4.1",
-    "@jsenv/core": "25.3.0",
-    "@jsenv/eslint-config": "16.0.9",
-    "@jsenv/importmap-eslint-resolver": "5.2.5",
-    "@jsenv/importmap-node-module": "5.1.3",
-    "eslint": "8.7.0",
-    "eslint-plugin-import": "2.25.4",
-    "prettier": "2.5.1"
   }
 }

package/src/internal/formatRatio.js

@@ -1,12 +1,6 @@
+import { formatPercentage } from "./format_percentage.js"
+
 export const formatRatioAsPercentage = (ratio) => {
-  const asPercentage = ratio * 100
-  const asPercentageFormatted = `${ratio < 0 ? `-` : "+"}${Math.abs(
-    limitDecimals(asPercentage, 2),
-  )}%`
+  const asPercentageFormatted = formatPercentage(ratio * 100)
   return asPercentageFormatted
 }
-
-const limitDecimals = (number, decimalCount = 2) => {
-  const multiplier = Math.pow(10, decimalCount)
-  return Math.round(number * multiplier) / multiplier
-}

package/src/internal/format_percentage.js

@@ -0,0 +1,30 @@
+export const formatPercentage = (number) => {
+  const absoluteValue = Math.abs(number)
+  const valueRounded = roundNumber(
+    absoluteValue,
+    determineDecimals(absoluteValue),
+  )
+  return `${number < 0 ? `-` : "+"}${valueRounded}%`
+}
+const determineDecimals = (number) => {
+  if (number < 0.001) {
+    return 4
+  }
+  if (number < 0.01) {
+    return 3
+  }
+  if (number < 0.1) {
+    return 2
+  }
+  if (number < 1) {
+    return 1
+  }
+  return 0
+}
+
+const roundNumber = (value, maxDecimals) => {
+  const expValue = Math.pow(10, maxDecimals)
+  const roundedValue = Math.round(expValue * value) / expValue
+  const valueAsString = roundedValue.toFixed(maxDecimals)
+  return parseFloat(valueAsString)
+}

package/src/reportPerformanceImpact.js

@@ -10,7 +10,7 @@ export const reportPerformanceImpact = async ({
   logLevel,
   commandLogs,
   cancelOnSIGINT,
-  projectDirectoryUrl,
+  rootDirectoryUrl,
 
   githubToken,
   repositoryOwner,
@@ -26,31 +26,31 @@ export const reportPerformanceImpact = async ({
   runLink,
   commitInGeneratedByInfo,
 }) => {
-  projectDirectoryUrl = assertAndNormalizeDirectoryUrl(projectDirectoryUrl)
+  rootDirectoryUrl = assertAndNormalizeDirectoryUrl(rootDirectoryUrl)
   if (typeof performanceReportPath !== "string") {
     throw new TypeError(
       `performanceReportPath must be a string but received ${performanceReportPath}`,
     )
   }
-  projectDirectoryUrl = assertAndNormalizeDirectoryUrl(projectDirectoryUrl)
+  rootDirectoryUrl = assertAndNormalizeDirectoryUrl(rootDirectoryUrl)
   const performanceReportUrl = resolveUrl(
     performanceReportPath,
-    projectDirectoryUrl,
+    rootDirectoryUrl,
   )
 
   return commentGitHubPullRequestImpact({
     logLevel,
     commandLogs,
     cancelOnSIGINT,
-    projectDirectoryUrl,
+    rootDirectoryUrl,
 
     githubToken,
     repositoryOwner,
     repositoryName,
     pullRequestNumber,
 
-    collectInfo: async ({ execCommandInProjectDirectory }) => {
-      await execCommandInProjectDirectory(installCommand)
+    collectInfo: async ({ execCommandInRootDirectory }) => {
+      await execCommandInRootDirectory(installCommand)
       const performanceReport = await importOneExportFromFile(
         performanceReportUrl,
       )