@jsenv/performance-impact 2.1.0 → 2.2.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/performance-impact",
-  "version": "2.1.0",
+  "version": "2.2.1",
   "description": "Report pull request impacts on performance metrics",
   "license": "MIT",
   "author": {

package/src/importMetricFromFiles.js

@@ -1,7 +1,7 @@
 import { assertAndNormalizeDirectoryUrl, resolveUrl } from "@jsenv/filesystem"
 import { createLogger } from "@jsenv/logger"
+import { importOneExportFromFile } from "@jsenv/dynamic-import-worker"
 
-import { collectOneExportFromFile } from "./internal/collectOneExportFromFile.js"
 import { measureMultipleTimes } from "./internal/measureMultipleTimes.js"
 import { assertMetrics } from "./internal/assertions.js"
 import { computeMetricsMedian } from "./internal/computeMetricsMedian.js"
@@ -21,7 +21,7 @@ export const importMetricFromFiles = async ({ logLevel, directoryUrl, metricsDes
     const url = resolveUrl(file, directoryUrl)
 
     const measure = async () => {
-      const metrics = await collectOneExportFromFile(url)
+      const metrics = await importOneExportFromFile(url)
       assertMetrics(metrics, `in ${file}`)
       return metrics
     }

package/src/internal/comment/jsenvFormatGroupSummary.js

@@ -1,5 +1,4 @@
 import { formatRatioAsPercentage } from "../formatRatio.js"
-import { median } from "../median.js"
 
 export const jsenvFormatGroupSummary = ({ groupName, beforeMergeMetrics, afterMergeMetrics }) => {
   if (!beforeMergeMetrics) {
@@ -7,7 +6,8 @@ export const jsenvFormatGroupSummary = ({ groupName, beforeMergeMetrics, afterMe
   }
 
   const allRatios = getAllImpactRatios({ beforeMergeMetrics, afterMergeMetrics })
-  if (allRatios.length === 0) {
+  const ratiosCount = allRatios.length
+  if (ratiosCount === 0) {
     return `${groupName} (no impact)`
   }
 
@@ -16,8 +16,7 @@ export const jsenvFormatGroupSummary = ({ groupName, beforeMergeMetrics, afterMe
     return `${groupName} (no impact)`
   }
 
-  const medianRatio = median(allRatios)
-  return `${groupName} (${formatRatioAsPercentage(medianRatio)})`
+  return `${groupName} (${formatRatioAsPercentage(ratioSum / ratiosCount)})`
 }
 
 const getAllImpactRatios = ({ afterMergeMetrics, beforeMergeMetrics }) => {
@@ -32,6 +31,12 @@ const getAllImpactRatios = ({ afterMergeMetrics, beforeMergeMetrics }) => {
     const metricValueBeforeMerge = metricBeforeMerge.value
     const metricValueAfterMerge = metricAfterMerge.value
     const metricDiff = metricValueAfterMerge - metricValueBeforeMerge
+    if (metricDiff === 0 && metricValueAfterMerge === 0 && metricValueBeforeMerge === 0) {
+      // there is no impact on a metric that is 0
+      // we can ignore this metric
+      return
+    }
+
     const metricDiffRatio =
       metricDiff === 0
         ? 0

package/src/reportPerformanceImpact.js

@@ -1,7 +1,7 @@
 import { resolveUrl, assertAndNormalizeDirectoryUrl } from "@jsenv/filesystem"
 import { commentGitHubPullRequestImpact } from "@jsenv/github-pull-request-impact"
+import { importOneExportFromFile } from "@jsenv/dynamic-import-worker"
 
-import { collectOneExportFromFile } from "./internal/collectOneExportFromFile.js"
 import { assertPerformanceReport } from "./internal/assertions.js"
 import { createPerfImpactComment } from "./internal/comment/createPerfImpactComment.js"
 import { jsenvCommentParameters } from "./internal/comment/jsenvCommentParameters.js"
@@ -50,7 +50,7 @@ export const reportPerformanceImpact = async ({
 
     collectInfo: async ({ execCommandInProjectDirectory }) => {
       await execCommandInProjectDirectory(installCommand)
-      const performanceReport = await collectOneExportFromFile(performanceReportUrl)
+      const performanceReport = await importOneExportFromFile(performanceReportUrl)
       assertPerformanceReport(performanceReport)
       return { version: 1, data: performanceReport }
     },