@jsenv/navi 0.29.53 → 0.29.54

package/dist/jsenv_navi.js

@@ -13091,8 +13091,7 @@ const setActionPrivateProperties = (action, properties) => {
  * the screen that will is often not even mounted — a route action runs before
  * its page renders, which is precisely the case a guess made at failure time
  * gets wrong. So nothing is guessed. The error is let go, and whoever displays
- * it SAYS so by marking it; what is still unmarked once the DOM has had its
- * chance was displayed by nobody, and only that is reported as unhandled.
+ * it SAYS so by marking it; what nobody ever took is reported as unhandled.
  *
  * The mark is `__handled_by__`, the same one the jsenv supervisor reads to stay
  * out of the way of an error the app is already showing — one mark, one meaning:
@@ -13112,22 +13111,58 @@ const errorIsDisplayed = (error) => {
 };
 
 /**
- * Reported from a macrotask: every render that could display the error —
- * Preact's own queue, a Suspense boundary settling on the failure, the error
- * boundary above it — happens in microtasks, so by the time this runs the
- * answer is final. A screen that would display the error much later than that
- * (mounted by something slower than a render) is reported anyway; it is the
- * one case where this says "nobody" a bit too early, and the report is then a
- * duplicate of what the screen shows rather than a lie about it.
- *
- * Rethrown rather than logged: an error nobody shows is an unhandled error, and
+ * A render has read this error — it is now the render tree's business, not this
+ * module's, and there is nothing left to report.
+ *
+ * Whatever the reader does with it is already covered without any deadline: it
+ * displays it (and marks it), or it throws it, and a thrown error either finds a
+ * boundary that displays it or reaches window on its own — `preact/debug`
+ * re-throws every error a boundary caught, and an unbounded one aborts the
+ * render loudly. Reporting it here as well would be a second voice saying the
+ * same thing, always the wrong one, since this module cannot see which of those
+ * happened.
+ */
+const errorTakenByRenderSet = new WeakSet();
+const markErrorAsTakenByRender = (error) => {
+  if (error && typeof error === "object") {
+    errorTakenByRenderSet.add(error);
+  }
+};
+
+/**
+ * When the answer "nobody took it" is final.
+ *
+ * The floor is one macrotask: every render that could take the error — Preact's
+ * queue, a Suspense boundary settling on the failure, the boundary above it —
+ * happens in microtasks.
+ *
+ * That floor is enough for an action failing under a page that is already on
+ * screen, and far too early for a route action: it fails ON the url change,
+ * before its page exists, and that page cannot render until the routing that
+ * asked for the data is over. Measured on an offline navigation, the screen
+ * displaying the error arrived ~12ms after this deadline — so the app was told
+ * it had displayed nothing while it was displaying it.
+ *
+ * The browser integration knows when the document has stopped moving and hands
+ * that over here (see installReportDeadlineExtension); nothing else does, and
+ * this module stays free of the DOM. Waiting longer costs nothing now that a
+ * read is enough to call this off: what still reaches the report was read by no
+ * render at all, and a late report about that is as good as a prompt one.
+ */
+let waitForDocumentSettled = null;
+const installReportDeadlineExtension = (fn) => {
+  waitForDocumentSettled = fn;
+};
+
+/**
+ * Rethrown rather than logged: an error nobody took is an unhandled error, and
  * the runtime already knows what to do with those (window "error" event, jsenv
  * overlay in dev). Same trick preact/debug uses for the same reason.
  */
 const errorReportedSet = new WeakSet();
 const reportErrorIfNobodyDisplaysIt = (error, { action } = {}) => {
-  setTimeout(() => {
-    if (errorIsDisplayed(error)) {
+  const decide = () => {
+    if (errorIsDisplayed(error) || errorTakenByRenderSet.has(error)) {
       return;
     }
     if (error && typeof error === "object") {
@@ -13143,6 +13178,19 @@ const reportErrorIfNobodyDisplaysIt = (error, { action } = {}) => {
       error.action = action;
     }
     throw error;
+  };
+
+  setTimeout(() => {
+    if (errorIsDisplayed(error) || errorTakenByRenderSet.has(error)) {
+      // Already taken within the microtasks that followed the failure: the
+      // common case, and there is nothing to wait for.
+      return;
+    }
+    if (waitForDocumentSettled) {
+      waitForDocumentSettled(decide);
+      return;
+    }
+    decide();
   });
 };
 
@@ -22102,6 +22150,39 @@ const browserIntegration = setupBrowserIntegrationViaHistory({
   isRouting: () => Boolean(updateRoutes),
 });
 
+/**
+ * How long an error that nothing displayed is given before it is called
+ * unhandled (see action_error_report.js, which knows the rule but not the DOM).
+ *
+ * A route action fails ON the url change, before its page exists: it is the
+ * routing itself that will bring what displays the error, so the answer is only
+ * final once the document has stopped moving AND the frame that paints what it
+ * brought has been through. Anything faster tells an app displaying "you are
+ * offline" that it displayed nothing.
+ */
+installReportDeadlineExtension((decide) => {
+  const whenPainted = () => {
+    // The frame that paints what routing brought, then the microtasks after it:
+    // a render claiming the error is on either side of that paint, never later.
+    requestAnimationFrame(() => {
+      setTimeout(decide);
+    });
+  };
+  if (!documentIsBusySignal.peek()) {
+    whenPainted();
+    return;
+  }
+  // Busy right now, so the synchronous first callback of subscribe() says
+  // "busy" and is skipped; what unsubscribes below is a later one.
+  const unsubscribe = documentIsBusySignal.subscribe((documentIsBusy) => {
+    if (documentIsBusy) {
+      return;
+    }
+    unsubscribe();
+    whenPainted();
+  });
+});
+
 setOnAllRouteReady((v) => {
   updateRoutes = v;
   browserIntegration.init();
@@ -35861,6 +35942,10 @@ const useActionAsyncData = (action, {
       throw dismissedPromise;
     }
     const actionError = action.errorSignal.peek();
+    // A render has it now, whichever way it goes from here (see
+    // action_error_report.js): displayed below, or thrown to a boundary that
+    // displays it — and if none does, the throw reaches window on its own.
+    markErrorAsTakenByRender(actionError);
     if (errorEffect === "use") {
       // Handed to the component, which is what displays it from here on
       // (see action_error_report.js)
@@ -71839,5 +71924,5 @@ const UserSvg = () => jsx("svg", {
   })
 });
 
-export { ActionRenderer, ActiveKeyboardShortcuts, Address, Badge, BadgeCount, BadgeList, Binder, Box, Button, ButtonCopyToClipboard, Caption, CardLayout, CheckSvg, CheckboxGroup, CloseSvg, Code, Col, Colgroup, Color, ConstructionSvg, ControlGroup, DaySpin, Details, Dialog, Editable, ErrorBoundary, ErrorBoundaryContext, ExclamationSvg, EyeClosedSvg, EyeSvg, Field, FixedBar, Form, Group, Head, HeartSvg, HomeSvg, Icon, Image, Input, InputDuration, Interpolate, Label, Link, LinkAnchorSvg, LinkBlankTargetSvg, LinkCurrentSvg, List, ListItem, ListItemGroup, ListItems, Loading, LoadingDotsSvg, LoadingIndicator, LoadingIndicatorFluid, LoadingOutline, MessageBox, Meter, Nav, NaviDebug, NumberSpin, Paragraph, Picker, Popover, Popup, Quantity, RadioGroup, Route, RouteTravel, RowNumberCol, RowNumberTableCell, SVGMaskOverlay, SearchSvg, Select, SelectableInput, SelectionContext, Separator, SettingsSvg, SidePanel, Slide, SlideContainer, Spin, SpinGroup, StarSvg, SummaryMarker, Svg, Table, TableCell, Tbody, Text, TextBox, Textarea, TextareaCharCount, Thead, Time, TimeRangeSpin, TimeSpin, Title, Tr, UITransition, Unit, UserSvg, ViewportLayout, Wheel, WheelGroup, WheelItem, actionRunEffect, anyMatchingRouteSignal, applySearch, arraySignalMembership, compareTwoJsValues, createAction, createAvailableConstraint, createI18n, createRequestCanceller, createSearch, createSelectionKeyboardShortcuts, createSlot, defineInteractionDetector, defineNaviConfirmPopupOptions, detectHorizontalOverflow, enableDebugActions, enableDebugOnDocumentLoading, ensureDocumentStartViewTransition, filterTableSelection, formatDatetime, formatDay, formatDayRelative, formatMonth, formatNumber, formatTime, formatTimeRelative, getNowHours, getNowHoursRoundedToStep, interpolateText, isCellSelected, isColumnSelected, isRowSelected, isScrolling, isToday, languagesSignal, localStorageSignal, moveArrayItemByIndex, navBack, navForward, navIntegratedVia, navTo, naviI18n, openCallout, rawUrlPart, registerGlobalConstraint, reload, rerunActions, resource, route, routeAction, scrollActivitySignal, setBaseUrl, setPreferredLanguage, setSupportedLanguages, setUrlTargetOptions, setupRoutes, smallTouchScreenSignal, stateSignal, stopLoad, stringifyTableSelectionValue, swapArrayItemByIndex, syncOwnedResourceToSignals, syncResourceToSignals, triggerNaviCommand, updateActions, useActionStatus, useArraySignalMembership, useAsyncData, useCalloutRequestClose, useCancelPrevious, useCellGridFromRows, useConstraintValidityState, useDependenciesDiff, useDisplayedLayoutEffect, useDocumentResource, useDocumentState, useDocumentUrl, useEditionController, useFocusGroup, useInputGroup, useKeyboardShortcuts, useNavState, useOrderedColumns, usePopupMode, useRouteStatus, useRunOnMount, useSearchText, useSelectableElement, useSelectionController, useSignalSync, useSlideValue, useStateArray, useTitleLevel, useUrlSearchParam, useUrlTargetId, valueInLocalStorage, windowWidthSignal };
+export { ActionRenderer, ActiveKeyboardShortcuts, Address, Badge, BadgeCount, BadgeList, Binder, Box, Button, ButtonCopyToClipboard, Caption, CardLayout, CheckSvg, CheckboxGroup, CloseSvg, Code, Col, Colgroup, Color, ConstructionSvg, ControlGroup, DaySpin, Details, Dialog, Editable, ErrorBoundary, ErrorBoundaryContext, ExclamationSvg, EyeClosedSvg, EyeSvg, Field, FixedBar, Form, Group, Head, HeartSvg, HomeSvg, Icon, Image, Input, InputDuration, Interpolate, Label, Link, LinkAnchorSvg, LinkBlankTargetSvg, LinkCurrentSvg, List, ListItem, ListItemGroup, ListItems, Loading, LoadingDotsSvg, LoadingIndicator, LoadingIndicatorFluid, LoadingOutline, MessageBox, Meter, Nav, NaviDebug, NumberSpin, Paragraph, Picker, Popover, Popup, Quantity, RadioGroup, Route, RouteTravel, RowNumberCol, RowNumberTableCell, SVGMaskOverlay, SearchSvg, Select, SelectableInput, SelectionContext, Separator, SettingsSvg, SidePanel, Slide, SlideContainer, Spin, SpinGroup, StarSvg, SummaryMarker, Svg, Table, TableCell, Tbody, Text, TextBox, Textarea, TextareaCharCount, Thead, Time, TimeRangeSpin, TimeSpin, Title, Tr, UITransition, Unit, UserSvg, ViewportLayout, Wheel, WheelGroup, WheelItem, actionRunEffect, anyMatchingRouteSignal, applySearch, arraySignalMembership, compareTwoJsValues, createAction, createAvailableConstraint, createI18n, createRequestCanceller, createSearch, createSelectionKeyboardShortcuts, createSlot, defineInteractionDetector, defineNaviConfirmPopupOptions, detectHorizontalOverflow, enableDebugActions, enableDebugOnDocumentLoading, ensureDocumentStartViewTransition, errorIsDisplayed, filterTableSelection, formatDatetime, formatDay, formatDayRelative, formatMonth, formatNumber, formatTime, formatTimeRelative, getNowHours, getNowHoursRoundedToStep, interpolateText, isCellSelected, isColumnSelected, isRowSelected, isScrolling, isToday, languagesSignal, localStorageSignal, markErrorAsDisplayedBy, moveArrayItemByIndex, navBack, navForward, navIntegratedVia, navTo, naviI18n, openCallout, rawUrlPart, registerGlobalConstraint, reload, rerunActions, resource, route, routeAction, scrollActivitySignal, setBaseUrl, setPreferredLanguage, setSupportedLanguages, setUrlTargetOptions, setupRoutes, smallTouchScreenSignal, stateSignal, stopLoad, stringifyTableSelectionValue, swapArrayItemByIndex, syncOwnedResourceToSignals, syncResourceToSignals, triggerNaviCommand, updateActions, useActionStatus, useArraySignalMembership, useAsyncData, useCalloutRequestClose, useCancelPrevious, useCellGridFromRows, useConstraintValidityState, useDependenciesDiff, useDisplayedLayoutEffect, useDocumentResource, useDocumentState, useDocumentUrl, useEditionController, useFocusGroup, useInputGroup, useKeyboardShortcuts, useNavState, useOrderedColumns, usePopupMode, useRouteStatus, useRunOnMount, useSearchText, useSelectableElement, useSelectionController, useSignalSync, useSlideValue, useStateArray, useTitleLevel, useUrlSearchParam, useUrlTargetId, valueInLocalStorage, windowWidthSignal };
 //# sourceMappingURL=jsenv_navi.js.map