@jsenv/navi 0.29.454 → 0.29.455

package/dist/jsenv_navi.js

@@ -39582,18 +39582,20 @@ const callLiftOverCallbacks = () => {
  *
  * A picker's `action` waits for its popup to close: what is done in there is
  * one answer, given when the person is done. A change made while the popup is
- * closed — a chip's cross, a paste, a cut, a value proposed from beside it
- * (`--navi-update`) — has no close coming, so nothing would ever send it: the
- * value moves on screen and the record behind it stays. Each of those gestures
- * calls this right after setting the value; a failing action puts the value
- * back (resetOnError), as it does after a close.
+ * closed — the clear cross, a chip's cross, a paste, a cut, a value proposed
+ * from beside it (`--navi-update`) — has no close coming, so nothing would ever
+ * send it: the value moves on screen and the record behind it stays. Each of
+ * those gestures calls this right after setting the value; a failing action
+ * puts the value back (resetOnError), as it does after a close.
  *
  * Called by gestures only. A value set without one — a bound signal followed, a
  * cancel or a failure rolled back — is the picker being told, not asked, which
  * is why this is not a reaction to every value set on a closed picker.
  *
- * The clear cross does the same through `--navi-send` (see --navi-clear in
- * commands.js), and so does not come through here.
+ * The action is requested the way the close requests it, not through
+ * `--navi-send`: a send also answers the surface around the control (a slide
+ * moves on, an open dialog closes — see resolveAfterSend in commands.js), and a
+ * cross pressed on a picker in a dialog is not the dialog being answered.
  */
 
 
@@ -39616,6 +39618,13 @@ const sendClosedPickerChange = (element, { event, name, requester }) => {
   if (props.picksNothing) {
     return;
   }
+  // A source with an action of its own made the request already: `<Button
+  // action={remove} command="--navi-clear">` runs the removal, and the command
+  // that follows only brings the picker in line with it. Sending the picker's
+  // action on top would ask twice.
+  if (requester?.__uiStateController__?.props.action) {
+    return;
+  }
   // `requester`: the source of a command may have claimed the press to send
   // this very change (see isAimedAtSelfInteractionsBelow).
   dispatchRequestAction(controlHost, { event, name, requester });
@@ -40013,20 +40022,6 @@ registerNaviCommand("--navi-clear", (source, event) => {
     return undefined;
   }
   const fromInput = source.closest(`[navi-control="input"]`);
-  // A control that commits on an explicit send — a picker, whose list sends the
-  // moment a value is chosen — has nothing that would commit a clear: its
-  // action never runs on a ui state change. Left alone, the field goes empty
-  // while the caller still holds the value it gave, and renders it right back.
-  //
-  // Unless the source committed the clear itself: a clear button given its own
-  // action (`<Button action={remove} command="--navi-clear">`) already made the
-  // request — the ui state is being brought in line with what just happened, and
-  // sending the picker's own action on top would ask twice.
-  const sourceController = source.__uiStateController__;
-  const fromSendOnlyControl = Boolean(
-    source.closest?.(`[navi-control=picker]`) &&
-    !sourceController?.props.action,
-  );
 
   const performClear = (clearEvent) => {
     dispatchRequestInteraction(target, {
@@ -40037,46 +40032,11 @@ registerNaviCommand("--navi-clear", (source, event) => {
       requester: source,
       prevented: () => clearEvent.preventDefault(),
       allowed: () => {
-        // What the control holds, before it holds nothing: the clear is
-        // optimistic — the field empties now and the send that commits it may
-        // still fail — so what it emptied has to be kept to be put back.
-        const uiStateBefore = getUIStateFromElement(target);
         dispatchRequestClearUIState(target, clearEvent);
-        if (!fromSendOnlyControl) {
-          return;
-        }
-        // After the clear, never before: the action is bound to the ui
-        // state signal, so this sends the value the control now holds.
-        const actionHost = findControlHost(target) || target;
-        const completion = watchActionCompletion(actionHost, () => {
-          triggerNaviCommand(source, "--navi-send", clearEvent, {
-            optional: true,
-          });
-        });
-        completion.whenSettled(({ error, aborted }) => {
-          if (!error && !aborted) {
-            return;
-          }
-          // The removal did not happen, so the field must stop saying it did.
-          // The error itself stays where the action put it — on the control,
-          // which is still there, unlike the cross that has just gone with the
-          // value it cleared (see addErrorMessage in use_execute_action.js).
-          //
-          // Put back from the inside ("clear_rollback" is an internal event
-          // type, see ui_state_controller.js) rather than asked for the way a
-          // user would: nobody acted, the control is being returned to the
-          // state its caller still holds. Asked from the outside it would be
-          // answered with "this element is busy" — the action is still
-          // settling — over the very error that explains why the value is back.
-          const controller = actionHost.__uiStateController__;
-          if (!controller) {
-            return;
-          }
-          const rollbackEvent = new CustomEvent("clear_rollback", {
-            detail: {},
-          });
-          chainEvent(rollbackEvent, clearEvent);
-          controller.setUIState(uiStateBefore, rollbackEvent);
+        sendClosedPickerChange(target, {
+          event: clearEvent,
+          name: "--navi-clear",
+          requester: source,
         });
       },
     });
@@ -40816,6 +40776,7 @@ registerNaviCommand("--navi-select", (source, event) => {
       return dispatchCustomEvent(target, "navi_request_select", {
         event,
         id: resolveCommandValue(source, event),
+        requester: source,
       });
     },
   };
@@ -40832,6 +40793,7 @@ registerNaviCommand("--navi-unselect", (source, event) => {
       return dispatchCustomEvent(target, "navi_request_unselect", {
         event,
         id: resolveCommandValue(source, event),
+        requester: source,
       });
     },
   };
@@ -44672,12 +44634,6 @@ const INTERNAL_EVENT_SET = new Set([
   // on registration, and group pushing value/defaultValue to children on registerChild.
   // Equivalent to defaultValue initialization: no uiAction, no commands, no parent notification.
   "initial_state_push",
-  // navi undoing its own optimistic write: the clear cross emptied the control
-  // before the send that commits it, the send failed, and the value it emptied
-  // goes back where it was (see the --navi-clear command). Nothing acted — the
-  // control is being put back on the state the caller still holds — so this
-  // must not fire a uiAction, a command, or a report on the way.
-  "clear_rollback",
   // A picker's popup closed on a cancel (the no button, Escape, a click
   // outside): what the picker held at open goes back. Nobody acted — no
   // command — but the value really did move back, so uiAction and the parent
@@ -82530,7 +82486,8 @@ const requestPickerListEntry = (pickerEl, pickerInputEl, e, goal) => {
     return;
   }
   const {
-    id: entry
+    id: entry,
+    requester
   } = e.detail;
   const isThere = uiState.some(item => compareTwoJsValues(item, entry));
   if (goal === "select" ? isThere : !isThere) {
@@ -82547,7 +82504,8 @@ const requestPickerListEntry = (pickerEl, pickerInputEl, e, goal) => {
       });
       sendClosedPickerChange(pickerInputEl, {
         event: e,
-        name: goal
+        name: goal,
+        requester
       });
     }
   });