@jsenv/navi 0.29.228 → 0.29.230

package/dist/jsenv_navi.js

@@ -63429,158 +63429,163 @@ const ListSelectable = props => {
     }
     setCurrentId(initialEl.id);
   }, []);
-  const listVnode = jsx(Next, {
-    "navi-selectable": "",
-    ...listControlRootProps,
-    ...listControlProps,
-    // "loading" is a control prop, so useControlgroupProps consumes it (into
-    // aria-busy / the :-navi-loading pseudo state) and it does not survive
-    // into the props below. ListUI needs it too — it is what makes the list
-    // render skeleton rows instead of its (not yet known) items.
-    loading: props.loading,
-    name: undefined,
-    value: undefined,
-    defaultValue: undefined,
-    selectable: undefined,
-    multiple: undefined,
-    deselectable: undefined,
-    focusGroupDirection: undefined,
-    focusGroupWrap: undefined
-    // Track focus inside the list: whichever item gets focus becomes current.
-    ,
-    onFocusIn: e => {
-      const realInput = e.target.closest("[navi-selectable-real-input]");
-      if (!realInput) {
-        return;
-      }
-      const itemEl = realInput.closest("[navi-list-item-real]");
-      if (itemEl && itemEl.id) {
-        setCurrentId(itemEl.id, e);
-      }
-    },
-    onnavi_request_select: e => {
-      const {
-        id
-      } = e.detail;
-      if (id === undefined) {
-        return;
-      }
-      const inputId = `${id}_input`;
-      const childController = uiGroupStateController.findChildById(inputId);
-      if (!childController) {
-        return;
-      }
-      const list = ref.current;
-      dispatchRequestInteraction(list, {
-        event: e,
-        name: "select",
-        prevented: () => e.preventDefault(),
-        // tell the requester that we don't want to select this item
-        // Asked of the item too, not only of the list: an item can be the one
-        // refusing (the list already holds all it accepts, see maxLength), and
-        // it is the one that then says why.
-        allowed: () => {
-          dispatchRequestInteraction(childController.ref.current, {
-            event: e,
-            name: "select",
-            prevented: () => e.preventDefault(),
-            allowed: () => childController.setUIState(childController.value, e)
-          });
+
+  // The group's contexts stand around the whole list, never between the <ul>
+  // and the rows: the walk that gives the rows their places is over the <ul>'s
+  // children, and a component sitting there is one child — every row would then
+  // stand in a single slot, and reordering them (a search) would move nothing.
+  const listVnode = jsx(ControlgroupChildrenWrapper, {
+    ...childrenWrapperProps,
+    children: jsx(Next, {
+      "navi-selectable": "",
+      ...listControlRootProps,
+      ...listControlProps,
+      // "loading" is a control prop, so useControlgroupProps consumes it (into
+      // aria-busy / the :-navi-loading pseudo state) and it does not survive
+      // into the props below. ListUI needs it too — it is what makes the list
+      // render skeleton rows instead of its (not yet known) items.
+      loading: props.loading,
+      name: undefined,
+      value: undefined,
+      defaultValue: undefined,
+      selectable: undefined,
+      multiple: undefined,
+      deselectable: undefined,
+      focusGroupDirection: undefined,
+      focusGroupWrap: undefined
+      // Track focus inside the list: whichever item gets focus becomes current.
+      ,
+      onFocusIn: e => {
+        const realInput = e.target.closest("[navi-selectable-real-input]");
+        if (!realInput) {
+          return;
         }
-      });
-    },
-    onnavi_request_unselect: e => {
-      const {
-        id
-      } = e.detail;
-      if (id === undefined) {
-        return;
-      }
-      const inputId = `${id}_input`;
-      const childController = uiGroupStateController.findChildById(inputId);
-      if (!childController) {
-        return;
-      }
-      const list = ref.current;
-      dispatchRequestInteraction(list, {
-        event: e,
-        name: "unselect",
-        prevented: () => e.preventDefault(),
-        // tell the requester that we don't want to unselect this item
-        allowed: () => childController.setUIState(undefined, e)
-      });
-    }
-    // "previous"/"next", not "up"/"down": a list is a line of items whichever
-    // way it is laid out, and a horizontal one walks sideways. The keys that
-    // drive it (arrows, Home/End) map onto that here, and so do the commands
-    // (--navi-previous / --navi-next / --navi-first / --navi-last).
-    ,
-    onnavi_request_nav: e => {
-      const {
-        goal
-      } = e.detail;
-      const navigableEls = getNavigableElements();
-      if (navigableEls.length === 0) {
-        return;
+        const itemEl = realInput.closest("[navi-list-item-real]");
+        if (itemEl && itemEl.id) {
+          setCurrentId(itemEl.id, e);
+        }
+      },
+      onnavi_request_select: e => {
+        const {
+          id
+        } = e.detail;
+        if (id === undefined) {
+          return;
+        }
+        const inputId = `${id}_input`;
+        const childController = uiGroupStateController.findChildById(inputId);
+        if (!childController) {
+          return;
+        }
+        const list = ref.current;
+        dispatchRequestInteraction(list, {
+          event: e,
+          name: "select",
+          prevented: () => e.preventDefault(),
+          // tell the requester that we don't want to select this item
+          // Asked of the item too, not only of the list: an item can be the one
+          // refusing (the list already holds all it accepts, see maxLength), and
+          // it is the one that then says why.
+          allowed: () => {
+            dispatchRequestInteraction(childController.ref.current, {
+              event: e,
+              name: "select",
+              prevented: () => e.preventDefault(),
+              allowed: () => childController.setUIState(childController.value, e)
+            });
+          }
+        });
+      },
+      onnavi_request_unselect: e => {
+        const {
+          id
+        } = e.detail;
+        if (id === undefined) {
+          return;
+        }
+        const inputId = `${id}_input`;
+        const childController = uiGroupStateController.findChildById(inputId);
+        if (!childController) {
+          return;
+        }
+        const list = ref.current;
+        dispatchRequestInteraction(list, {
+          event: e,
+          name: "unselect",
+          prevented: () => e.preventDefault(),
+          // tell the requester that we don't want to unselect this item
+          allowed: () => childController.setUIState(undefined, e)
+        });
       }
-      const currentId = currentIdRef.current;
-      let currentIndex = -1;
-      if (currentId) {
-        currentIndex = navigableEls.findIndex(el => el.id === currentId);
-      }
-      let targetEl;
-      if (goal === "first") {
-        targetEl = navigableEls[0];
-      } else if (goal === "last") {
-        targetEl = navigableEls[navigableEls.length - 1];
-      } else if (goal === "next") {
-        if (currentIndex === -1) {
+      // "previous"/"next", not "up"/"down": a list is a line of items whichever
+      // way it is laid out, and a horizontal one walks sideways. The keys that
+      // drive it (arrows, Home/End) map onto that here, and so do the commands
+      // (--navi-previous / --navi-next / --navi-first / --navi-last).
+      ,
+      onnavi_request_nav: e => {
+        const {
+          goal
+        } = e.detail;
+        const navigableEls = getNavigableElements();
+        if (navigableEls.length === 0) {
+          return;
+        }
+        const currentId = currentIdRef.current;
+        let currentIndex = -1;
+        if (currentId) {
+          currentIndex = navigableEls.findIndex(el => el.id === currentId);
+        }
+        let targetEl;
+        if (goal === "first") {
           targetEl = navigableEls[0];
-        } else if (currentIndex < navigableEls.length - 1) {
-          targetEl = navigableEls[currentIndex + 1];
-        } else {
+        } else if (goal === "last") {
           targetEl = navigableEls[navigableEls.length - 1];
+        } else if (goal === "next") {
+          if (currentIndex === -1) {
+            targetEl = navigableEls[0];
+          } else if (currentIndex < navigableEls.length - 1) {
+            targetEl = navigableEls[currentIndex + 1];
+          } else {
+            targetEl = navigableEls[navigableEls.length - 1];
+          }
+        } else if (goal === "previous") {
+          if (currentIndex === -1) {
+            targetEl = navigableEls[0];
+          } else if (currentIndex > 0) {
+            targetEl = navigableEls[currentIndex - 1];
+          } else {
+            targetEl = navigableEls[0];
+          }
         }
-      } else if (goal === "previous") {
-        if (currentIndex === -1) {
-          targetEl = navigableEls[0];
-        } else if (currentIndex > 0) {
-          targetEl = navigableEls[currentIndex - 1];
-        } else {
-          targetEl = navigableEls[0];
+        if (!targetEl) {
+          return;
         }
-      }
-      if (!targetEl) {
-        return;
-      }
-      setCurrentId(targetEl.id, e);
-      dispatchCustomEvent(ref.current, "navi_request_scroll", {
-        event: e,
-        id: targetEl.id
-      });
-    },
-    onnavi_request_activate: e => {
-      const currentId = currentIdRef.current;
-      if (!currentId) {
-        return;
-      }
-      if (multiple || deselectable) {
-        const inputId = `${currentId}_input`;
-        const childController = uiGroupStateController.findChildById(inputId);
-        const isSelected = childController && childController.uiState;
-        dispatchCustomEvent(ref.current, isSelected ? "navi_request_unselect" : "navi_request_select", {
+        setCurrentId(targetEl.id, e);
+        dispatchCustomEvent(ref.current, "navi_request_scroll", {
+          event: e,
+          id: targetEl.id
+        });
+      },
+      onnavi_request_activate: e => {
+        const currentId = currentIdRef.current;
+        if (!currentId) {
+          return;
+        }
+        if (multiple || deselectable) {
+          const inputId = `${currentId}_input`;
+          const childController = uiGroupStateController.findChildById(inputId);
+          const isSelected = childController && childController.uiState;
+          dispatchCustomEvent(ref.current, isSelected ? "navi_request_unselect" : "navi_request_select", {
+            event: e,
+            id: currentId
+          });
+          return;
+        }
+        dispatchCustomEvent(ref.current, "navi_request_select", {
           event: e,
           id: currentId
         });
-        return;
-      }
-      dispatchCustomEvent(ref.current, "navi_request_select", {
-        event: e,
-        id: currentId
-      });
-    },
-    children: jsx(ControlgroupChildrenWrapper, {
-      ...childrenWrapperProps,
+      },
       children: props.children
     })
   });
@@ -64960,52 +64965,59 @@ const ListContent = ({
   children
 }) => {
   const listProps = useContext(BoxForwardedPropsContext);
-  return jsx(Box, {
-    className: "navi_list_scroll_container",
-    overflow: overflow,
-    overflowX: overflowX,
-    overflowY: overflowY,
-    ...scrollBoxPaddingProps,
-    children: jsx(UnorderedList, {
-      role: role,
-      fallback: fallback,
-      fallbackShown: fallbackShown,
-      searchFallback: searchFallback,
-      searchFallbackShown: searchFallbackShown,
-      loadingPlaceholderShown: loadingPlaceholderShown,
-      error: error,
-      searchNoMatchMode: searchNoMatchMode,
-      separator: separator,
-      itemTransition: itemTransition,
-      expandX: expandX
-      // Deliberately not expandY here (unlike expandX above): the outer
-      // .navi_list_container already gets its own expandY treatment (see
-      // ListUI's own Box above) to fill whatever space its *own* parent
-      // gives it (e.g. a flex-column ancestor's flex-grow) — the <ul>
-      // itself must stay auto-height regardless, or it gets capped to
-      // match .navi_list_scroll_container's own (possibly much smaller)
-      // flex-resolved height instead of its real content height. That
-      // breaks two things at once: virtual scroll's own filler sizing
-      // (nothing to overflow into the scroll container in the first
-      // place) and any sticky List.Item header/footer inside it (their
-      // sticky "containing block" — the <ul>'s own box — would be
-      // artificially small, so they run out of room to stay stuck well
-      // before the user has actually scrolled through all the content).
-      ,
-      horizontal: horizontal,
-      spacing: spacing,
-      columns: columns,
-      itemColumns: itemColumns,
-      ...listProps,
-      tracker: tracker,
-      renderWindow: renderWindow,
-      virtual: virtual,
-      children: jsx(PendingScrollRefContext.Provider, {
-        value: pendingScrollRef,
-        children: children
+  return (
+    // Every provider the list puts around its items stands OUTSIDE the <ul>:
+    // the walk that gives the rows their places (see ListDeclaredChildren) is
+    // over the <ul>'s children, and one component between it and the caller's
+    // rows is one child — all the rows would then stand in a single slot, and
+    // reordering them would move nothing.
+    jsx(PendingScrollRefContext.Provider, {
+      value: pendingScrollRef,
+      children: jsx(Box, {
+        className: "navi_list_scroll_container",
+        overflow: overflow,
+        overflowX: overflowX,
+        overflowY: overflowY,
+        ...scrollBoxPaddingProps,
+        children: jsx(UnorderedList, {
+          role: role,
+          fallback: fallback,
+          fallbackShown: fallbackShown,
+          searchFallback: searchFallback,
+          searchFallbackShown: searchFallbackShown,
+          loadingPlaceholderShown: loadingPlaceholderShown,
+          error: error,
+          searchNoMatchMode: searchNoMatchMode,
+          separator: separator,
+          itemTransition: itemTransition,
+          expandX: expandX
+          // Deliberately not expandY here (unlike expandX above): the outer
+          // .navi_list_container already gets its own expandY treatment (see
+          // ListUI's own Box above) to fill whatever space its *own* parent
+          // gives it (e.g. a flex-column ancestor's flex-grow) — the <ul>
+          // itself must stay auto-height regardless, or it gets capped to
+          // match .navi_list_scroll_container's own (possibly much smaller)
+          // flex-resolved height instead of its real content height. That
+          // breaks two things at once: virtual scroll's own filler sizing
+          // (nothing to overflow into the scroll container in the first
+          // place) and any sticky List.Item header/footer inside it (their
+          // sticky "containing block" — the <ul>'s own box — would be
+          // artificially small, so they run out of room to stay stuck well
+          // before the user has actually scrolled through all the content).
+          ,
+          horizontal: horizontal,
+          spacing: spacing,
+          columns: columns,
+          itemColumns: itemColumns,
+          ...listProps,
+          tracker: tracker,
+          renderWindow: renderWindow,
+          virtual: virtual,
+          children: children
+        })
       })
     })
-  });
+  );
 };
 // Where the items sit is a question about the track (the <ul>), not about the
 // frame around it: the frame's only child is the scroll box, which fills it and
@@ -65200,6 +65212,10 @@ const useListScrollSync = ({
       const block = blockRequested || (event.type === "navi_displayed" ? "center" : "nearest");
       const scrollToItemCall = `${getElementSignature(itemEl)}.scrollIntoView({ block: "${block}", container: "nearest" })`;
       debugScroll(`${trigger} -> ${scrollToItemCall}`);
+      // The list is going somewhere on purpose, so there is no view to hold
+      // still any more: an anchor captured before this drop it, or it would
+      // put the list back where it was the moment the rows move under it.
+      anchorRef.current = null;
       scrollIntoViewScoped(itemEl, {
         container: getScroller(),
         block
@@ -65210,17 +65226,14 @@ const useListScrollSync = ({
         item
       });
     };
-    const {
-      start,
-      end
-    } = renderWindowRef.current;
-    const isInWindow = index >= start && index < end;
-    if (isInWindow) {
-      const itemEl = findRowElement(getListEl(), item.id);
-      if (itemEl) {
-        scrollItemIntoView(itemEl);
-        return;
-      }
+
+    // Whether the row is drawn is asked of the dom, not of the render window:
+    // the window says what a run draws, and a list whose rows are declared one
+    // by one has them all in the dom whatever the window says.
+    const itemEl = findRowElement(getListEl(), item.id);
+    if (itemEl) {
+      scrollItemIntoView(itemEl);
+      return;
     }
     // Not in DOM — shift the render window. The item will read
     // pendingScrollRef on mount and scroll into view.
@@ -65342,9 +65355,8 @@ const useListScrollSync = ({
   }, []);
   // Watch scores of the top renderBudget items.
   // When scores change during an active search, scroll to top to reveal the most relevant items.
-  // When search becomes empty, restore the scroll position from before the search started.
-  // We save the first-visible item ID so restoration is item-precise
-  // and survives render-window shifts or item reordering.
+  // When search becomes empty, put the list back at the offset (and the render
+  // window) it was at when the search started — see docs/scroll.md.
 
   // NOTE POUR LE JOUR OU ON A LE MULTISELECT:
   // Lorsqu'on selectionne quelque chose pendant une recherche, alors ensuite meme si on clear
@@ -67252,6 +67264,28 @@ const createListVirtual = () => {
     } else {
       ownerIdsBySlot.set(slotId, [ownerId]);
     }
+    warnIfEveryRowInOneSlot(slotId);
+  };
+  // Rows that all stand in the same slot keep the order they first mounted in:
+  // the walk is over the children the list is given, and a component holding
+  // them is one child however many rows it renders. Everything about a place
+  // then stops following what the caller writes — a search reordering the rows
+  // moves nothing. Said once, and only for the shape that can be nothing else:
+  // the list's whole content is one child, and several rows came out of it.
+  let everyRowInOneSlotWarned = false;
+  const warnIfEveryRowInOneSlot = slotId => {
+    if (everyRowInOneSlotWarned) {
+      return;
+    }
+    const rootSlotIds = slotIdsByParent.get(null);
+    if (!rootSlotIds || rootSlotIds.length !== 1 || rootSlotIds[0] !== slotId) {
+      return;
+    }
+    if (ownerIdsBySlot.get(slotId).length < 2) {
+      return;
+    }
+    everyRowInOneSlotWarned = true;
+    console.warn(`List: every row stands in the same slot, so they keep the order they first rendered in — reordering them (a search, a sort) will not move them. The list's rows must be its own children: give it the rows (or a <List.Items>), not a component rendering them.`);
   };
   const removeFromSlot = (slotId, ownerId) => {
     const ownerIds = ownerIdsBySlot.get(slotId);