@jsenv/lighthouse-impact 4.0.2 → 4.0.4

package/README.md

@@ -112,7 +112,7 @@ _.github/workflows/lighthouse_impact.yml_
 
 name: lighthouse impact
 
-on: pull_request_target
+on: pull_request
 
 jobs:
   lighthouse_impact:
@@ -120,11 +120,11 @@ jobs:
     name: lighthouse impact
     steps:
       - name: Setup git
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Setup node
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
-          node-version: "16.13.0"
+          node-version: "18.3.0"
       - name: Install node modules
         run: npm install
       - name: Report lighthouse impact
@@ -138,7 +138,7 @@ _report_lighthouse_impact.mjs_
  * This file is executed by lighthouse_impact.yml GitHub workflow.
  * - it generates lighthouse report before and after merging a pull request
  * - Then, it creates or updates a comment in the pull request
- * See https://github.com/jsenv/workflow/tree/main/packages/jsenv-performance-impact
+ * See https://github.com/jsenv/workflow/tree/main/packages/performance-impact
  */
 
 import {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/lighthouse-impact",
-  "version": "4.0.2",
+  "version": "4.0.4",
   "description": "Package description",
   "license": "MIT",
   "author": {
@@ -11,7 +11,7 @@
   "repository": {
     "type": "git",
     "url": "https://github.com/jsenv/workflow",
-    "directory": "packages/jsenv-lighthouse-impact"
+    "directory": "packages/lighthouse-impact"
   },
   "engines": {
     "node": ">=16.13.0"
@@ -37,9 +37,9 @@
   "dependencies": {
     "@jsenv/abort": "4.2.4",
     "@jsenv/dynamic-import-worker": "1.1.0",
-    "@jsenv/filesystem": "4.1.6",
-    "@jsenv/github-pull-request-impact": "1.7.1",
-    "@jsenv/log": "3.3.2",
-    "lighthouse": "9.6.8"
+    "@jsenv/filesystem": "4.2.3",
+    "@jsenv/github-pull-request-impact": "1.7.2",
+    "@jsenv/log": "3.3.4",
+    "lighthouse": "10.2.0"
   }
 }

package/src/generate/generate_lighthouse_report.js

@@ -110,7 +110,7 @@ export const generateLighthouseReport = async (
       throw e
     }
 
-    const lighthouseReport = reduceToMedianReport(reports)
+    const lighthouseReport = await reduceToMedianReport(reports)
     if (log) {
       logger.info(formatReportAsSummaryText(lighthouseReport))
     }
@@ -124,7 +124,7 @@ export const generateLighthouseReport = async (
     }
     if (htmlFileUrl) {
       assertAndNormalizeFileUrl(htmlFileUrl)
-      const html = formatReportAsHtml(lighthouseReport)
+      const html = await formatReportAsHtml(lighthouseReport)
       writeFileSync(htmlFileUrl, html)
       if (htmlFileLog) {
         logger.info(`-> ${htmlFileUrl}`)

package/src/generate/lighthouse_api.js

@@ -1,9 +1,5 @@
-import { createRequire } from "node:module"
-
-const require = createRequire(import.meta.url)
-
 export const runLighthouse = async (url, lighthouseOptions) => {
-  const lighthouse = require("lighthouse")
+  const { default: lighthouse } = await import("lighthouse")
   const results = await lighthouse(url, undefined, lighthouseOptions)
   // use results.lhr for the JS-consumeable output
   // https://github.com/GoogleChrome/lighthouse/blob/master/types/lhr.d.ts
@@ -19,10 +15,8 @@ export const runLighthouse = async (url, lighthouseOptions) => {
   return lhr
 }
 
-export const reduceToMedianReport = (lighthouseReports) => {
-  const {
-    computeMedianRun,
-  } = require("lighthouse/lighthouse-core/lib/median-run.js")
+export const reduceToMedianReport = async (lighthouseReports) => {
+  const { computeMedianRun } = await import("lighthouse/core/lib/median-run.js")
   return computeMedianRun(lighthouseReports)
 }
 
@@ -39,8 +33,10 @@ export const formatReportAsJson = (lighthouseReport) => {
   return json
 }
 
-export const formatReportAsHtml = (lighthouseReport) => {
-  const ReportGenerator = require("lighthouse/report/generator/report-generator.js")
+export const formatReportAsHtml = async (lighthouseReport) => {
+  const { ReportGenerator } = await import(
+    "lighthouse/report/generator/report-generator.js"
+  )
   const html = ReportGenerator.generateReportHtml(lighthouseReport)
   return html
 }

package/src/report_lighthouse_impact_in_github_pr.js

@@ -109,7 +109,7 @@ export const reportLighthouseImpactInGithubPullRequest = async ({
       }
     },
     generatedByLink: {
-      url: "https://github.com/jsenv/workflow/tree/main/packages/jsenv-lighthouse-impact",
+      url: "https://github.com/jsenv/workflow/tree/main/packages/lighthouse-impact",
       text: "@jsenv/lighthouse-impact",
     },
     runLink,