@jsenv/lighthouse-impact 1.2.1 → 2.1.2

package/README.md

@@ -1,12 +1,4 @@
-# Lighthouse impact
-
-Report pull request impacts on lighthouse score.
-
-[![npm package](https://img.shields.io/npm/v/@jsenv/lighthouse-impact.svg?logo=npm&label=package)](https://www.npmjs.com/package/@jsenv/lighthouse-impact)
-[![github main](https://github.com/jsenv/lighthouse-impact/workflows/main/badge.svg)](https://github.com/jsenv/lighthouse-impact/actions?workflow=main)
-[![codecov coverage](https://codecov.io/gh/jsenv/lighthouse-impact/branch/main/graph/badge.svg)](https://codecov.io/gh/jsenv/lighthouse-impact)
-
-# Presentation
+# Lighthouse impact [![npm package](https://img.shields.io/npm/v/@jsenv/lighthouse-impact.svg?logo=npm&label=package)](https://www.npmjs.com/package/@jsenv/lighthouse-impact) [![github main](https://github.com/jsenv/lighthouse-impact/workflows/main/badge.svg)](https://github.com/jsenv/lighthouse-impact/actions?workflow=main) [![codecov coverage](https://codecov.io/gh/jsenv/lighthouse-impact/branch/main/graph/badge.svg)](https://codecov.io/gh/jsenv/lighthouse-impact)
 
 `@jsenv/lighthouse-impact` analyses a pull request impact on lighthouse score. This analysis is posted in a comment of the pull request on GitHub.
 
@@ -32,7 +24,7 @@ The first thing you need is a script capable to generate a lighthouse report.
 npm install --save-dev @jsenv/lighthouse-impact
 ```
 
-_generate_lighthouse_report.mjs_
+_lighthouse.mjs_
 
 ```js
 /*
@@ -42,24 +34,23 @@ _generate_lighthouse_report.mjs_
  */
 import { createServer } from "node:http"
 import { readFileSync } from "node:fs"
-import { getLighthouseReportUsingHeadlessChrome } from "@jsenv/lighthouse-impact"
+import { generateLighthouseReport } from "@jsenv/lighthouse-impact"
 
 const htmlFileUrl = new URL("./index.html", import.meta.url)
 const html = String(readFileSync(htmlFileUrl))
 
-export const generateLighthouseReport = async () => {
-  const server = createServer((request, response) => {
-    response.writeHead(200, {
-      "content-type": "text/html",
-    })
-    response.end(html)
+const server = createServer((request, response) => {
+  response.writeHead(200, {
+    "content-type": "text/html",
   })
-  server.listen(8080)
-  server.unref()
+  response.end(html)
+})
+server.listen(8080)
+server.unref()
 
-  const lighthouseReport = await getLighthouseReportUsingHeadlessChrome("http://127.0.0.1:8080")
-  return lighthouseReport
-}
+export const lighthouseReport = await generateLighthouseReport(
+  "http://127.0.0.1:8080",
+)
 ```
 
 _index.html_
@@ -78,7 +69,7 @@ _index.html_
 </html>
 ```
 
-At this stage, you could generate a lighthouse report on your machine. For an example, see [package.json#L36](./package.json#L36) and [script/lighthouse/generate_lighthouse_report.mjs#L35](./script/lighthouse/generate_lighthouse_report.mjs#L35).
+At this stage, you could generate a lighthouse report on your machine. For an example, see [package.json#L37](./package.json#L37) and [script/lighthouse/lighthouse.mjs#L19](./script/lighthouse/lighthouse.mjs#L19).
 
 Now it's time to configure a workflow to compare lighthouse reports before and after merging a pull request.
 
@@ -108,10 +99,10 @@ jobs:
       - name: Setup git
         uses: actions/checkout@v2
       - name: Setup node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
-          node-version: "16.x"
-      - name: Setup npm
+          node-version: "16.13.0"
+      - name: Install node modules
         run: npm install
       - name: Report lighthouse impact
         run: node ./report_lighthouse_impact.mjs
@@ -127,11 +118,14 @@ _report_lighthouse_impact.mjs_
  * See https://github.com/jsenv/lighthouse-impact#how-it-works
  */
 
-import { reportLighthouseImpact, readGitHubWorkflowEnv } from "@jsenv/lighthouse-impact"
+import {
+  reportLighthouseImpact,
+  readGitHubWorkflowEnv,
+} from "@jsenv/lighthouse-impact"
 
-reportLighthouseImpact({
+await reportLighthouseImpact({
   ...readGitHubWorkflowEnv(),
-  moduleGeneratingLighthouseReportRelativeUrl: "./generate_lighthouse_report.mjs",
+  lighthouseReportPath: "./lighthouse.mjs#lighthouseReport",
 })
 ```
 
@@ -173,7 +167,7 @@ reportLighthouseImpact({
 +  repositoryName: process.env.TRAVIS_REPO_SLUG.split("/")[1],
 +  pullRequestNumber: process.env.TRAVIS_PULL_REQUEST,
 +  githubToken: process.env.GITHUB_TOKEN, // see next step
-  moduleGeneratingLighthouseReportRelativeUrl: "./generate_lighthouse_report.mjs",
+   lighthouseReportPath: "./lighthouse.mjs#lighthouseReport",
 })
 ```
 

package/main.js

@@ -1,5 +1,4 @@
-export { readGitHubWorkflowEnv } from "@jsenv/github-pull-request-impact"
+export { generateLighthouseReport } from "./src/generateLighthouseReport.js"
 
-export { getLighthouseReportUsingHeadlessChrome } from "./src/getLighthouseReportUsingHeadlessChrome.js"
-export { logLighthouseReport } from "./src/logLighthouseReport.js"
+export { readGitHubWorkflowEnv } from "@jsenv/github-pull-request-impact"
 export { reportLighthouseImpact } from "./src/reportLighthouseImpact.js"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/lighthouse-impact",
-  "version": "1.2.1",
+  "version": "2.1.2",
   "description": "Package description",
   "license": "MIT",
   "author": {
@@ -13,7 +13,7 @@
     "url": "https://github.com/jsenv/lighthouse-impact"
   },
   "engines": {
-    "node": ">=14.17.0"
+    "node": ">=16.13.0"
   },
   "publishConfig": {
     "access": "public",
@@ -26,47 +26,43 @@
     },
     "./*": "./*"
   },
+  "main": "./main.js",
   "files": [
     "/src/",
     "/main.js"
   ],
   "scripts": {
-    "eslint-check": "node ./node_modules/eslint/bin/eslint.js .",
-    "generate-importmap": "node ./script/importmap/generate_importmap.mjs",
-    "measure-performances": "node ./script/performance/generate_performance_report.mjs --local",
-    "generate-lighthouse-report": "node ./script/lighthouse/generate_lighthouse_report.mjs --local",
+    "eslint": "node ./node_modules/eslint/bin/eslint.js . --ext=.js,.mjs",
+    "importmap": "node ./script/importmap/importmap.mjs",
+    "performance": "node --expose-gc ./script/performance/performance.mjs --log",
+    "lighthouse": "node ./script/lighthouse/lighthouse.mjs --local",
     "generate-comment-snapshot-file": "node ./test/comment/generate_comment_snapshot_file.mjs",
     "test": "node ./script/test/test.mjs",
     "test-with-coverage": "npm run test -- --coverage",
-    "prettier-format": "node ./script/prettier/prettier_format.mjs",
-    "prettier-format-stage": "npm run prettier-format -- --staged",
-    "prettier-check": "npm run prettier-format -- --dry-run",
-    "prepublishOnly": "node ./script/publish/remove_postinstall.mjs",
-    "postpublish": "node ./script/publish/restore_postinstall.mjs"
+    "prettier": "prettier --write ."
   },
   "dependencies": {
-    "@jsenv/cancellation": "3.0.0",
+    "@jsenv/abort": "4.1.2",
+    "@jsenv/dynamic-import-worker": "1.0.0",
+    "@jsenv/filesystem": "2.5.1",
     "@jsenv/github-pull-request-impact": "1.6.4",
     "@jsenv/logger": "4.0.1",
-    "@jsenv/util": "4.1.1",
-    "chrome-launcher": "0.14.0",
-    "lighthouse": "8.2.0"
+    "chrome-launcher": "0.15.0",
+    "lighthouse": "9.1.0"
   },
   "devDependencies": {
-    "@jsenv/assert": "2.2.6",
-    "@jsenv/codecov-upload": "3.5.0",
-    "@jsenv/core": "19.6.2",
-    "@jsenv/eslint-config": "15.0.2",
+    "@jsenv/assert": "2.4.0",
+    "@jsenv/core": "24.5.8",
+    "@jsenv/eslint-config": "16.0.9",
     "@jsenv/github-release-package": "1.2.3",
-    "@jsenv/importmap-eslint-resolver": "5.1.0",
-    "@jsenv/importmap-node-module": "1.0.1",
+    "@jsenv/importmap-eslint-resolver": "5.2.1",
+    "@jsenv/importmap-node-module": "2.8.0",
     "@jsenv/package-publish": "1.6.2",
-    "@jsenv/performance-impact": "1.6.2",
-    "@jsenv/prettier-check-project": "5.6.1",
-    "@jsenv/server": "6.1.1",
-    "eslint": "7.32.0",
-    "eslint-plugin-html": "6.1.2",
-    "eslint-plugin-import": "2.24.0",
-    "prettier": "2.3.2"
+    "@jsenv/performance-impact": "2.2.1",
+    "@jsenv/server": "12.2.0",
+    "eslint": "8.4.1",
+    "eslint-plugin-html": "6.2.0",
+    "eslint-plugin-import": "2.25.3",
+    "prettier": "2.5.1"
   }
 }

package/src/{getLighthouseReportUsingHeadlessChrome.js → generateLighthouseReport.js}

@@ -3,30 +3,24 @@
 import { createRequire } from "node:module"
 
 import { createLogger } from "@jsenv/logger"
+import { Abort, raceProcessTeardownEvents } from "@jsenv/abort"
+
 import {
-  createCancellationToken,
-  createCancellationSource,
-  composeCancellationToken,
-  createOperation,
-  executeAsyncFunction,
-} from "@jsenv/cancellation"
-import { writeFile, resolveUrl } from "@jsenv/util"
+  writeFile,
+  resolveUrl,
+  assertAndNormalizeDirectoryUrl,
+} from "@jsenv/filesystem"
 
-const require = createRequire(import.meta.url)
+import { formatLighthouseReportForLog } from "./internal/formatLighthouseReportForLog.js"
 
-const lighthouse = require("lighthouse")
-// eslint-disable-next-line import/no-unresolved
-const ReportGenerator = require("lighthouse/report/report-generator")
-const { computeMedianRun } = require("lighthouse/lighthouse-core/lib/median-run.js")
-const chromeLauncher = require("chrome-launcher")
+const require = createRequire(import.meta.url)
 
-export const getLighthouseReportUsingHeadlessChrome = async (
+export const generateLighthouseReport = async (
   url,
   {
-    cancellationToken = createCancellationToken(),
-    cancelOnSIGINT = true,
+    signal = new AbortController().signal,
+    handleSIGINT = true,
     logLevel,
-    projectDirectoryUrl,
 
     headless = true,
     gpu = false,
@@ -38,29 +32,33 @@ export const getLighthouseReportUsingHeadlessChrome = async (
     runCount = 1,
     delayBetweenEachRunInSeconds = 1,
 
-    jsonFile = Boolean(projectDirectoryUrl),
+    projectDirectoryUrl, // required only when jsonFile or htmlFile is passed
+    log = false,
+    jsonFile = false,
     jsonFileRelativeUrl = "./lighthouse/lighthouse_report.json",
     jsonFileLog = true,
-    htmlFile = Boolean(projectDirectoryUrl),
+    htmlFile = false,
     htmlFileRelativeUrl = "./lighthouse/lighthouse_report.html",
     htmlFileLog = true,
   } = {},
 ) => {
-  let cleanup = () => {}
-
-  if (cancelOnSIGINT) {
-    const processCancellationSource = createCancellationSource()
-    const processCancellationToken = processCancellationSource.token
-    cancellationToken = composeCancellationToken(cancellationToken, processCancellationToken)
-    const SIGINTCallback = () => {
-      processCancellationSource.cancel("process SIGINT")
-    }
-    process.once("SIGINT", SIGINTCallback)
-    // beware if someday something do things on cleanup
-    // to call the old cleanup function
-    cleanup = () => {
-      process.removeListener("SIGINT", SIGINTCallback)
-    }
+  const ReportGenerator = require("lighthouse/report/generator/report-generator.js")
+  const {
+    computeMedianRun,
+  } = require("lighthouse/lighthouse-core/lib/median-run.js")
+  const chromeLauncher = require("chrome-launcher")
+
+  const generateReportOperation = Abort.startOperation()
+  generateReportOperation.addAbortSignal(signal)
+  if (handleSIGINT) {
+    generateReportOperation.addAbortSource((abort) => {
+      return raceProcessTeardownEvents(
+        {
+          SIGINT: true,
+        },
+        abort,
+      )
+    })
   }
 
   const jsenvGenerateLighthouseReport = async () => {
@@ -75,39 +73,63 @@ export const getLighthouseReportUsingHeadlessChrome = async (
       "--disk-cache-size=1",
       // "--disk-cache-dir=/dev/null",
     ]
-    const chrome = await createOperation({
-      cancellationToken,
-      start: () => chromeLauncher.launch({ chromeFlags }),
-    })
+    const chrome = await chromeLauncher.launch({ chromeFlags })
+    if (generateReportOperation.signal.aborted) {
+      return { aborted: true }
+    }
+
     const lighthouseOptions = {
       chromeFlags,
       port: chrome.port,
     }
 
     const reports = []
-    await Array(runCount)
-      .fill()
-      .reduce(async (previous, _, index) => {
-        await previous
-        if (index > 0 && delayBetweenEachRunInSeconds) {
-          await new Promise((resolve) => setTimeout(resolve, delayBetweenEachRunInSeconds * 1000))
-        }
-        const report = await generateOneLighthouseReport(url, {
-          cancellationToken,
-          lighthouseOptions,
-          config,
-        })
-        reports.push(report)
-      }, Promise.resolve())
+    try {
+      await Array(runCount)
+        .fill()
+        .reduce(async (previous, _, index) => {
+          generateReportOperation.throwIfAborted()
+          await previous
+
+          if (index > 0 && delayBetweenEachRunInSeconds) {
+            await new Promise((resolve) =>
+              setTimeout(resolve, delayBetweenEachRunInSeconds * 1000),
+            )
+          }
+          generateReportOperation.throwIfAborted()
+          const report = await generateOneLighthouseReport(url, {
+            lighthouseOptions,
+            config,
+          })
+          reports.push(report)
+        }, Promise.resolve())
+    } catch (e) {
+      if (Abort.isAbortError(e)) {
+        return { aborted: true }
+      }
+      throw e
+    }
 
     const lighthouseReport = computeMedianRun(reports)
+
+    if (log) {
+      logger.info(formatLighthouseReportForLog(lighthouseReport))
+    }
+
     await chrome.kill()
 
+    if (jsonFile || htmlFile) {
+      projectDirectoryUrl = assertAndNormalizeDirectoryUrl(projectDirectoryUrl)
+    }
+
     const promises = []
     if (jsonFile) {
       promises.push(
         (async () => {
-          const jsonFileUrl = resolveUrl(jsonFileRelativeUrl, projectDirectoryUrl)
+          const jsonFileUrl = resolveUrl(
+            jsonFileRelativeUrl,
+            projectDirectoryUrl,
+          )
           const json = JSON.stringify(lighthouseReport, null, "  ")
           await writeFile(jsonFileUrl, json)
           if (jsonFileLog) {
@@ -119,7 +141,10 @@ export const getLighthouseReportUsingHeadlessChrome = async (
     if (htmlFile) {
       promises.push(
         (async () => {
-          const htmlFileUrl = resolveUrl(htmlFileRelativeUrl, projectDirectoryUrl)
+          const htmlFileUrl = resolveUrl(
+            htmlFileRelativeUrl,
+            projectDirectoryUrl,
+          )
           const html = ReportGenerator.generateReportHtml(lighthouseReport)
           await writeFile(htmlFileUrl, html)
           if (htmlFileLog) {
@@ -133,29 +158,19 @@ export const getLighthouseReportUsingHeadlessChrome = async (
     return lighthouseReport
   }
 
-  return executeAsyncFunction(
-    async () => {
-      try {
-        return await jsenvGenerateLighthouseReport()
-      } finally {
-        cleanup()
-      }
-    },
-    {
-      catchCancellation: true,
-      considerUnhandledRejectionsAsExceptions: true,
-    },
-  )
+  try {
+    return await jsenvGenerateLighthouseReport()
+  } finally {
+    await generateReportOperation.end()
+  }
 }
 
 const generateOneLighthouseReport = async (
   url,
-  { cancellationToken, lighthouseOptions, config },
+  { lighthouseOptions, config },
 ) => {
-  const results = await createOperation({
-    cancellationToken,
-    start: () => lighthouse(url, lighthouseOptions, config),
-  })
+  const lighthouse = require("lighthouse")
+  const results = await lighthouse(url, lighthouseOptions, config)
 
   // use results.lhr for the JS-consumeable output
   // https://github.com/GoogleChrome/lighthouse/blob/master/types/lhr.d.ts

package/src/internal/createLighthouseImpactComment.js

@@ -38,8 +38,12 @@ export const createLighthouseImpactComment = ({
   }
 
   const bodyLines = [
-    ...(beforeMergeGist ? [`<!-- before_merge_gist_id=${beforeMergeGist.id} -->`] : []),
-    ...(afterMergeGist ? [`<!-- after_merge_gist_id=${afterMergeGist.id} -->`] : []),
+    ...(beforeMergeGist
+      ? [`<!-- before_merge_gist_id=${beforeMergeGist.id} -->`]
+      : []),
+    ...(afterMergeGist
+      ? [`<!-- after_merge_gist_id=${afterMergeGist.id} -->`]
+      : []),
     `<h4>Lighthouse impact</h4>`,
     ...(impactAnalysisEnabled
       ? [
@@ -76,19 +80,24 @@ const renderBody = ({
   pullRequestBase,
   pullRequestHead,
 }) => {
-  return Object.keys(afterMergeLighthouseReport.categories).map((categoryName) => {
-    return renderCategory(categoryName, {
-      beforeMergeLighthouseReport,
-      afterMergeLighthouseReport,
-      pullRequestBase,
-      pullRequestHead,
-    })
-  }).join(`
+  return Object.keys(afterMergeLighthouseReport.categories).map(
+    (categoryName) => {
+      return renderCategory(categoryName, {
+        beforeMergeLighthouseReport,
+        afterMergeLighthouseReport,
+        pullRequestBase,
+        pullRequestHead,
+      })
+    },
+  ).join(`
 
 `)
 }
 
-const renderCategory = (category, { beforeMergeLighthouseReport, afterMergeLighthouseReport }) => {
+const renderCategory = (
+  category,
+  { beforeMergeLighthouseReport, afterMergeLighthouseReport },
+) => {
   const beforeMergeDisplayedScore = scoreToDisplayedScore(
     beforeMergeLighthouseReport.categories[category].score,
   )
@@ -114,7 +123,8 @@ const renderCategory = (category, { beforeMergeLighthouseReport, afterMergeLight
 </details>`
 }
 
-const scoreToDisplayedScore = (floatingNumber) => Math.round(floatingNumber * 100)
+const scoreToDisplayedScore = (floatingNumber) =>
+  Math.round(floatingNumber * 100)
 
 const renderCategoryAudits = (
   category,
@@ -156,7 +166,10 @@ const renderCategoryAudits = (
       return
     }
 
-    if (typeof beforeMergeAuditOutput === "number" && typeof afterMergeAuditOutput === "number") {
+    if (
+      typeof beforeMergeAuditOutput === "number" &&
+      typeof afterMergeAuditOutput === "number"
+    ) {
       const diff = afterMergeAuditOutput - beforeMergeAuditOutput
 
       audits.push([
@@ -170,7 +183,9 @@ const renderCategoryAudits = (
 
     audits.push([
       `<td nowrap>${auditId}</td>`,
-      `<td nowrap>${beforeMergeAuditOutput === afterMergeAuditOutput ? "none" : "---"}</td>`,
+      `<td nowrap>${
+        beforeMergeAuditOutput === afterMergeAuditOutput ? "none" : "---"
+      }</td>`,
       `<td nowrap>${beforeMergeAuditOutput}</td>`,
       `<td nowrap>${afterMergeAuditOutput}</td>`,
     ])
@@ -237,7 +252,11 @@ const renderAudit = (audit) => {
   return null
 }
 
-const renderGistLinks = ({ beforeMergeGist, afterMergeGist, pullRequestBase }) => {
+const renderGistLinks = ({
+  beforeMergeGist,
+  afterMergeGist,
+  pullRequestBase,
+}) => {
   return `<sub>
   Impact analyzed comparing <a href="${gistIdToReportUrl(
     beforeMergeGist.id,

package/src/{logLighthouseReport.js → internal/formatLighthouseReportForLog.js}

@@ -1,7 +1,7 @@
-export const logLighthouseReport = (lighthouseReport) => {
+export const formatLighthouseReportForLog = (lighthouseReport) => {
   const scores = {}
   Object.keys(lighthouseReport.categories).forEach((name) => {
     scores[name] = lighthouseReport.categories[name].score
   })
-  console.log(JSON.stringify(scores, null, "  "))
+  return JSON.stringify(scores, null, "  ")
 }

package/src/internal/patchOrPostGists.js

@@ -1,6 +1,10 @@
 /* eslint-disable new-cap */
 import { createDetailedMessage } from "@jsenv/logger"
-import { GET, POST, PATCH } from "@jsenv/github-pull-request-impact/src/internal/git_hub_api.js"
+import {
+  GET,
+  POST,
+  PATCH,
+} from "@jsenv/github-pull-request-impact/src/internal/git_hub_api.js"
 
 // https://developer.github.com/v3/gists/#create-a-gist
 
@@ -27,8 +31,10 @@ export const patchOrPostGists = async ({
       afterMergeGistId = gistIds.afterMergeGistId
       logger.debug(
         createDetailedMessage(`gists found in comment body`, {
-          "before merging gist with lighthouse report": gistIdToUrl(beforeMergeGistId),
-          "after merging gist with lighthouse report": gistIdToUrl(afterMergeGistId),
+          "before merging gist with lighthouse report":
+            gistIdToUrl(beforeMergeGistId),
+          "after merging gist with lighthouse report":
+            gistIdToUrl(afterMergeGistId),
         }),
       )
     } else {
@@ -39,10 +45,16 @@ export const patchOrPostGists = async ({
   logger.debug(`update or create both gists.`)
   let [beforeMergeGist, afterMergeGist] = await Promise.all([
     beforeMergeGistId
-      ? GET(`https://api.github.com/gists/${beforeMergeGistId}`, { cancellationToken, githubToken })
+      ? GET(`https://api.github.com/gists/${beforeMergeGistId}`, {
+          cancellationToken,
+          githubToken,
+        })
       : null,
     afterMergeGistId
-      ? GET(`https://api.github.com/gists/${afterMergeGistId}`, { cancellationToken, githubToken })
+      ? GET(`https://api.github.com/gists/${afterMergeGistId}`, {
+          cancellationToken,
+          githubToken,
+        })
       : null,
   ])
 
@@ -65,10 +77,14 @@ export const patchOrPostGists = async ({
     logger.info(`base gist updated`)
   } else {
     logger.info(`creating base gist`)
-    beforeMergeGist = await POST(`https://api.github.com/gists`, beforeMergeGistBody, {
-      cancellationToken,
-      githubToken,
-    })
+    beforeMergeGist = await POST(
+      `https://api.github.com/gists`,
+      beforeMergeGistBody,
+      {
+        cancellationToken,
+        githubToken,
+      },
+    )
     logger.info(`base gist created at ${gistIdToUrl(beforeMergeGist.id)}`)
   }
 
@@ -79,7 +95,9 @@ export const patchOrPostGists = async ({
     beforeMerge: false,
   })
   if (afterMergeGist) {
-    logger.info(`updating after merge gist at ${gistIdToUrl(afterMergeGist.id)}`)
+    logger.info(
+      `updating after merge gist at ${gistIdToUrl(afterMergeGist.id)}`,
+    )
     afterMergeGist = await PATCH(
       `https://api.github.com/gists/${afterMergeGist.id}`,
       afterMergeGistBody,
@@ -91,10 +109,14 @@ export const patchOrPostGists = async ({
     logger.info(`after merge gist updated`)
   } else {
     logger.info(`creating after merge gist`)
-    afterMergeGist = await POST(`https://api.github.com/gists`, afterMergeGistBody, {
-      cancellationToken,
-      githubToken,
-    })
+    afterMergeGist = await POST(
+      `https://api.github.com/gists`,
+      afterMergeGistBody,
+      {
+        cancellationToken,
+        githubToken,
+      },
+    )
     logger.info(`after merge gist created at ${gistIdToUrl(afterMergeGist.id)}`)
   }
 
@@ -120,8 +142,12 @@ const createGistBody = (
   }
 }
 
-const beforeMergeGistIdRegex = new RegExp("<!-- before_merge_gist_id=([a-zA-Z0-9_]+) -->")
-const afterMergeGistIdRegex = new RegExp("<!-- after_merge_gist_id=([a-zA-Z0-9_]+) -->")
+const beforeMergeGistIdRegex = new RegExp(
+  "<!-- before_merge_gist_id=([a-zA-Z0-9_]+) -->",
+)
+const afterMergeGistIdRegex = new RegExp(
+  "<!-- after_merge_gist_id=([a-zA-Z0-9_]+) -->",
+)
 
 const gistIdsFromComment = (comment) => {
   const beforeMergeGistIdMatch = comment.body.match(beforeMergeGistIdRegex)

package/src/reportLighthouseImpact.js

@@ -1,5 +1,6 @@
 import { commentGitHubPullRequestImpact } from "@jsenv/github-pull-request-impact"
-import { assertAndNormalizeDirectoryUrl, resolveUrl, readFileSystemNodeStat } from "@jsenv/util"
+import { assertAndNormalizeDirectoryUrl, resolveUrl } from "@jsenv/filesystem"
+import { importOneExportFromFile } from "@jsenv/dynamic-import-worker"
 
 import { patchOrPostGists } from "./internal/patchOrPostGists.js"
 import { createLighthouseImpactComment } from "./internal/createLighthouseImpactComment.js"
@@ -7,6 +8,8 @@ import { createLighthouseImpactComment } from "./internal/createLighthouseImpact
 export const reportLighthouseImpact = async ({
   logLevel,
   commandLogs = false,
+  // TODO: update { cancellationToken, cancelOnSIGINT } in "@jsenv/github-pull-request-impact"
+  // to use { signal, handleSIGINT } instead
   cancellationToken,
   cancelOnSIGINT,
   projectDirectoryUrl,
@@ -16,7 +19,7 @@ export const reportLighthouseImpact = async ({
   repositoryName,
   pullRequestNumber,
   installCommand = "npm install",
-  moduleGeneratingLighthouseReportRelativeUrl, // rename this
+  lighthouseReportPath,
 
   runLink,
   commitInGeneratedByInfo,
@@ -24,14 +27,14 @@ export const reportLighthouseImpact = async ({
   skipGistWarning = false,
 }) => {
   projectDirectoryUrl = assertAndNormalizeDirectoryUrl(projectDirectoryUrl)
-  if (typeof moduleGeneratingLighthouseReportRelativeUrl !== "string") {
+  if (typeof lighthouseReportPath !== "string") {
     throw new TypeError(
-      `moduleGeneratingLighthouseReportRelativeUrl must be a string but received ${moduleGeneratingLighthouseReportRelativeUrl}`,
+      `lighthouseReportPath must be a string but received ${lighthouseReportPath}`,
     )
   }
   projectDirectoryUrl = assertAndNormalizeDirectoryUrl(projectDirectoryUrl)
-  const moduleGeneratingLighthouseReportUrl = resolveUrl(
-    moduleGeneratingLighthouseReportRelativeUrl,
+  const lighthouseReportUrl = resolveUrl(
+    lighthouseReportPath,
     projectDirectoryUrl,
   )
 
@@ -51,19 +54,9 @@ export const reportLighthouseImpact = async ({
 
     collectInfo: async ({ execCommandInProjectDirectory }) => {
       await execCommandInProjectDirectory(installCommand)
-      await assertGenerateLighthouseReportFileExists(moduleGeneratingLighthouseReportUrl)
-
-      const { generateLighthouseReport } = await import(
-        `${moduleGeneratingLighthouseReportUrl}?cache_busting=${Date.now()}`
+      const lighthouseReport = await importOneExportFromFile(
+        lighthouseReportUrl,
       )
-      if (typeof generateLighthouseReport !== "function") {
-        throw new TypeError(
-          `generateLighthouseReport export must be a function, got ${generateLighthouseReport}`,
-        )
-      }
-
-      const lighthouseReport = await generateLighthouseReport()
-
       return { version: 1, data: lighthouseReport }
     },
     commentIdentifier: `<!-- Generated by @jsenv/lighthouse-impact -->`,
@@ -132,15 +125,3 @@ export const reportLighthouseImpact = async ({
     catchError,
   })
 }
-
-const assertGenerateLighthouseReportFileExists = async (fileUrl) => {
-  const fileStat = await readFileSystemNodeStat(fileUrl, {
-    nullIfNotFound: true,
-  })
-
-  if (!fileStat) {
-    throw new Error(
-      `Cannot find the file responsible to export generateLighthouseReport at ${fileUrl}`,
-    )
-  }
-}