@jsenv/core 41.5.35 → 41.5.38

package/dist/start_dev_server/start_dev_server.js

@@ -1,4 +1,5 @@
 import { WebSocketResponse, pickContentType, ServerEvents, serverPluginErrorHandler, fetchDirectory, composeTwoResponses, serverPluginCORS, jsenvAccessControlAllowedHeaders, startServer } from "@jsenv/server";
+import { randomUUID, X509Certificate } from "node:crypto";
 import { existsSync, statSync, readFileSync, realpathSync, readdirSync, lstatSync } from "node:fs";
 import { pathToFileURL } from "node:url";
 import { urlToRelativeUrl, registerFileLifecycle, lookupPackageDirectory, readPackageAtOrNull, generateContentFrame, errorToHTML, URL_META, asUrlWithoutSearch, DATA_URL, CONTENT_TYPE, normalizeImportMap, composeTwoImportMaps, resolveImport, createDetailedMessage, UNICODE, JS_QUOTES, urlToExtension, urlToBasename, applyNodeEsmResolution, readCustomConditionsFromProcessArgs, urlIsOrIsInsideOf, collectFiles, registerDirectoryLifecycle, readEntryStatSync, applyFileSystemMagicResolution, getExtensionsToTry, urlToFilename, ensurePathnameTrailingSlash, compareFileUrls, setUrlExtension, stringifyUrlSite, injectQueryParamsIntoSpecifier, isSpecifierForNodeBuiltin, injectQueryParams, urlToFileSystemPath, writeFileSync, moveUrl, ensureWindowsDriveLetter, validateResponseIntegrity, setUrlFilename, getCallerPosition, asSpecifierWithoutSearch, bufferToEtag, isFileSystemPath, urlToPathname, setUrlBasename, createLogger, normalizeUrl, ANSI, RUNTIME_COMPAT, formatError, assertAndNormalizeDirectoryUrl, browserDefaultRuntimeCompat, inferRuntimeCompatFromClosestPackage, createTaskLog } from "./jsenv_core_packages.js";
@@ -8,7 +9,6 @@ import { createMagicSource, composeTwoSourcemaps, generateSourcemapFileUrl, gene
 import { jsenvPluginSupervisor } from "@jsenv/plugin-supervisor";
 import { jsenvPluginTranspilation } from "@jsenv/plugin-transpilation";
 import { bundleJsModules } from "@jsenv/plugin-bundling";
-import { randomUUID } from "node:crypto";
 import { convertFileSystemErrorToResponseProperties } from "@jsenv/server/src/plugins/filesystem/filesystem_error_to_response.js";
 import "./jsenv_core_node_modules.js";
 import "node:process";
@@ -982,15 +982,15 @@ const runtimeFromRequest = (request) => {
 };
 
 const clientReporterFileUrl = new URL(
-  "../js/client_reporter.js",
+  "../client/client_monitoring/client_reporter.js",
   import.meta.url,
 ).href;
 const clientsPageFileUrl = new URL(
-  "../html/clients_page.html",
+  "../client/client_monitoring/clients_page.html",
   import.meta.url,
 ).href;
 const clientMonitorPageFileUrl = new URL(
-  "../html/client_monitor_page.html",
+  "../client/client_monitoring/client_monitor_page.html",
   import.meta.url,
 ).href;
 
@@ -1549,7 +1549,7 @@ const jsenvPluginClientMonitoring = () => {
  */
 
 
-const clientFileUrl$1 = new URL("../js/page_switcher.js", import.meta.url)
+const clientFileUrl$1 = new URL("../client/page_switcher/page_switcher.js", import.meta.url)
   .href;
 
 const jsenvPluginPageSwitcher = () => {
@@ -5136,7 +5136,7 @@ ${reason}`,
       return createFailedToFetchUrlContentError({
         code: "NOT_FOUND",
         reason: "no entry on filesystem",
-        ...detailsFromInjectionsOnOwner(urlInfo.firstReference),
+        ...detailsFromHtmlUrlNotFound(urlInfo.firstReference),
       });
     }
   }
@@ -5396,6 +5396,31 @@ const detailsFromInjectionsOnOwner = (reference) => {
   };
 };
 
+// An url of an html attribute leading to no file may be meant for a server rather
+// than for jsenv: a route of a backend, which "jsenv-ignore" leaves alone. Only the
+// build is concerned: in dev the browser requests the url whatever jsenv does with it.
+const detailsFromHtmlUrlNotFound = (reference) => {
+  const detailsFromInjections = detailsFromInjectionsOnOwner(reference);
+  if (detailsFromInjections.suggestion) {
+    return detailsFromInjections;
+  }
+  if (!reference) {
+    return {};
+  }
+  const ownerUrlInfo = reference.ownerUrlInfo;
+  if (ownerUrlInfo.type !== "html" || !ownerUrlInfo.context.build) {
+    return {};
+  }
+  const { node, attributeName } = reference.astInfo || {};
+  if (!node || !attributeName) {
+    return {};
+  }
+  return {
+    suggestion: `when "${reference.specifier}" is answered by a server rather than a file, add "jsenv-ignore" so the build leaves that url alone:
+<${node.nodeName} jsenv-ignore ${attributeName}="${reference.specifier}" />`,
+  };
+};
+
 const detailsFromPluginController = (jsenvPluginsController) => {
   const currentPlugin = jsenvPluginsController.getCurrentPlugin();
   if (!currentPlugin) {
@@ -7721,7 +7746,7 @@ const STATIC_IMPORT_SUBTYPES = ["import_static", "export_named", "export_all"];
  */
 
 
-const clientFileUrl = import.meta.resolve("../js/dependency_status.js");
+const clientFileUrl = import.meta.resolve("../client/dependency_status/dependency_status.js");
 
 const jsenvPluginDependencyStatus = ({
   dependencyProblemEventEmitter,
@@ -8602,6 +8627,99 @@ const devServerPluginChromeDevToolsJson = ({ sourceDirectoryUrl }) => {
   };
 };
 
+/*
+ * Lets another device (a phone) trust the root certificate that signs the dev
+ * server certificate, so it opens the dev server over https without a warning.
+ *
+ * Everything under HTTPS_TRUST_PATHNAME is served over plain http too (see the
+ * redirectHttpToHttps passed by startDevServer): it is the one page that must
+ * load before the certificate is trusted, over https it would show the very
+ * warning it exists to remove. Only the certificate is served, never its key.
+ *
+ * The page is sent as written, not cooked like the project pages: it needs
+ * nothing cooking injects, and a project plugin rewriting html must not be able
+ * to break the one page reached before trust.
+ *
+ * What it means for the device, and why the fingerprint must be compared with
+ * the terminal: docs/users/b_dev/b_dev.md, "Trusting it on a phone".
+ */
+
+
+const HTTPS_TRUST_PATHNAME = "/.internal/https/";
+
+const httpsTrustPageFileUrl = new URL(
+  "../client/https_trust/https_trust.html",
+  import.meta.url,
+);
+
+// rootCertificate is a node:crypto X509Certificate
+const devServerPluginHttpsTrust = ({ rootCertificate }) => {
+  const commonName = readCommonName(rootCertificate.subject);
+  const rootCertificateInfo = {
+    fingerprint256: rootCertificate.fingerprint256,
+    commonName,
+  };
+  // "https local root certificate" -> "https_local_root_certificate.crt"
+  const rootCertificateFilename = `${commonName.replace(/[^\w.-]+/g, "_")}.crt`;
+
+  return {
+    name: "jsenv:https_trust",
+    routes: [
+      {
+        endpoint: `GET ${HTTPS_TRUST_PATHNAME}`,
+        description:
+          "Page to trust the dev server https on another device (a phone). Served over http.",
+        declarationSource: import.meta.url,
+        fetch: () => {
+          return new Response(readFileSync(httpsTrustPageFileUrl), {
+            headers: { "content-type": "text/html" },
+          });
+        },
+      },
+      {
+        endpoint: `GET ${HTTPS_TRUST_PATHNAME}root.crt`,
+        description: "The root certificate signing the dev server certificate.",
+        declarationSource: import.meta.url,
+        fetch: () => {
+          return new Response(rootCertificate.toString(), {
+            headers: {
+              "content-type": "application/x-x509-ca-cert",
+              "content-disposition": `attachment; filename="${rootCertificateFilename}"`,
+            },
+          });
+        },
+      },
+      {
+        endpoint: `GET ${HTTPS_TRUST_PATHNAME}root.json`,
+        description: "Fingerprint and name of the root certificate.",
+        declarationSource: import.meta.url,
+        fetch: () => {
+          return Response.json(rootCertificateInfo);
+        },
+      },
+      {
+        endpoint: `GET ${HTTPS_TRUST_PATHNAME}ping`,
+        description:
+          "Fetched over https by the page: it fails as long as the device does not trust the certificate.",
+        declarationSource: import.meta.url,
+        fetch: () => {
+          return new Response(null, { status: 204 });
+        },
+      },
+    ],
+  };
+};
+
+// "CN=https local root certificate\nO=..." -> "https local root certificate"
+const readCommonName = (subject) => {
+  for (const line of subject.split("\n")) {
+    if (line.startsWith("CN=")) {
+      return line.slice("CN=".length);
+    }
+  }
+  return subject;
+};
+
 const devServerPluginInjectServerResponseHeader = ({
   sourceDirectoryUrl,
 }) => {
@@ -12527,7 +12645,7 @@ const EXECUTED_BY_TEST_PLAN = process.argv.includes("--jsenv-test");
  * @param {number} [params.port=3456] - Port to listen on (0 = a free port).
  * @param {string} [params.hostname] - Hostname to bind to.
  * @param {boolean} [params.acceptAnyIp=false] - Also accept connections on the machine's IPs (so other devices on the network — a phone — can reach the server). Off by default: exposing the dev server beyond localhost is an explicit choice, not something a dev tool decides.
- * @param {boolean|object} [params.https=false] - HTTPS as `{ certificate, privateKey }`.
+ * @param {object} [params.https] - HTTPS as `{ certificate, privateKey }` (PEM strings). With `rootCertificate` (the PEM of the authority that signed `certificate`) and `acceptAnyIp`, the dev server also serves `http://<ip>:<port>/.internal/https/`, a page to trust that authority on a phone (see docs/users/b_dev/b_dev.md, "Trusting it on a phone").
  * @param {boolean} [params.http2=false] - HTTP/2 (requires https).
  * @param {Array} [params.plugins=[]] - jsenv plugins (transformUrlContent, serverRoutes, serverEvents, effect, …).
  * @param {Array} [params.serverPlugins=[]] - `@jsenv/server`-level plugins.
@@ -12659,6 +12777,7 @@ const startDevServer = async ({
       );
     }
   }
+  let httpsTrust = null;
   // params normalization
   {
     if (runtimeCompat === undefined) {
@@ -12673,6 +12792,16 @@ const startDevServer = async ({
     if (clientAutoreload === false) {
       clientAutoreload = { enabled: false };
     }
+    if (https) {
+      const { certificate, privateKey, rootCertificate } = https;
+      https = { certificate, privateKey };
+      // a localhost-only server has no phone to serve
+      if (rootCertificate && acceptAnyIp) {
+        httpsTrust = {
+          rootCertificate: new X509Certificate(rootCertificate),
+        };
+      }
+    }
   }
 
   const logger = createLogger({ logLevel });
@@ -12830,6 +12959,7 @@ const startDevServer = async ({
     }),
     // chrome devtools
     devServerPluginChromeDevToolsJson({ sourceDirectoryUrl }),
+    ...(httpsTrust ? [devServerPluginHttpsTrust(httpsTrust)] : []),
     ...serverPlugins,
     devServerPluginServeSourceFiles({
       packageDirectory,
@@ -12868,6 +12998,12 @@ const startDevServer = async ({
     startLog: false,
 
     https,
+    ...(httpsTrust
+      ? {
+          redirectHttpToHttps: ({ resource }) =>
+            !resource.startsWith(HTTPS_TRUST_PATHNAME),
+        }
+      : {}),
     http2,
     acceptAnyIp,
     hostname,
@@ -12893,6 +13029,17 @@ const startDevServer = async ({
   logger.info(``);
   Object.keys(server.origins).forEach((key) => {
     logger.info(`- ${server.origins[key]}`);
+    if (httpsTrust && key === "externalip") {
+      const externalHostname = new URL(server.origins.externalip).hostname;
+      const httpsTrustPageUrl = new URL(
+        HTTPS_TRUST_PATHNAME,
+        `http://${externalHostname}:${server.port}`,
+      );
+      logger.info(`  trust it on a phone: ${httpsTrustPageUrl}`);
+      logger.info(
+        `  root certificate SHA-256: ${httpsTrust.rootCertificate.fingerprint256}`,
+      );
+    }
   });
   logger.info(``);
   return {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "41.5.35",
+  "version": "41.5.38",
   "type": "module",
   "description": "Tool to develop, test and build js projects",
   "repository": {
@@ -80,7 +80,7 @@
     "@jsenv/plugin-minification": "1.7.27",
     "@jsenv/plugin-supervisor": "1.8.29",
     "@jsenv/plugin-transpilation": "1.7.14",
-    "@jsenv/server": "17.6.8",
+    "@jsenv/server": "17.6.9",
     "@jsenv/sourcemap": "1.4.13",
     "react-table": "7.8.0"
   },

package/src/dev/dev_server_plugins/client/https_trust.html

@@ -0,0 +1,352 @@
+<!doctype html>
+<html lang="en">
+  <head>
+    <meta charset="utf-8" />
+    <meta name="viewport" content="width=device-width, initial-scale=1" />
+    <title>Trust the dev server https</title>
+    <style>
+      :root {
+        color-scheme: light dark;
+        --ink: #111827;
+        --muted: #6b7280;
+        --paper: #f3f4f6;
+        --card: #ffffff;
+        --line: #e5e7eb;
+        --accent: #2563eb;
+        --accent-ink: #ffffff;
+        --ok: #15803d;
+        --ok-paper: #dcfce7;
+        --warn: #b45309;
+        --warn-paper: #fef3c7;
+      }
+      @media (prefers-color-scheme: dark) {
+        :root {
+          --ink: #e5e7eb;
+          --muted: #9ca3af;
+          --paper: #0b1020;
+          --card: #111827;
+          --line: #1f2937;
+          --accent: #3b82f6;
+          --ok: #4ade80;
+          --ok-paper: #052e16;
+          --warn: #fbbf24;
+          --warn-paper: #2d1a02;
+        }
+      }
+      body {
+        margin: 0;
+        padding: 16px;
+        color: var(--ink);
+        font:
+          15px/1.5 -apple-system,
+          BlinkMacSystemFont,
+          "Segoe UI",
+          Roboto,
+          sans-serif;
+        background: var(--paper);
+      }
+      main {
+        display: flex;
+        max-width: 34rem;
+        margin: 0 auto;
+        flex-direction: column;
+        gap: 16px;
+      }
+      h1 {
+        margin: 8px 0 0;
+        font-size: 1.35rem;
+      }
+      h2 {
+        margin: 0;
+        font-size: 1rem;
+      }
+      p {
+        margin: 0;
+      }
+      ol {
+        margin: 0;
+        padding-left: 1.3em;
+      }
+      li + li {
+        margin-top: 6px;
+      }
+      code {
+        font:
+          0.85em ui-monospace,
+          SFMono-Regular,
+          Menlo,
+          monospace;
+      }
+      .muted {
+        color: var(--muted);
+      }
+      .card {
+        display: flex;
+        padding: 14px 16px;
+        flex-direction: column;
+        gap: 10px;
+        background: var(--card);
+        border: 1px solid var(--line);
+        border-radius: 10px;
+      }
+      .button {
+        display: block;
+        padding: 12px 16px;
+        color: var(--accent);
+        font-weight: 600;
+        text-align: center;
+        text-decoration: none;
+        border: 1px solid var(--accent);
+        border-radius: 8px;
+      }
+      .button[data-primary] {
+        color: var(--accent-ink);
+        background: var(--accent);
+      }
+      #status {
+        font-weight: 600;
+      }
+      #status_card[data-state="trusted"] {
+        background: var(--ok-paper);
+        border-color: var(--ok);
+      }
+      #status_card[data-state="trusted"] #status {
+        color: var(--ok);
+      }
+      #status_card[data-state="untrusted"] {
+        background: var(--warn-paper);
+        border-color: var(--warn);
+      }
+      #status_card[data-state="untrusted"] #status {
+        color: var(--warn);
+      }
+      #fingerprint {
+        display: block;
+        word-break: break-all;
+      }
+      details {
+        padding: 14px 16px;
+        background: var(--card);
+        border: 1px solid var(--line);
+        border-radius: 10px;
+      }
+      summary {
+        font-weight: 600;
+        cursor: pointer;
+      }
+      details[open] summary {
+        margin-bottom: 10px;
+      }
+      details .this_device {
+        display: none;
+        color: var(--muted);
+        font-weight: 400;
+      }
+      details[data-current] .this_device {
+        display: inline;
+      }
+      details p + ol,
+      details ol + p,
+      details p + p {
+        margin-top: 10px;
+      }
+    </style>
+  </head>
+  <body>
+    <main>
+      <h1>Trust the dev server https</h1>
+      <p class="muted">
+        Install the root certificate of the computer running the dev server and
+        this device opens it over https without a warning. Service workers,
+        push, install and the other secure-context APIs need it.
+      </p>
+
+      <div id="status_card" class="card" data-state="checking">
+        <p id="status">Checking whether this device trusts the dev server…</p>
+        <a id="continue" class="button" jsenv-ignore href="/">
+          Continue to https
+        </a>
+      </div>
+
+      <div class="card">
+        <a
+          id="download"
+          class="button"
+          jsenv-ignore
+          href="./root.crt"
+          data-primary
+        >
+          Download the root certificate
+        </a>
+        <p>
+          <span class="muted">SHA-256 fingerprint</span>
+          <code id="fingerprint">…</code>
+        </p>
+        <p class="muted">
+          Once installed, the fingerprint the device shows must match the one
+          the dev server prints in its terminal: this page travels over plain
+          http, so the network could swap the file.
+        </p>
+      </div>
+
+      <div id="platforms">
+        <details data-platform="android" open>
+          <summary>
+            Android <span class="this_device">(this device)</span>
+          </summary>
+          <ol>
+            <li>
+              Tap <b>Download the root certificate</b>. Opening the file only
+              says CA certificates must be installed from Settings: that is
+              expected.
+            </li>
+            <li>
+              In <b>Settings</b>, search for <b>CA certificate</b>. Or go to
+              Security → Encryption &amp; credentials → Install a certificate →
+              CA certificate.
+            </li>
+            <li>
+              Tap <b>Install anyway</b> and pick the file in Downloads. Android
+              asks for a screen lock if there is none.
+            </li>
+            <li>Come back here, the check above turns green.</li>
+          </ol>
+          <p class="muted">
+            Android then shows “Network may be monitored”: expected, the device
+            trusts a certificate installed by hand. Chrome honors it, most apps
+            do not.
+          </p>
+        </details>
+        <details data-platform="ios" open>
+          <summary>
+            iPhone, iPad <span class="this_device">(this device)</span>
+          </summary>
+          <ol>
+            <li>
+              Open this page in <b>Safari</b>, tap
+              <b>Download the root certificate</b>, then <b>Allow</b>.
+            </li>
+            <li>
+              In <b>Settings</b>, tap <b>Profile Downloaded</b> →
+              <b>Install</b>.
+            </li>
+            <li>
+              Then
+              <b>Settings → General → About → Certificate Trust Settings</b> and
+              turn on <b class="common_name">the root certificate</b>. Without
+              this step the certificate is installed but not trusted.
+            </li>
+            <li>Come back here, the check above turns green.</li>
+          </ol>
+        </details>
+        <details data-platform="desktop" open>
+          <summary>
+            Computer <span class="this_device">(this device)</span>
+          </summary>
+          <p>
+            On the computer running the dev server,
+            <code>npx @jsenv/https-local init</code> installs and trusts the
+            root certificate.
+          </p>
+          <p>
+            On another computer, download it and add it to the trusted root
+            certificates of the system. On macOS: open the file, then set it to
+            “Always Trust” in Keychain Access.
+          </p>
+        </details>
+      </div>
+
+      <details open>
+        <summary>Good to know</summary>
+        <p>
+          The device trusts anything signed by this root certificate. Its key
+          never leaves the computer running the dev server, only the certificate
+          is served: the trade-off already made on that computer.
+        </p>
+        <p>
+          <b>See the fingerprint, or remove it.</b> Android: Settings →
+          Encryption &amp; credentials → Trusted credentials → User → tap it.
+          iPhone, iPad: Settings → General → VPN &amp; Device Management → the
+          profile.
+        </p>
+      </details>
+    </main>
+
+    <script type="module">
+      const readPlatform = () => {
+        const userAgent = window.navigator.userAgent;
+        if (/android/i.test(userAgent)) {
+          return "android";
+        }
+        if (/iPhone|iPad|iPod/.test(userAgent)) {
+          return "ios";
+        }
+        // iPadOS Safari introduces itself as a Mac
+        if (
+          /Macintosh/.test(userAgent) &&
+          window.navigator.maxTouchPoints > 1
+        ) {
+          return "ios";
+        }
+        return "desktop";
+      };
+      const platform = readPlatform();
+      const platforms = document.querySelector("#platforms");
+      for (const details of platforms.querySelectorAll("[data-platform]")) {
+        if (details.getAttribute("data-platform") === platform) {
+          details.setAttribute("data-current", "");
+          platforms.prepend(details);
+        } else {
+          details.open = false;
+        }
+      }
+
+      // http and https share the port of the dev server
+      const port =
+        window.location.port ||
+        (window.location.protocol === "https:" ? "443" : "80");
+      const httpsOrigin = new URL(`https://${window.location.hostname}:${port}`)
+        .origin;
+      const continueLink = document.querySelector("#continue");
+      continueLink.href = `${httpsOrigin}/`;
+
+      const statusCard = document.querySelector("#status_card");
+      const status = document.querySelector("#status");
+      const download = document.querySelector("#download");
+      const checkTrust = async () => {
+        try {
+          // rejects as long as the certificate is not trusted, unless this
+          // browser clicked through the certificate warning for this host
+          await fetch(`${httpsOrigin}${window.location.pathname}ping`, {
+            mode: "no-cors",
+            cache: "no-store",
+          });
+        } catch {
+          statusCard.setAttribute("data-state", "untrusted");
+          status.textContent = "This device does not trust the dev server yet.";
+          continueLink.removeAttribute("data-primary");
+          download.setAttribute("data-primary", "");
+          return;
+        }
+        statusCard.setAttribute("data-state", "trusted");
+        status.textContent = "✓ This device trusts the dev server.";
+        continueLink.setAttribute("data-primary", "");
+        download.removeAttribute("data-primary");
+      };
+      checkTrust();
+      // back from the settings where the certificate was installed
+      document.addEventListener("visibilitychange", () => {
+        if (document.visibilityState === "visible") {
+          checkTrust();
+        }
+      });
+
+      const response = await fetch("./root.json");
+      const { fingerprint256, commonName } = await response.json();
+      document.querySelector("#fingerprint").textContent = fingerprint256;
+      for (const element of document.querySelectorAll(".common_name")) {
+        element.textContent = commonName;
+      }
+    </script>
+  </body>
+</html>