@jsenv/core 41.5.3 → 41.5.4

package/dist/build/build.js

@@ -6023,6 +6023,8 @@ const createNodeEsmResolver = ({
   packageDirectory,
   runtimeCompat,
   rootDirectoryUrl,
+  dev,
+  build,
   packageConditions = {},
   packageConditionsConfig,
   preservesSymlink,
@@ -6040,6 +6042,8 @@ const createNodeEsmResolver = ({
       packageConditionsConfig,
       rootDirectoryUrl,
       runtimeCompat,
+      dev,
+      build,
       preservesSymlink,
     },
   );
@@ -6201,6 +6205,8 @@ const createBuildPackageConditions = (
     packageConditionsConfig,
     rootDirectoryUrl,
     runtimeCompat,
+    dev,
+    build,
     preservesSymlink,
   },
 ) => {
@@ -6290,8 +6296,19 @@ const createBuildPackageConditions = (
     };
 
     const conditionDefaultResolvers = {
+      // "dev:*" conditions target packages under active development: they
+      // apply to files resolved outside node_modules (sources, workspace
+      // symlinks), never to installed packages.
       "dev:*": devResolver,
-      "development": devResolver,
+      // "development"/"production" follow the ecosystem semantics
+      // (Vite, webpack): they describe how the app runs, not where the
+      // package lives, so they apply to every package, node_modules
+      // included. Dev server resolves "development"; build resolves
+      // "production", unless the build is dev-flavored
+      // (build({ entryPoints: { "./file.js": { dev: true } } }))
+      // in which case it resolves "development" too.
+      "development": Boolean(dev),
+      "production": Boolean(build) && !dev,
       "node": nodeRuntimeEnabled,
       "browser": !nodeRuntimeEnabled,
       "import": true,
@@ -6505,6 +6522,7 @@ const jsenvPluginNodeEsmResolution = ({
   resolutionConfig = {},
   packageConditions,
   packageConditionsConfig = {},
+  dev,
 }) => {
   let nodeEsmResolverDefault;
   const resolverMap = new Map();
@@ -6526,6 +6544,8 @@ const jsenvPluginNodeEsmResolution = ({
       packageDirectory,
       runtimeCompat: kitchenContext.runtimeCompat,
       rootDirectoryUrl: kitchenContext.rootDirectoryUrl,
+      dev: dev === undefined ? kitchenContext.dev : dev,
+      build: kitchenContext.build,
       packageConditions,
       packageConditionsConfig: {
         ...kitchenContext.packageConditionsConfig,
@@ -6543,6 +6563,8 @@ const jsenvPluginNodeEsmResolution = ({
         packageDirectory,
         runtimeCompat: kitchenContext.runtimeCompat,
         rootDirectoryUrl: kitchenContext.rootDirectoryUrl,
+        dev: dev === undefined ? kitchenContext.dev : dev,
+        build: kitchenContext.build,
         // preservesSymlink: true,
         packageConditions,
         packageConditionsConfig: {
@@ -8189,11 +8211,16 @@ const babelPluginMetadataExpressionPaths = (
  * - left as is to be evaluated to undefined (import.meta.build but it's the dev server)
  * - replaced by undefined (import.meta.dev but it's build; the goal is to ensure it's tree-shaked)
  *
+ * A build can also be dev-flavored (build({ entryPoints: { "./file.js": { dev: true } } })):
+ * import.meta.dev is then replaced by true, so a package can publish a build
+ * that keeps its dev-only code, exposed to consumers via the "development"
+ * package export condition.
+ *
  * TODO: ideally during dev we would keep import.meta.dev and ensure we set it to true rather than replacing it with true?
  */
 
 
-const jsenvPluginImportMetaScenarios = () => {
+const jsenvPluginImportMetaScenarios = ({ dev } = {}) => {
   return {
     name: "jsenv:import_meta_scenario",
     appliesDuring: "*",
@@ -8223,17 +8250,19 @@ const jsenvPluginImportMetaScenarios = () => {
             }
           },
         });
-        const { dev, build } = importMetaScenarioNodes;
+        const devNodes = importMetaScenarioNodes.dev;
+        const buildNodes = importMetaScenarioNodes.build;
         const replacements = [];
         const replace = (node, value) => {
           replacements.push({ node, value });
         };
         if (urlInfo.context.build) {
           // during build ensure replacement for tree-shaking
-          dev.forEach((node) => {
-            replace(node, "undefined");
+          // (or for keeping dev code when the build is dev-flavored)
+          devNodes.forEach((node) => {
+            replace(node, dev ? "true" : "undefined");
           });
-          build.forEach((node) => {
+          buildNodes.forEach((node) => {
             replace(node, "true");
           });
         } else {
@@ -8241,7 +8270,7 @@ const jsenvPluginImportMetaScenarios = () => {
           // it will be evaluated to undefined.
           // Moreover it can be surprising to see some "undefined"
           // when source file contains "import.meta.build"
-          dev.forEach((node) => {
+          devNodes.forEach((node) => {
             replace(node, "true");
           });
         }
@@ -10119,6 +10148,9 @@ const getCorePlugins = ({
   runtimeCompat,
   packageDirectory,
   sourceFilesConfig,
+  // during build, a dev-flavored entry point sets dev: true
+  // (during dev the kitchen context already says so, no need to pass it)
+  dev,
 
   referenceAnalysis = {},
   nodeEsmResolution = {},
@@ -10215,6 +10247,7 @@ const getCorePlugins = ({
             resolutionConfig: nodeEsmResolution,
             packageConditions,
             packageConditionsConfig,
+            dev,
           }),
         ]
       : []),
@@ -10232,7 +10265,7 @@ const getCorePlugins = ({
 
     jsenvPluginImportMetaCss(),
     jsenvPluginCommonJsGlobals(),
-    jsenvPluginImportMetaScenarios(),
+    jsenvPluginImportMetaScenarios({ dev }),
     ...(scenarioPlaceholders ? [jsenvPluginGlobalScenarios()] : []),
     jsenvPluginNodeRuntime({ runtimeCompat }),
 
@@ -12413,6 +12446,12 @@ const jsenvPluginMappings = (mappings) => {
  *        Relative URL where this entry point will be written in the build directory
  * @param {object} [entryPoint.runtimeCompat]
  *        Runtime compatibility configuration for this entry point
+ * @param {boolean} [entryPoint.dev=false]
+ *        Produce a dev-flavored build: import.meta.dev is replaced by true
+ *        (instead of undefined) and dependencies resolve their "development"
+ *        package export condition (instead of "production"). Meant for packages
+ *        publishing two flavors, the dev one exposed to consumers via the
+ *        "development" condition in their package.json "exports"
  * @param {string} [entryPoint.assetsDirectory]
  *        Directory where asset files will be written for this entry point
  * @param {string|url} [entryPoint.base]
@@ -12536,12 +12575,10 @@ entryPoints: {
         let runtimeType;
         {
           if (isBareSpecifier(key)) {
-            const packageConditions = [
-              "development",
-              "dev:*",
-              "node",
-              "import",
-            ];
+            // "development" is not resolved here on purpose: it points at a
+            // package's dev-flavored dist, which is not a build input;
+            // "dev:*" points at sources, which are.
+            const packageConditions = ["dev:*", "node", "import"];
             try {
               const { url, type } = applyNodeEsmResolution({
                 conditions: packageConditions,
@@ -13273,6 +13310,7 @@ entryPoints: {
 const entryPointDefaultParams = {
   buildRelativeUrl: undefined,
   mode: undefined,
+  dev: false,
   runtimeCompat: undefined,
   plugins: [],
   mappings: undefined,
@@ -13328,6 +13366,7 @@ const prepareEntryPointBuild = async (
   let {
     buildRelativeUrl,
     mode,
+    dev,
     runtimeCompat,
     plugins,
     mappings,
@@ -13508,6 +13547,7 @@ const prepareEntryPointBuild = async (
       packageDirectory,
       rootDirectoryUrl: sourceDirectoryUrl,
       runtimeCompat,
+      dev,
       referenceAnalysis,
       nodeEsmResolution,
       packageConditions,

package/dist/start_dev_server/start_dev_server.js

@@ -2689,6 +2689,8 @@ const createNodeEsmResolver = ({
   packageDirectory,
   runtimeCompat,
   rootDirectoryUrl,
+  dev,
+  build,
   packageConditions = {},
   packageConditionsConfig,
   preservesSymlink,
@@ -2706,6 +2708,8 @@ const createNodeEsmResolver = ({
       packageConditionsConfig,
       rootDirectoryUrl,
       runtimeCompat,
+      dev,
+      build,
       preservesSymlink,
     },
   );
@@ -2867,6 +2871,8 @@ const createBuildPackageConditions = (
     packageConditionsConfig,
     rootDirectoryUrl,
     runtimeCompat,
+    dev,
+    build,
     preservesSymlink,
   },
 ) => {
@@ -2956,8 +2962,19 @@ const createBuildPackageConditions = (
     };
 
     const conditionDefaultResolvers = {
+      // "dev:*" conditions target packages under active development: they
+      // apply to files resolved outside node_modules (sources, workspace
+      // symlinks), never to installed packages.
       "dev:*": devResolver,
-      "development": devResolver,
+      // "development"/"production" follow the ecosystem semantics
+      // (Vite, webpack): they describe how the app runs, not where the
+      // package lives, so they apply to every package, node_modules
+      // included. Dev server resolves "development"; build resolves
+      // "production", unless the build is dev-flavored
+      // (build({ entryPoints: { "./file.js": { dev: true } } }))
+      // in which case it resolves "development" too.
+      "development": Boolean(dev),
+      "production": Boolean(build) && !dev,
       "node": nodeRuntimeEnabled,
       "browser": !nodeRuntimeEnabled,
       "import": true,
@@ -3171,6 +3188,7 @@ const jsenvPluginNodeEsmResolution = ({
   resolutionConfig = {},
   packageConditions,
   packageConditionsConfig = {},
+  dev,
 }) => {
   let nodeEsmResolverDefault;
   const resolverMap = new Map();
@@ -3192,6 +3210,8 @@ const jsenvPluginNodeEsmResolution = ({
       packageDirectory,
       runtimeCompat: kitchenContext.runtimeCompat,
       rootDirectoryUrl: kitchenContext.rootDirectoryUrl,
+      dev: dev === undefined ? kitchenContext.dev : dev,
+      build: kitchenContext.build,
       packageConditions,
       packageConditionsConfig: {
         ...kitchenContext.packageConditionsConfig,
@@ -3209,6 +3229,8 @@ const jsenvPluginNodeEsmResolution = ({
         packageDirectory,
         runtimeCompat: kitchenContext.runtimeCompat,
         rootDirectoryUrl: kitchenContext.rootDirectoryUrl,
+        dev: dev === undefined ? kitchenContext.dev : dev,
+        build: kitchenContext.build,
         // preservesSymlink: true,
         packageConditions,
         packageConditionsConfig: {
@@ -5994,11 +6016,16 @@ const babelPluginMetadataExpressionPaths = (
  * - left as is to be evaluated to undefined (import.meta.build but it's the dev server)
  * - replaced by undefined (import.meta.dev but it's build; the goal is to ensure it's tree-shaked)
  *
+ * A build can also be dev-flavored (build({ entryPoints: { "./file.js": { dev: true } } })):
+ * import.meta.dev is then replaced by true, so a package can publish a build
+ * that keeps its dev-only code, exposed to consumers via the "development"
+ * package export condition.
+ *
  * TODO: ideally during dev we would keep import.meta.dev and ensure we set it to true rather than replacing it with true?
  */
 
 
-const jsenvPluginImportMetaScenarios = () => {
+const jsenvPluginImportMetaScenarios = ({ dev } = {}) => {
   return {
     name: "jsenv:import_meta_scenario",
     appliesDuring: "*",
@@ -6028,17 +6055,19 @@ const jsenvPluginImportMetaScenarios = () => {
             }
           },
         });
-        const { dev, build } = importMetaScenarioNodes;
+        const devNodes = importMetaScenarioNodes.dev;
+        const buildNodes = importMetaScenarioNodes.build;
         const replacements = [];
         const replace = (node, value) => {
           replacements.push({ node, value });
         };
         if (urlInfo.context.build) {
           // during build ensure replacement for tree-shaking
-          dev.forEach((node) => {
-            replace(node, "undefined");
+          // (or for keeping dev code when the build is dev-flavored)
+          devNodes.forEach((node) => {
+            replace(node, dev ? "true" : "undefined");
           });
-          build.forEach((node) => {
+          buildNodes.forEach((node) => {
             replace(node, "true");
           });
         } else {
@@ -6046,7 +6075,7 @@ const jsenvPluginImportMetaScenarios = () => {
           // it will be evaluated to undefined.
           // Moreover it can be surprising to see some "undefined"
           // when source file contains "import.meta.build"
-          dev.forEach((node) => {
+          devNodes.forEach((node) => {
             replace(node, "true");
           });
         }
@@ -7984,6 +8013,9 @@ const getCorePlugins = ({
   runtimeCompat,
   packageDirectory,
   sourceFilesConfig,
+  // during build, a dev-flavored entry point sets dev: true
+  // (during dev the kitchen context already says so, no need to pass it)
+  dev,
 
   referenceAnalysis = {},
   nodeEsmResolution = {},
@@ -8080,6 +8112,7 @@ const getCorePlugins = ({
             resolutionConfig: nodeEsmResolution,
             packageConditions,
             packageConditionsConfig,
+            dev,
           }),
         ]
       : []),
@@ -8097,7 +8130,7 @@ const getCorePlugins = ({
 
     jsenvPluginImportMetaCss(),
     jsenvPluginCommonJsGlobals(),
-    jsenvPluginImportMetaScenarios(),
+    jsenvPluginImportMetaScenarios({ dev }),
     ...(scenarioPlaceholders ? [jsenvPluginGlobalScenarios()] : []),
     jsenvPluginNodeRuntime({ runtimeCompat }),
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "41.5.3",
+  "version": "41.5.4",
   "type": "module",
   "description": "Tool to develop, test and build js projects",
   "repository": {

package/src/build/build.js

@@ -117,6 +117,12 @@ import { jsenvPluginMappings } from "./jsenv_plugin_mappings.js";
  *        Relative URL where this entry point will be written in the build directory
  * @param {object} [entryPoint.runtimeCompat]
  *        Runtime compatibility configuration for this entry point
+ * @param {boolean} [entryPoint.dev=false]
+ *        Produce a dev-flavored build: import.meta.dev is replaced by true
+ *        (instead of undefined) and dependencies resolve their "development"
+ *        package export condition (instead of "production"). Meant for packages
+ *        publishing two flavors, the dev one exposed to consumers via the
+ *        "development" condition in their package.json "exports"
  * @param {string} [entryPoint.assetsDirectory]
  *        Directory where asset files will be written for this entry point
  * @param {string|url} [entryPoint.base]
@@ -240,12 +246,10 @@ entryPoints: {
         let runtimeType;
         {
           if (isBareSpecifier(key)) {
-            const packageConditions = [
-              "development",
-              "dev:*",
-              "node",
-              "import",
-            ];
+            // "development" is not resolved here on purpose: it points at a
+            // package's dev-flavored dist, which is not a build input;
+            // "dev:*" points at sources, which are.
+            const packageConditions = ["dev:*", "node", "import"];
             try {
               const { url, type } = applyNodeEsmResolution({
                 conditions: packageConditions,
@@ -979,6 +983,7 @@ entryPoints: {
 const entryPointDefaultParams = {
   buildRelativeUrl: undefined,
   mode: undefined,
+  dev: false,
   runtimeCompat: undefined,
   plugins: [],
   mappings: undefined,
@@ -1034,6 +1039,7 @@ const prepareEntryPointBuild = async (
   let {
     buildRelativeUrl,
     mode,
+    dev,
     runtimeCompat,
     plugins,
     mappings,
@@ -1214,6 +1220,7 @@ const prepareEntryPointBuild = async (
       packageDirectory,
       rootDirectoryUrl: sourceDirectoryUrl,
       runtimeCompat,
+      dev,
       referenceAnalysis,
       nodeEsmResolution,
       packageConditions,

package/src/plugins/import_meta_scenarios/jsenv_plugin_import_meta_scenarios.js

@@ -7,13 +7,18 @@
  * - left as is to be evaluated to undefined (import.meta.build but it's the dev server)
  * - replaced by undefined (import.meta.dev but it's build; the goal is to ensure it's tree-shaked)
  *
+ * A build can also be dev-flavored (build({ entryPoints: { "./file.js": { dev: true } } })):
+ * import.meta.dev is then replaced by true, so a package can publish a build
+ * that keeps its dev-only code, exposed to consumers via the "development"
+ * package export condition.
+ *
  * TODO: ideally during dev we would keep import.meta.dev and ensure we set it to true rather than replacing it with true?
  */
 
 import { getImportMetaPropertyName, visitJsAst } from "@jsenv/ast";
 import { createMagicSource } from "@jsenv/sourcemap";
 
-export const jsenvPluginImportMetaScenarios = () => {
+export const jsenvPluginImportMetaScenarios = ({ dev } = {}) => {
   return {
     name: "jsenv:import_meta_scenario",
     appliesDuring: "*",
@@ -43,17 +48,19 @@ export const jsenvPluginImportMetaScenarios = () => {
             }
           },
         });
-        const { dev, build } = importMetaScenarioNodes;
+        const devNodes = importMetaScenarioNodes.dev;
+        const buildNodes = importMetaScenarioNodes.build;
         const replacements = [];
         const replace = (node, value) => {
           replacements.push({ node, value });
         };
         if (urlInfo.context.build) {
           // during build ensure replacement for tree-shaking
-          dev.forEach((node) => {
-            replace(node, "undefined");
+          // (or for keeping dev code when the build is dev-flavored)
+          devNodes.forEach((node) => {
+            replace(node, dev ? "true" : "undefined");
           });
-          build.forEach((node) => {
+          buildNodes.forEach((node) => {
             replace(node, "true");
           });
         } else {
@@ -61,7 +68,7 @@ export const jsenvPluginImportMetaScenarios = () => {
           // it will be evaluated to undefined.
           // Moreover it can be surprising to see some "undefined"
           // when source file contains "import.meta.build"
-          dev.forEach((node) => {
+          devNodes.forEach((node) => {
             replace(node, "true");
           });
         }

package/src/plugins/plugins.js

@@ -38,6 +38,9 @@ export const getCorePlugins = ({
   runtimeCompat,
   packageDirectory,
   sourceFilesConfig,
+  // during build, a dev-flavored entry point sets dev: true
+  // (during dev the kitchen context already says so, no need to pass it)
+  dev,
 
   referenceAnalysis = {},
   nodeEsmResolution = {},
@@ -134,6 +137,7 @@ export const getCorePlugins = ({
             resolutionConfig: nodeEsmResolution,
             packageConditions,
             packageConditionsConfig,
+            dev,
           }),
         ]
       : []),
@@ -151,7 +155,7 @@ export const getCorePlugins = ({
 
     jsenvPluginImportMetaCss(),
     jsenvPluginCommonJsGlobals(),
-    jsenvPluginImportMetaScenarios(),
+    jsenvPluginImportMetaScenarios({ dev }),
     ...(scenarioPlaceholders ? [jsenvPluginGlobalScenarios()] : []),
     jsenvPluginNodeRuntime({ runtimeCompat }),
 

package/src/plugins/resolution_node_esm/jsenv_plugin_node_esm_resolution.js

@@ -5,6 +5,7 @@ export const jsenvPluginNodeEsmResolution = ({
   resolutionConfig = {},
   packageConditions,
   packageConditionsConfig = {},
+  dev,
 }) => {
   let nodeEsmResolverDefault;
   const resolverMap = new Map();
@@ -26,6 +27,8 @@ export const jsenvPluginNodeEsmResolution = ({
       packageDirectory,
       runtimeCompat: kitchenContext.runtimeCompat,
       rootDirectoryUrl: kitchenContext.rootDirectoryUrl,
+      dev: dev === undefined ? kitchenContext.dev : dev,
+      build: kitchenContext.build,
       packageConditions,
       packageConditionsConfig: {
         ...kitchenContext.packageConditionsConfig,
@@ -43,6 +46,8 @@ export const jsenvPluginNodeEsmResolution = ({
         packageDirectory,
         runtimeCompat: kitchenContext.runtimeCompat,
         rootDirectoryUrl: kitchenContext.rootDirectoryUrl,
+        dev: dev === undefined ? kitchenContext.dev : dev,
+        build: kitchenContext.build,
         // preservesSymlink: true,
         packageConditions,
         packageConditionsConfig: {

package/src/plugins/resolution_node_esm/node_esm_resolver.js

@@ -20,6 +20,8 @@ export const createNodeEsmResolver = ({
   packageDirectory,
   runtimeCompat,
   rootDirectoryUrl,
+  dev,
+  build,
   packageConditions = {},
   packageConditionsConfig,
   preservesSymlink,
@@ -37,6 +39,8 @@ export const createNodeEsmResolver = ({
       packageConditionsConfig,
       rootDirectoryUrl,
       runtimeCompat,
+      dev,
+      build,
       preservesSymlink,
     },
   );
@@ -198,6 +202,8 @@ const createBuildPackageConditions = (
     packageConditionsConfig,
     rootDirectoryUrl,
     runtimeCompat,
+    dev,
+    build,
     preservesSymlink,
   },
 ) => {
@@ -287,8 +293,19 @@ const createBuildPackageConditions = (
     };
 
     const conditionDefaultResolvers = {
+      // "dev:*" conditions target packages under active development: they
+      // apply to files resolved outside node_modules (sources, workspace
+      // symlinks), never to installed packages.
       "dev:*": devResolver,
-      "development": devResolver,
+      // "development"/"production" follow the ecosystem semantics
+      // (Vite, webpack): they describe how the app runs, not where the
+      // package lives, so they apply to every package, node_modules
+      // included. Dev server resolves "development"; build resolves
+      // "production", unless the build is dev-flavored
+      // (build({ entryPoints: { "./file.js": { dev: true } } }))
+      // in which case it resolves "development" too.
+      "development": Boolean(dev),
+      "production": Boolean(build) && !dev,
       "node": nodeRuntimeEnabled,
       "browser": !nodeRuntimeEnabled,
       "import": true,