@jsenv/core 41.5.22 → 41.5.24

package/dist/build/build.js

@@ -10128,17 +10128,16 @@ const jsenvPluginAutoreloadOnServerRestart = () => {
   };
 };
 
-/**
- * Lorsqu'on bundle un package ayant pas le field sideEffects
- * alors on fini potentiellement par dire
- * sideEffect: false
- * sur le package racine alors qu'on en sait rien
- * on pourrait mettre un package.json dans dist dans ce cas
- * qui ne déclare pas le field side effect afin
- * d'override le package.json du project qui lui dit qu'il ny en a pas
- *
- * On part du principe pour le moment que c'est la respo du package racine de déclarer cela
+/*
+ * Tells the bundler which modules may be dropped when nothing imports a value
+ * from them, from the "sideEffects" field of the package.json closest to each
+ * file — a dependency's own declaration for its files, the project's for its
+ * own. A package that declares nothing keeps every module (the bundler's own
+ * default), so an undeclared root only loses precision, never code.
  *
+ * Whether the project's package.json is written back with the side-effect
+ * files this build produced is decided in build.js, and only for a project that
+ * already declares the field; it is not this plugin's concern.
  */
 
 
@@ -10146,15 +10145,6 @@ const jsenvPluginPackageSideEffects = ({ packageDirectory }) => {
   if (!packageDirectory.url) {
     return [];
   }
-  const packageJson = packageDirectory.read(packageDirectory.url);
-  if (!packageJson) {
-    return [];
-  }
-  const { sideEffects } = packageJson;
-  if (sideEffects !== false && !Array.isArray(sideEffects)) {
-    return [];
-  }
-
   const packageSideEffectsCacheMap = new Map();
   const readSideEffectInfoFromClosestPackage = (urlInfo) => {
     const closestPackageDirectoryUrl = urlInfo.packageDirectoryUrl;

package/dist/start_dev_server/start_dev_server.js

@@ -8028,17 +8028,16 @@ const jsenvPluginAutoreloadOnServerRestart = () => {
   };
 };
 
-/**
- * Lorsqu'on bundle un package ayant pas le field sideEffects
- * alors on fini potentiellement par dire
- * sideEffect: false
- * sur le package racine alors qu'on en sait rien
- * on pourrait mettre un package.json dans dist dans ce cas
- * qui ne déclare pas le field side effect afin
- * d'override le package.json du project qui lui dit qu'il ny en a pas
- *
- * On part du principe pour le moment que c'est la respo du package racine de déclarer cela
+/*
+ * Tells the bundler which modules may be dropped when nothing imports a value
+ * from them, from the "sideEffects" field of the package.json closest to each
+ * file — a dependency's own declaration for its files, the project's for its
+ * own. A package that declares nothing keeps every module (the bundler's own
+ * default), so an undeclared root only loses precision, never code.
  *
+ * Whether the project's package.json is written back with the side-effect
+ * files this build produced is decided in build.js, and only for a project that
+ * already declares the field; it is not this plugin's concern.
  */
 
 
@@ -8046,15 +8045,6 @@ const jsenvPluginPackageSideEffects = ({ packageDirectory }) => {
   if (!packageDirectory.url) {
     return [];
   }
-  const packageJson = packageDirectory.read(packageDirectory.url);
-  if (!packageJson) {
-    return [];
-  }
-  const { sideEffects } = packageJson;
-  if (sideEffects !== false && !Array.isArray(sideEffects)) {
-    return [];
-  }
-
   const packageSideEffectsCacheMap = new Map();
   const readSideEffectInfoFromClosestPackage = (urlInfo) => {
     const closestPackageDirectoryUrl = urlInfo.packageDirectoryUrl;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "41.5.22",
+  "version": "41.5.24",
   "type": "module",
   "description": "Tool to develop, test and build js projects",
   "repository": {
@@ -79,7 +79,7 @@
     "@jsenv/plugin-minification": "1.7.22",
     "@jsenv/plugin-supervisor": "1.8.24",
     "@jsenv/plugin-transpilation": "1.7.9",
-    "@jsenv/server": "17.6.5",
+    "@jsenv/server": "17.6.6",
     "@jsenv/sourcemap": "1.4.9",
     "react-table": "7.8.0"
   },

package/src/plugins/package_side_effects/jsenv_plugin_package_side_effects.js

@@ -1,14 +1,13 @@
-/**
- * Lorsqu'on bundle un package ayant pas le field sideEffects
- * alors on fini potentiellement par dire
- * sideEffect: false
- * sur le package racine alors qu'on en sait rien
- * on pourrait mettre un package.json dans dist dans ce cas
- * qui ne déclare pas le field side effect afin
- * d'override le package.json du project qui lui dit qu'il ny en a pas
- *
- * On part du principe pour le moment que c'est la respo du package racine de déclarer cela
+/*
+ * Tells the bundler which modules may be dropped when nothing imports a value
+ * from them, from the "sideEffects" field of the package.json closest to each
+ * file — a dependency's own declaration for its files, the project's for its
+ * own. A package that declares nothing keeps every module (the bundler's own
+ * default), so an undeclared root only loses precision, never code.
  *
+ * Whether the project's package.json is written back with the side-effect
+ * files this build produced is decided in build.js, and only for a project that
+ * already declares the field; it is not this plugin's concern.
  */
 
 import { isSpecifierForNodeBuiltin } from "@jsenv/node-esm-resolution/src/node_builtin_specifiers.js";
@@ -18,15 +17,6 @@ export const jsenvPluginPackageSideEffects = ({ packageDirectory }) => {
   if (!packageDirectory.url) {
     return [];
   }
-  const packageJson = packageDirectory.read(packageDirectory.url);
-  if (!packageJson) {
-    return [];
-  }
-  const { sideEffects } = packageJson;
-  if (sideEffects !== false && !Array.isArray(sideEffects)) {
-    return [];
-  }
-
   const packageSideEffectsCacheMap = new Map();
   const readSideEffectInfoFromClosestPackage = (urlInfo) => {
     const closestPackageDirectoryUrl = urlInfo.packageDirectoryUrl;