@jsenv/core 41.5.14 → 41.5.16

package/dist/build/build.js

@@ -2131,6 +2131,10 @@ const createUrlInfo = (url, context) => {
     modifiedTimestamp: 0,
     descendantModifiedTimestamp: 0,
     dereferencedTimestamp: 0,
+    // when a client last fetched this url outside a hot request; in other
+    // words the last time this url entered a fresh page (see
+    // jsenv_plugin_hot_search_param)
+    servedWithoutHotTimestamp: 0,
     originalContentEtag: null,
     contentEtag: null,
     isValid: () => false,
@@ -9445,6 +9449,7 @@ const jsenvPluginHotSearchParam = () => {
         modifiedTimestamp,
         descendantModifiedTimestamp,
         dereferencedTimestamp,
+        servedWithoutHotTimestamp,
       } = referencedUrlInfo;
       if (
         !modifiedTimestamp &&
@@ -9468,6 +9473,18 @@ const jsenvPluginHotSearchParam = () => {
         descendantModifiedTimestamp,
         dereferencedTimestamp,
       );
+      // These timestamps say "this url changed at some point", not "the client
+      // is running an outdated version of it": they are never cleared, so a
+      // file modified once keeps them for the rest of the dev server's life.
+      // A client that fetched this url after that modification (a page load:
+      // see rememberServedWithoutHot in the dev server) already runs the
+      // latest content. Sending it "?hot" then makes the browser evaluate a
+      // second, identical copy of a module it already has — a second module
+      // scope for a file that never changed, which breaks everything a module
+      // holds once (registries, contexts, singletons).
+      if (latestTimestamp <= servedWithoutHotTimestamp) {
+        return null;
+      }
       return {
         hot: latestTimestamp,
       };
@@ -12193,8 +12210,16 @@ const createBuildUrlsGenerator = ({
     // THAT bundle). They are told apart by the entry point they come from —
     // sharing the file would leave one entry importing exports the file on disk
     // does not have.
+    //
+    // A source file is shared between entry points only while they write it to
+    // the same assets directory. Two entry points with their own directory each
+    // get their own copy: the file lands where the entry point that references
+    // it lands, so removing one entry point's directory takes nothing away from
+    // another.
     const insideBuildDirectory = urlIsOrIsInsideOf(url, buildDirectoryUrl);
-    const key = insideBuildDirectory ? `${entryKey} ${url}` : url;
+    const key = insideBuildDirectory
+      ? `${entryKey} ${url}`
+      : `${assetsDirectory} ${url}`;
     const buildUrlFromMap = buildUrlMap.get(key);
     if (buildUrlFromMap) {
       return buildUrlFromMap;
@@ -12226,7 +12251,7 @@ const createBuildUrlsGenerator = ({
     }
     if (urlInfo.type === "entry_build") {
       const buildUrl = new URL(urlInfo.filenameHint, buildDirectoryUrl).href;
-      associateBuildUrl(url, buildUrl);
+      associateBuildUrl(key, buildUrl);
       return buildUrl;
     }
     if (
@@ -12244,7 +12269,7 @@ const createBuildUrlsGenerator = ({
       const urlObject = new URL(url);
       const { search } = urlObject;
       const buildUrl = `${buildDirectoryUrl}${directoryPath}${search}`;
-      associateBuildUrl(url, buildUrl);
+      associateBuildUrl(key, buildUrl);
       return buildUrl;
     }
 
@@ -12259,7 +12284,7 @@ const createBuildUrlsGenerator = ({
     let { search, hash } = urlObject;
     const name = reserveName(directoryPath, getUrlName(url, urlInfo));
     const buildUrl = `${buildDirectoryUrl}${directoryPath}${name}${search}${hash}`;
-    associateBuildUrl(url, buildUrl);
+    associateBuildUrl(key, buildUrl);
     return buildUrl;
   };
 

package/dist/start_dev_server/start_dev_server.js

@@ -7170,6 +7170,7 @@ const jsenvPluginHotSearchParam = () => {
         modifiedTimestamp,
         descendantModifiedTimestamp,
         dereferencedTimestamp,
+        servedWithoutHotTimestamp,
       } = referencedUrlInfo;
       if (
         !modifiedTimestamp &&
@@ -7193,6 +7194,18 @@ const jsenvPluginHotSearchParam = () => {
         descendantModifiedTimestamp,
         dereferencedTimestamp,
       );
+      // These timestamps say "this url changed at some point", not "the client
+      // is running an outdated version of it": they are never cleared, so a
+      // file modified once keeps them for the rest of the dev server's life.
+      // A client that fetched this url after that modification (a page load:
+      // see rememberServedWithoutHot in the dev server) already runs the
+      // latest content. Sending it "?hot" then makes the browser evaluate a
+      // second, identical copy of a module it already has — a second module
+      // scope for a file that never changed, which breaks everything a module
+      // holds once (registries, contexts, singletons).
+      if (latestTimestamp <= servedWithoutHotTimestamp) {
+        return null;
+      }
       return {
         hot: latestTimestamp,
       };
@@ -9675,6 +9688,10 @@ const createUrlInfo = (url, context) => {
     modifiedTimestamp: 0,
     descendantModifiedTimestamp: 0,
     dereferencedTimestamp: 0,
+    // when a client last fetched this url outside a hot request; in other
+    // words the last time this url entered a fresh page (see
+    // jsenv_plugin_hot_search_param)
+    servedWithoutHotTimestamp: 0,
     originalContentEtag: null,
     contentEtag: null,
     isValid: () => false,
@@ -11922,7 +11939,20 @@ const devServerPluginServeSourceFiles = ({
             );
             return response;
           };
+          // What the client holds for this url is what we last sent it: a
+          // request without "?hot" is a page loading this url into an empty
+          // module registry, so from here on the client runs this exact
+          // content. Remembering when that happened is what allows
+          // jsenv_plugin_hot_search_param to tell a modification the client
+          // has already received from one it must re-execute to see.
+          const rememberServedWithoutHot = () => {
+            if (request.searchParams.has("hot")) {
+              return;
+            }
+            urlInfo.servedWithoutHotTimestamp = Date.now();
+          };
           const respondWithNotModified = () => {
+            rememberServedWithoutHot();
             const headers = {
               "cache-control": `private,max-age=0,must-revalidate`,
             };
@@ -12007,6 +12037,9 @@ const devServerPluginServeSourceFiles = ({
             ) {
               return respondWithNotModified();
             }
+            if (urlInfo.status === 200) {
+              rememberServedWithoutHot();
+            }
             response = {
               url: reference.url,
               // a plugin can cook a complete response body for an url that is

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "41.5.14",
+  "version": "41.5.16",
   "type": "module",
   "description": "Tool to develop, test and build js projects",
   "repository": {
@@ -44,7 +44,7 @@
   "scripts": {
     "build": "node --conditions=dev:jsenv ./scripts/build/build.mjs",
     "build:file_size": "node ./scripts/build/build_file_size.mjs --log",
-    "build:packages": "npm run build --workspaces --if-present --conditions=developement",
+    "build:packages": "npm run build -- ./packages/",
     "database:install": "npx @jsenv/database install",
     "database:manage": "node --conditions=dev:jsenv ./packages/backend/database/src/cli/manage.js",
     "database:setup": "npm run database:setup --workspaces --if-present --conditions=dev:jsenv",

package/src/build/build_urls_generator.js

@@ -59,8 +59,16 @@ export const createBuildUrlsGenerator = ({
     // THAT bundle). They are told apart by the entry point they come from —
     // sharing the file would leave one entry importing exports the file on disk
     // does not have.
+    //
+    // A source file is shared between entry points only while they write it to
+    // the same assets directory. Two entry points with their own directory each
+    // get their own copy: the file lands where the entry point that references
+    // it lands, so removing one entry point's directory takes nothing away from
+    // another.
     const insideBuildDirectory = urlIsOrIsInsideOf(url, buildDirectoryUrl);
-    const key = insideBuildDirectory ? `${entryKey} ${url}` : url;
+    const key = insideBuildDirectory
+      ? `${entryKey} ${url}`
+      : `${assetsDirectory} ${url}`;
     const buildUrlFromMap = buildUrlMap.get(key);
     if (buildUrlFromMap) {
       return buildUrlFromMap;
@@ -92,7 +100,7 @@ export const createBuildUrlsGenerator = ({
     }
     if (urlInfo.type === "entry_build") {
       const buildUrl = new URL(urlInfo.filenameHint, buildDirectoryUrl).href;
-      associateBuildUrl(url, buildUrl);
+      associateBuildUrl(key, buildUrl);
       return buildUrl;
     }
     if (
@@ -110,7 +118,7 @@ export const createBuildUrlsGenerator = ({
       const urlObject = new URL(url);
       const { search } = urlObject;
       const buildUrl = `${buildDirectoryUrl}${directoryPath}${search}`;
-      associateBuildUrl(url, buildUrl);
+      associateBuildUrl(key, buildUrl);
       return buildUrl;
     }
 
@@ -125,7 +133,7 @@ export const createBuildUrlsGenerator = ({
     let { search, hash } = urlObject;
     const name = reserveName(directoryPath, getUrlName(url, urlInfo));
     const buildUrl = `${buildDirectoryUrl}${directoryPath}${name}${search}${hash}`;
-    associateBuildUrl(url, buildUrl);
+    associateBuildUrl(key, buildUrl);
     return buildUrl;
   };
 

package/src/dev/dev_server_plugins/dev_server_plugin_serve_source_files.js

@@ -387,7 +387,20 @@ export const devServerPluginServeSourceFiles = ({
             );
             return response;
           };
+          // What the client holds for this url is what we last sent it: a
+          // request without "?hot" is a page loading this url into an empty
+          // module registry, so from here on the client runs this exact
+          // content. Remembering when that happened is what allows
+          // jsenv_plugin_hot_search_param to tell a modification the client
+          // has already received from one it must re-execute to see.
+          const rememberServedWithoutHot = () => {
+            if (request.searchParams.has("hot")) {
+              return;
+            }
+            urlInfo.servedWithoutHotTimestamp = Date.now();
+          };
           const respondWithNotModified = () => {
+            rememberServedWithoutHot();
             const headers = {
               "cache-control": `private,max-age=0,must-revalidate`,
             };
@@ -472,6 +485,9 @@ export const devServerPluginServeSourceFiles = ({
             ) {
               return respondWithNotModified();
             }
+            if (urlInfo.status === 200) {
+              rememberServedWithoutHot();
+            }
             response = {
               url: reference.url,
               // a plugin can cook a complete response body for an url that is

package/src/kitchen/url_graph/url_graph.js

@@ -183,6 +183,10 @@ const createUrlInfo = (url, context) => {
     modifiedTimestamp: 0,
     descendantModifiedTimestamp: 0,
     dereferencedTimestamp: 0,
+    // when a client last fetched this url outside a hot request; in other
+    // words the last time this url entered a fresh page (see
+    // jsenv_plugin_hot_search_param)
+    servedWithoutHotTimestamp: 0,
     originalContentEtag: null,
     contentEtag: null,
     isValid: () => false,

package/src/plugins/autoreload/jsenv_plugin_hot_search_param.js

@@ -48,6 +48,7 @@ export const jsenvPluginHotSearchParam = () => {
         modifiedTimestamp,
         descendantModifiedTimestamp,
         dereferencedTimestamp,
+        servedWithoutHotTimestamp,
       } = referencedUrlInfo;
       if (
         !modifiedTimestamp &&
@@ -71,6 +72,18 @@ export const jsenvPluginHotSearchParam = () => {
         descendantModifiedTimestamp,
         dereferencedTimestamp,
       );
+      // These timestamps say "this url changed at some point", not "the client
+      // is running an outdated version of it": they are never cleared, so a
+      // file modified once keeps them for the rest of the dev server's life.
+      // A client that fetched this url after that modification (a page load:
+      // see rememberServedWithoutHot in the dev server) already runs the
+      // latest content. Sending it "?hot" then makes the browser evaluate a
+      // second, identical copy of a module it already has — a second module
+      // scope for a file that never changed, which breaks everything a module
+      // holds once (registries, contexts, singletons).
+      if (latestTimestamp <= servedWithoutHotTimestamp) {
+        return null;
+      }
       return {
         hot: latestTimestamp,
       };