@jsenv/core 41.4.25 → 41.4.27

package/dist/build/build.js

@@ -1,4 +1,4 @@
-import { parseHtml, injectHtmlNodeAsEarlyAsPossible, createHtmlNode, stringifyHtmlAst, applyBabelPlugins, generateUrlForInlineContent, injectJsenvScript, parseJsWithAcorn, visitHtmlNodes, analyzeScriptNode, getHtmlNodeText, getHtmlNodeAttribute, getHtmlNodePosition, getUrlForContentInsideHtml, setHtmlNodeAttributes, setHtmlNodeText, parseCssUrls, getHtmlNodeAttributePosition, parseSrcSet, removeHtmlNodeText, parseJsUrls, getUrlForContentInsideJs, visitJsAst, getImportMetaPropertyName, visitJsAstUntil, analyzeLinkNode, findHtmlNode, removeHtmlNode, insertHtmlNodeAfter } from "@jsenv/ast";
+import { parseHtml, injectHtmlNodeAsEarlyAsPossible, createHtmlNode, stringifyHtmlAst, applyBabelPlugins, generateUrlForInlineContent, injectJsenvScript, parseJsWithAcorn, visitHtmlNodes, analyzeScriptNode, getHtmlNodeText, getHtmlNodeAttribute, getHtmlNodePosition, getUrlForContentInsideHtml, setHtmlNodeAttributes, setHtmlNodeText, parseCssUrls, getHtmlNodeAttributePosition, parseSrcSet, removeHtmlNodeText, parseJsUrls, getUrlForContentInsideJs, renderCssTemplateLiteral, visitJsAst, getImportMetaPropertyName, visitJsAstUntil, analyzeLinkNode, findHtmlNode, removeHtmlNode, insertHtmlNodeAfter } from "@jsenv/ast";
 import { bundleJsModules, jsenvPluginBundling } from "@jsenv/plugin-bundling";
 import { jsenvPluginMinification } from "@jsenv/plugin-minification";
 import { jsenvPluginTranspilation, jsenvPluginJsModuleFallback } from "@jsenv/plugin-transpilation";
@@ -5689,9 +5689,17 @@ const parseAndTransformJsReferences = async (
 
     sequentialActions.push(async () => {
       await inlineUrlInfo.cook();
-      const replacement = JS_QUOTES.escapeSpecialChars(inlineUrlInfo.content, {
-        quote,
-      });
+      const { substitutions } = inlineReferenceInfo;
+      const replacement = substitutions
+        ? // the expressions the template holds take their placeholder's place
+          // back; a template literal is written whatever the runtime supports,
+          // transpilation runs after and lowers it when it has to
+          renderCssTemplateLiteral(inlineUrlInfo.content, substitutions)
+        : JS_QUOTES.escapeSpecialChars(inlineUrlInfo.content, { quote });
+      if (replacement === null) {
+        // a placeholder did not survive: the source stays as it was written
+        return;
+      }
       magicSource.replace({
         start: inlineReferenceInfo.start,
         end: inlineReferenceInfo.end,
@@ -8314,6 +8322,12 @@ const jsenvPluginNodeRuntime = ({ runtimeCompat }) => {
  * import.meta.css = css;
  * ```
  *
+ * "jsenv:js_reference_analysis" reads the css assigned here as an inline css and
+ * sends it through the css pipeline: transpilation, url() resolution, minification,
+ * comments. A "${}" standing where a css value stands is swapped for a placeholder
+ * and put back afterwards; anywhere else it makes the template unreadable and the
+ * css is shipped exactly as written, with everything the pipeline does lost.
+ *
  */
 
 
@@ -8346,6 +8360,12 @@ const jsenvPluginImportMetaCss = () => {
           return null;
         }
         if (urlInfo.context.build) {
+          if (hasModuleScopeAssignment(urlInfo.contentAst)) {
+            urlInfo.contentSideEffects.push({
+              has: true,
+              reason: "import.meta.css assigned at module scope",
+            });
+          }
           const packageName = urlInfo.packageName;
           const packageDirectoryUrl =
             urlInfo.packageDirectoryUrl || urlInfo.context.rootDirectoryUrl;
@@ -8389,6 +8409,28 @@ const jsenvPluginImportMetaCss = () => {
   };
 };
 
+// A stylesheet assigned at module scope is adopted when the module runs: that
+// assignment IS the module's side effect. It has to be told, because a
+// package.json "sideEffects" list is authoritative once it exists — a module
+// it does not name is dropped whole when it is imported for nothing else, and
+// its css silently leaves the build.
+const hasModuleScopeAssignment = (ast) => {
+  for (const node of ast.body) {
+    if (node.type !== "ExpressionStatement") {
+      continue;
+    }
+    const { expression } = node;
+    if (
+      expression.type === "AssignmentExpression" &&
+      expression.operator === "=" &&
+      getImportMetaPropertyName(expression.left) === "css"
+    ) {
+      return true;
+    }
+  }
+  return false;
+};
+
 const babelPluginRewriteImportMetaCssAssignment = (
   { types: t },
   { relativeUrl },

package/dist/start_dev_server/start_dev_server.js

@@ -3,7 +3,7 @@ import { existsSync, readFileSync, realpathSync, readdirSync, lstatSync, statSyn
 import { pathToFileURL } from "node:url";
 import { urlToRelativeUrl, registerFileLifecycle, lookupPackageDirectory, readPackageAtOrNull, generateContentFrame, errorToHTML, DATA_URL, CONTENT_TYPE, normalizeImportMap, composeTwoImportMaps, resolveImport, JS_QUOTES, urlToExtension, urlToBasename, applyNodeEsmResolution, URL_META, readCustomConditionsFromProcessArgs, urlIsOrIsInsideOf, collectFiles, registerDirectoryLifecycle, readEntryStatSync, applyFileSystemMagicResolution, getExtensionsToTry, urlToFilename, asUrlWithoutSearch, ensurePathnameTrailingSlash, compareFileUrls, setUrlExtension, createDetailedMessage, stringifyUrlSite, injectQueryParamsIntoSpecifier, isSpecifierForNodeBuiltin, injectQueryParams, urlToFileSystemPath, writeFileSync, moveUrl, ensureWindowsDriveLetter, validateResponseIntegrity, setUrlFilename, getCallerPosition, asSpecifierWithoutSearch, bufferToEtag, isFileSystemPath, urlToPathname, setUrlBasename, createLogger, normalizeUrl, ANSI, RUNTIME_COMPAT, formatError, assertAndNormalizeDirectoryUrl, createTaskLog } from "./jsenv_core_packages.js";
 import { createPluginsController } from "@jsenv/server/src/plugins_controller.js";
-import { parseHtml, injectJsenvScript, stringifyHtmlAst, parseCssUrls, getHtmlNodeAttribute, getHtmlNodePosition, getHtmlNodeAttributePosition, setHtmlNodeAttributes, parseSrcSet, getUrlForContentInsideHtml, removeHtmlNodeText, setHtmlNodeText, getHtmlNodeText, analyzeScriptNode, visitHtmlNodes, parseJsUrls, getUrlForContentInsideJs, applyBabelPlugins, visitJsAst, getImportMetaPropertyName, visitJsAstUntil, analyzeLinkNode, injectHtmlNodeAsEarlyAsPossible, createHtmlNode, generateUrlForInlineContent, parseJsWithAcorn } from "@jsenv/ast";
+import { parseHtml, injectJsenvScript, stringifyHtmlAst, parseCssUrls, getHtmlNodeAttribute, getHtmlNodePosition, getHtmlNodeAttributePosition, setHtmlNodeAttributes, parseSrcSet, getUrlForContentInsideHtml, removeHtmlNodeText, setHtmlNodeText, getHtmlNodeText, analyzeScriptNode, visitHtmlNodes, parseJsUrls, getUrlForContentInsideJs, renderCssTemplateLiteral, applyBabelPlugins, visitJsAst, getImportMetaPropertyName, visitJsAstUntil, analyzeLinkNode, injectHtmlNodeAsEarlyAsPossible, createHtmlNode, generateUrlForInlineContent, parseJsWithAcorn } from "@jsenv/ast";
 import { jsenvPluginSupervisor } from "@jsenv/plugin-supervisor";
 import { jsenvPluginTranspilation } from "@jsenv/plugin-transpilation";
 import { createMagicSource, composeTwoSourcemaps, generateSourcemapFileUrl, generateSourcemapDataUrl, SOURCEMAP } from "@jsenv/sourcemap";
@@ -2369,9 +2369,17 @@ const parseAndTransformJsReferences = async (
 
     sequentialActions.push(async () => {
       await inlineUrlInfo.cook();
-      const replacement = JS_QUOTES.escapeSpecialChars(inlineUrlInfo.content, {
-        quote,
-      });
+      const { substitutions } = inlineReferenceInfo;
+      const replacement = substitutions
+        ? // the expressions the template holds take their placeholder's place
+          // back; a template literal is written whatever the runtime supports,
+          // transpilation runs after and lowers it when it has to
+          renderCssTemplateLiteral(inlineUrlInfo.content, substitutions)
+        : JS_QUOTES.escapeSpecialChars(inlineUrlInfo.content, { quote });
+      if (replacement === null) {
+        // a placeholder did not survive: the source stays as it was written
+        return;
+      }
       magicSource.replace({
         start: inlineReferenceInfo.start,
         end: inlineReferenceInfo.end,
@@ -6133,6 +6141,12 @@ const jsenvPluginNodeRuntime = ({ runtimeCompat }) => {
  * import.meta.css = css;
  * ```
  *
+ * "jsenv:js_reference_analysis" reads the css assigned here as an inline css and
+ * sends it through the css pipeline: transpilation, url() resolution, minification,
+ * comments. A "${}" standing where a css value stands is swapped for a placeholder
+ * and put back afterwards; anywhere else it makes the template unreadable and the
+ * css is shipped exactly as written, with everything the pipeline does lost.
+ *
  */
 
 
@@ -6165,6 +6179,12 @@ const jsenvPluginImportMetaCss = () => {
           return null;
         }
         if (urlInfo.context.build) {
+          if (hasModuleScopeAssignment(urlInfo.contentAst)) {
+            urlInfo.contentSideEffects.push({
+              has: true,
+              reason: "import.meta.css assigned at module scope",
+            });
+          }
           const packageName = urlInfo.packageName;
           const packageDirectoryUrl =
             urlInfo.packageDirectoryUrl || urlInfo.context.rootDirectoryUrl;
@@ -6208,6 +6228,28 @@ const jsenvPluginImportMetaCss = () => {
   };
 };
 
+// A stylesheet assigned at module scope is adopted when the module runs: that
+// assignment IS the module's side effect. It has to be told, because a
+// package.json "sideEffects" list is authoritative once it exists — a module
+// it does not name is dropped whole when it is imported for nothing else, and
+// its css silently leaves the build.
+const hasModuleScopeAssignment = (ast) => {
+  for (const node of ast.body) {
+    if (node.type !== "ExpressionStatement") {
+      continue;
+    }
+    const { expression } = node;
+    if (
+      expression.type === "AssignmentExpression" &&
+      expression.operator === "=" &&
+      getImportMetaPropertyName(expression.left) === "css"
+    ) {
+      return true;
+    }
+  }
+  return false;
+};
+
 const babelPluginRewriteImportMetaCssAssignment = (
   { types: t },
   { relativeUrl },
@@ -11660,7 +11702,17 @@ const devServerPluginServeSourceFiles = ({
             // so it is derived from the url and cooked first.
             const inlineParentUrl = getInlineContentParentUrl(requestedUrl);
             if (inlineParentUrl) {
-              if (!kitchen.graph.getUrlInfo(inlineParentUrl)) {
+              const inlineParentUrlInfo =
+                kitchen.graph.getUrlInfo(inlineParentUrl);
+              // A parent cooked before the file changed still holds the
+              // references it had then; the inline content is as fresh as its
+              // parent, so the parent is cooked again before being asked.
+              if (
+                !inlineParentUrlInfo ||
+                inlineParentUrlInfo.content === undefined ||
+                !inlineParentUrlInfo.contentFinalized ||
+                !inlineParentUrlInfo.isValid()
+              ) {
                 const rootUrlInfo = kitchen.graph.rootUrlInfo;
                 const inlineParentWebUrl = WEB_URL_CONVERTER.asWebUrl(
                   inlineParentUrl,
@@ -11684,6 +11736,16 @@ const devServerPluginServeSourceFiles = ({
                 request.resource,
                 inlineParentUrl,
               );
+              if (!reference) {
+                // The parent does not hold that inline content: the script was
+                // edited out of the html. What the graph kept under this url is
+                // what the parent used to say, it must not be served.
+                return {
+                  url: requestedUrl,
+                  status: 404,
+                  statusText: "no inline content at this position",
+                };
+              }
             }
           }
           if (reference) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "41.4.25",
+  "version": "41.4.27",
   "type": "module",
   "description": "Tool to develop, test and build js projects",
   "repository": {
@@ -73,12 +73,12 @@
     "test:snapshot_clear": "npx @jsenv/filesystem clear **/tests/**/side_effects/"
   },
   "dependencies": {
-    "@jsenv/ast": "6.9.2",
-    "@jsenv/js-module-fallback": "1.5.1",
+    "@jsenv/ast": "6.9.3",
+    "@jsenv/js-module-fallback": "1.5.2",
     "@jsenv/plugin-bundling": "2.10.18",
-    "@jsenv/plugin-minification": "1.7.10",
-    "@jsenv/plugin-supervisor": "1.8.13",
-    "@jsenv/plugin-transpilation": "1.6.2",
+    "@jsenv/plugin-minification": "1.7.11",
+    "@jsenv/plugin-supervisor": "1.8.14",
+    "@jsenv/plugin-transpilation": "1.6.3",
     "@jsenv/server": "17.6.3",
     "@jsenv/sourcemap": "1.4.2",
     "react-table": "7.8.0"

package/src/dev/dev_server_plugins/dev_server_plugin_serve_source_files.js

@@ -287,7 +287,17 @@ export const devServerPluginServeSourceFiles = ({
             // so it is derived from the url and cooked first.
             const inlineParentUrl = getInlineContentParentUrl(requestedUrl);
             if (inlineParentUrl) {
-              if (!kitchen.graph.getUrlInfo(inlineParentUrl)) {
+              const inlineParentUrlInfo =
+                kitchen.graph.getUrlInfo(inlineParentUrl);
+              // A parent cooked before the file changed still holds the
+              // references it had then; the inline content is as fresh as its
+              // parent, so the parent is cooked again before being asked.
+              if (
+                !inlineParentUrlInfo ||
+                inlineParentUrlInfo.content === undefined ||
+                !inlineParentUrlInfo.contentFinalized ||
+                !inlineParentUrlInfo.isValid()
+              ) {
                 const rootUrlInfo = kitchen.graph.rootUrlInfo;
                 const inlineParentWebUrl = WEB_URL_CONVERTER.asWebUrl(
                   inlineParentUrl,
@@ -311,6 +321,16 @@ export const devServerPluginServeSourceFiles = ({
                 request.resource,
                 inlineParentUrl,
               );
+              if (!reference) {
+                // The parent does not hold that inline content: the script was
+                // edited out of the html. What the graph kept under this url is
+                // what the parent used to say, it must not be served.
+                return {
+                  url: requestedUrl,
+                  status: 404,
+                  statusText: "no inline content at this position",
+                };
+              }
             }
           }
           if (reference) {

package/src/plugins/import_meta_css/jsenv_plugin_import_meta_css.js

@@ -21,6 +21,12 @@
  * import.meta.css = css;
  * ```
  *
+ * "jsenv:js_reference_analysis" reads the css assigned here as an inline css and
+ * sends it through the css pipeline: transpilation, url() resolution, minification,
+ * comments. A "${}" standing where a css value stands is swapped for a placeholder
+ * and put back afterwards; anywhere else it makes the template unreadable and the
+ * css is shipped exactly as written, with everything the pipeline does lost.
+ *
  */
 
 import {
@@ -58,6 +64,12 @@ export const jsenvPluginImportMetaCss = () => {
           return null;
         }
         if (urlInfo.context.build) {
+          if (hasModuleScopeAssignment(urlInfo.contentAst)) {
+            urlInfo.contentSideEffects.push({
+              has: true,
+              reason: "import.meta.css assigned at module scope",
+            });
+          }
           const packageName = urlInfo.packageName;
           const packageDirectoryUrl =
             urlInfo.packageDirectoryUrl || urlInfo.context.rootDirectoryUrl;
@@ -101,6 +113,28 @@ export const jsenvPluginImportMetaCss = () => {
   };
 };
 
+// A stylesheet assigned at module scope is adopted when the module runs: that
+// assignment IS the module's side effect. It has to be told, because a
+// package.json "sideEffects" list is authoritative once it exists — a module
+// it does not name is dropped whole when it is imported for nothing else, and
+// its css silently leaves the build.
+const hasModuleScopeAssignment = (ast) => {
+  for (const node of ast.body) {
+    if (node.type !== "ExpressionStatement") {
+      continue;
+    }
+    const { expression } = node;
+    if (
+      expression.type === "AssignmentExpression" &&
+      expression.operator === "=" &&
+      getImportMetaPropertyName(expression.left) === "css"
+    ) {
+      return true;
+    }
+  }
+  return false;
+};
+
 const babelPluginRewriteImportMetaCssAssignment = (
   { types: t },
   { relativeUrl },

package/src/plugins/reference_analysis/js/jsenv_plugin_js_reference_analysis.js

@@ -1,4 +1,8 @@
-import { getUrlForContentInsideJs, parseJsUrls } from "@jsenv/ast";
+import {
+  getUrlForContentInsideJs,
+  parseJsUrls,
+  renderCssTemplateLiteral,
+} from "@jsenv/ast";
 import {
   isWebWorkerEntryPointReference,
   isWebWorkerUrlInfo,
@@ -70,9 +74,17 @@ const parseAndTransformJsReferences = async (
 
     sequentialActions.push(async () => {
       await inlineUrlInfo.cook();
-      const replacement = JS_QUOTES.escapeSpecialChars(inlineUrlInfo.content, {
-        quote,
-      });
+      const { substitutions } = inlineReferenceInfo;
+      const replacement = substitutions
+        ? // the expressions the template holds take their placeholder's place
+          // back; a template literal is written whatever the runtime supports,
+          // transpilation runs after and lowers it when it has to
+          renderCssTemplateLiteral(inlineUrlInfo.content, substitutions)
+        : JS_QUOTES.escapeSpecialChars(inlineUrlInfo.content, { quote });
+      if (replacement === null) {
+        // a placeholder did not survive: the source stays as it was written
+        return;
+      }
       magicSource.replace({
         start: inlineReferenceInfo.start,
         end: inlineReferenceInfo.end,