@jsenv/core 40.3.1 → 40.3.2

package/README.md

@@ -2,50 +2,59 @@
 
 [![npm package](https://img.shields.io/npm/v/@jsenv/core.svg?logo=npm&label=package)](https://www.npmjs.com/package/@jsenv/core)
 
-Jsenv is a suite of tools that can be used in projects involving JavaScript.
+## Overview
 
-The goal of `@jsenv/core` is to provide the following tools:
+Jsenv is a suite of tools for JavaScript projects that prioritizes standards and simplicity, making it ideal for both beginners and those who need straightforward tools.
 
-1. **dev server**; A server that serves source files, facilitating development with live reloading.
-2. **build**; Optimizes source files into a specified directory for production.
-3. **build server**; Serves the built files, allowing for testing and verifying the production build.
-4. **test runner**; Runs test files concurrently, ensuring code reliability.
+## Installation
 
-Jsenv prioritizes standards and simplicity, making it ideal for both beginners and those who need straightforward tools without unnecessary complexities.
+```console
+npm install --save-dev @jsenv/core
+```
+
+> **Compatibility**: Tested on Mac, Windows, and Linux with Node.js 20. Other environments are not officially tested.
 
-To try jsenv on your machine, use [@jsenv/cli](./packages/related/cli/#jsenvcli).
+## Documentation
 
-For additional details, consult the [documentation](./docs/users/users.md)
+For comprehensive documentation, see the full [user documentation](https://github.com/jsenv/core/blob/main/docs/users/users.md).
 
-<!-- # The best parts
+## Basic Usage
 
-- **Robust versioning during build**: Avoids <a href="https://bundlers.tooling.report/hashing/avoid-cascade/" target="_blank">cascading hash changes</a><sup>↗</sup>.
-- **Load js module with classic script**: See the [asJsClassic plugin](./docs/users/g_plugins/g_plugins.md#asjsclassic).
-- **Large browser support after build**: Ensures compatibility with older versions of Firefox, Chrome, and Safari.
-- **Advanced support of top level await**.
-- **Advanced support of web workers**.
-- **Test files are executed like standard files**.
-- **Isolated environment for each test file**: Ensures tests run independently, preventing side effects.
-- Single set of files after build: Simplifies support and deployement with a single set of files.
-- Execute tests in multiple browsers: Supports Chrome, Safari, and Firefox.
-- Extensive browser support during dev: Allows the use of various browsers beyond the latest Chrome, which is useful for reproducing browser-specific bugs. -->
+Start a development server:
+
+```js
+import { startDevServer } from "@jsenv/core";
+
+await startDevServer({
+  sourceDirectoryUrl: import.meta.resolve("./"),
+});
+```
 
-<!--
-The following commands can be used to skip the prompt
+## Core Features
 
-| Command                                     |
-| ------------------------------------------- |
-| `npm create jsenv@latest -- --web`          |
-| `npm create jsenv@latest -- --web-preact`   |
-| `npm create jsenv@latest -- --web-react`    |
-| `npm create jsenv@latest -- --node-package` |
--->
+`@jsenv/core` provides four main tools:
 
-<!-- # Installation
+1. **Dev Server**: Serves source files with live reloading to facilitate development
+2. **Build**: Optimizes source files into a specified directory for production
+3. **Build Server**: Serves the built files, allowing for testing and verifying the production build
+4. **Test Runner**: Runs test files concurrently to ensure code reliability
+
+## Key Advantages
+
+- **Standards-first approach**: Built on web standards rather than custom abstractions
+- **Robust versioning**: Avoids cascading hash changes during builds
+- **Broad browser compatibility**: Works with modern and older browsers
+- **Isolated testing**: Prevents cross-test contamination
+- **Simple API**: Designed for clarity and ease of use
+
+## Quick Start
+
+The easiest way to try jsenv is with the CLI:
 
 ```console
-npm install --save-dev @jsenv/core
+npx @jsenv/cli
 ```
 
-_@jsenv/core_ is tested on Mac, Windows, Linux with Node.js 20.
-Other operating systems and Node.js versions are not tested. -->
+The CLI provides templates for web applications, React projects, and Node.js packages to get you started quickly.
+
+Read more in [@jsenv/cli](https://github.com/jsenv/core/tree/main/packages/related/cli#jsenvcli).

package/dist/build/build.js

@@ -1,7 +1,7 @@
 import { parseHtml, injectHtmlNodeAsEarlyAsPossible, createHtmlNode, stringifyHtmlAst, applyBabelPlugins, generateUrlForInlineContent, parseJsWithAcorn, visitHtmlNodes, analyzeScriptNode, getHtmlNodeText, getHtmlNodeAttribute, getHtmlNodePosition, getUrlForContentInsideHtml, setHtmlNodeAttributes, setHtmlNodeText, parseCssUrls, getHtmlNodeAttributePosition, parseSrcSet, removeHtmlNodeText, parseJsUrls, getUrlForContentInsideJs, analyzeLinkNode, injectJsenvScript, findHtmlNode, removeHtmlNode, insertHtmlNodeAfter } from "@jsenv/ast";
 import { memoryUsage } from "node:process";
 import { readFileSync, existsSync, readdirSync, lstatSync, realpathSync } from "node:fs";
-import { lookupPackageDirectory$1 as lookupPackageDirectory, registerDirectoryLifecycle$1 as registerDirectoryLifecycle, urlToRelativeUrl$1 as urlToRelativeUrl, createDetailedMessage$1 as createDetailedMessage, stringifyUrlSite$1 as stringifyUrlSite, generateContentFrame$1 as generateContentFrame, validateResponseIntegrity$1 as validateResponseIntegrity, urlIsInsideOf$1 as urlIsInsideOf, ensureWindowsDriveLetter$1 as ensureWindowsDriveLetter, setUrlFilename$1 as setUrlFilename, moveUrl$1 as moveUrl, getCallerPosition$1 as getCallerPosition, urlToBasename$1 as urlToBasename, urlToExtension$1 as urlToExtension, asSpecifierWithoutSearch$1 as asSpecifierWithoutSearch, asUrlWithoutSearch$1 as asUrlWithoutSearch, injectQueryParamsIntoSpecifier$1 as injectQueryParamsIntoSpecifier, bufferToEtag$1 as bufferToEtag, isFileSystemPath$1 as isFileSystemPath, urlToPathname$1 as urlToPathname, setUrlBasename$1 as setUrlBasename, urlToFileSystemPath$1 as urlToFileSystemPath, writeFileSync$1 as writeFileSync, createLogger$1 as createLogger, URL_META$1 as URL_META, applyNodeEsmResolution$1 as applyNodeEsmResolution, RUNTIME_COMPAT$1 as RUNTIME_COMPAT, normalizeUrl$1 as normalizeUrl, ANSI$1 as ANSI, CONTENT_TYPE$1 as CONTENT_TYPE, urlToFilename$1 as urlToFilename, DATA_URL$1 as DATA_URL, errorToHTML$1 as errorToHTML, normalizeImportMap$1 as normalizeImportMap, composeTwoImportMaps$1 as composeTwoImportMaps, resolveImport$1 as resolveImport, JS_QUOTES$1 as JS_QUOTES, defaultLookupPackageScope$1 as defaultLookupPackageScope, defaultReadPackageJson$1 as defaultReadPackageJson, readCustomConditionsFromProcessArgs$1 as readCustomConditionsFromProcessArgs, readEntryStatSync$1 as readEntryStatSync, ensurePathnameTrailingSlash$1 as ensurePathnameTrailingSlash, compareFileUrls$1 as compareFileUrls, applyFileSystemMagicResolution$1 as applyFileSystemMagicResolution, getExtensionsToTry$1 as getExtensionsToTry, setUrlExtension$1 as setUrlExtension, updateJsonFileSync$1 as updateJsonFileSync, isSpecifierForNodeBuiltin$1 as isSpecifierForNodeBuiltin, jsenvPluginTranspilation$1 as jsenvPluginTranspilation, renderDetails, humanizeDuration, humanizeFileSize, renderTable, renderBigSection, distributePercentages, humanizeMemory, comparePathnames, UNICODE, escapeRegexpSpecialChars, injectQueryParamIntoSpecifierWithoutEncoding, renderUrlOrRelativeUrlFilename, assertAndNormalizeDirectoryUrl$1 as assertAndNormalizeDirectoryUrl, Abort, raceProcessTeardownEvents, startMonitoringCpuUsage, startMonitoringMemoryUsage, createLookupPackageDirectory, readPackageAtOrNull$1 as readPackageAtOrNull, inferRuntimeCompatFromClosestPackage, browserDefaultRuntimeCompat, nodeDefaultRuntimeCompat, clearDirectorySync, createTaskLog$1 as createTaskLog, jsenvPluginBundling, jsenvPluginMinification, ensureEmptyDirectory, jsenvPluginJsModuleFallback, createDynamicLog } from "../jsenv_core_packages.js";
+import { lookupPackageDirectory$1 as lookupPackageDirectory, registerDirectoryLifecycle$1 as registerDirectoryLifecycle, urlToRelativeUrl$1 as urlToRelativeUrl, createDetailedMessage$1 as createDetailedMessage, stringifyUrlSite$1 as stringifyUrlSite, generateContentFrame$1 as generateContentFrame, validateResponseIntegrity$1 as validateResponseIntegrity, urlIsInsideOf$1 as urlIsInsideOf, ensureWindowsDriveLetter$1 as ensureWindowsDriveLetter, setUrlFilename$1 as setUrlFilename, moveUrl$1 as moveUrl, getCallerPosition$1 as getCallerPosition, urlToBasename$1 as urlToBasename, urlToExtension$1 as urlToExtension, asSpecifierWithoutSearch$1 as asSpecifierWithoutSearch, asUrlWithoutSearch$1 as asUrlWithoutSearch, injectQueryParamsIntoSpecifier$1 as injectQueryParamsIntoSpecifier, bufferToEtag$1 as bufferToEtag, isFileSystemPath$1 as isFileSystemPath, urlToPathname$1 as urlToPathname, setUrlBasename$1 as setUrlBasename, urlToFileSystemPath$1 as urlToFileSystemPath, writeFileSync$1 as writeFileSync, createLogger$1 as createLogger, URL_META$1 as URL_META, applyNodeEsmResolution$1 as applyNodeEsmResolution, RUNTIME_COMPAT$1 as RUNTIME_COMPAT, normalizeUrl$1 as normalizeUrl, ANSI$1 as ANSI, CONTENT_TYPE$1 as CONTENT_TYPE, urlToFilename$1 as urlToFilename, DATA_URL$1 as DATA_URL, errorToHTML$1 as errorToHTML, normalizeImportMap$1 as normalizeImportMap, composeTwoImportMaps$1 as composeTwoImportMaps, resolveImport$1 as resolveImport, JS_QUOTES$1 as JS_QUOTES, defaultLookupPackageScope$1 as defaultLookupPackageScope, defaultReadPackageJson$1 as defaultReadPackageJson, readCustomConditionsFromProcessArgs$1 as readCustomConditionsFromProcessArgs, readEntryStatSync$1 as readEntryStatSync, ensurePathnameTrailingSlash$1 as ensurePathnameTrailingSlash, compareFileUrls$1 as compareFileUrls, applyFileSystemMagicResolution$1 as applyFileSystemMagicResolution, getExtensionsToTry$1 as getExtensionsToTry, setUrlExtension$1 as setUrlExtension, isSpecifierForNodeBuiltin$1 as isSpecifierForNodeBuiltin, updateJsonFileSync$1 as updateJsonFileSync, jsenvPluginTranspilation$1 as jsenvPluginTranspilation, renderDetails, humanizeDuration, humanizeFileSize, renderTable, renderBigSection, distributePercentages, humanizeMemory, comparePathnames, UNICODE, escapeRegexpSpecialChars, injectQueryParamIntoSpecifierWithoutEncoding, renderUrlOrRelativeUrlFilename, assertAndNormalizeDirectoryUrl$1 as assertAndNormalizeDirectoryUrl, Abort, raceProcessTeardownEvents, startMonitoringCpuUsage, startMonitoringMemoryUsage, createLookupPackageDirectory, readPackageAtOrNull$1 as readPackageAtOrNull, inferRuntimeCompatFromClosestPackage, browserDefaultRuntimeCompat, nodeDefaultRuntimeCompat, clearDirectorySync, createTaskLog$1 as createTaskLog, jsenvPluginBundling, jsenvPluginMinification, ensureEmptyDirectory, jsenvPluginJsModuleFallback, createDynamicLog } from "../jsenv_core_packages.js";
 import { pathToFileURL } from "node:url";
 import { generateSourcemapFileUrl, createMagicSource, composeTwoSourcemaps, generateSourcemapDataUrl, SOURCEMAP } from "@jsenv/sourcemap";
 import { performance } from "node:perf_hooks";
@@ -8229,10 +8229,6 @@ const jsenvPluginPackageSideEffects = ({ packageDirectory }) => {
     return [];
   }
 
-  const sideEffectFileUrlSet = new Set();
-  const packageJsonFileUrl = new URL("./package.json", packageDirectory.url)
-    .href;
-
   const normalizeSideEffectFileUrl = (url) => {
     const urlRelativeToPackage = urlToRelativeUrl(url, packageDirectory.url);
     return urlRelativeToPackage[0] === "."
@@ -8240,6 +8236,20 @@ const jsenvPluginPackageSideEffects = ({ packageDirectory }) => {
       : `./${urlRelativeToPackage}`;
   };
 
+  const updatePackageSideEffects = (sideEffectBuildFileUrls) => {
+    const packageJsonFileUrl = new URL("./package.json", packageDirectory.url)
+      .href;
+    const sideEffectRelativeUrlArray = [];
+    for (const sideEffectBuildUrl of sideEffectBuildFileUrls) {
+      sideEffectRelativeUrlArray.push(
+        normalizeSideEffectFileUrl(sideEffectBuildUrl),
+      );
+    }
+    updateJsonFileSync(packageJsonFileUrl, {
+      sideEffects: sideEffectRelativeUrlArray,
+    });
+  };
+
   const sideEffectBuildFileUrls = [];
 
   const packageSideEffectsCacheMap = new Map();
@@ -8375,39 +8385,43 @@ const jsenvPluginPackageSideEffects = ({ packageDirectory }) => {
         }
       }
     },
-    refineBuild: () => {
+    refineBuild: (kitchen) => {
       if (sideEffectBuildFileUrls.length === 0) {
         return;
       }
-      let sideEffectsToAdd = [];
       if (sideEffects === false) {
-        sideEffectsToAdd = sideEffectBuildFileUrls;
-      } else if (Array.isArray(sideEffects)) {
+        updatePackageSideEffects(sideEffectBuildFileUrls);
+        return;
+      }
+      const { buildDirectoryUrl } = kitchen.context;
+      const sideEffectFileUrlSet = new Set();
+      if (Array.isArray(sideEffects)) {
+        let packageNeedsUpdate = false;
         for (const sideEffectFileRelativeUrl of sideEffects) {
           const sideEffectFileUrl = new URL(
             sideEffectFileRelativeUrl,
             packageDirectory.url,
           ).href;
-          sideEffectFileUrlSet.add(sideEffectFileUrl);
+          if (
+            urlIsInsideOf(sideEffectFileUrl, buildDirectoryUrl) &&
+            !sideEffectBuildFileUrls.includes(sideEffectFileUrl)
+          ) {
+            packageNeedsUpdate = true;
+          } else {
+            sideEffectFileUrlSet.add(sideEffectFileUrl);
+          }
         }
-        for (const url of sideEffectBuildFileUrls) {
-          if (sideEffectFileUrlSet.has(url)) {
+        for (const sideEffectBuildUrl of sideEffectBuildFileUrls) {
+          if (sideEffectFileUrlSet.has(sideEffectBuildUrl)) {
             continue;
           }
-          sideEffectsToAdd.push(url);
+          packageNeedsUpdate = true;
+          sideEffectFileUrlSet.add(sideEffectBuildUrl);
+        }
+        if (packageNeedsUpdate) {
+          updatePackageSideEffects(sideEffectFileUrlSet);
         }
       }
-      if (sideEffectsToAdd.length === 0) {
-        return;
-      }
-
-      const finalSideEffects = Array.isArray(sideEffects) ? sideEffects : [];
-      for (const sideEffectBuildUrl of sideEffectBuildFileUrls) {
-        finalSideEffects.push(normalizeSideEffectFileUrl(sideEffectBuildUrl));
-      }
-      updateJsonFileSync(packageJsonFileUrl, {
-        sideEffects: finalSideEffects,
-      });
     },
   };
 };
@@ -11811,7 +11825,7 @@ const prepareEntryPointBuild = async (
           }
           if (refineBuildCallbackSet.size) {
             for (const refineBuildCallback of refineBuildCallbackSet) {
-              refineBuildCallback(finalKitchen.graph);
+              refineBuildCallback(finalKitchen);
             }
           }
         }

package/dist/start_dev_server/start_dev_server.js

@@ -1,6 +1,6 @@
 import { WebSocketResponse, pickContentType, ServerEvents, jsenvServiceCORS, jsenvAccessControlAllowedHeaders, composeTwoResponses, serveDirectory, jsenvServiceErrorHandler, startServer } from "@jsenv/server";
 import { convertFileSystemErrorToResponseProperties } from "@jsenv/server/src/internal/convertFileSystemErrorToResponseProperties.js";
-import { lookupPackageDirectory, registerDirectoryLifecycle, urlToRelativeUrl, moveUrl, urlIsInsideOf, ensureWindowsDriveLetter, createDetailedMessage, stringifyUrlSite, generateContentFrame, validateResponseIntegrity, setUrlFilename, getCallerPosition, urlToBasename, urlToExtension, asSpecifierWithoutSearch, asUrlWithoutSearch, injectQueryParamsIntoSpecifier, bufferToEtag, isFileSystemPath, urlToPathname, setUrlBasename, urlToFileSystemPath, writeFileSync, createLogger, URL_META, applyNodeEsmResolution, RUNTIME_COMPAT, normalizeUrl, ANSI, CONTENT_TYPE, errorToHTML, DATA_URL, normalizeImportMap, composeTwoImportMaps, resolveImport, JS_QUOTES, defaultLookupPackageScope, defaultReadPackageJson, readCustomConditionsFromProcessArgs, readEntryStatSync, urlToFilename, ensurePathnameTrailingSlash, compareFileUrls, applyFileSystemMagicResolution, getExtensionsToTry, setUrlExtension, updateJsonFileSync, isSpecifierForNodeBuiltin, jsenvPluginTranspilation, memoizeByFirstArgument, assertAndNormalizeDirectoryUrl, createTaskLog, readPackageAtOrNull } from "../jsenv_core_packages.js";
+import { lookupPackageDirectory, registerDirectoryLifecycle, urlToRelativeUrl, moveUrl, urlIsInsideOf, ensureWindowsDriveLetter, createDetailedMessage, stringifyUrlSite, generateContentFrame, validateResponseIntegrity, setUrlFilename, getCallerPosition, urlToBasename, urlToExtension, asSpecifierWithoutSearch, asUrlWithoutSearch, injectQueryParamsIntoSpecifier, bufferToEtag, isFileSystemPath, urlToPathname, setUrlBasename, urlToFileSystemPath, writeFileSync, createLogger, URL_META, applyNodeEsmResolution, RUNTIME_COMPAT, normalizeUrl, ANSI, CONTENT_TYPE, errorToHTML, DATA_URL, normalizeImportMap, composeTwoImportMaps, resolveImport, JS_QUOTES, defaultLookupPackageScope, defaultReadPackageJson, readCustomConditionsFromProcessArgs, readEntryStatSync, urlToFilename, ensurePathnameTrailingSlash, compareFileUrls, applyFileSystemMagicResolution, getExtensionsToTry, setUrlExtension, isSpecifierForNodeBuiltin, updateJsonFileSync, jsenvPluginTranspilation, memoizeByFirstArgument, assertAndNormalizeDirectoryUrl, createTaskLog, readPackageAtOrNull } from "../jsenv_core_packages.js";
 import { readFileSync, existsSync, readdirSync, lstatSync, realpathSync } from "node:fs";
 import { pathToFileURL } from "node:url";
 import { generateSourcemapFileUrl, createMagicSource, composeTwoSourcemaps, generateSourcemapDataUrl, SOURCEMAP } from "@jsenv/sourcemap";
@@ -8270,10 +8270,6 @@ const jsenvPluginPackageSideEffects = ({ packageDirectory }) => {
     return [];
   }
 
-  const sideEffectFileUrlSet = new Set();
-  const packageJsonFileUrl = new URL("./package.json", packageDirectory.url)
-    .href;
-
   const normalizeSideEffectFileUrl = (url) => {
     const urlRelativeToPackage = urlToRelativeUrl(url, packageDirectory.url);
     return urlRelativeToPackage[0] === "."
@@ -8281,6 +8277,20 @@ const jsenvPluginPackageSideEffects = ({ packageDirectory }) => {
       : `./${urlRelativeToPackage}`;
   };
 
+  const updatePackageSideEffects = (sideEffectBuildFileUrls) => {
+    const packageJsonFileUrl = new URL("./package.json", packageDirectory.url)
+      .href;
+    const sideEffectRelativeUrlArray = [];
+    for (const sideEffectBuildUrl of sideEffectBuildFileUrls) {
+      sideEffectRelativeUrlArray.push(
+        normalizeSideEffectFileUrl(sideEffectBuildUrl),
+      );
+    }
+    updateJsonFileSync(packageJsonFileUrl, {
+      sideEffects: sideEffectRelativeUrlArray,
+    });
+  };
+
   const sideEffectBuildFileUrls = [];
 
   const packageSideEffectsCacheMap = new Map();
@@ -8416,39 +8426,43 @@ const jsenvPluginPackageSideEffects = ({ packageDirectory }) => {
         }
       }
     },
-    refineBuild: () => {
+    refineBuild: (kitchen) => {
       if (sideEffectBuildFileUrls.length === 0) {
         return;
       }
-      let sideEffectsToAdd = [];
       if (sideEffects === false) {
-        sideEffectsToAdd = sideEffectBuildFileUrls;
-      } else if (Array.isArray(sideEffects)) {
+        updatePackageSideEffects(sideEffectBuildFileUrls);
+        return;
+      }
+      const { buildDirectoryUrl } = kitchen.context;
+      const sideEffectFileUrlSet = new Set();
+      if (Array.isArray(sideEffects)) {
+        let packageNeedsUpdate = false;
         for (const sideEffectFileRelativeUrl of sideEffects) {
           const sideEffectFileUrl = new URL(
             sideEffectFileRelativeUrl,
             packageDirectory.url,
           ).href;
-          sideEffectFileUrlSet.add(sideEffectFileUrl);
+          if (
+            urlIsInsideOf(sideEffectFileUrl, buildDirectoryUrl) &&
+            !sideEffectBuildFileUrls.includes(sideEffectFileUrl)
+          ) {
+            packageNeedsUpdate = true;
+          } else {
+            sideEffectFileUrlSet.add(sideEffectFileUrl);
+          }
         }
-        for (const url of sideEffectBuildFileUrls) {
-          if (sideEffectFileUrlSet.has(url)) {
+        for (const sideEffectBuildUrl of sideEffectBuildFileUrls) {
+          if (sideEffectFileUrlSet.has(sideEffectBuildUrl)) {
             continue;
           }
-          sideEffectsToAdd.push(url);
+          packageNeedsUpdate = true;
+          sideEffectFileUrlSet.add(sideEffectBuildUrl);
+        }
+        if (packageNeedsUpdate) {
+          updatePackageSideEffects(sideEffectFileUrlSet);
         }
       }
-      if (sideEffectsToAdd.length === 0) {
-        return;
-      }
-
-      const finalSideEffects = Array.isArray(sideEffects) ? sideEffects : [];
-      for (const sideEffectBuildUrl of sideEffectBuildFileUrls) {
-        finalSideEffects.push(normalizeSideEffectFileUrl(sideEffectBuildUrl));
-      }
-      updateJsonFileSync(packageJsonFileUrl, {
-        sideEffects: finalSideEffects,
-      });
     },
   };
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "40.3.1",
+  "version": "40.3.2",
   "description": "Tool to develop, test and build js projects",
   "license": "MIT",
   "author": {
@@ -50,10 +50,8 @@
   "sideEffects": [
     "./src/kitchen/client/inline_content.js",
     "./dist/client/inline_content/inline_content.js",
-    "./dist/client/directory_listing/jsenv_core_node_modules.js",
     "./dist/jsenv_core_node_modules.js",
-    "./dist/client/new_stylesheet/new_stylesheet.js",
-    "./dist/client/inline_content/inline_content.js"
+    "./dist/client/new_stylesheet/new_stylesheet.js"
   ],
   "scripts": {
     "eslint": "npx eslint .",
@@ -130,4 +128,4 @@
     "prettier-plugin-organize-imports": "4.1.0",
     "strip-ansi": "7.1.0"
   }
-}
+}

package/src/build/build.js

@@ -1339,7 +1339,7 @@ const prepareEntryPointBuild = async (
           }
           if (refineBuildCallbackSet.size) {
             for (const refineBuildCallback of refineBuildCallbackSet) {
-              refineBuildCallback(finalKitchen.graph);
+              refineBuildCallback(finalKitchen);
             }
           }
         }

package/src/plugins/package_side_effects/jsenv_plugin_package_side_effects.js

@@ -14,7 +14,7 @@
 import { updateJsonFileSync } from "@jsenv/filesystem";
 import { isSpecifierForNodeBuiltin } from "@jsenv/node-esm-resolution/src/node_builtin_specifiers.js";
 import { URL_META } from "@jsenv/url-meta";
-import { urlToRelativeUrl } from "@jsenv/urls";
+import { urlIsInsideOf, urlToRelativeUrl } from "@jsenv/urls";
 
 export const jsenvPluginPackageSideEffects = ({ packageDirectory }) => {
   if (!packageDirectory.url) {
@@ -29,10 +29,6 @@ export const jsenvPluginPackageSideEffects = ({ packageDirectory }) => {
     return [];
   }
 
-  const sideEffectFileUrlSet = new Set();
-  const packageJsonFileUrl = new URL("./package.json", packageDirectory.url)
-    .href;
-
   const normalizeSideEffectFileUrl = (url) => {
     const urlRelativeToPackage = urlToRelativeUrl(url, packageDirectory.url);
     return urlRelativeToPackage[0] === "."
@@ -40,6 +36,20 @@ export const jsenvPluginPackageSideEffects = ({ packageDirectory }) => {
       : `./${urlRelativeToPackage}`;
   };
 
+  const updatePackageSideEffects = (sideEffectBuildFileUrls) => {
+    const packageJsonFileUrl = new URL("./package.json", packageDirectory.url)
+      .href;
+    const sideEffectRelativeUrlArray = [];
+    for (const sideEffectBuildUrl of sideEffectBuildFileUrls) {
+      sideEffectRelativeUrlArray.push(
+        normalizeSideEffectFileUrl(sideEffectBuildUrl),
+      );
+    }
+    updateJsonFileSync(packageJsonFileUrl, {
+      sideEffects: sideEffectRelativeUrlArray,
+    });
+  };
+
   const sideEffectBuildFileUrls = [];
 
   const packageSideEffectsCacheMap = new Map();
@@ -175,39 +185,43 @@ export const jsenvPluginPackageSideEffects = ({ packageDirectory }) => {
         }
       }
     },
-    refineBuild: () => {
+    refineBuild: (kitchen) => {
       if (sideEffectBuildFileUrls.length === 0) {
         return;
       }
-      let sideEffectsToAdd = [];
       if (sideEffects === false) {
-        sideEffectsToAdd = sideEffectBuildFileUrls;
-      } else if (Array.isArray(sideEffects)) {
+        updatePackageSideEffects(sideEffectBuildFileUrls);
+        return;
+      }
+      const { buildDirectoryUrl } = kitchen.context;
+      const sideEffectFileUrlSet = new Set();
+      if (Array.isArray(sideEffects)) {
+        let packageNeedsUpdate = false;
         for (const sideEffectFileRelativeUrl of sideEffects) {
           const sideEffectFileUrl = new URL(
             sideEffectFileRelativeUrl,
             packageDirectory.url,
           ).href;
-          sideEffectFileUrlSet.add(sideEffectFileUrl);
+          if (
+            urlIsInsideOf(sideEffectFileUrl, buildDirectoryUrl) &&
+            !sideEffectBuildFileUrls.includes(sideEffectFileUrl)
+          ) {
+            packageNeedsUpdate = true;
+          } else {
+            sideEffectFileUrlSet.add(sideEffectFileUrl);
+          }
         }
-        for (const url of sideEffectBuildFileUrls) {
-          if (sideEffectFileUrlSet.has(url)) {
+        for (const sideEffectBuildUrl of sideEffectBuildFileUrls) {
+          if (sideEffectFileUrlSet.has(sideEffectBuildUrl)) {
             continue;
           }
-          sideEffectsToAdd.push(url);
+          packageNeedsUpdate = true;
+          sideEffectFileUrlSet.add(sideEffectBuildUrl);
+        }
+        if (packageNeedsUpdate) {
+          updatePackageSideEffects(sideEffectFileUrlSet);
         }
       }
-      if (sideEffectsToAdd.length === 0) {
-        return;
-      }
-
-      const finalSideEffects = Array.isArray(sideEffects) ? sideEffects : [];
-      for (const sideEffectBuildUrl of sideEffectBuildFileUrls) {
-        finalSideEffects.push(normalizeSideEffectFileUrl(sideEffectBuildUrl));
-      }
-      updateJsonFileSync(packageJsonFileUrl, {
-        sideEffects: finalSideEffects,
-      });
     },
   };
 };