@jsenv/core 40.12.1 → 40.12.3

package/dist/build/build.js

@@ -2902,9 +2902,8 @@ const shouldHandleSourcemap = (urlInfo) => {
   return true;
 };
 
-const inlineContentClientFileUrl = import.meta.resolve(
-  "../client/inline_content/inline_content.js",
-);
+const inlineContentClientFileUrl = import.meta
+  .resolve("../client/inline_content/inline_content.js");
 
 const createKitchen = ({
   name,
@@ -4101,9 +4100,8 @@ const jsenvPluginInlining = () => {
 };
 
 const jsenvPluginHtmlSyntaxErrorFallback = () => {
-  const htmlSyntaxErrorFileUrl = import.meta.resolve(
-    "../client/html_syntax_error/html_syntax_error.html",
-  );
+  const htmlSyntaxErrorFileUrl = import.meta
+    .resolve("../client/html_syntax_error/html_syntax_error.html");
 
   return {
     mustStayFirst: true,
@@ -6550,9 +6548,8 @@ const jsenvPluginVersionSearchParam = () => {
  */
 
 
-const htmlFileUrlForDirectory = import.meta.resolve(
-  "../client/directory_listing/directory_listing.html",
-);
+const htmlFileUrlForDirectory = import.meta
+  .resolve("../client/directory_listing/directory_listing.html");
 
 const jsenvPluginDirectoryListing = ({
   spa,
@@ -7039,13 +7036,7 @@ const jsenvPluginFsRedirection = ({
         // 2. The url pathname does not have an extension
         //    This point assume client is requesting a file when there is an extension
         //    and it assumes all routes will not use extension
-        // 3. The url pathname does not ends with "/"
-        //    In that case we assume client explicitely asks to load a directory
-        if (
-          spa &&
-          !urlToExtension(urlObject) &&
-          !urlToPathname(urlObject).endsWith("/")
-        ) {
+        if (spa && !urlToExtension(urlObject)) {
           const { requestedUrl, rootDirectoryUrl, mainFilePath } =
             reference.ownerUrlInfo.context;
           const closestHtmlRootFile = getClosestHtmlRootFile(
@@ -7817,12 +7808,10 @@ const jsenvPluginNodeRuntime = ({ runtimeCompat }) => {
 
 
 const jsenvPluginImportMetaCss = () => {
-  const importMetaCssClientFileUrl = import.meta.resolve(
-    "../client/import_meta_css/import_meta_css.js",
-  );
-  const importMetaCssBuildFileUrl = import.meta.resolve(
-    "../client/import_meta_css/import_meta_css_build.js",
-  );
+  const importMetaCssClientFileUrl = import.meta
+    .resolve("../client/import_meta_css/import_meta_css.js");
+  const importMetaCssBuildFileUrl = import.meta
+    .resolve("../client/import_meta_css/import_meta_css_build.js");
 
   return {
     name: "jsenv:import_meta_css",
@@ -8154,9 +8143,8 @@ const htmlNodeCanHotReload = (node) => {
 };
 
 const jsenvPluginImportMetaHot = () => {
-  const importMetaHotClientFileUrl = import.meta.resolve(
-    "../client/import_meta_hot/import_meta_hot.js",
-  );
+  const importMetaHotClientFileUrl = import.meta
+    .resolve("../client/import_meta_hot/import_meta_hot.js");
 
   return {
     name: "jsenv:import_meta_hot",
@@ -8948,9 +8936,8 @@ const jsenvPluginChromeDevtoolsJson = () => {
 };
 
 const jsenvPluginAutoreloadOnServerRestart = () => {
-  const autoreloadOnRestartClientFileUrl = import.meta.resolve(
-    "@jsenv/server/src/services/autoreload_on_server_restart/client/autoreload_on_server_restart.js",
-  );
+  const autoreloadOnRestartClientFileUrl = import.meta
+    .resolve("@jsenv/server/src/services/autoreload_on_server_restart/client/autoreload_on_server_restart.js");
 
   return {
     name: "jsenv:autoreload_on_server_restart",

package/dist/build/jsenv_core_packages.js

@@ -521,8 +521,6 @@ const SIGINT_CALLBACK = {
  * https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URIs#syntax
  */
 
-/* eslint-env browser, node */
-
 const DATA_URL = {
   parse: (string) => {
     const afterDataProtocol = string.slice("data:".length);
@@ -852,19 +850,47 @@ const setDecimalsPrecision = (
 //   return numberTruncated
 // }
 
-const unitShort = {
-  year: "y",
-  month: "m",
-  week: "w",
-  day: "d",
-  hour: "h",
-  minute: "m",
-  second: "s",
+const UNIT_MS = {
+  year: 31_557_600_000,
+  month: 2_629_000_000,
+  week: 604_800_000,
+  day: 86_400_000,
+  hour: 3_600_000,
+  minute: 60_000,
+  second: 1000,
+};
+const UNIT_KEYS = Object.keys(UNIT_MS);
+const SMALLEST_UNIT_NAME = UNIT_KEYS[UNIT_KEYS.length - 1];
+const TIME_DICTIONARY_EN = {
+  year: { long: "year", plural: "years", short: "y" },
+  month: { long: "month", plural: "months", short: "m" },
+  week: { long: "week", plural: "weeks", short: "w" },
+  day: { long: "day", plural: "days", short: "d" },
+  hour: { long: "hour", plural: "hours", short: "h" },
+  minute: { long: "minute", plural: "minutes", short: "m" },
+  second: { long: "second", plural: "seconds", short: "s" },
+  joinDuration: (primary, remaining) => `${primary} and ${remaining}`,
+};
+const TIME_DICTIONARY_FR = {
+  year: { long: "an", plural: "ans", short: "a" },
+  month: { long: "mois", plural: "mois", short: "m" },
+  week: { long: "semaine", plural: "semaines", short: "s" },
+  day: { long: "jour", plural: "jours", short: "j" },
+  hour: { long: "heure", plural: "heures", short: "h" },
+  minute: { long: "minute", plural: "minutes", short: "m" },
+  second: { long: "seconde", plural: "secondes", short: "s" },
+  joinDuration: (primary, remaining) => `${primary} et ${remaining}`,
 };
 
 const humanizeDuration = (
   ms,
-  { short, rounded = true, decimals } = {},
+  {
+    short,
+    rounded = true,
+    decimals,
+    lang = "en",
+    timeDictionnary = lang === "fr" ? TIME_DICTIONARY_FR : TIME_DICTIONARY_EN,
+  } = {},
 ) => {
   // ignore ms below meaningfulMs so that:
   // humanizeDuration(0.5) -> "0 second"
@@ -874,7 +900,9 @@ const humanizeDuration = (
   // yes we could return "0.1 millisecond" but we choosed consistency over precision
   // so that the prefered unit is "second" (and does not become millisecond when ms is super small)
   if (ms < 1) {
-    return short ? "0s" : "0 second";
+    return short
+      ? `0${timeDictionnary.second.short}`
+      : `0 ${timeDictionnary.second.long}`;
   }
   const { primary, remaining } = parseMs(ms);
   if (!remaining) {
@@ -883,52 +911,51 @@ const humanizeDuration = (
         decimals === undefined ? (primary.name === "second" ? 1 : 0) : decimals,
       short,
       rounded,
+      timeDictionnary,
     });
   }
-  return `${humanizeDurationUnit(primary, {
+  const primaryText = humanizeDurationUnit(primary, {
     decimals: decimals === undefined ? 0 : decimals,
     short,
     rounded,
-  })} and ${humanizeDurationUnit(remaining, {
+    timeDictionnary,
+  });
+  const remainingText = humanizeDurationUnit(remaining, {
     decimals: decimals === undefined ? 0 : decimals,
     short,
     rounded,
-  })}`;
+    timeDictionnary,
+  });
+  return timeDictionnary.joinDuration(primaryText, remainingText);
 };
-const humanizeDurationUnit = (unit, { decimals, short, rounded }) => {
+const humanizeDurationUnit = (
+  unit,
+  { decimals, short, rounded, timeDictionnary },
+) => {
   const count = rounded
     ? setRoundedPrecision(unit.count, { decimals })
     : setPrecision(unit.count, { decimals });
-  let name = unit.name;
+  const name = unit.name;
   if (short) {
-    name = unitShort[name];
-    return `${count}${name}`;
+    const unitText = timeDictionnary[name].short;
+    return `${count}${unitText}`;
   }
   if (count <= 1) {
-    return `${count} ${name}`;
+    const unitText = timeDictionnary[name].long;
+    return `${count} ${unitText}`;
   }
-  return `${count} ${name}s`;
-};
-const MS_PER_UNITS = {
-  year: 31_557_600_000,
-  month: 2_629_000_000,
-  week: 604_800_000,
-  day: 86_400_000,
-  hour: 3_600_000,
-  minute: 60_000,
-  second: 1000,
+  const unitText = timeDictionnary[name].plural;
+  return `${count} ${unitText}`;
 };
 
 const parseMs = (ms) => {
-  const unitNames = Object.keys(MS_PER_UNITS);
-  const smallestUnitName = unitNames[unitNames.length - 1];
-  let firstUnitName = smallestUnitName;
-  let firstUnitCount = ms / MS_PER_UNITS[smallestUnitName];
-  const firstUnitIndex = unitNames.findIndex((unitName) => {
-    if (unitName === smallestUnitName) {
+  let firstUnitName = SMALLEST_UNIT_NAME;
+  let firstUnitCount = ms / UNIT_MS[SMALLEST_UNIT_NAME];
+  const firstUnitIndex = UNIT_KEYS.findIndex((unitName) => {
+    if (unitName === SMALLEST_UNIT_NAME) {
       return false;
     }
-    const msPerUnit = MS_PER_UNITS[unitName];
+    const msPerUnit = UNIT_MS[unitName];
     const unitCount = Math.floor(ms / msPerUnit);
     if (unitCount) {
       firstUnitName = unitName;
@@ -937,7 +964,7 @@ const parseMs = (ms) => {
     }
     return false;
   });
-  if (firstUnitName === smallestUnitName) {
+  if (firstUnitName === SMALLEST_UNIT_NAME) {
     return {
       primary: {
         name: firstUnitName,
@@ -945,9 +972,9 @@ const parseMs = (ms) => {
       },
     };
   }
-  const remainingMs = ms - firstUnitCount * MS_PER_UNITS[firstUnitName];
-  const remainingUnitName = unitNames[firstUnitIndex + 1];
-  const remainingUnitCount = remainingMs / MS_PER_UNITS[remainingUnitName];
+  const remainingMs = ms - firstUnitCount * UNIT_MS[firstUnitName];
+  const remainingUnitName = UNIT_KEYS[firstUnitIndex + 1];
+  const remainingUnitCount = remainingMs / UNIT_MS[remainingUnitName];
   // - 1 year and 1 second is too much information
   //   so we don't check the remaining units
   // - 1 year and 0.0001 week is awful

package/dist/client/inline_content/inline_content.js

@@ -1,5 +1,3 @@
-/* eslint-env browser,node */
-
 /*
  * This file does not use export const InlineContent = function() {} on purpose:
  * - An export would be renamed by rollup,

package/dist/client/ribbon/ribbon.js

@@ -2,14 +2,14 @@ const injectRibbon = ({ text }) => {
   const css = /* css */ `
     #jsenv_ribbon_container {
       position: fixed;
-      z-index: 1001;
       top: 0;
       right: 0;
+      z-index: 1001;
       width: 100px;
       height: 100px;
-      overflow: hidden;
       opacity: 0.5;
       pointer-events: none;
+      overflow: hidden;
     }
     #jsenv_ribbon {
       position: absolute;
@@ -20,20 +20,20 @@ const injectRibbon = ({ text }) => {
     }
     #jsenv_ribbon_text {
       position: absolute;
-      left: 0px;
       top: 20px;
-      transform: rotate(45deg);
+      left: 0px;
       display: block;
       width: 125px;
-      line-height: 36px;
-      background-color: orange;
       color: rgb(55, 7, 7);
-      box-shadow: 0 5px 10px rgba(0, 0, 0, 0.1);
       font-weight: 700;
       font-size: 16px;
       font-family: "Lato", sans-serif;
-      text-shadow: 0 1px 1px rgba(0, 0, 0, 0.2);
       text-align: center;
+      text-shadow: 0 1px 1px rgba(0, 0, 0, 0.2);
+      line-height: 36px;
+      background-color: orange;
+      box-shadow: 0 5px 10px rgba(0, 0, 0, 0.1);
+      transform: rotate(45deg);
       user-select: none;
     }
   `;

package/dist/start_build_server/jsenv_core_packages.js

@@ -760,19 +760,47 @@ const setDecimalsPrecision = (
 //   return numberTruncated
 // }
 
-const unitShort = {
-  year: "y",
-  month: "m",
-  week: "w",
-  day: "d",
-  hour: "h",
-  minute: "m",
-  second: "s",
+const UNIT_MS = {
+  year: 31_557_600_000,
+  month: 2_629_000_000,
+  week: 604_800_000,
+  day: 86_400_000,
+  hour: 3_600_000,
+  minute: 60_000,
+  second: 1000,
+};
+const UNIT_KEYS = Object.keys(UNIT_MS);
+const SMALLEST_UNIT_NAME = UNIT_KEYS[UNIT_KEYS.length - 1];
+const TIME_DICTIONARY_EN = {
+  year: { long: "year", plural: "years", short: "y" },
+  month: { long: "month", plural: "months", short: "m" },
+  week: { long: "week", plural: "weeks", short: "w" },
+  day: { long: "day", plural: "days", short: "d" },
+  hour: { long: "hour", plural: "hours", short: "h" },
+  minute: { long: "minute", plural: "minutes", short: "m" },
+  second: { long: "second", plural: "seconds", short: "s" },
+  joinDuration: (primary, remaining) => `${primary} and ${remaining}`,
+};
+const TIME_DICTIONARY_FR = {
+  year: { long: "an", plural: "ans", short: "a" },
+  month: { long: "mois", plural: "mois", short: "m" },
+  week: { long: "semaine", plural: "semaines", short: "s" },
+  day: { long: "jour", plural: "jours", short: "j" },
+  hour: { long: "heure", plural: "heures", short: "h" },
+  minute: { long: "minute", plural: "minutes", short: "m" },
+  second: { long: "seconde", plural: "secondes", short: "s" },
+  joinDuration: (primary, remaining) => `${primary} et ${remaining}`,
 };
 
 const humanizeDuration = (
   ms,
-  { short, rounded = true, decimals } = {},
+  {
+    short,
+    rounded = true,
+    decimals,
+    lang = "en",
+    timeDictionnary = lang === "fr" ? TIME_DICTIONARY_FR : TIME_DICTIONARY_EN,
+  } = {},
 ) => {
   // ignore ms below meaningfulMs so that:
   // humanizeDuration(0.5) -> "0 second"
@@ -782,7 +810,9 @@ const humanizeDuration = (
   // yes we could return "0.1 millisecond" but we choosed consistency over precision
   // so that the prefered unit is "second" (and does not become millisecond when ms is super small)
   if (ms < 1) {
-    return short ? "0s" : "0 second";
+    return short
+      ? `0${timeDictionnary.second.short}`
+      : `0 ${timeDictionnary.second.long}`;
   }
   const { primary, remaining } = parseMs(ms);
   if (!remaining) {
@@ -791,52 +821,51 @@ const humanizeDuration = (
         decimals === undefined ? (primary.name === "second" ? 1 : 0) : decimals,
       short,
       rounded,
+      timeDictionnary,
     });
   }
-  return `${humanizeDurationUnit(primary, {
+  const primaryText = humanizeDurationUnit(primary, {
     decimals: decimals === undefined ? 0 : decimals,
     short,
     rounded,
-  })} and ${humanizeDurationUnit(remaining, {
+    timeDictionnary,
+  });
+  const remainingText = humanizeDurationUnit(remaining, {
     decimals: decimals === undefined ? 0 : decimals,
     short,
     rounded,
-  })}`;
+    timeDictionnary,
+  });
+  return timeDictionnary.joinDuration(primaryText, remainingText);
 };
-const humanizeDurationUnit = (unit, { decimals, short, rounded }) => {
+const humanizeDurationUnit = (
+  unit,
+  { decimals, short, rounded, timeDictionnary },
+) => {
   const count = rounded
     ? setRoundedPrecision(unit.count, { decimals })
     : setPrecision(unit.count, { decimals });
-  let name = unit.name;
+  const name = unit.name;
   if (short) {
-    name = unitShort[name];
-    return `${count}${name}`;
+    const unitText = timeDictionnary[name].short;
+    return `${count}${unitText}`;
   }
   if (count <= 1) {
-    return `${count} ${name}`;
+    const unitText = timeDictionnary[name].long;
+    return `${count} ${unitText}`;
   }
-  return `${count} ${name}s`;
-};
-const MS_PER_UNITS = {
-  year: 31_557_600_000,
-  month: 2_629_000_000,
-  week: 604_800_000,
-  day: 86_400_000,
-  hour: 3_600_000,
-  minute: 60_000,
-  second: 1000,
+  const unitText = timeDictionnary[name].plural;
+  return `${count} ${unitText}`;
 };
 
 const parseMs = (ms) => {
-  const unitNames = Object.keys(MS_PER_UNITS);
-  const smallestUnitName = unitNames[unitNames.length - 1];
-  let firstUnitName = smallestUnitName;
-  let firstUnitCount = ms / MS_PER_UNITS[smallestUnitName];
-  const firstUnitIndex = unitNames.findIndex((unitName) => {
-    if (unitName === smallestUnitName) {
+  let firstUnitName = SMALLEST_UNIT_NAME;
+  let firstUnitCount = ms / UNIT_MS[SMALLEST_UNIT_NAME];
+  const firstUnitIndex = UNIT_KEYS.findIndex((unitName) => {
+    if (unitName === SMALLEST_UNIT_NAME) {
       return false;
     }
-    const msPerUnit = MS_PER_UNITS[unitName];
+    const msPerUnit = UNIT_MS[unitName];
     const unitCount = Math.floor(ms / msPerUnit);
     if (unitCount) {
       firstUnitName = unitName;
@@ -845,7 +874,7 @@ const parseMs = (ms) => {
     }
     return false;
   });
-  if (firstUnitName === smallestUnitName) {
+  if (firstUnitName === SMALLEST_UNIT_NAME) {
     return {
       primary: {
         name: firstUnitName,
@@ -853,9 +882,9 @@ const parseMs = (ms) => {
       },
     };
   }
-  const remainingMs = ms - firstUnitCount * MS_PER_UNITS[firstUnitName];
-  const remainingUnitName = unitNames[firstUnitIndex + 1];
-  const remainingUnitCount = remainingMs / MS_PER_UNITS[remainingUnitName];
+  const remainingMs = ms - firstUnitCount * UNIT_MS[firstUnitName];
+  const remainingUnitName = UNIT_KEYS[firstUnitIndex + 1];
+  const remainingUnitCount = remainingMs / UNIT_MS[remainingUnitName];
   // - 1 year and 1 second is too much information
   //   so we don't check the remaining units
   // - 1 year and 0.0001 week is awful

package/dist/start_dev_server/jsenv_core_packages.js

@@ -10,8 +10,6 @@ import { pathToFileURL, fileURLToPath } from "node:url";
  * https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URIs#syntax
  */
 
-/* eslint-env browser, node */
-
 const DATA_URL = {
   parse: (string) => {
     const afterDataProtocol = string.slice("data:".length);
@@ -360,19 +358,47 @@ const setDecimalsPrecision = (
 //   return numberTruncated
 // }
 
-const unitShort = {
-  year: "y",
-  month: "m",
-  week: "w",
-  day: "d",
-  hour: "h",
-  minute: "m",
-  second: "s",
+const UNIT_MS = {
+  year: 31_557_600_000,
+  month: 2_629_000_000,
+  week: 604_800_000,
+  day: 86_400_000,
+  hour: 3_600_000,
+  minute: 60_000,
+  second: 1000,
+};
+const UNIT_KEYS = Object.keys(UNIT_MS);
+const SMALLEST_UNIT_NAME = UNIT_KEYS[UNIT_KEYS.length - 1];
+const TIME_DICTIONARY_EN = {
+  year: { long: "year", plural: "years", short: "y" },
+  month: { long: "month", plural: "months", short: "m" },
+  week: { long: "week", plural: "weeks", short: "w" },
+  day: { long: "day", plural: "days", short: "d" },
+  hour: { long: "hour", plural: "hours", short: "h" },
+  minute: { long: "minute", plural: "minutes", short: "m" },
+  second: { long: "second", plural: "seconds", short: "s" },
+  joinDuration: (primary, remaining) => `${primary} and ${remaining}`,
+};
+const TIME_DICTIONARY_FR = {
+  year: { long: "an", plural: "ans", short: "a" },
+  month: { long: "mois", plural: "mois", short: "m" },
+  week: { long: "semaine", plural: "semaines", short: "s" },
+  day: { long: "jour", plural: "jours", short: "j" },
+  hour: { long: "heure", plural: "heures", short: "h" },
+  minute: { long: "minute", plural: "minutes", short: "m" },
+  second: { long: "seconde", plural: "secondes", short: "s" },
+  joinDuration: (primary, remaining) => `${primary} et ${remaining}`,
 };
 
 const humanizeDuration = (
   ms,
-  { short, rounded = true, decimals } = {},
+  {
+    short,
+    rounded = true,
+    decimals,
+    lang = "en",
+    timeDictionnary = lang === "fr" ? TIME_DICTIONARY_FR : TIME_DICTIONARY_EN,
+  } = {},
 ) => {
   // ignore ms below meaningfulMs so that:
   // humanizeDuration(0.5) -> "0 second"
@@ -382,7 +408,9 @@ const humanizeDuration = (
   // yes we could return "0.1 millisecond" but we choosed consistency over precision
   // so that the prefered unit is "second" (and does not become millisecond when ms is super small)
   if (ms < 1) {
-    return short ? "0s" : "0 second";
+    return short
+      ? `0${timeDictionnary.second.short}`
+      : `0 ${timeDictionnary.second.long}`;
   }
   const { primary, remaining } = parseMs(ms);
   if (!remaining) {
@@ -391,52 +419,51 @@ const humanizeDuration = (
         decimals === undefined ? (primary.name === "second" ? 1 : 0) : decimals,
       short,
       rounded,
+      timeDictionnary,
     });
   }
-  return `${humanizeDurationUnit(primary, {
+  const primaryText = humanizeDurationUnit(primary, {
     decimals: decimals === undefined ? 0 : decimals,
     short,
     rounded,
-  })} and ${humanizeDurationUnit(remaining, {
+    timeDictionnary,
+  });
+  const remainingText = humanizeDurationUnit(remaining, {
     decimals: decimals === undefined ? 0 : decimals,
     short,
     rounded,
-  })}`;
+    timeDictionnary,
+  });
+  return timeDictionnary.joinDuration(primaryText, remainingText);
 };
-const humanizeDurationUnit = (unit, { decimals, short, rounded }) => {
+const humanizeDurationUnit = (
+  unit,
+  { decimals, short, rounded, timeDictionnary },
+) => {
   const count = rounded
     ? setRoundedPrecision(unit.count, { decimals })
     : setPrecision(unit.count, { decimals });
-  let name = unit.name;
+  const name = unit.name;
   if (short) {
-    name = unitShort[name];
-    return `${count}${name}`;
+    const unitText = timeDictionnary[name].short;
+    return `${count}${unitText}`;
   }
   if (count <= 1) {
-    return `${count} ${name}`;
+    const unitText = timeDictionnary[name].long;
+    return `${count} ${unitText}`;
   }
-  return `${count} ${name}s`;
-};
-const MS_PER_UNITS = {
-  year: 31_557_600_000,
-  month: 2_629_000_000,
-  week: 604_800_000,
-  day: 86_400_000,
-  hour: 3_600_000,
-  minute: 60_000,
-  second: 1000,
+  const unitText = timeDictionnary[name].plural;
+  return `${count} ${unitText}`;
 };
 
 const parseMs = (ms) => {
-  const unitNames = Object.keys(MS_PER_UNITS);
-  const smallestUnitName = unitNames[unitNames.length - 1];
-  let firstUnitName = smallestUnitName;
-  let firstUnitCount = ms / MS_PER_UNITS[smallestUnitName];
-  const firstUnitIndex = unitNames.findIndex((unitName) => {
-    if (unitName === smallestUnitName) {
+  let firstUnitName = SMALLEST_UNIT_NAME;
+  let firstUnitCount = ms / UNIT_MS[SMALLEST_UNIT_NAME];
+  const firstUnitIndex = UNIT_KEYS.findIndex((unitName) => {
+    if (unitName === SMALLEST_UNIT_NAME) {
       return false;
     }
-    const msPerUnit = MS_PER_UNITS[unitName];
+    const msPerUnit = UNIT_MS[unitName];
     const unitCount = Math.floor(ms / msPerUnit);
     if (unitCount) {
       firstUnitName = unitName;
@@ -445,7 +472,7 @@ const parseMs = (ms) => {
     }
     return false;
   });
-  if (firstUnitName === smallestUnitName) {
+  if (firstUnitName === SMALLEST_UNIT_NAME) {
     return {
       primary: {
         name: firstUnitName,
@@ -453,9 +480,9 @@ const parseMs = (ms) => {
       },
     };
   }
-  const remainingMs = ms - firstUnitCount * MS_PER_UNITS[firstUnitName];
-  const remainingUnitName = unitNames[firstUnitIndex + 1];
-  const remainingUnitCount = remainingMs / MS_PER_UNITS[remainingUnitName];
+  const remainingMs = ms - firstUnitCount * UNIT_MS[firstUnitName];
+  const remainingUnitName = UNIT_KEYS[firstUnitIndex + 1];
+  const remainingUnitCount = remainingMs / UNIT_MS[remainingUnitName];
   // - 1 year and 1 second is too much information
   //   so we don't check the remaining units
   // - 1 year and 0.0001 week is awful