@jsenv/core 29.1.12 → 29.1.14

package/dist/main.js

@@ -7060,7 +7060,7 @@ const fetchFileSystem = async (filesystemUrl, {
 
     rootDirectoryUrl = rootDirectoryUrlString;
   } // here you might be tempted to add || cacheControl === 'no-cache'
-  // but no-cache means resource can be cache but must be revalidated (yeah naming is strange)
+  // but no-cache means resource can be cached but must be revalidated (yeah naming is strange)
   // https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#Cacheability
 
 
@@ -25759,10 +25759,16 @@ const createFileService = ({
       response = {
         url: reference.url,
         status: 200,
-        headers: {
-          "cache-control": `private,max-age=0,must-revalidate`,
-          // it's safe to use "_" separator because etag is encoded with base64 (see https://stackoverflow.com/a/13195197)
-          "eTag": `${urlInfoTargetedByCache.originalContentEtag}_${urlInfoTargetedByCache.contentEtag}`,
+        headers: { // when we send eTag to the client the next request to the server
+          // will send etag in request headers.
+          // If they match jsenv bypass cooking and returns 304
+          // This must not happen when a plugin uses "no-store" or "no-cache" as it means
+          // plugin logic wants to happens for every request to this url
+          ...(urlInfo.headers["cache-control"] === "no-store" || urlInfo.headers["cache-control"] === "no-cache" ? {} : {
+            "cache-control": `private,max-age=0,must-revalidate`,
+            // it's safe to use "_" separator because etag is encoded with base64 (see https://stackoverflow.com/a/13195197)
+            "eTag": `${urlInfoTargetedByCache.originalContentEtag}_${urlInfoTargetedByCache.contentEtag}`
+          }),
           ...urlInfo.headers,
           "content-type": urlInfo.contentType,
           "content-length": Buffer.byteLength(urlInfo.content)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "29.1.12",
+  "version": "29.1.14",
   "description": "Tool to develop, test and build js projects",
   "license": "MIT",
   "author": {
@@ -100,7 +100,7 @@
     "@babel/eslint-parser": "7.19.1",
     "@babel/plugin-syntax-import-assertions": "7.18.6",
     "@jsenv/assert": "2.7.0",
-    "@jsenv/eslint-config": "16.2.1",
+    "@jsenv/eslint-config": "16.2.3",
     "@jsenv/file-size-impact": "13.0.1",
     "@jsenv/https-local": "3.0.1",
     "@jsenv/package-workspace": "0.5.0",

package/src/dev/file_service.js

@@ -334,9 +334,19 @@ export const createFileService = ({
         url: reference.url,
         status: 200,
         headers: {
-          "cache-control": `private,max-age=0,must-revalidate`,
-          // it's safe to use "_" separator because etag is encoded with base64 (see https://stackoverflow.com/a/13195197)
-          "eTag": `${urlInfoTargetedByCache.originalContentEtag}_${urlInfoTargetedByCache.contentEtag}`,
+          // when we send eTag to the client the next request to the server
+          // will send etag in request headers.
+          // If they match jsenv bypass cooking and returns 304
+          // This must not happen when a plugin uses "no-store" or "no-cache" as it means
+          // plugin logic wants to happens for every request to this url
+          ...(urlInfo.headers["cache-control"] === "no-store" ||
+          urlInfo.headers["cache-control"] === "no-cache"
+            ? {}
+            : {
+                "cache-control": `private,max-age=0,must-revalidate`,
+                // it's safe to use "_" separator because etag is encoded with base64 (see https://stackoverflow.com/a/13195197)
+                "eTag": `${urlInfoTargetedByCache.originalContentEtag}_${urlInfoTargetedByCache.contentEtag}`,
+              }),
           ...urlInfo.headers,
           "content-type": urlInfo.contentType,
           "content-length": Buffer.byteLength(urlInfo.content),