@jsenv/core 27.5.2 → 27.5.3

package/dist/js/html_supervisor_installer.js

@@ -131,7 +131,8 @@ const formatError = (error, {
   // so use it only when error.stack is not available
 
 
-  if (url && !stack) {
+  if (url && !stack && // ignore window.reportError() it gives no valuable info
+  !url.endsWith("html_supervisor_installer.js")) {
     onErrorLocated(resolveUrlSite({
       url,
       line,
@@ -358,6 +359,7 @@ const link = ({
 }) => `<a href="${href}">${text}</a>`;
 
 const JSENV_ERROR_OVERLAY_TAGNAME = "jsenv-error-overlay";
+let previousErrorInfo = null;
 const displayErrorInDocument = (error, {
   rootDirectoryUrl,
   errorBaseUrl,
@@ -369,6 +371,22 @@ const displayErrorInDocument = (error, {
   reportedBy,
   requestedRessource
 }) => {
+  const nowMs = Date.now(); // ensure error dispatched on window by browser is displayed first
+  // then the server error replaces it (because it contains more information)
+
+  if (previousErrorInfo) {
+    const previousErrorReportedBy = previousErrorInfo.reportedBy;
+    const msEllapsedSincePreviousError = nowMs - previousErrorInfo.ms;
+
+    if (previousErrorReportedBy === "server" && reportedBy === "browser" && msEllapsedSincePreviousError < 50) {
+      return () => {};
+    }
+  }
+
+  previousErrorInfo = {
+    ms: nowMs,
+    reportedBy
+  };
   const {
     theme,
     title,
@@ -815,15 +833,18 @@ const installHtmlSupervisor = ({
       }
 
       const {
-        error
+        error,
+        filename,
+        lineno,
+        colno
       } = errorEvent;
       displayErrorInDocument(error, {
         rootDirectoryUrl,
         errorBaseUrl,
         openInEditor,
-        url: errorEvent.filename,
-        line: errorEvent.lineno,
-        column: errorEvent.colno,
+        url: filename,
+        line: lineno,
+        column: colno,
         reportedBy: "browser"
       });
     });
@@ -864,27 +885,22 @@ const installHtmlSupervisor = ({
 
           if (isFaviconAutoRequest) {
             return;
-          } // setTimeout is to ensure the error
-          // dispatched on window by browser is displayed first,
-          // then the server error replaces it (because it contains more information)
-
-
-          setTimeout(() => {
-            displayErrorInDocument({
-              message,
-              stack
-            }, {
-              rootDirectoryUrl,
-              errorBaseUrl,
-              openInEditor,
-              url: traceUrl,
-              line: traceLine,
-              column: traceColumn,
-              codeFrame: traceMessage,
-              reportedBy: "server",
-              requestedRessource
-            });
-          }, 10);
+          }
+
+          displayErrorInDocument({
+            message,
+            stack
+          }, {
+            rootDirectoryUrl,
+            errorBaseUrl,
+            openInEditor,
+            url: traceUrl,
+            line: traceLine,
+            column: traceColumn,
+            codeFrame: traceMessage,
+            reportedBy: "server",
+            requestedRessource
+          });
         }
       });
     }

package/dist/main.js

@@ -25715,7 +25715,7 @@ const executeTestPlan = async ({
   keepRunning = false,
   cooldownBetweenExecutions = 0,
   gcBetweenExecutions = logMemoryHeapUsage,
-  coverageEnabled = process.argv.includes("--cover") || process.argv.includes("--coverage"),
+  coverageEnabled = process.argv.includes("--coverage"),
   coverageConfig = {
     "./src/": true
   },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "27.5.2",
+  "version": "27.5.3",
   "description": "Tool to develop, test and build js projects",
   "license": "MIT",
   "author": {

package/src/plugins/html_supervisor/client/error_formatter.js

@@ -103,7 +103,12 @@ export const formatError = (
 
   // error.stack is more reliable than url/line/column reported on window error events
   // so use it only when error.stack is not available
-  if (url && !stack) {
+  if (
+    url &&
+    !stack &&
+    // ignore window.reportError() it gives no valuable info
+    !url.endsWith("html_supervisor_installer.js")
+  ) {
     onErrorLocated(resolveUrlSite({ url, line, column }))
   }
 

package/src/plugins/html_supervisor/client/error_overlay.js

@@ -2,6 +2,8 @@ import { formatError } from "./error_formatter.js"
 
 const JSENV_ERROR_OVERLAY_TAGNAME = "jsenv-error-overlay"
 
+let previousErrorInfo = null
+
 export const displayErrorInDocument = (
   error,
   {
@@ -16,6 +18,25 @@ export const displayErrorInDocument = (
     requestedRessource,
   },
 ) => {
+  const nowMs = Date.now()
+  // ensure error dispatched on window by browser is displayed first
+  // then the server error replaces it (because it contains more information)
+  if (previousErrorInfo) {
+    const previousErrorReportedBy = previousErrorInfo.reportedBy
+    const msEllapsedSincePreviousError = nowMs - previousErrorInfo.ms
+    if (
+      previousErrorReportedBy === "server" &&
+      reportedBy === "browser" &&
+      msEllapsedSincePreviousError < 50
+    ) {
+      return () => {}
+    }
+  }
+  previousErrorInfo = {
+    ms: nowMs,
+    reportedBy,
+  }
+
   const { theme, title, text, codeFramePromise, tip } = formatError(error, {
     rootDirectoryUrl,
     errorBaseUrl,

package/src/plugins/html_supervisor/client/html_supervisor_installer.js

@@ -225,14 +225,14 @@ export const installHtmlSupervisor = ({
         // ignore custom error event (not sent by browser)
         return
       }
-      const { error } = errorEvent
+      const { error, filename, lineno, colno } = errorEvent
       displayErrorInDocument(error, {
         rootDirectoryUrl,
         errorBaseUrl,
         openInEditor,
-        url: errorEvent.filename,
-        line: errorEvent.lineno,
-        column: errorEvent.colno,
+        url: filename,
+        line: lineno,
+        column: colno,
         reportedBy: "browser",
       })
     })
@@ -252,7 +252,6 @@ export const installHtmlSupervisor = ({
         }
         return false
       }
-
       window.__server_events__.addEventCallbacks({
         error_while_serving_file: (serverErrorEvent) => {
           if (!isExecuting()) {
@@ -271,28 +270,23 @@ export const installHtmlSupervisor = ({
           if (isFaviconAutoRequest) {
             return
           }
-          // setTimeout is to ensure the error
-          // dispatched on window by browser is displayed first,
-          // then the server error replaces it (because it contains more information)
-          setTimeout(() => {
-            displayErrorInDocument(
-              {
-                message,
-                stack,
-              },
-              {
-                rootDirectoryUrl,
-                errorBaseUrl,
-                openInEditor,
-                url: traceUrl,
-                line: traceLine,
-                column: traceColumn,
-                codeFrame: traceMessage,
-                reportedBy: "server",
-                requestedRessource,
-              },
-            )
-          }, 10)
+          displayErrorInDocument(
+            {
+              message,
+              stack,
+            },
+            {
+              rootDirectoryUrl,
+              errorBaseUrl,
+              openInEditor,
+              url: traceUrl,
+              line: traceLine,
+              column: traceColumn,
+              codeFrame: traceMessage,
+              reportedBy: "server",
+              requestedRessource,
+            },
+          )
         },
       })
     }

package/src/test/execute_test_plan.js

@@ -60,8 +60,7 @@ export const executeTestPlan = async ({
   cooldownBetweenExecutions = 0,
   gcBetweenExecutions = logMemoryHeapUsage,
 
-  coverageEnabled = process.argv.includes("--cover") ||
-    process.argv.includes("--coverage"),
+  coverageEnabled = process.argv.includes("--coverage"),
   coverageConfig = {
     "./src/": true,
   },