@jsenv/core 27.3.2 → 27.4.0

package/src/test/coverage/report_to_coverage.js

@@ -50,7 +50,7 @@ export const reportToCoverage = async (
         coverageMethodForNodeJs !== "NODE_V8_COVERAGE"
       ) {
         logger.warn(
-          `No "coverageFileUrl" from execution named "${executionName}" of ${file}`,
+          `"${executionName}" execution of ${file} did not properly write coverage into ${executionResult.coverageFileUrl}`,
         )
       }
     },
@@ -152,18 +152,23 @@ const getCoverageFromReport = async ({ signal, report, onMissing }) => {
           const executionResultForFileOnRuntime =
             executionResultForFile[executionName]
           const { coverageFileUrl } = executionResultForFileOnRuntime
-          if (!coverageFileUrl) {
-            onMissing({
-              executionName,
-              file,
-              executionResult: executionResultForFileOnRuntime,
-            })
-            return
+          let executionCoverage
+          try {
+            executionCoverage = JSON.parse(
+              String(readFileSync(new URL(coverageFileUrl))),
+            )
+          } catch (e) {
+            if (e.code === "ENOENT" || e.name === "SyntaxError") {
+              onMissing({
+                executionName,
+                file,
+                executionResult: executionResultForFileOnRuntime,
+              })
+              return
+            }
+            throw e
           }
 
-          const executionCoverage = JSON.parse(
-            String(readFileSync(new URL(coverageFileUrl))),
-          )
           if (isV8Coverage(executionCoverage)) {
             v8Coverage = v8Coverage
               ? composeTwoV8Coverages(v8Coverage, executionCoverage)

package/src/test/execute_plan.js

@@ -143,7 +143,7 @@ export const executePlan = async (
           createDetailedMessage(
             `process.env.NODE_V8_COVERAGE is required to generate coverage for Node.js subprocesses`,
             {
-              "suggestion": `Preprend NODE_V8_COVERAGE=.coverage/node to the command executing this process`,
+              "suggestion": `set process.env.NODE_V8_COVERAGE`,
               "suggestion 2": `use coverageMethodForNodeJs: "Profiler". But it means coverage for child_process and worker_thread cannot be collected`,
             },
           ),
@@ -224,7 +224,8 @@ export const executePlan = async (
               getCustomBabelPlugins: ({ clientRuntimeCompat }) => {
                 if (
                   coverageEnabled &&
-                  Object.keys(clientRuntimeCompat)[0] !== "chrome"
+                  (coverageMethodForBrowsers !== "playwright_api" ||
+                    Object.keys(clientRuntimeCompat)[0] !== "chrome")
                 ) {
                   return {
                     "transform-instrument": [

package/src/test/execute_test_plan.js

@@ -67,7 +67,9 @@ export const executeTestPlan = async ({
   },
   coverageIncludeMissing = true,
   coverageAndExecutionAllowed = false,
-  coverageMethodForNodeJs = "NODE_V8_COVERAGE", // "Profiler" also accepted
+  coverageMethodForNodeJs = process.env.NODE_V8_COVERAGE
+    ? "NODE_V8_COVERAGE"
+    : "Profiler",
   coverageMethodForBrowsers = "playwright_api", // "istanbul" also accepted
   coverageV8ConflictWarning = true,
   coverageTempDirectoryRelativeUrl = "./.coverage/tmp/",

package/src/test/logs_file_execution.js

@@ -217,7 +217,6 @@ const formatConsoleCalls = (consoleCalls) => {
   if (consoleCalls.length === 0) {
     return ""
   }
-
   const repartition = {
     debug: 0,
     info: 0,
@@ -225,17 +224,10 @@ const formatConsoleCalls = (consoleCalls) => {
     error: 0,
     log: 0,
   }
-  let consoleOutput = ``
   consoleCalls.forEach((consoleCall) => {
     repartition[consoleCall.type]++
-    const text = consoleCall.text
-    const textFormatted = prefixFirstAndIndentRemainingLines({
-      prefix: CONSOLE_ICONS[consoleCall.type],
-      text,
-      trimLastLine: consoleCall === consoleCalls[consoleCalls.length - 1],
-    })
-    consoleOutput += textFormatted
   })
+  const consoleOutput = formatConsoleOutput(consoleCalls)
 
   return `${ANSI.color(
     `-------- ${formatConsoleSummary(repartition)} --------`,
@@ -245,6 +237,65 @@ ${consoleOutput}
 ${ANSI.color(`-------------------------`, ANSI.GREY)}`
 }
 
+export const formatConsoleOutput = (consoleCalls) => {
+  // inside Node.js you can do process.stdout.write()
+  // and in that case the consoleCall is not suffixed with "\n"
+  // we want to keep these calls together in the output
+  const regroupedCalls = []
+  consoleCalls.forEach((consoleCall, index) => {
+    if (index === 0) {
+      regroupedCalls.push(consoleCall)
+      return
+    }
+    const previousCall = consoleCalls[index - 1]
+    if (previousCall.type !== consoleCall.type) {
+      regroupedCalls.push(consoleCall)
+      return
+    }
+    if (previousCall.text.endsWith("\n")) {
+      regroupedCalls.push(consoleCall)
+      return
+    }
+    if (previousCall.text.endsWith("\r")) {
+      regroupedCalls.push(consoleCall)
+      return
+    }
+    const previousRegroupedCallIndex = regroupedCalls.length - 1
+    const previousRegroupedCall = regroupedCalls[previousRegroupedCallIndex]
+    previousRegroupedCall.text = `${previousRegroupedCall.text}${consoleCall.text}`
+  })
+
+  let consoleOutput = ``
+  regroupedCalls.forEach((regroupedCall, index) => {
+    const text = regroupedCall.text
+    const textFormatted = prefixFirstAndIndentRemainingLines({
+      prefix: CONSOLE_ICONS[regroupedCall.type],
+      text,
+      trimLastLine: index === regroupedCalls.length - 1,
+    })
+    consoleOutput += textFormatted
+  })
+  return consoleOutput
+}
+
+const prefixFirstAndIndentRemainingLines = ({ prefix, text, trimLastLine }) => {
+  const lines = text.split(/\r?\n/)
+  const firstLine = lines.shift()
+  let result = `${prefix} ${firstLine}`
+  let i = 0
+  const indentation = `  `
+  while (i < lines.length) {
+    const line = lines[i].trim()
+    i++
+    result += line.length
+      ? `\n${indentation}${line}`
+      : trimLastLine && i === lines.length
+      ? ""
+      : `\n`
+  }
+  return result
+}
+
 const CONSOLE_ICONS = {
   debug: UNICODE.DEBUG,
   info: UNICODE.INFO,
@@ -274,24 +325,6 @@ const formatConsoleSummary = (repartition) => {
   return `console (${parts.join(" ")})`
 }
 
-const prefixFirstAndIndentRemainingLines = ({ prefix, text, trimLastLine }) => {
-  const lines = text.split(/\r?\n/)
-  const firstLine = lines.shift()
-  let result = `${prefix} ${firstLine}`
-  let i = 0
-  const indentation = `  `
-  while (i < lines.length) {
-    const line = lines[i].trim()
-    i++
-    result += line.length
-      ? `\n${indentation}${line}`
-      : trimLastLine && i === lines.length
-      ? ""
-      : `\n`
-  }
-  return result
-}
-
 const formatExecution = ({ label, details = {}, consoleOutput }) => {
   let message = ``
   message += label

package/src/test/logs_file_execution.test.mjs

@@ -0,0 +1,41 @@
+import { assert } from "@jsenv/assert"
+
+import { formatConsoleOutput } from "./logs_file_execution.js"
+
+{
+  const actual = formatConsoleOutput([
+    { type: "log", text: "a\n" },
+    { type: "log", text: "b\n" },
+  ])
+  const expected = `  a
+  b`
+  assert({ actual, expected })
+}
+
+{
+  const actual = formatConsoleOutput([
+    { type: "log", text: "a" },
+    { type: "log", text: "b" },
+  ])
+  const expected = `  ab`
+  assert({ actual, expected })
+}
+
+{
+  const actual = formatConsoleOutput([
+    {
+      type: "log",
+      text: `1
+2`,
+    },
+    {
+      type: "log",
+      text: `alpha
+beta`,
+    },
+  ])
+  const expected = `  1
+  2alpha
+  beta`
+  assert({ actual, expected })
+}