@jsenv/core 27.2.2 → 27.3.2

package/README.md

@@ -23,7 +23,7 @@ npm create jsenv@latest
 npm install --save-dev @jsenv/core
 ```
 
-_@jsenv/core_ is tested on Mac, Windows, Linux on Node.js 16.14.0. Other operating systems and Node.js versions are not tested.
+_@jsenv/core_ is tested on Mac, Windows, Linux on Node.js 18.5.0. Other operating systems and Node.js versions are not tested.
 
 # Documentation
 

package/dist/main.js

@@ -9,6 +9,7 @@ import net, { createServer } from "node:net";
 import { Readable, Stream, Writable } from "node:stream";
 import { Http2ServerResponse } from "node:http2";
 import { createReadStream, readdirSync, statSync, readFile as readFile$1, chmod, stat, lstat, readdir, promises, unlink, openSync, closeSync, rmdir, readFileSync as readFileSync$1, watch, writeFile as writeFile$1, writeFileSync as writeFileSync$1, mkdirSync, existsSync, realpathSync } from "node:fs";
+import { lookup } from "node:dns";
 import { performance } from "node:perf_hooks";
 import { extname, dirname, basename } from "node:path";
 import { pathToFileURL, fileURLToPath } from "node:url";
@@ -2653,15 +2654,32 @@ const statusIsClientError = status => status >= 400 && status < 500;
 
 const statusIsServerError = status => status >= 500 && status < 600;
 
-const getServerOrigins = ({
+const applyDnsResolution = async hostname => {
+  const dnsResolution = await new Promise((resolve, reject) => {
+    lookup(hostname, (error, address, family) => {
+      if (error) {
+        reject(error);
+      } else {
+        resolve({
+          address,
+          family
+        });
+      }
+    });
+  });
+  return dnsResolution;
+};
+
+const getServerOrigins = async ({
   protocol,
   ip,
   port
 }) => {
   const isInternalIp = ip === "127.0.0.1";
+  const localhostDnsResolution = await applyDnsResolution("localhost");
   const internalOrigin = createServerOrigin({
     protocol,
-    hostname: "localhost",
+    hostname: localhostDnsResolution.address === "127.0.0.1" ? "localhost" : "127.0.0.1",
     port
   });
 
@@ -3536,7 +3554,7 @@ const startServer = async ({
   };
 
   status = "opened";
-  const serverOrigins = getServerOrigins({
+  const serverOrigins = await getServerOrigins({
     protocol,
     ip,
     port
@@ -26760,7 +26778,6 @@ nodeWorkerThread.run = async ({
     env: envForWorkerThread,
     execArgv: execArgvForWorkerThread,
     // workerData: { options },
-    // trackUnmanagedFds: true,
     stdin: true,
     stdout: true,
     stderr: true
@@ -26778,7 +26795,13 @@ nodeWorkerThread.run = async ({
     onceWorkerThreadMessage(workerThread, "ready", resolve);
   });
   const stop = memoize(async () => {
-    await workerThreadReadyPromise;
+    // read all stdout before terminating
+    // (no need for stderr because it's sync)
+    while (workerThread.stdout.read() !== null) {}
+
+    await new Promise(resolve => {
+      setTimeout(resolve);
+    });
     await workerThread.terminate();
   });
   const winnerPromise = new Promise(resolve => {
@@ -26916,25 +26939,27 @@ nodeWorkerThread.run = async ({
 const installWorkerThreadOutputListener = (workerThread, callback) => {
   // beware that we may receive ansi output here, should not be a problem but keep that in mind
   const stdoutDataCallback = chunk => {
+    const text = String(chunk);
     callback({
       type: "log",
-      text: String(chunk)
+      text
     });
   };
 
   workerThread.stdout.on("data", stdoutDataCallback);
 
   const stdErrorDataCallback = chunk => {
+    const text = String(chunk);
     callback({
       type: "error",
-      text: String(chunk)
+      text
     });
   };
 
   workerThread.stderr.on("data", stdErrorDataCallback);
   return () => {
     workerThread.stdout.removeListener("data", stdoutDataCallback);
-    workerThread.stderr.removeListener("data", stdoutDataCallback);
+    workerThread.stderr.removeListener("data", stdErrorDataCallback);
   };
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "27.2.2",
+  "version": "27.3.2",
   "description": "Tool to develop, test and build js projects",
   "license": "MIT",
   "author": {
@@ -13,7 +13,7 @@
     "url": "https://github.com/jsenv/jsenv-core"
   },
   "engines": {
-    "node": ">=16.13.0"
+    "node": ">=18.5.0"
   },
   "publishConfig": {
     "access": "public",
@@ -73,7 +73,7 @@
     "@jsenv/integrity": "0.0.1",
     "@jsenv/log": "3.1.0",
     "@jsenv/node-esm-resolution": "0.1.0",
-    "@jsenv/server": "12.7.5",
+    "@jsenv/server": "12.8.0",
     "@jsenv/sourcemap": "1.0.1",
     "@jsenv/uneval": "1.6.0",
     "@jsenv/url-meta": "7.0.0",

package/src/execute/runtimes/node/node_worker_thread.js

@@ -86,7 +86,6 @@ nodeWorkerThread.run = async ({
       env: envForWorkerThread,
       execArgv: execArgvForWorkerThread,
       // workerData: { options },
-      // trackUnmanagedFds: true,
       stdin: true,
       stdout: true,
       stderr: true,
@@ -103,7 +102,12 @@ nodeWorkerThread.run = async ({
   })
 
   const stop = memoize(async () => {
-    await workerThreadReadyPromise
+    // read all stdout before terminating
+    // (no need for stderr because it's sync)
+    while (workerThread.stdout.read() !== null) {}
+    await new Promise((resolve) => {
+      setTimeout(resolve)
+    })
     await workerThread.terminate()
   })
 
@@ -232,16 +236,18 @@ nodeWorkerThread.run = async ({
 const installWorkerThreadOutputListener = (workerThread, callback) => {
   // beware that we may receive ansi output here, should not be a problem but keep that in mind
   const stdoutDataCallback = (chunk) => {
-    callback({ type: "log", text: String(chunk) })
+    const text = String(chunk)
+    callback({ type: "log", text })
   }
   workerThread.stdout.on("data", stdoutDataCallback)
   const stdErrorDataCallback = (chunk) => {
-    callback({ type: "error", text: String(chunk) })
+    const text = String(chunk)
+    callback({ type: "error", text })
   }
   workerThread.stderr.on("data", stdErrorDataCallback)
   return () => {
     workerThread.stdout.removeListener("data", stdoutDataCallback)
-    workerThread.stderr.removeListener("data", stdoutDataCallback)
+    workerThread.stderr.removeListener("data", stdErrorDataCallback)
   }
 }