@jsenv/core 27.0.2 → 27.0.3

package/dist/main.js

@@ -21446,6 +21446,7 @@ const createUrlInfo = url => {
     content: undefined,
     sourcemap: null,
     sourcemapReference: null,
+    sourcemapIsWrong: false,
     timing: {},
     headers: {}
   };
@@ -21891,7 +21892,8 @@ const createUrlInfoTransformer = ({
       type,
       contentType,
       content,
-      sourcemap
+      sourcemap,
+      sourcemapIsWrong
     } = transformations;
 
     if (type) {
@@ -21910,7 +21912,17 @@ const createUrlInfoTransformer = ({
       const sourcemapNormalized = normalizeSourcemap(urlInfo, sourcemap);
       const finalSourcemap = await composeTwoSourcemaps(urlInfo.sourcemap, sourcemapNormalized);
       const finalSourcemapNormalized = normalizeSourcemap(urlInfo, finalSourcemap);
-      urlInfo.sourcemap = finalSourcemapNormalized;
+      urlInfo.sourcemap = finalSourcemapNormalized; // A plugin is allowed to modify url content
+      // without returning a sourcemap
+      // This is the case for preact and react plugins.
+      // They are currently generating wrong source mappings
+      // when used.
+      // Generating the correct sourcemap in this situation
+      // is a nightmare no-one could solve in years so
+      // jsenv won't emit a warning and use the following strategy:
+      // "no sourcemap is better than wrong sourcemap"
+
+      urlInfo.sourcemapIsWrong = sourcemapIsWrong;
     }
   };
 
@@ -21939,16 +21951,18 @@ const createUrlInfoTransformer = ({
 
       sourcemapUrlInfo.content = JSON.stringify(sourcemap, null, "  ");
 
-      if (sourcemaps === "inline") {
-        sourcemapReference.generatedSpecifier = generateSourcemapDataUrl(sourcemap);
-      }
+      if (!urlInfo.sourcemapIsWrong) {
+        if (sourcemaps === "inline") {
+          sourcemapReference.generatedSpecifier = generateSourcemapDataUrl(sourcemap);
+        }
 
-      if (sourcemaps === "file" || sourcemaps === "inline") {
-        urlInfo.content = SOURCEMAP.writeComment({
-          contentType: urlInfo.contentType,
-          content: urlInfo.content,
-          specifier: sourcemaps === "file" && sourcemapsRelativeSources ? urlToRelativeUrl(sourcemapReference.url, urlInfo.url) : sourcemapReference.generatedSpecifier
-        });
+        if (sourcemaps === "file" || sourcemaps === "inline") {
+          urlInfo.content = SOURCEMAP.writeComment({
+            contentType: urlInfo.contentType,
+            content: urlInfo.content,
+            specifier: sourcemaps === "file" && sourcemapsRelativeSources ? urlToRelativeUrl(sourcemapReference.url, urlInfo.url) : sourcemapReference.generatedSpecifier
+          });
+        }
       }
     } else if (urlInfo.sourcemapReference) {
       // in the end we don't use the sourcemap placeholder

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "27.0.2",
+  "version": "27.0.3",
   "description": "Tool to develop, test and build js projects",
   "license": "MIT",
   "author": {
@@ -60,9 +60,9 @@
     "playwright": "1.x"
   },
   "dependencies": {
-    "@babel/plugin-proposal-dynamic-import": "7.16.7",
+    "@babel/plugin-proposal-dynamic-import": "7.18.6",
     "@babel/plugin-transform-modules-systemjs": "7.18.6",
-    "@babel/plugin-transform-modules-umd": "7.18.0",
+    "@babel/plugin-transform-modules-umd": "7.18.6",
     "@c88/v8-coverage": "0.1.1",
     "@financial-times/polyfill-useragent-normaliser": "2.0.1",
     "@jsenv/ast": "1.1.1",
@@ -96,9 +96,9 @@
   },
   "devDependencies": {
     "@babel/eslint-parser": "7.18.2",
-    "@babel/plugin-syntax-import-assertions": "7.17.12",
+    "@babel/plugin-syntax-import-assertions": "7.18.6",
     "@jsenv/assert": "2.6.0",
-    "@jsenv/eslint-config": "16.0.9",
+    "@jsenv/eslint-config": "16.1.0",
     "@jsenv/file-size-impact": "13.0.1",
     "@jsenv/https-local": "2.1.0",
     "@jsenv/package-workspace": "0.4.1",

package/src/omega/url_graph/url_info_transformations.js

@@ -117,7 +117,8 @@ export const createUrlInfoTransformer = ({
     if (!transformations) {
       return
     }
-    const { type, contentType, content, sourcemap } = transformations
+    const { type, contentType, content, sourcemap, sourcemapIsWrong } =
+      transformations
     if (type) {
       urlInfo.type = type
     }
@@ -138,6 +139,16 @@ export const createUrlInfoTransformer = ({
         finalSourcemap,
       )
       urlInfo.sourcemap = finalSourcemapNormalized
+      // A plugin is allowed to modify url content
+      // without returning a sourcemap
+      // This is the case for preact and react plugins.
+      // They are currently generating wrong source mappings
+      // when used.
+      // Generating the correct sourcemap in this situation
+      // is a nightmare no-one could solve in years so
+      // jsenv won't emit a warning and use the following strategy:
+      // "no sourcemap is better than wrong sourcemap"
+      urlInfo.sourcemapIsWrong = sourcemapIsWrong
     }
   }
 
@@ -162,19 +173,21 @@ export const createUrlInfoTransformer = ({
         })
       }
       sourcemapUrlInfo.content = JSON.stringify(sourcemap, null, "  ")
-      if (sourcemaps === "inline") {
-        sourcemapReference.generatedSpecifier =
-          generateSourcemapDataUrl(sourcemap)
-      }
-      if (sourcemaps === "file" || sourcemaps === "inline") {
-        urlInfo.content = SOURCEMAP.writeComment({
-          contentType: urlInfo.contentType,
-          content: urlInfo.content,
-          specifier:
-            sourcemaps === "file" && sourcemapsRelativeSources
-              ? urlToRelativeUrl(sourcemapReference.url, urlInfo.url)
-              : sourcemapReference.generatedSpecifier,
-        })
+      if (!urlInfo.sourcemapIsWrong) {
+        if (sourcemaps === "inline") {
+          sourcemapReference.generatedSpecifier =
+            generateSourcemapDataUrl(sourcemap)
+        }
+        if (sourcemaps === "file" || sourcemaps === "inline") {
+          urlInfo.content = SOURCEMAP.writeComment({
+            contentType: urlInfo.contentType,
+            content: urlInfo.content,
+            specifier:
+              sourcemaps === "file" && sourcemapsRelativeSources
+                ? urlToRelativeUrl(sourcemapReference.url, urlInfo.url)
+                : sourcemapReference.generatedSpecifier,
+          })
+        }
       }
     } else if (urlInfo.sourcemapReference) {
       // in the end we don't use the sourcemap placeholder

package/src/omega/url_graph.js

@@ -215,6 +215,7 @@ const createUrlInfo = (url) => {
 
     sourcemap: null,
     sourcemapReference: null,
+    sourcemapIsWrong: false,
     timing: {},
     headers: {},
   }