@jsenv/core 27.0.0-alpha.60 → 27.0.0-alpha.63

package/package.json

@@ -1,8 +1,13 @@
 {
   "name": "@jsenv/core",
-  "version": "27.0.0-alpha.60",
+  "version": "27.0.0-alpha.63",
   "description": "Tool to develop, test and build js projects",
   "license": "MIT",
+  "author": {
+    "name": "dmail",
+    "email": "dmaillard06@gmail.com",
+    "url": "https://twitter.com/damienmaillard"
+  },
   "repository": {
     "type": "git",
     "url": "https://github.com/jsenv/jsenv-core"
@@ -63,12 +68,12 @@
     "@jsenv/filesystem": "3.2.2",
     "@jsenv/importmap": "1.2.0",
     "@jsenv/integrity": "0.0.1",
-    "@jsenv/log": "1.5.2",
+    "@jsenv/log": "1.6.1",
     "@jsenv/logger": "4.0.1",
-    "@jsenv/node-esm-resolution": "0.0.6",
+    "@jsenv/node-esm-resolution": "0.0.7",
     "@jsenv/server": "12.6.2",
     "@jsenv/uneval": "1.6.0",
-    "@jsenv/utils": "1.7.5",
+    "@jsenv/utils": "1.7.7",
     "construct-style-sheets-polyfill": "3.1.0",
     "cssnano": "5.1.7",
     "cssnano-preset-default": "5.2.7",
@@ -93,9 +98,9 @@
     "@jsenv/assert": "2.5.4",
     "@jsenv/eslint-config": "16.0.9",
     "@jsenv/file-size-impact": "12.1.11",
-    "@jsenv/https-local": "1.0.8",
+    "@jsenv/https-local": "1.0.11",
     "@jsenv/importmap-node-module": "5.1.3",
-    "@jsenv/package-workspace": "0.1.1",
+    "@jsenv/package-workspace": "0.1.2",
     "@jsenv/performance-impact": "2.2.10",
     "@jsenv/pwa": "5.0.0",
     "eslint": "8.13.0",

package/src/build/build.js

@@ -17,9 +17,9 @@ import {
   registerDirectoryLifecycle,
 } from "@jsenv/filesystem"
 import { Abort, raceProcessTeardownEvents } from "@jsenv/abort"
-import { createLogger } from "@jsenv/logger"
+import { createLogger, loggerToLevels } from "@jsenv/logger"
 
-import { createTaskLog } from "@jsenv/utils/logs/task_log.js"
+import { createTaskLog } from "@jsenv/log"
 import {
   injectQueryParams,
   setUrlFilename,
@@ -109,8 +109,9 @@ export const build = async ({
   cooldownBetweenFileEvents,
   watch = false,
 
-  writeOnFileSystem = true,
   buildDirectoryClean = true,
+  writeOnFileSystem = true,
+  writeGeneratedFiles = false,
   baseUrl = "/",
   assetManifest = true,
   assetManifestFileRelativeUrl = "asset-manifest.json",
@@ -140,6 +141,7 @@ export const build = async ({
   const runBuild = async ({ signal, logLevel }) => {
     const logger = createLogger({ logLevel })
     const buildOperation = Abort.startOperation()
+    const infoLogsAreDisabled = !loggerToLevels(logger).info
     buildOperation.addAbortSignal(signal)
     const entryPointKeys = Object.keys(entryPoints)
     if (entryPointKeys.length === 1) {
@@ -151,7 +153,9 @@ build ${entryPointKeys.length} entry points`)
     }
 
     const rawGraph = createUrlGraph()
-    const prebuildTask = createTaskLog(logger, "prebuild")
+    const prebuildTask = createTaskLog("prebuild", {
+      disabled: infoLogsAreDisabled,
+    })
     let urlCount = 0
     const rawGraphKitchen = createKitchen({
       signal,
@@ -161,6 +165,7 @@ build ${entryPointKeys.length} entry points`)
       scenario: "build",
       sourcemaps,
       runtimeCompat,
+      writeGeneratedFiles,
       plugins: [
         ...plugins,
         {
@@ -316,7 +321,9 @@ build ${entryPointKeys.length} entry points`)
       if (urlInfosToBundle.length === 0) {
         return
       }
-      const bundleTask = createTaskLog(logger, `bundle "${type}"`)
+      const bundleTask = createTaskLog(`bundle "${type}"`, {
+        disabled: infoLogsAreDisabled,
+      })
       try {
         const bundlerGeneratedUrlInfos =
           await rawGraphKitchen.pluginController.callAsyncHook(
@@ -378,6 +385,7 @@ build ${entryPointKeys.length} entry points`)
       sourcemaps,
       sourcemapsRelativeSources: !versioning,
       runtimeCompat,
+      writeGeneratedFiles,
       plugins: [
         jsenvPluginUrlAnalysis(),
         jsenvPluginAsJsClassic({
@@ -636,7 +644,7 @@ build ${entryPointKeys.length} entry points`)
         },
       ],
     })
-    const buildTask = createTaskLog(logger, "build")
+    const buildTask = createTaskLog("build", { disabled: infoLogsAreDisabled })
     const postBuildEntryUrls = []
     try {
       await loadUrlGraph({
@@ -670,6 +678,7 @@ ${Object.keys(finalGraph.urlInfos).join("\n")}`,
       await applyUrlVersioning({
         buildOperation,
         logger,
+        infoLogsAreDisabled,
         buildDirectoryUrl,
         rawUrls,
         buildUrls,
@@ -677,6 +686,7 @@ ${Object.keys(finalGraph.urlInfos).join("\n")}`,
         postBuildEntryUrls,
         sourcemaps,
         runtimeCompat,
+        writeGeneratedFiles,
         rawGraph,
         finalGraph,
         finalGraphKitchen,
@@ -802,11 +812,10 @@ ${Object.keys(finalGraph.urlInfos).join("\n")}`,
     resolveFirstBuild = resolve
     rejectFirstBuild = reject
   })
-  const watchLogger = createLogger({ logLevel: "info" })
   let buildAbortController
   let watchFilesTask
   const startBuild = async () => {
-    const buildTask = createTaskLog(watchLogger, "build")
+    const buildTask = createTaskLog("build")
     buildAbortController = new AbortController()
     try {
       const result = await runBuild({
@@ -815,14 +824,14 @@ ${Object.keys(finalGraph.urlInfos).join("\n")}`,
       })
       buildTask.done()
       resolveFirstBuild(result)
-      watchFilesTask = createTaskLog(watchLogger, "watch files")
+      watchFilesTask = createTaskLog("watch files")
     } catch (e) {
       if (Abort.isAbortError(e)) {
         buildTask.fail(`build aborted`)
       } else if (e.code === "PARSE_ERROR") {
         buildTask.fail()
-        watchLogger.error(e.stack)
-        watchFilesTask = createTaskLog(watchLogger, "watch files")
+        console.error(e.stack)
+        watchFilesTask = createTaskLog("watch files")
       } else {
         buildTask.fail()
         rejectFirstBuild(e)
@@ -871,6 +880,7 @@ ${Object.keys(finalGraph.urlInfos).join("\n")}`,
 const applyUrlVersioning = async ({
   buildOperation,
   logger,
+  infoLogsAreDisabled,
   buildDirectoryUrl,
   rawUrls,
   buildUrls,
@@ -878,13 +888,16 @@ const applyUrlVersioning = async ({
   postBuildEntryUrls,
   sourcemaps,
   runtimeCompat,
+  writeGeneratedFiles,
   rawGraph,
   finalGraph,
   finalGraphKitchen,
   lineBreakNormalization,
   versioningMethod,
 }) => {
-  const versioningTask = createTaskLog(logger, "inject version in urls")
+  const versioningTask = createTaskLog("inject version in urls", {
+    disabled: infoLogsAreDisabled,
+  })
   try {
     const urlsSorted = sortByDependencies(finalGraph.urlInfos)
     urlsSorted.forEach((url) => {
@@ -980,6 +993,7 @@ const applyUrlVersioning = async ({
       sourcemaps,
       sourcemapsRelativeSources: true,
       runtimeCompat,
+      writeGeneratedFiles,
       plugins: [
         jsenvPluginUrlAnalysis(),
         jsenvPluginInline({

package/src/build/start_build_server.js

@@ -13,6 +13,7 @@
  * we want to be in the user shoes and we should not alter build files.
  */
 
+import { parentPort } from "node:worker_threads"
 import {
   jsenvAccessControlAllowedHeaders,
   startServer,
@@ -25,10 +26,11 @@ import {
   assertAndNormalizeDirectoryUrl,
   registerDirectoryLifecycle,
 } from "@jsenv/filesystem"
-import { createLogger } from "@jsenv/logger"
+import { createLogger, loggerToLevels } from "@jsenv/logger"
 
+import { createTaskLog } from "@jsenv/log"
+import { getCallerPosition } from "@jsenv/utils/src/caller_position.js"
 import { initReloadableProcess } from "@jsenv/utils/process_reload/process_reload.js"
-import { createTaskLog } from "@jsenv/utils/logs/task_log.js"
 
 export const startBuildServer = async ({
   signal = new AbortController().signal,
@@ -45,14 +47,20 @@ export const startBuildServer = async ({
 
   rootDirectoryUrl,
   buildDirectoryUrl,
+  mainBuildFileUrl = "/index.html",
   buildServerFiles = {
     "./package.json": true,
     "./jsenv.config.mjs": true,
   },
-  buildServerMainFile,
-  buildServerAutoreload = false,
+  buildServerMainFile = getCallerPosition().url,
+  // force disable server autoreload when this code is executed:
+  // - inside a forked child process
+  // - inside a worker thread
+  // (because node cluster won't work)
+  buildServerAutoreload = typeof process.send !== "function" &&
+    !parentPort &&
+    !process.debugPort,
   cooldownBetweenFileEvents,
-  mainBuildFileUrl = "/index.html",
 }) => {
   const logger = createLogger({ logLevel })
   rootDirectoryUrl = assertAndNormalizeDirectoryUrl(rootDirectoryUrl)
@@ -114,7 +122,9 @@ export const startBuildServer = async ({
   }
   signal = reloadableProcess.signal
 
-  const startServerTask = createTaskLog(logger, "start build server")
+  const startBuildServerTask = createTaskLog("start build server", {
+    disabled: !loggerToLevels(logger).info,
+  })
   const server = await startServer({
     signal,
     stopOnExit: false,
@@ -174,7 +184,7 @@ export const startBuildServer = async ({
       )
     },
   })
-  startServerTask.done()
+  startBuildServerTask.done()
   logger.info(``)
   Object.keys(server.origins).forEach((key) => {
     logger.info(`- ${server.origins[key]}`)

package/src/dev/start_dev_server.js

@@ -1,11 +1,13 @@
+import { parentPort } from "node:worker_threads"
 import {
   assertAndNormalizeDirectoryUrl,
   registerDirectoryLifecycle,
 } from "@jsenv/filesystem"
-import { createLogger } from "@jsenv/logger"
+import { createLogger, loggerToLevels } from "@jsenv/logger"
 
+import { createTaskLog } from "@jsenv/log"
+import { getCallerPosition } from "@jsenv/utils/src/caller_position.js"
 import { initReloadableProcess } from "@jsenv/utils/process_reload/process_reload.js"
-import { createTaskLog } from "@jsenv/utils/logs/task_log.js"
 import { getCorePlugins } from "@jsenv/core/src/plugins/plugins.js"
 import { createUrlGraph } from "@jsenv/core/src/omega/url_graph.js"
 import { createKitchen } from "@jsenv/core/src/omega/kitchen.js"
@@ -33,8 +35,14 @@ export const startDevServer = async ({
     "./package.json": true,
     "./jsenv.config.mjs": true,
   },
-  devServerMainFile,
-  devServerAutoreload = false,
+  devServerMainFile = getCallerPosition().url,
+  // force disable server autoreload when this code is executed:
+  // - inside a forked child process
+  // - inside a worker thread
+  // (because node cluster won't work)
+  devServerAutoreload = typeof process.send !== "function" &&
+    !parentPort &&
+    !process.debugPort,
   clientFiles = {
     "./**": true,
     "./**/.*/": false, // any folder starting with a dot is ignored (includes .git,.jsenv for instance)
@@ -61,6 +69,7 @@ export const startDevServer = async ({
     },
   },
   toolbar = false,
+  writeGeneratedFiles = true,
 }) => {
   const logger = createLogger({ logLevel })
   rootDirectoryUrl = assertAndNormalizeDirectoryUrl(rootDirectoryUrl)
@@ -118,7 +127,9 @@ export const startDevServer = async ({
     }
   }
 
-  const startServerTask = createTaskLog(logger, "start server")
+  const startDevServerTask = createTaskLog("start dev server", {
+    disabled: !loggerToLevels(logger).info,
+  })
 
   const clientFileChangeCallbackList = []
   const clientFilesPruneCallbackList = []
@@ -154,6 +165,7 @@ export const startDevServer = async ({
     urlGraph,
     scenario: "dev",
     sourcemaps,
+    writeGeneratedFiles,
     plugins: [
       ...plugins,
       ...getCorePlugins({
@@ -190,7 +202,7 @@ export const startDevServer = async ({
     kitchen,
     scenario: "dev",
   })
-  startServerTask.done()
+  startDevServerTask.done()
   logger.info(``)
   Object.keys(server.origins).forEach((key) => {
     logger.info(`- ${server.origins[key]}`)

package/src/execute/execute.js

@@ -35,6 +35,7 @@ export const execute = async ({
   injectedGlobals,
   transpilation,
   htmlSupervisor = true,
+  writeGeneratedFiles = false,
 
   port,
   protocol,
@@ -74,6 +75,7 @@ export const execute = async ({
       urlGraph,
       scenario,
       sourcemaps,
+      writeGeneratedFiles,
       plugins: [
         ...plugins,
         ...getCorePlugins({

package/src/omega/kitchen.js

@@ -1,13 +1,12 @@
 import {
   urlIsInsideOf,
   writeFileSync,
-  isFileSystemPath,
-  fileSystemPathToUrl,
   moveUrl,
   ensureWindowsDriveLetter,
 } from "@jsenv/filesystem"
 import { createDetailedMessage } from "@jsenv/logger"
 
+import { getCallerPosition } from "@jsenv/utils/src/caller_position.js"
 import { stringifyUrlSite } from "@jsenv/utils/urls/url_trace.js"
 import { CONTENT_TYPE } from "@jsenv/utils/content_type/content_type.js"
 import { normalizeUrl, setUrlFilename } from "@jsenv/utils/urls/url_utils.js"
@@ -47,7 +46,7 @@ export const createKitchen = ({
   }[scenario],
   sourcemapsRelativeSources,
   runtimeCompat = defaultRuntimeCompat,
-  writeOnFileSystem = true,
+  writeGeneratedFiles,
 }) => {
   const pluginController = createPluginController({
     plugins,
@@ -504,21 +503,11 @@ export const createKitchen = ({
       },
       inject: ({ trace, ...rest }) => {
         if (trace === undefined) {
-          const { prepareStackTrace } = Error
-          Error.prepareStackTrace = (error, stack) => {
-            Error.prepareStackTrace = prepareStackTrace
-            return stack
-          }
-          const { stack } = new Error()
-          const callerCallsite = stack[1]
-          const fileName = callerCallsite.getFileName()
+          const { url, line, column } = getCallerPosition()
           trace = stringifyUrlSite({
-            url:
-              fileName && isFileSystemPath(fileName)
-                ? fileSystemPathToUrl(fileName)
-                : fileName,
-            line: callerCallsite.getLineNumber(),
-            column: callerCallsite.getColumnNumber(),
+            url,
+            line,
+            column,
           })
         }
         return addReference({
@@ -613,7 +602,7 @@ export const createKitchen = ({
     outDirectoryUrl = outDirectoryUrl ? String(outDirectoryUrl) : undefined
 
     const writeFiles = ({ gotError }) => {
-      if (!writeOnFileSystem || !outDirectoryUrl) {
+      if (!writeGeneratedFiles || !outDirectoryUrl) {
         return
       }
       const { generatedUrl } = urlInfo

package/src/omega/server/file_service.js

@@ -83,7 +83,10 @@ export const createFileService = ({
       await kitchen.cook({
         reference: referenceFromGraph || reference,
         urlInfo,
-        outDirectoryUrl: `${rootDirectoryUrl}.jsenv/${scenario}/${runtimeName}@${runtimeVersion}/`,
+        outDirectoryUrl:
+          scenario === "dev"
+            ? `${rootDirectoryUrl}.jsenv/${runtimeName}@${runtimeVersion}/`
+            : `${rootDirectoryUrl}.jsenv/${scenario}/${runtimeName}@${runtimeVersion}/`,
         clientRuntimeCompat: {
           [runtimeName]: runtimeVersion,
         },

package/src/omega/url_graph/url_graph_report.js

@@ -1,7 +1,4 @@
-import { ANSI } from "@jsenv/log"
-
-import { byteAsFileSize } from "@jsenv/utils/logs/size_log.js"
-import { distributeNumbers } from "@jsenv/utils/logs/number_distribution.js"
+import { ANSI, byteAsFileSize, distributePercentages } from "@jsenv/log"
 
 export const createUrlGraphSummary = (
   urlGraph,
@@ -96,11 +93,7 @@ const createUrlGraphReport = (urlGraph) => {
       sizesToDistribute[groupName] = sizeGroups[groupName]
     }
   })
-  const ratios = distributeNumbers(sizesToDistribute)
-  const percentageGroups = {}
-  Object.keys(ratios).forEach((groupName) => {
-    percentageGroups[groupName] = parseFloat(ratios[groupName]) * 100
-  })
+  const percentageGroups = distributePercentages(sizesToDistribute)
 
   return {
     // sourcemaps are special, there size are ignored

package/src/plugins/autoreload/dev_sse/client/event_source_client.js

@@ -26,13 +26,16 @@ const dequeue = async () => {
   const callbacks = pendingCallbacks.slice()
   pendingCallbacks = []
   running = true
-  await callbacks.reduce(async (previous, callback) => {
-    await previous
-    await callback()
-  }, Promise.resolve())
-  running = false
-  if (pendingCallbacks.length) {
-    dequeue()
+  try {
+    await callbacks.reduce(async (previous, callback) => {
+      await previous
+      await callback()
+    }, Promise.resolve())
+  } finally {
+    running = false
+    if (pendingCallbacks.length) {
+      dequeue()
+    }
   }
 }
 
@@ -93,11 +96,15 @@ const applyHotReload = async ({ hotInstructions }) => {
       // if (!urlHotMeta) {return }
 
       if (type === "prune") {
-        console.group(`[jsenv] prune: ${boundary} (inside ${acceptedBy})`)
+        console.groupCollapsed(
+          `[jsenv] prune: ${boundary} (inside ${acceptedBy})`,
+        )
       } else if (acceptedBy === boundary) {
-        console.group(`[jsenv] hot reloading: ${boundary}`)
+        console.groupCollapsed(`[jsenv] hot reloading: ${boundary}`)
       } else {
-        console.group(`[jsenv] hot reloading: ${acceptedBy} inside ${boundary}`)
+        console.groupCollapsed(
+          `[jsenv] hot reloading: ${acceptedBy} inside ${boundary}`,
+        )
       }
       if (urlHotMeta && urlHotMeta.disposeCallback) {
         console.log(`call dispose callback`)

package/src/plugins/autoreload/dev_sse/jsenv_plugin_dev_sse_server.js

@@ -113,7 +113,7 @@ export const jsenvPluginDevSSEServer = ({
     return iterate(firstUrlInfo, trace)
   }
   clientFileChangeCallbackList.push(({ url, event }) => {
-    const urlInfo = urlGraph.urlInfos[url]
+    const urlInfo = urlGraph.getUrlInfo(url)
     // file not part of dependency graph
     if (!urlInfo) {
       return

package/src/plugins/cache_control/jsenv_plugin_cache_control.js

@@ -6,7 +6,7 @@ export const jsenvPluginCacheControl = () => {
       test: true,
     },
     augmentResponse: ({ reference }, context) => {
-      if (context.scenario === "dev") {
+      if (context.scenario === "test") {
         // During dev, all files are put into browser cache for 1 hour because:
         // 1: Browser cache is a temporary directory created by playwright
         // 2: We assume source files won't be modified while tests are running

package/src/plugins/commonjs_globals/jsenv_plugin_commonjs_globals.js

@@ -22,7 +22,7 @@ export const jsenvPluginCommonJsGlobals = () => {
     const isJsModule = urlInfo.type === "js_module"
     const replaceMap = {
       "process.env.NODE_ENV": `("${
-        scenario === "dev" || scenario === "test" ? "dev" : "prod"
+        scenario === "dev" || scenario === "test" ? "development" : "production"
       }")`,
       "global": "globalThis",
       "__filename": isJsModule

package/src/plugins/import_meta_hot/html_hot_dependencies.js

@@ -103,7 +103,7 @@ export const collectHotDataFromHtmlAst = (htmlAst) => {
   }
   iterate(htmlAst, {})
 
-  return { hotReferences }
+  return hotReferences
 }
 
 const nodeNamesWithHref = ["link", "a", "image", "use"]
@@ -125,7 +125,7 @@ const getNodeContext = (node) => {
 
 const htmlNodeCanHotReload = (node) => {
   if (node.nodeName === "link") {
-    const { isStylesheet, isRessourceHint } = parseLinkNode(node)
+    const { isStylesheet, isRessourceHint, rel } = parseLinkNode(node)
     if (isStylesheet) {
       // stylesheets can be hot replaced by default
       return true
@@ -135,6 +135,9 @@ const htmlNodeCanHotReload = (node) => {
       // but we won't do anything (if the ressource is deleted we should?)
       return true
     }
+    if (rel === "icon") {
+      return true
+    }
     return false
   }
   return [

package/src/plugins/import_meta_hot/jsenv_plugin_import_meta_hot.js

@@ -25,7 +25,7 @@ export const jsenvPluginImportMetaHot = ({ rootDirectoryUrl }) => {
           return
         }
         const htmlAst = parseHtmlString(htmlUrlInfo.content)
-        const { hotReferences } = collectHotDataFromHtmlAst(htmlAst)
+        const hotReferences = collectHotDataFromHtmlAst(htmlAst)
         htmlUrlInfo.data.hotDecline = false
         htmlUrlInfo.data.hotAcceptSelf = false
         htmlUrlInfo.data.hotAcceptDependencies = hotReferences.map(

package/src/test/execute_plan.js

@@ -65,6 +65,7 @@ export const executePlan = async (
     nodeEsmResolution,
     fileSystemMagicResolution,
     transpilation,
+    writeGeneratedFiles,
 
     protocol,
     privateKey,
@@ -134,7 +135,7 @@ export const executePlan = async (
         urlGraph,
         scenario,
         sourcemaps,
-        writeOnFileSystem: false,
+        writeGeneratedFiles,
         plugins: [
           ...plugins,
           ...getCorePlugins({
@@ -208,7 +209,13 @@ export const executePlan = async (
     const debugLogsEnabled = loggerToLevels(logger).debug
     const executionLogsEnabled = loggerToLevels(logger).info
     const executionSpinner =
-      !debugLogsEnabled && executionLogsEnabled && process.stdout.isTTY
+      !debugLogsEnabled &&
+      executionLogsEnabled &&
+      process.stdout.isTTY &&
+      // if there is an error during execution npm will mess up the output
+      // (happens when npm runs several command in a workspace)
+      // so we enable spinner only when !process.exitCode (no error so far)
+      !process.exitCode
 
     const startMs = Date.now()
     const report = {}

package/src/test/execute_test_plan.js

@@ -87,6 +87,7 @@ export const executeTestPlan = async ({
   injectedGlobals,
   nodeEsmResolution,
   fileSystemMagicResolution,
+  writeGeneratedFiles = false,
 
   protocol,
   privateKey,
@@ -173,6 +174,7 @@ export const executeTestPlan = async ({
     injectedGlobals,
     nodeEsmResolution,
     fileSystemMagicResolution,
+    writeGeneratedFiles,
 
     protocol,
     privateKey,

package/src/test/logs_file_execution.js

@@ -1,7 +1,4 @@
-import { ANSI, UNICODE } from "@jsenv/log"
-
-import { msAsDuration } from "@jsenv/utils/logs/duration_log.js"
-import { byteAsMemoryUsage } from "@jsenv/utils/logs/size_log.js"
+import { ANSI, UNICODE, msAsDuration, byteAsMemoryUsage } from "@jsenv/log"
 
 import { EXECUTION_COLORS } from "./execution_colors.js"