@jsenv/core 27.0.0-alpha.53 → 27.0.0-alpha.54

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "27.0.0-alpha.53",
+  "version": "27.0.0-alpha.54",
   "description": "Tool to develop, test and build js projects",
   "license": "MIT",
   "repository": {
@@ -68,7 +68,7 @@
     "@jsenv/node-esm-resolution": "0.0.6",
     "@jsenv/server": "12.6.2",
     "@jsenv/uneval": "1.6.0",
-    "@jsenv/utils": "1.7.2",
+    "@jsenv/utils": "1.7.3",
     "construct-style-sheets-polyfill": "3.1.0",
     "cssnano": "5.1.7",
     "cssnano-preset-default": "5.2.7",

package/src/build/build.js

@@ -22,6 +22,7 @@ import {
   injectQueryParams,
   setUrlFilename,
   asUrlUntilPathname,
+  normalizeUrl,
 } from "@jsenv/utils/urls/url_utils.js"
 import { createVersionGenerator } from "@jsenv/utils/versioning/version_generator.js"
 import { generateSourcemapUrl } from "@jsenv/utils/sourcemap/sourcemap_utils.js"
@@ -223,9 +224,16 @@ ${Object.keys(rawGraph.urlInfos).join("\n")}`,
     })
   })
   const addToBundlerIfAny = (rawUrlInfo) => {
-    // if (rawUrlInfo.dependencies.size === 0) {
-    //   return
-    // }
+    if (
+      // entry point must be given to the bundler (rollup)
+      // so that the bundler know it's an entry point, even if it has no dependency
+      // this way the bundler can share code properly and avoid inlining an entry point
+      // if it's used by an other entry point
+      !rawUrlInfo.data.isEntryPoint &&
+      rawUrlInfo.dependencies.size === 0
+    ) {
+      return
+    }
     const bundler = bundlers[rawUrlInfo.type]
     if (bundler) {
       bundler.urlInfos.push(rawUrlInfo)
@@ -253,6 +261,21 @@ ${Object.keys(rawGraph.urlInfos).join("\n")}`,
           }
           addToBundlerIfAny(dependencyUrlInfo)
         })
+        rawUrlInfo.references.forEach((reference) => {
+          if (
+            reference.isRessourceHint &&
+            reference.expectedType === "js_module"
+          ) {
+            const referencedUrlInfo = rawGraph.getUrlInfo(reference.url)
+            if (
+              referencedUrlInfo &&
+              // something else than the ressource hint is using this url
+              referencedUrlInfo.dependents.size > 0
+            ) {
+              addToBundlerIfAny(referencedUrlInfo)
+            }
+          }
+        })
         return
       }
     }
@@ -361,25 +384,10 @@ ${Object.keys(rawGraph.urlInfos).join("\n")}`,
           if (urlRedirectedByBundle) {
             return urlRedirectedByBundle
           }
-          const parentIsFromBundle = Boolean(
-            bundleUrlInfos[reference.parentUrl],
-          )
-          // urls inside css bundled by parcel
-          // contains url relative to the bundle file (which is considered inside build directory)
-          // if the file is not itself a bundle file it must be resolved against
-          // the original css url
-          if (
-            parentIsFromBundle &&
-            !bundleUrlInfos[url] &&
-            urlIsInsideOf(url, buildDirectoryUrl)
-          ) {
-            const parentRawUrl = rawUrls[reference.parentUrl]
-            url = new URL(reference.specifier, parentRawUrl).href
-          }
           const urlRedirected = rawUrlRedirections[url]
           return urlRedirected || url
         },
-        normalizeUrl: (reference) => {
+        redirectUrl: (reference) => {
           if (!reference.url.startsWith("file:")) {
             return null
           }
@@ -860,11 +868,13 @@ const applyUrlVersioning = async ({
       })
       urlInfo.data.version = versionGenerator.generate()
 
-      urlInfo.data.versionedUrl = injectVersionIntoBuildUrl({
-        buildUrl: urlInfo.url,
-        version: urlInfo.data.version,
-        versioningMethod,
-      })
+      urlInfo.data.versionedUrl = normalizeUrl(
+        injectVersionIntoBuildUrl({
+          buildUrl: urlInfo.url,
+          version: urlInfo.data.version,
+          versioningMethod,
+        }),
+      )
     })
     const versionMappings = {}
     const usedVersionMappings = []

package/src/execute/runtimes/browsers/from_playwright.js

@@ -280,6 +280,9 @@ export const createRuntimeFromPlaywright = ({
                 /* eslint-disable no-undef */
                 /* istanbul ignore next */
                 () => {
+                  if (!window.__html_supervisor__) {
+                    throw new Error(`window.__html_supervisor__ not found`)
+                  }
                   return window.__html_supervisor__.getScriptExecutionResults()
                 },
                 /* eslint-enable no-undef */

package/src/omega/kitchen.js

@@ -10,7 +10,7 @@ import { createDetailedMessage } from "@jsenv/logger"
 
 import { stringifyUrlSite } from "@jsenv/utils/urls/url_trace.js"
 import { CONTENT_TYPE } from "@jsenv/utils/content_type/content_type.js"
-import { setUrlFilename } from "@jsenv/utils/urls/url_utils.js"
+import { normalizeUrl, setUrlFilename } from "@jsenv/utils/urls/url_utils.js"
 
 import { createPluginController } from "../plugins/plugin_controller.js"
 import { createUrlInfoTransformer } from "./url_graph/url_info_transformations.js"
@@ -142,7 +142,7 @@ export const createKitchen = ({
   }
   const resolveReference = (reference) => {
     try {
-      const resolvedUrl = pluginController.callHooksUntil(
+      let resolvedUrl = pluginController.callHooksUntil(
         "resolveUrl",
         reference,
         baseContext,
@@ -150,6 +150,7 @@ export const createKitchen = ({
       if (!resolvedUrl) {
         throw new Error(`NO_RESOLVE`)
       }
+      resolvedUrl = normalizeUrl(resolvedUrl)
       reference.url = resolvedUrl
       if (reference.external) {
         reference.generatedUrl = resolvedUrl
@@ -157,35 +158,20 @@ export const createKitchen = ({
         return urlGraph.reuseOrCreateUrlInfo(reference.url)
       }
       pluginController.callHooks(
-        "normalizeUrl",
+        "redirectUrl",
         reference,
         baseContext,
         (returnValue) => {
-          if (returnValue === reference.url) {
-            return
-          }
-          const normalizedReturnValue = returnValue.startsWith("data:")
-            ? returnValue
-            : returnValue.replace(/[=](?=&|$)/g, "")
+          const normalizedReturnValue = normalizeUrl(returnValue)
           if (normalizedReturnValue === reference.url) {
             return
           }
           const previousReference = { ...reference }
-          reference.url = returnValue
+          reference.url = normalizedReturnValue
           mutateReference(previousReference, reference)
         },
       )
-      // force a last normalization on url search params
-      // some plugin use URLSearchParams to alter the url search params
-      // which can result into "file:///file.css?css_module"
-      // becoming "file:///file.css?css_module="
-      // we want to get rid of the "=" and consider it's the same url
-      if (
-        // disable on data urls (would mess up base64 encoding)
-        !reference.url.startsWith("data:")
-      ) {
-        reference.url = reference.url.replace(/[=](?=&|$)/g, "")
-      }
+
       const urlInfo = urlGraph.reuseOrCreateUrlInfo(reference.url)
       applyReferenceEffectsOnUrlInfo(reference, urlInfo, baseContext)
 
@@ -281,12 +267,13 @@ export const createKitchen = ({
       return
     }
     try {
-      const returnValue = await pluginController.callAsyncHooksUntil(
-        "fetchUrlContent",
-        urlInfo,
-        context,
-      )
-      if (!returnValue) {
+      const fetchUrlContentReturnValue =
+        await pluginController.callAsyncHooksUntil(
+          "fetchUrlContent",
+          urlInfo,
+          context,
+        )
+      if (!fetchUrlContentReturnValue) {
         logger.warn(
           createDetailedMessage(
             `no plugin has handled the url during "fetchUrlContent" hook -> consider url as external (ignore it)`,
@@ -299,7 +286,7 @@ export const createKitchen = ({
         urlInfo.external = true
         return
       }
-      if (returnValue.external) {
+      if (fetchUrlContentReturnValue.external) {
         urlInfo.external = true
         return
       }
@@ -312,7 +299,7 @@ export const createKitchen = ({
         content,
         sourcemap,
         filename,
-      } = returnValue
+      } = fetchUrlContentReturnValue
       urlInfo.type =
         type ||
         reference.expectedType ||

package/src/omega/url_graph/url_graph_load.js

@@ -6,7 +6,6 @@ export const loadUrlGraph = async ({
   startLoading,
   outDirectoryUrl,
   clientRuntimeCompat,
-  skipRessourceHint = false,
 }) => {
   if (outDirectoryUrl) {
     await ensureEmptyDirectory(outDirectoryUrl)
@@ -34,7 +33,11 @@ export const loadUrlGraph = async ({
     })
     const { references } = urlInfo
     references.forEach((reference) => {
-      if (skipRessourceHint && reference.isRessourceHint) {
+      // we don't cook ressource hints
+      // because they might refer to ressource that will be modified during build
+      // It also means something else have to reference that url in order to cook it
+      // so that the preload is deleted by "resync_ressource_hints.js" otherwise
+      if (reference.isRessourceHint) {
         return
       }
       // we use reference.generatedUrl to mimic what a browser would do:

package/src/plugins/autoreload/jsenv_plugin_hmr.js

@@ -2,7 +2,7 @@ export const jsenvPluginHmr = () => {
   return {
     name: "jsenv:hmr",
     appliesDuring: { dev: true },
-    normalizeUrl: (reference) => {
+    redirectUrl: (reference) => {
       const urlObject = new URL(reference.url)
       if (!urlObject.searchParams.has("hmr")) {
         reference.data.hmr = false

package/src/plugins/bundling/js_module/bundle_js_module.js

@@ -247,20 +247,9 @@ const rollupPluginJsenv = ({
         code: urlInfo.content,
         map: urlInfo.sourcemap
           ? sourcemapConverter.toFilePaths(urlInfo.sourcemap)
-          : urlInfo.sourcemap,
+          : null,
       }
     },
-    // resolveFileUrl: ({ moduleId }) => {
-    //   return `${fileUrlConverter.asFileUrl(moduleId)}`
-    // },
-    renderChunk: (code, chunkInfo) => {
-      const { facadeModuleId } = chunkInfo
-      if (!facadeModuleId) {
-        // happens for inline module scripts for instance
-        return null
-      }
-      return null
-    },
   }
 }
 

package/src/plugins/filesystem_magic/jsenv_plugin_filesystem_magic.js

@@ -13,7 +13,7 @@ export const jsenvPluginFileSystemMagic = ({
   return {
     name: "jsenv:filesystem_magic",
     appliesDuring: "*",
-    normalizeUrl: (reference) => {
+    redirectUrl: (reference) => {
       // http, https, data, about, etc
       if (!reference.url.startsWith("file:")) {
         return null

package/src/plugins/plugin_controller.js

@@ -5,7 +5,7 @@ export const createPluginController = ({
   scenario,
   hooks = [
     "resolveUrl",
-    "normalizeUrl",
+    "redirectUrl",
     "fetchUrlContent",
     "transformUrlContent",
     "transformUrlSearchParams",
@@ -226,7 +226,7 @@ const assertAndNormalizeReturnValue = (hookName, returnValue) => {
 const returnValueAssertions = [
   {
     name: "url_assertion",
-    appliesTo: ["resolveUrl", "normalizeUrl"],
+    appliesTo: ["resolveUrl", "redirectUrl"],
     assertion: (valueReturned) => {
       if (valueReturned instanceof URL) {
         return valueReturned.href

package/src/plugins/transpilation/as_js_classic/jsenv_plugin_as_js_classic.js

@@ -44,34 +44,42 @@ export const jsenvPluginAsJsClassic = ({ systemJsInjection }) => {
 }
 
 const asJsClassic = ({ systemJsInjection, systemJsClientFileUrl }) => {
+  const propagateJsClassicSearchParam = (reference, context) => {
+    const parentUrlInfo = context.urlGraph.getUrlInfo(reference.parentUrl)
+    if (
+      !parentUrlInfo ||
+      !new URL(parentUrlInfo.url).searchParams.has("as_js_classic")
+    ) {
+      return null
+    }
+    const urlTransformed = injectQueryParams(reference.url, {
+      as_js_classic: "",
+    })
+    reference.filename = generateJsClassicFilename(reference.url)
+    return urlTransformed
+  }
+
   return {
     name: "jsenv:as_js_classic",
     appliesDuring: "*",
     // forward ?as_js_classic to referenced urls
-    normalizeUrl: (reference, context) => {
-      // We want to propagate transformation of js module to js classic
-      // but only for import specifier (static/dynamic import + re-export)
-      // All other references won't get the ?as_js_classic
-      // otherwise we could try to transform inline ressources, specifiers inside new URL(). ...
-      if (
-        reference.type !== "js_import_export" &&
-        reference.subtype !== "system_register_arg" &&
-        reference.subtype !== "system_import_arg"
-      ) {
+    redirectUrl: {
+      // We want to propagate transformation of js module to js classic to:
+      // - import specifier (static/dynamic import + re-export)
+      // - url specifier when inside System.register/_context.import()
+      //   (because it's the transpiled equivalent of static and dynamic imports)
+      // And not other references otherwise we could try to transform inline ressources
+      // or specifiers inside new URL()...
+      js_import_export: propagateJsClassicSearchParam,
+      js_url_specifier: (reference, context) => {
+        if (
+          reference.subtype === "system_register_arg" ||
+          reference.subtype === "system_import_arg"
+        ) {
+          return propagateJsClassicSearchParam(reference, context)
+        }
         return null
-      }
-      const parentUrlInfo = context.urlGraph.getUrlInfo(reference.parentUrl)
-      if (
-        !parentUrlInfo ||
-        !new URL(parentUrlInfo.url).searchParams.has("as_js_classic")
-      ) {
-        return null
-      }
-      const urlTransformed = injectQueryParams(reference.url, {
-        as_js_classic: "",
-      })
-      reference.filename = generateJsClassicFilename(reference.url)
-      return urlTransformed
+      },
     },
     fetchUrlContent: async (urlInfo, context) => {
       const originalUrlInfo = await fetchOriginalUrlInfo({

package/src/plugins/transpilation/as_js_classic/jsenv_plugin_script_type_module_as_classic.js

@@ -98,7 +98,16 @@ export const jsenvPluginScriptTypeModuleAsClassic = ({
         })
 
         const jsModuleUrls = []
-        const getReferenceAsJsClassic = async (reference) => {
+        const getReferenceAsJsClassic = async (
+          reference,
+          {
+            // we don't cook ressource hints
+            // because they might refer to ressource that will be modified during build
+            // It also means something else HAVE to reference that url in order to cook it
+            // so that the preload is deleted by "resync_ressource_hints.js" otherwise
+            cookIt = false,
+          } = {},
+        ) => {
           const [newReference, newUrlInfo] = context.referenceUtils.update(
             reference,
             {
@@ -112,6 +121,8 @@ export const jsenvPluginScriptTypeModuleAsClassic = ({
           const jsModuleUrl = newUrlInfo.url
           if (!jsModuleUrls.includes(jsModuleUrl)) {
             jsModuleUrls.push(newUrlInfo.url)
+          }
+          if (cookIt) {
             // during dev it means js modules will be cooked before server sends the HTML
             // it's ok because:
             // - during dev script_type_module are supported (dev use a recent browser)
@@ -141,9 +152,9 @@ export const jsenvPluginScriptTypeModuleAsClassic = ({
           // but it's unlikely to happen and people should use "modulepreload" in that case anyway
           if (expectedScriptType === "module") {
             actions.push(async () => {
-              const [newReference] = await getReferenceAsJsClassic(
-                context.referenceUtils.findByGeneratedSpecifier(href),
-              )
+              const reference =
+                context.referenceUtils.findByGeneratedSpecifier(href)
+              const [newReference] = await getReferenceAsJsClassic(reference)
               assignHtmlNodeAttributes(preloadAsScriptNode, {
                 href: newReference.generatedSpecifier,
               })
@@ -158,9 +169,9 @@ export const jsenvPluginScriptTypeModuleAsClassic = ({
           )
           const href = hrefAttribute.value
           actions.push(async () => {
-            const [newReference] = await getReferenceAsJsClassic(
-              context.referenceUtils.findByGeneratedSpecifier(href),
-            )
+            const reference =
+              context.referenceUtils.findByGeneratedSpecifier(href)
+            const [newReference] = await getReferenceAsJsClassic(reference)
             assignHtmlNodeAttributes(modulePreloadNode, {
               rel: "preload",
               as: "script",
@@ -176,9 +187,11 @@ export const jsenvPluginScriptTypeModuleAsClassic = ({
           if (srcAttribute) {
             actions.push(async () => {
               const specifier = srcAttribute.value
-              const [newReference] = await getReferenceAsJsClassic(
-                context.referenceUtils.findByGeneratedSpecifier(specifier),
-              )
+              const reference =
+                context.referenceUtils.findByGeneratedSpecifier(specifier)
+              const [newReference] = await getReferenceAsJsClassic(reference, {
+                cookIt: true,
+              })
               removeHtmlNodeAttributeByName(moduleScriptNode, "type")
               srcAttribute.value = newReference.generatedSpecifier
             })
@@ -214,6 +227,7 @@ export const jsenvPluginScriptTypeModuleAsClassic = ({
             })
             const [, newUrlInfo] = await getReferenceAsJsClassic(
               inlineReference,
+              { cookIt: true },
             )
             removeHtmlNodeAttributeByName(moduleScriptNode, "type")
             setHtmlNodeGeneratedText(moduleScriptNode, {

package/src/plugins/transpilation/as_js_classic/jsenv_plugin_workers_type_module_as_classic.js

@@ -21,7 +21,7 @@ export const jsenvPluginWorkersTypeModuleAsClassic = ({
   return {
     name: "jsenv:workers_type_module_as_classic",
     appliesDuring: "*",
-    normalizeUrl: {
+    redirectUrl: {
       js_url_specifier: (reference, context) => {
         if (reference.expectedType !== "js_module") {
           return null

package/src/plugins/transpilation/import_assertions/jsenv_plugin_import_assertions.js

@@ -36,7 +36,7 @@ export const jsenvPluginImportAssertions = () => {
   const importAssertions = {
     name: "jsenv:import_assertions",
     appliesDuring: "*",
-    normalizeUrl: {
+    redirectUrl: {
       js_import_export: (reference, context) => {
         if (!reference.assert) {
           return null

package/src/plugins/url_analysis/html/html_urls.js

@@ -96,8 +96,8 @@ const visitHtmlUrls = ({ url, htmlAst, onUrl }) => {
       ...readFetchMetas(node),
     })
   }
-  const onNode = (node) => {
-    if (node.nodeName === "link") {
+  const visitors = {
+    link: (node) => {
       const relAttribute = getHtmlNodeAttributeByName(node, "rel")
       const rel = relAttribute ? relAttribute.value : undefined
       const typeAttribute = getHtmlNodeAttributeByName(node, "type")
@@ -114,13 +114,9 @@ const visitHtmlUrls = ({ url, htmlAst, onUrl }) => {
           stylesheet: "css",
         }[rel],
       })
-      return
-    }
-    // if (node.nodeName === "style") {
-    //   // styles.push(node)
-    //   return
-    // }
-    if (node.nodeName === "script") {
+    },
+    // style: () => {},
+    script: (node) => {
       const typeAttributeNode = getHtmlNodeAttributeByName(node, "type")
       visitAttributeAsUrlSpecifier({
         type: "script_src",
@@ -133,23 +129,22 @@ const visitHtmlUrls = ({ url, htmlAst, onUrl }) => {
         node,
         attributeName: "src",
       })
-      return
-    }
-    if (node.nodeName === "a") {
+    },
+    a: (node) => {
       visitAttributeAsUrlSpecifier({
         type: "a_href",
         node,
         attributeName: "href",
       })
-    }
-    if (node.nodeName === "iframe") {
+    },
+    iframe: (node) => {
       visitAttributeAsUrlSpecifier({
         type: "iframe_src",
         node,
         attributeName: "src",
       })
-    }
-    if (node.nodeName === "img") {
+    },
+    img: (node) => {
       visitAttributeAsUrlSpecifier({
         type: "img_src",
         node,
@@ -159,9 +154,8 @@ const visitHtmlUrls = ({ url, htmlAst, onUrl }) => {
         type: "img_srcset",
         node,
       })
-      return
-    }
-    if (node.nodeName === "source") {
+    },
+    souce: (node) => {
       visitAttributeAsUrlSpecifier({
         type: "source_src",
         node,
@@ -171,25 +165,22 @@ const visitHtmlUrls = ({ url, htmlAst, onUrl }) => {
         type: "source_srcset",
         node,
       })
-      return
-    }
+    },
     // svg <image> tag
-    if (node.nodeName === "image") {
+    image: (node) => {
       visitAttributeAsUrlSpecifier({
         type: "image_href",
         node,
         attributeName: "href",
       })
-      return
-    }
-    if (node.nodeName === "use") {
+    },
+    use: (node) => {
       visitAttributeAsUrlSpecifier({
         type: "use_href",
         node,
         attributeName: "href",
       })
-      return
-    }
+    },
   }
   const visitAttributeAsUrlSpecifier = ({
     type,
@@ -252,7 +243,12 @@ const visitHtmlUrls = ({ url, htmlAst, onUrl }) => {
       })
     }
   }
-  visitHtmlAst(htmlAst, onNode)
+  visitHtmlAst(htmlAst, (node) => {
+    const visitor = visitors[node.nodeName]
+    if (visitor) {
+      visitor(node)
+    }
+  })
 }
 
 const crossOriginCompatibleTagNames = ["script", "link", "img", "source"]

package/src/plugins/url_version/jsenv_plugin_url_version.js

@@ -2,7 +2,7 @@ export const jsenvPluginUrlVersion = ({ longTermCache = true } = {}) => {
   return {
     name: "jsenv:url_version",
     appliesDuring: "*", // maybe only during dev?
-    normalizeUrl: (reference) => {
+    redirectUrl: (reference) => {
       // "v" search param goal is to enable long-term cache
       // for server response headers
       // it is also used by hmr to bypass browser cache