@jsenv/core 25.1.1 → 25.2.0

package/src/internal/compiling/html_source_file_service.js

@@ -232,22 +232,23 @@ const transformHTMLSourceFile = async ({
     const { scripts } = parseHtmlAstRessources(htmlAst)
     scripts.forEach((script) => {
       const typeAttribute = getHtmlNodeAttributeByName(script, "type")
+      const type = typeAttribute ? typeAttribute.value : ""
       const srcAttribute = getHtmlNodeAttributeByName(script, "src")
-
-      // remote
-      if (typeAttribute && typeAttribute.value === "module" && srcAttribute) {
+      const src = srcAttribute ? srcAttribute.value : ""
+      if (type === "module" && src) {
         removeHtmlNodeAttribute(script, srcAttribute)
+        // Ideally jsenv should take into account eventual
+        // "integrity" and "crossorigin" attribute during "executeFileUsingDynamicImport"
         setHtmlNodeText(
           script,
           `window.__jsenv__.executeFileUsingDynamicImport(${JSON.stringify(
-            srcAttribute.value,
+            src,
           )})`,
         )
         return
       }
-      // inline
       const textNode = getHtmlNodeTextNode(script)
-      if (typeAttribute && typeAttribute.value === "module" && textNode) {
+      if (type === "module" && textNode) {
         const scriptId = getIdForInlineHtmlNode(script, scripts)
         const scriptSpecifier = `${urlToFilename(
           fileUrl,
@@ -274,7 +275,8 @@ const transformHTMLSourceFile = async ({
     projectDirectoryUrl,
   })
 
-  return stringifyHtmlAst(htmlAst)
+  const htmlTransformed = stringifyHtmlAst(htmlAst)
+  return htmlTransformed
 }
 
 const visitImportmapScripts = async ({
@@ -314,14 +316,12 @@ const visitImportmapScripts = async ({
           )
           return
         }
-
         const importMapContent = await importMapResponse.json()
         const importMapInlined = moveImportMap(
           importMapContent,
           importMapUrl,
           htmlFileUrl,
         )
-
         replaceHtmlNode(
           importmapScript,
           `<script type="importmap">${JSON.stringify(

package/src/internal/compiling/js-compilation-service/jsenvTransform.js

@@ -6,6 +6,7 @@ import {
   getMinimalBabelPluginMap,
   babelPluginsFromBabelPluginMap,
 } from "@jsenv/core/src/internal/compiling/babel_plugins.js"
+import { babelPluginProxyExternalImports } from "@jsenv/core/src/internal/compiling/babel_plugin_proxy_external_imports.js"
 import { babelPluginImportMetadata } from "@jsenv/core/src/internal/compiling/babel_plugin_import_metadata.js"
 
 import { ansiToHTML } from "./ansiToHTML.js"
@@ -15,9 +16,7 @@ import { babelPluginSystemJsPrepend } from "./babel_plugin_systemjs_prepend.js"
 import { filePathToBabelHelperName } from "./babelHelper.js"
 
 export const jsenvTransform = async ({
-  code,
-  map, // optional
-  ast, // optional
+  jsenvRemoteDirectory,
   url,
   relativeUrl, // optional
 
@@ -25,12 +24,15 @@ export const jsenvTransform = async ({
   moduleOutFormat,
   importMetaFormat = moduleOutFormat,
   topLevelAwait,
-
   babelHelpersInjectionAsImport,
   prependSystemJs,
   transformGenerator,
   regeneratorRuntimeImportPath,
+
   sourcemapEnabled,
+  ast, // optional
+  map, // optional
+  code,
 }) => {
   const transformModulesSystemJs = require("@babel/plugin-transform-modules-systemjs")
   const proposalDynamicImport = require("@babel/plugin-proposal-dynamic-import")
@@ -146,6 +148,14 @@ export const jsenvTransform = async ({
           ],
         }
       : {}),
+    ...(jsenvRemoteDirectory
+      ? {
+          "proxy-external-imports": [
+            babelPluginProxyExternalImports,
+            { jsenvRemoteDirectory },
+          ],
+        }
+      : {}),
     "import-metadata": [babelPluginImportMetadata],
   }
   if (moduleOutFormat === "systemjs") {

package/src/internal/compiling/js-compilation-service/transformJs.js

@@ -3,10 +3,9 @@ import { urlToRelativeUrl } from "@jsenv/filesystem"
 import { jsenvTransform } from "./jsenvTransform.js"
 
 export const transformJs = async ({
-  code,
-  map,
-  url,
   projectDirectoryUrl,
+  jsenvRemoteDirectory,
+  url,
 
   babelPluginMap,
   moduleOutFormat = "esmodule",
@@ -16,6 +15,9 @@ export const transformJs = async ({
   topLevelAwait,
   transformGenerator = true,
   sourcemapEnabled = true,
+
+  map,
+  code,
 }) => {
   if (typeof projectDirectoryUrl !== "string") {
     throw new TypeError(
@@ -40,12 +42,14 @@ export const transformJs = async ({
   }
 
   const transformResult = await jsenvTransform({
-    code,
-    map,
     url,
     relativeUrl: url.startsWith(projectDirectoryUrl)
       ? urlToRelativeUrl(url, projectDirectoryUrl)
       : undefined,
+    projectDirectoryUrl,
+    jsenvRemoteDirectory,
+    code,
+    map,
 
     babelPluginMap,
     moduleOutFormat,