@jsenv/core 24.5.3 → 24.5.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "24.5.3",
+  "version": "24.5.4",
   "description": "Tool to develop, test and build js projects",
   "license": "MIT",
   "repository": {

package/src/internal/building/asset_url_versioning.js

@@ -20,14 +20,31 @@ const fileNamePatternFromRessource = (ressource) => {
   }
 
   if (ressource.urlVersioningDisabled) {
-    if (ressource.isEntryPoint || ressource.isJsModule) {
-      return `[name][extname]`
+    if (canMoveToAssetsDirectory(ressource)) {
+      return assetFileNamePatternWithoutHash
     }
-    return assetFileNamePatternWithoutHash
+    return `[name][extname]`
   }
 
-  if (ressource.isEntryPoint || ressource.isJsModule) {
-    return `[name]-[hash][extname]`
+  if (canMoveToAssetsDirectory(ressource)) {
+    return assetFileNamePattern
   }
-  return assetFileNamePattern
+  return `[name]-[hash][extname]`
+}
+
+const canMoveToAssetsDirectory = (ressource) => {
+  if (ressource.isEntryPoint) {
+    return false
+  }
+  // in theory js module can be moved to assets directory
+  // but that needs to be tested
+  if (ressource.isJsModule) {
+    return false
+  }
+  // service worker MUST be at the root (same level than the HTML file)
+  // otherwise it might be registered for the scope "/assets/" instead of "/"
+  if (ressource.isServiceWorker) {
+    return false
+  }
+  return true
 }