@jsenv/core 23.8.7 → 23.8.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "23.8.7",
+  "version": "23.8.9",
   "description": "Tool to develop, test and build js projects",
   "license": "MIT",
   "repository": {
@@ -67,7 +67,7 @@
     "@c88/v8-coverage": "0.1.1",
     "@jsenv/abort": "4.1.1",
     "@jsenv/filesystem": "2.5.1",
-    "@jsenv/importmap": "1.1.0",
+    "@jsenv/importmap": "1.2.0",
     "@jsenv/log": "1.4.0",
     "@jsenv/logger": "4.0.1",
     "@jsenv/server": "10.0.11",
@@ -121,11 +121,11 @@
     "@babel/preset-env": "7.15.8",
     "@jsenv/assert": "2.3.2",
     "@jsenv/babel-preset": "./packages/jsenv-babel-preset",
-    "@jsenv/eslint-config": "16.0.8",
+    "@jsenv/eslint-config": "16.0.9",
     "@jsenv/github-release-package": "1.2.3",
-    "@jsenv/https-local": "1.0.2",
+    "@jsenv/https-local": "1.0.3",
     "@jsenv/importmap-eslint-resolver": "5.1.2",
-    "@jsenv/importmap-node-module": "2.4.1",
+    "@jsenv/importmap-node-module": "2.7.0",
     "@jsenv/package-publish": "1.6.2",
     "@jsenv/performance-impact": "2.2.1",
     "@jsenv/prettier-check-project": "5.6.1",

package/src/internal/{runtime/createBrowserRuntime → browser-launcher}/displayErrorInDocument.js

@@ -1,3 +1,5 @@
+/* eslint-env browser */
+
 export const displayErrorInDocument = (error) => {
   const title = "An error occured"
   let theme

package/src/internal/{runtime/createBrowserRuntime → browser-launcher}/displayErrorNotification.js

@@ -1,3 +1,4 @@
+/* eslint-env browser */
 const { Notification } = window
 
 const displayErrorNotificationNotAvailable = () => {}

package/src/internal/browser-launcher/executeHtmlFile.js

@@ -186,6 +186,14 @@ const executeSource = async ({
         coverage,
       }
     })
+  } else {
+    transformResult = composeTransformer(transformResult, (result) => {
+      const { namespace: fileExecutionResultMap } = result
+      Object.keys(fileExecutionResultMap).forEach((fileRelativeUrl) => {
+        delete fileExecutionResultMap[fileRelativeUrl].coverage
+      })
+      return result
+    })
   }
 
   const fileClientUrl = resolveUrl(fileRelativeUrl, `${compileServerOrigin}/`)

package/src/internal/browser-launcher/jsenv-browser-system.js

@@ -7,6 +7,9 @@ import { fetchUrl } from "../browser-utils/fetch-browser.js"
 import { fetchAndEvalUsingFetch } from "../browser-utils/fetchAndEvalUsingFetch.js"
 import { memoize } from "../memoize.js"
 
+import { displayErrorInDocument } from "./displayErrorInDocument.js"
+import { displayErrorNotification } from "./displayErrorNotification.js"
+
 const getNavigationStartTime = () => {
   try {
     return window.performance.timing.navigationStart
@@ -80,7 +83,7 @@ const executeFileUsingDynamicImport = async (
       performance.measure(`jsenv_file_import`, `jsenv_file_import_start`)
       const executionResult = {
         status: "errored",
-        exceptionSource: unevalException(e),
+        error: e,
         coverage: readCoverage(),
       }
       onExecutionError(executionResult, { currentScript })
@@ -114,16 +117,23 @@ const executeFileUsingSystemJs = (specifier) => {
   return fileExecutionResultPromise
 }
 
-const onExecutionError = (executionResult, { currentScript }) => {
-  // eslint-disable-next-line no-eval
-  const originalError = window.eval(executionResult.exceptionSource)
-  if (originalError.code === "NETWORK_FAILURE") {
+const onExecutionError = (
+  executionResult,
+  {
+    currentScript,
+    errorExposureInConsole = true,
+    errorExposureInNotification = false,
+    errorExposureInDocument = true,
+  },
+) => {
+  const error = executionResult.error
+  if (error.code === "NETWORK_FAILURE") {
     if (currentScript) {
       const errorEvent = new Event("error")
       currentScript.dispatchEvent(errorEvent)
     }
   } else {
-    const { parsingError } = originalError
+    const { parsingError } = error
     const globalErrorEvent = new Event("error")
     if (parsingError) {
       globalErrorEvent.filename = parsingError.filename
@@ -131,13 +141,26 @@ const onExecutionError = (executionResult, { currentScript }) => {
       globalErrorEvent.message = parsingError.message
       globalErrorEvent.colno = parsingError.columnNumber
     } else {
-      globalErrorEvent.filename = originalError.filename
-      globalErrorEvent.lineno = originalError.lineno
-      globalErrorEvent.message = originalError.message
-      globalErrorEvent.colno = originalError.columnno
+      globalErrorEvent.filename = error.filename
+      globalErrorEvent.lineno = error.lineno
+      globalErrorEvent.message = error.message
+      globalErrorEvent.colno = error.columnno
     }
     window.dispatchEvent(globalErrorEvent)
   }
+
+  if (errorExposureInConsole) {
+    console.error(error)
+  }
+  if (errorExposureInNotification) {
+    displayErrorNotification(error)
+  }
+  if (errorExposureInDocument) {
+    displayErrorInDocument(error)
+  }
+
+  executionResult.exceptionSource = unevalException(error)
+  delete executionResult.error
 }
 
 const getBrowserRuntime = memoize(async () => {

package/src/internal/runtime/createBrowserRuntime/createBrowserRuntime.js

@@ -1,6 +1,5 @@
 import { normalizeImportMap } from "@jsenv/importmap/src/normalizeImportMap.js"
 
-import { unevalException } from "../../unevalException.js"
 // do not use memoize from @jsenv/filesystem to avoid pulling @jsenv/filesystem code into the browser build
 import { memoize } from "../../memoize.js"
 import { fetchUrl } from "../../browser-utils/fetch-browser.js"
@@ -8,8 +7,6 @@ import { createImportResolverForImportmap } from "../../import-resolution/import
 import { measureAsyncFnPerf } from "../../perf_browser.js"
 
 import { createBrowserSystem } from "./createBrowserSystem.js"
-import { displayErrorInDocument } from "./displayErrorInDocument.js"
-import { displayErrorNotification } from "./displayErrorNotification.js"
 import { makeNamespaceTransferable } from "./makeNamespaceTransferable.js"
 
 const memoizedCreateBrowserSystem = memoize(createBrowserSystem)
@@ -86,9 +83,6 @@ export const createBrowserRuntime = async ({
     specifier,
     {
       transferableNamespace = false,
-      errorExposureInConsole = true,
-      errorExposureInNotification = false,
-      errorExposureInDocument = true,
       executionExposureOnWindow = false,
       errorTransform = (error) => error,
       measurePerformance,
@@ -122,19 +116,9 @@ export const createBrowserRuntime = async ({
           transformedError = error
         }
 
-        if (errorExposureInConsole) {
-          displayErrorInConsole(transformedError)
-        }
-        if (errorExposureInNotification) {
-          displayErrorNotification(transformedError)
-        }
-        if (errorExposureInDocument) {
-          displayErrorInDocument(transformedError)
-        }
-
         return {
           status: "errored",
-          exceptionSource: unevalException(transformedError),
+          error: transformedError,
           coverage: readCoverage(),
         }
       }
@@ -157,7 +141,3 @@ export const createBrowserRuntime = async ({
 }
 
 const readCoverage = () => window.__coverage__
-
-const displayErrorInConsole = (error) => {
-  console.error(error)
-}