@jsenv/core 22.0.1 → 22.0.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jsenv/core",
-  "version": "22.0.1",
+  "version": "22.0.3",
   "description": "Tool to develop, test and build js projects",
   "license": "MIT",
   "repository": {
@@ -57,10 +57,10 @@
     "@babel/helpers": "7.15.4",
     "@babel/parser": "7.15.7",
     "@babel/plugin-proposal-dynamic-import": "7.14.5",
-    "@babel/plugin-transform-modules-systemjs": "7.15.4",
     "@babel/plugin-syntax-dynamic-import": "7.8.3",
     "@babel/plugin-syntax-import-meta": "7.10.4",
     "@babel/plugin-syntax-numeric-separator": "7.10.4",
+    "@babel/plugin-transform-modules-systemjs": "7.15.4",
     "@c88/v8-coverage": "0.1.1",
     "@jsenv/cancellation": "3.0.0",
     "@jsenv/filesystem": "2.2.0",
@@ -69,11 +69,11 @@
     "@jsenv/node-signals": "2.0.1",
     "@jsenv/server": "7.2.0",
     "@jsenv/uneval": "1.6.0",
-    "@rollup/plugin-commonjs": "20.0.0",
+    "@rollup/plugin-commonjs": "21.0.0",
     "@rollup/plugin-json": "4.1.0",
     "@rollup/plugin-node-resolve": "13.0.5",
     "@rollup/plugin-replace": "3.0.0",
-    "ansi-to-html": "0.7.1",
+    "ansi-to-html": "0.7.2",
     "babel-plugin-transform-async-to-promises": "0.8.15",
     "bytes": "3.1.0",
     "cjs-module-lexer": "1.2.2",
@@ -92,13 +92,14 @@
     "magic-string": "0.25.7",
     "parse5": "6.0.1",
     "playwright": "1.15.1",
-    "postcss": "8.3.8",
+    "postcss": "8.3.9",
     "postcss-value-parser": "4.1.0",
     "regenerator-runtime": "0.13.9",
     "resolve": "1.20.0",
-    "rollup": "2.57.0",
+    "rollup": "2.58.0",
     "rollup-plugin-node-builtins-brofs": "2.1.3",
     "rollup-plugin-node-globals": "1.4.0",
+    "rollup-plugin-polyfill-node": "0.7.0",
     "source-map": "0.7.3",
     "string-width": "5.0.1",
     "supports-color": "9.0.2",
@@ -134,22 +135,22 @@
     "@babel/plugin-transform-new-target": "7.14.5",
     "@babel/plugin-transform-object-super": "7.14.5",
     "@babel/plugin-transform-parameters": "7.15.4",
+    "@babel/plugin-transform-react-jsx": "7.14.9",
     "@babel/plugin-transform-regenerator": "7.14.5",
     "@babel/plugin-transform-shorthand-properties": "7.14.5",
     "@babel/plugin-transform-spread": "7.14.6",
     "@babel/plugin-transform-sticky-regex": "7.14.5",
     "@babel/plugin-transform-template-literals": "7.14.5",
     "@babel/plugin-transform-typeof-symbol": "7.14.5",
-    "@babel/plugin-transform-unicode-regex": "7.14.5",
-    "@babel/plugin-transform-react-jsx": "7.14.9",
     "@babel/plugin-transform-typescript": "7.15.4",
+    "@babel/plugin-transform-unicode-regex": "7.14.5",
     "@babel/preset-env": "7.15.6",
     "@jsenv/assert": "2.3.1",
     "@jsenv/codecov-upload": "3.5.0",
-    "@jsenv/eslint-config": "16.0.4",
+    "@jsenv/eslint-config": "16.0.6",
     "@jsenv/github-release-package": "1.2.3",
     "@jsenv/importmap-eslint-resolver": "5.1.2",
-    "@jsenv/importmap-node-module": "2.2.1",
+    "@jsenv/importmap-node-module": "2.3.1",
     "@jsenv/package-publish": "1.6.2",
     "@jsenv/performance-impact": "1.7.0",
     "@jsenv/prettier-check-project": "5.6.1",

package/readme.md

@@ -330,23 +330,66 @@ npm install --save-dev @jsenv/core
 
 Jsenv can execute standard JavaScript and be configured to run non-standard JavaScript.
 
-Standard corresponds to [JavaScript Modules](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules), destructuring, optional chaining and so on.
+_non-standard JavaScript examples:_
 
-Non-standard corresponds to [CommonJS modules](https://code-trotter.com/web/understand-the-different-javascript-modules-formats/#commonjs-cjs) and [JSX](https://reactjs.org/docs/introducing-jsx.html).
+- [CommonJS modules](https://code-trotter.com/web/understand-the-different-javascript-modules-formats/#commonjs-cjs)
+- [JSX](https://reactjs.org/docs/introducing-jsx.html)
 
 > Keep in mind one of your dependency may use non-standard JavaScript. For instance react uses CommonJS modules.
 
 ## jsenv.config.mjs
 
-We recommend to regroup configuration in a _jsenv.config.mjs_ file at the root of your working directory.
-
-To get a better idea see [jsenv.config.js](./jsenv.config.js). The file can be imported and passed using the spread operator. This technic helps to see jsenv custom configuration quickly and share it between files.
+Jsenv codebase regroups configuration in a top level [jsenv.config.mjs](./jsenv.config.js) file.
+The file is meant to be imported and passed using the spread operator.
 
 ![screenshot about jsenv config import and spread operator](./docs/jsenv-config-spread.png)
 
 — See [script/test/test.js](https://github.com/jsenv/jsenv-core/blob/e44e362241e8e2142010322cb4552983b3bc9744/script/test/test.js#L2)
 
-That being said it's only a recommendation. There is nothing enforcing or checking the presence of _jsenv.config.mjs_.
+This technic helps to see jsenv custom configuration quickly and share it between files. That being said you are free to organize your configuration as you want.
+
+## babel.config.cjs
+
+When code needs to be transformed, the project must contain a [babel config file](https://babeljs.io/docs/en/config-files).
+
+There is 2 scenarios where it happens:
+
+- Code needs to be compatible with old browsers
+- Code is not standard (jsx for instance)
+
+In that case, it's recommended to use the following babel plugins declared in `babel.config.cjs`
+
+```js
+/*
+ * This file is used to configure a list of babel plugins as documented in
+ * https://babeljs.io/docs/en/config-files
+ *
+ * During dev: babel plugins natively supported by browsers and Node.js are not used.
+ * During build:
+ *  - When "runtimeSupport" is configured, babel plugins already supported by these runtime won't be used
+ *  See https://github.com/jsenv/jsenv-template-pwa/blob/main/jsenv.config.mjs#L12
+ *  - Otherwise all babel plugins are use
+ *
+ */
+
+// "@babel/preset-env" transforms async function to generators
+// but it's verbose and slow compared to using promises, so we:
+// 1. Exclude "transform-async-to-generator", "transform-regenerator"
+// 2. Enable "babel-plugin-transform-async-to-promises"
+// See https://github.com/babel/babel/issues/8121
+module.exports = {
+  presets: [
+    [
+      "@babel/preset-env",
+      {
+        modules: false,
+        exclude: ["transform-async-to-generator", "transform-regenerator"],
+      },
+    ],
+  ],
+  plugins: ["babel-plugin-transform-async-to-promises"],
+}
+```
 
 ## CommonJS
 

package/src/commonJsToJavaScriptModule.js

@@ -1,7 +1,5 @@
-/* eslint-disable import/max-dependencies */
 import { urlToFileSystemPath, resolveUrl } from "@jsenv/filesystem"
 
-import { require } from "@jsenv/core/src/internal/require.js"
 import { transformResultToCompilationResult } from "@jsenv/core/src/internal/compiling/transformResultToCompilationResult.js"
 import { rollupPluginCommonJsNamedExports } from "@jsenv/core/src/internal/compiling/rollup_plugin_commonjs_named_exports.js"
 
@@ -44,6 +42,7 @@ export const commonJsToJavaScriptModule = async ({
       "main",
     ],
     extensions: [".mjs", ".cjs", ".js", ".json"],
+    preferBuiltins: false,
     exportConditions: [],
   })
 
@@ -97,8 +96,9 @@ export const commonJsToJavaScriptModule = async ({
     logger,
   })
 
-  const builtins = require("rollup-plugin-node-builtins-brofs")
-  const nodeBuiltinsRollupPlugin = builtins()
+  const { default: rollupPluginNodePolyfills } = await import(
+    "rollup-plugin-polyfill-node"
+  )
 
   const { rollup } = await import("rollup")
   const rollupBuild = await rollup({
@@ -112,8 +112,33 @@ export const commonJsToJavaScriptModule = async ({
       commonJsRollupPlugin,
       commonJsNamedExportsRollupPlugin,
       nodeGlobalRollupPlugin,
-      ...(convertBuiltinsToBrowser ? [nodeBuiltinsRollupPlugin] : []),
+      ...(convertBuiltinsToBrowser
+        ? [
+            rollupPluginNodePolyfills({
+              include: null,
+            }),
+          ]
+        : []),
     ],
+    onwarn: (warning) => {
+      const { loc, message } = warning
+      const logMessage = loc
+        ? `${loc.file}:${loc.line}:${loc.column} ${message}`
+        : message
+
+      // These warnings are usually harmless in packages, so don't show them by default
+      if (
+        warning.code === "CIRCULAR_DEPENDENCY" ||
+        warning.code === "NAMESPACE_CONFLICT" ||
+        warning.code === "THIS_IS_UNDEFINED" ||
+        warning.code === "EMPTY_BUNDLE" ||
+        warning.code === "UNUSED_EXTERNAL_IMPORT"
+      ) {
+        logger.debug(logMessage)
+      } else {
+        logger.warn(logMessage)
+      }
+    },
   })
 
   const generateOptions = {

package/src/internal/compiling/babel_plugins.js

@@ -1,5 +1,14 @@
 import { require } from "@jsenv/core/src/internal/require.js"
 
+export const babelPluginNamesToRemoveFromBest = [
+  "proposal-private-property-in-object",
+  "proposal-logical-assignment-operators",
+  "proposal-export-namespace-from",
+  "proposal-class-properties",
+  "proposal-private-methods",
+  "transform-named-capturing-groups-regex",
+]
+
 export const getMinimalBabelPluginMap = () => {
   const syntaxDynamicImport = require("@babel/plugin-syntax-dynamic-import")
   const syntaxImportMeta = require("@babel/plugin-syntax-import-meta")

package/src/internal/compiling/startCompileServer.js

@@ -29,7 +29,10 @@ import {
 } from "@jsenv/filesystem"
 
 import { loadBabelPluginMapFromFile } from "./load_babel_plugin_map_from_file.js"
-import { extractSyntaxBabelPluginMap } from "./babel_plugins.js"
+import {
+  extractSyntaxBabelPluginMap,
+  babelPluginNamesToRemoveFromBest,
+} from "./babel_plugins.js"
 import { generateGroupMap } from "../generateGroupMap/generateGroupMap.js"
 import { createCallbackList } from "../createCallbackList.js"
 import {
@@ -165,6 +168,22 @@ export const startCompileServer = async ({
     runtimeSupport,
   })
 
+  const { best } = compileServerGroupMap
+  if (best) {
+    // here it's just that @babel/preset-env is a bit aggressive in the list of babel plugins
+    // that it enables
+    // we don't want to end up transforming code that could run without any compile step
+    // ideally we should maintain our own babel preset list
+    // (would just be the jsenvBabelPluginMap)
+    // so that we have the correct list of babel plugins
+    // and we are not forced to remove some of them
+    // we should also fix the node system not working anymore
+    best.babelPluginRequiredNameArray =
+      best.babelPluginRequiredNameArray.filter((babelPluginName) => {
+        return !babelPluginNamesToRemoveFromBest.includes(babelPluginName)
+      })
+  }
+
   babelPluginMap = {
     "transform-replace-expressions": [
       babelPluginReplaceExpressions,