@jscad/modeling 2.9.4 → 2.10.0

package/src/maths/mat4/isOnlyTransformScale.test.js

@@ -1,9 +1,11 @@
 const test = require('ava')
 
+const { TAU } = require('../constants')
+
 const { isOnlyTransformScale, create, fromTranslation, fromTaitBryanRotation, fromScaling, invert, multiply } = require('./index')
 
 test('mat4: isOnlyTransformScale() should return true for right angles', (t) => {
-  let someRotation = fromTaitBryanRotation(create(), Math.PI, 0, 0)
+  let someRotation = fromTaitBryanRotation(create(), TAU / 2, 0, 0)
   t.true(isOnlyTransformScale(someRotation))
   t.true(isOnlyTransformScale(invert(create(), someRotation)))
 

package/src/maths/mat4/rotate.js

@@ -1,3 +1,7 @@
+const { EPS } = require('../constants')
+
+const { sin, cos } = require('../utils/trigonometry')
+
 const copy = require('./copy')
 
 /**
@@ -12,20 +16,20 @@ const copy = require('./copy')
  */
 const rotate = (out, matrix, radians, axis) => {
   let [x, y, z] = axis
-  let len = Math.hypot(x, y, z)
+  const lengthSquared = x * x + y * y + z * z
 
-  if (Math.abs(len) < 0.000001) {
+  if (Math.abs(lengthSquared) < EPS) {
     // axis is 0,0,0 or almost
     return copy(out, matrix)
   }
 
-  len = 1 / len
+  const len = 1 / Math.sqrt(lengthSquared)
   x *= len
   y *= len
   z *= len
 
-  const s = Math.sin(radians)
-  const c = Math.cos(radians)
+  const s = sin(radians)
+  const c = cos(radians)
   const t = 1 - c
 
   const a00 = matrix[0]

package/src/maths/mat4/rotateX.js

@@ -1,3 +1,5 @@
+const { sin, cos } = require('../utils/trigonometry')
+
 /**
  * Rotates a matrix by the given angle around the X axis.
  *
@@ -8,8 +10,8 @@
  * @alias module:modeling/maths/mat4.rotateX
  */
 const rotateX = (out, matrix, radians) => {
-  const s = Math.sin(radians)
-  const c = Math.cos(radians)
+  const s = sin(radians)
+  const c = cos(radians)
   const a10 = matrix[4]
   const a11 = matrix[5]
   const a12 = matrix[6]

package/src/maths/mat4/rotateY.js

@@ -1,3 +1,5 @@
+const { sin, cos } = require('../utils/trigonometry')
+
 /**
  * Rotates a matrix by the given angle around the Y axis.
  *
@@ -8,8 +10,8 @@
  * @alias module:modeling/maths/mat4.rotateY
  */
 const rotateY = (out, matrix, radians) => {
-  const s = Math.sin(radians)
-  const c = Math.cos(radians)
+  const s = sin(radians)
+  const c = cos(radians)
   const a00 = matrix[0]
   const a01 = matrix[1]
   const a02 = matrix[2]

package/src/maths/mat4/rotateZ.js

@@ -1,3 +1,5 @@
+const { sin, cos } = require('../utils/trigonometry')
+
 /**
  * Rotates a matrix by the given angle around the Z axis.
  *
@@ -8,8 +10,8 @@
  * @alias module:modeling/maths/mat4.rotateZ
  */
 const rotateZ = (out, matrix, radians) => {
-  const s = Math.sin(radians)
-  const c = Math.cos(radians)
+  const s = sin(radians)
+  const c = cos(radians)
   const a00 = matrix[0]
   const a01 = matrix[1]
   const a02 = matrix[2]

package/src/maths/mat4/translate.test.js

@@ -52,10 +52,9 @@ test('mat4: translate() called with three parameters should update a mat4 with c
   t.true(compareVectors(obs4, [1, 0, 0, 0, 0, 3, 0, 0, 0, 0, 5, 0, 2, 9, 30, 1]))
   t.true(compareVectors(ret4, [1, 0, 0, 0, 0, 3, 0, 0, 0, 0, 5, 0, 2, 9, 30, 1]))
 
-  const r = (90 * 0.017453292519943295)
   const rotateZMatrix = [
-    Math.cos(r), -Math.sin(r), 0, 0,
-    Math.sin(r), Math.cos(r), 0, 0,
+    0, -1, 0, 0,
+    1, 0, 0, 0,
     0, 0, 1, 0,
     0, 0, 0, 1
   ]

package/src/maths/rotation.test.js

@@ -2,15 +2,18 @@ const test = require('ava')
 
 const { compareVectors } = require('../../test/helpers/index')
 
-const { mat4, vec2, vec3 } = require('./index')
+const { constants, mat4, vec2, vec3 } = require('./index')
 
 // ALL POSITIVE ROTATIONS ARE CLOCKWISE
 // see https://webglfundamentals.org/webgl/lessons/webgl-3d-orthographic.html
 // IN A LEFT-HANDED COORDINATE SYSTEM
 
+// JSCAD IS RIGHT-HANDED COORDINATE SYSTEM
+// WHERE POSITIVE ROTATIONS ARE COUNTER-CLOCKWISE
+
 // identity matrices for comparisons
 
-const rad90 = Math.PI / 2
+const rad90 = constants.TAU / 4
 
 // +90 degree rotation about X
 const cwX90Matrix = [

package/src/maths/utils/index.d.ts

@@ -3,5 +3,6 @@ export { default as area } from './area'
 export { default as interpolateBetween2DPointsForY } from './interpolateBetween2DPointsForY'
 export { default as intersect } from './intersect'
 export { default as solve2Linear } from './solve2Linear'
+export { sin, cos } from './trigonometry'
 
 export as namespace utils

package/src/maths/utils/index.js

@@ -7,7 +7,9 @@
 module.exports = {
   aboutEqualNormals: require('./aboutEqualNormals'),
   area: require('./area'),
+  cos: require('./trigonometry').cos,
   interpolateBetween2DPointsForY: require('./interpolateBetween2DPointsForY'),
   intersect: require('./intersect'),
+  sin: require('./trigonometry').sin,
   solve2Linear: require('./solve2Linear')
 }

package/src/{utils → maths/utils}/trigonometry.js

@@ -1,4 +1,4 @@
-const { NEPS } = require('../maths/constants')
+const { NEPS } = require('../constants')
 
 /*
  * Returns zero if n is within epsilon of zero, otherwise return n
@@ -6,28 +6,28 @@ const { NEPS } = require('../maths/constants')
 const rezero = (n) => Math.abs(n) < NEPS ? 0 : n
 
 /**
- * Return Math.sin but accurate for 90 degree rotations.
+ * Return Math.sin but accurate for TAU / 4 rotations.
  * Fixes rounding errors when sin should be 0.
  *
  * @param {Number} radians - angle in radians
  * @returns {Number} sine of the given angle
  * @alias module:modeling/utils.sin
  * @example
- * sin(Math.PI) == 0
- * sin(2 * Math.PI) == 0
+ * sin(TAU / 2) == 0
+ * sin(TAU) == 0
  */
 const sin = (radians) => rezero(Math.sin(radians))
 
 /**
- * Return Math.cos but accurate for 90 degree rotations.
+ * Return Math.cos but accurate for TAU / 4 rotations.
  * Fixes rounding errors when cos should be 0.
  *
  * @param {Number} radians - angle in radians
  * @returns {Number} cosine of the given angle
  * @alias module:modeling/utils.cos
  * @example
- * cos(0.5 * Math.PI) == 0
- * cos(1.5 * Math.PI) == 0
+ * cos(TAU * 0.25) == 0
+ * cos(TAU * 0.75) == 0
  */
 const cos = (radians) => rezero(Math.cos(radians))
 

package/src/{utils → maths/utils}/trigonometry.test.js

@@ -1,14 +1,16 @@
 const test = require('ava')
 
+const { TAU } = require('../constants')
+
 const { cos, sin } = require('./trigonometry')
 
 test('utils: sin() should return rounded values', (t) => {
   t.is(sin(0), 0)
   t.is(sin(9), Math.sin(9))
-  t.is(sin(0.5 * Math.PI), 1)
-  t.is(sin(1.0 * Math.PI), 0)
-  t.is(sin(1.5 * Math.PI), -1)
-  t.is(sin(2.0 * Math.PI), 0)
+  t.is(sin(0.25 * TAU), 1)
+  t.is(sin(0.5 * TAU), 0)
+  t.is(sin(0.75 * TAU), -1)
+  t.is(sin(TAU), 0)
   t.is(sin(NaN), NaN)
   t.is(sin(Infinity), NaN)
 })
@@ -16,10 +18,10 @@ test('utils: sin() should return rounded values', (t) => {
 test('utils: cos() should return rounded values', (t) => {
   t.is(cos(0), 1)
   t.is(cos(9), Math.cos(9))
-  t.is(cos(0.5 * Math.PI), 0)
-  t.is(cos(1.0 * Math.PI), -1)
-  t.is(cos(1.5 * Math.PI), 0)
-  t.is(cos(2.0 * Math.PI), 1)
+  t.is(cos(0.25 * TAU), 0)
+  t.is(cos(0.5 * TAU), -1)
+  t.is(cos(0.75 * TAU), 0)
+  t.is(cos(TAU), 1)
   t.is(cos(NaN), NaN)
   t.is(cos(Infinity), NaN)
 })

package/src/maths/vec2/distance.js

@@ -9,7 +9,7 @@
 const distance = (a, b) => {
   const x = b[0] - a[0]
   const y = b[1] - a[1]
-  return Math.hypot(x, y)
+  return Math.sqrt(x * x + y * y)
 }
 
 module.exports = distance

package/src/maths/vec2/fromAngleDegrees.js

@@ -8,6 +8,6 @@ const fromAngleRadians = require('./fromAngleRadians')
  * @returns {vec2} out
  * @alias module:modeling/maths/vec2.fromAngleDegrees
  */
-const fromAngleDegrees = (out, degrees) => fromAngleRadians(out, Math.PI * degrees / 180)
+const fromAngleDegrees = (out, degrees) => fromAngleRadians(out, degrees * 0.017453292519943295)
 
 module.exports = fromAngleDegrees

package/src/maths/vec2/fromAngleRadians.js

@@ -1,3 +1,5 @@
+const { sin, cos } = require('../utils/trigonometry')
+
 /**
  * Create a new vector in the direction of the given angle.
  *
@@ -7,8 +9,8 @@
  * @alias module:modeling/maths/vec2.fromAngleRadians
  */
 const fromAngleRadians = (out, radians) => {
-  out[0] = Math.cos(radians)
-  out[1] = Math.sin(radians)
+  out[0] = cos(radians)
+  out[1] = sin(radians)
   return out
 }
 

package/src/maths/vec2/fromAngleRadians.test.js

@@ -1,4 +1,7 @@
 const test = require('ava')
+
+const { TAU } = require('../constants')
+
 const { fromAngleRadians, create } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
@@ -7,6 +10,6 @@ test('vec2: fromAngleRadians() should return a new vec2 with correct values', (t
   const obs1 = fromAngleRadians(create(), 0)
   t.true(compareVectors(obs1, [1.0, 0.0]))
 
-  const obs2 = fromAngleRadians(obs1, Math.PI)
+  const obs2 = fromAngleRadians(obs1, TAU / 2)
   t.true(compareVectors(obs2, [-1, 1.2246468525851679e-16]))
 })

package/src/maths/vec2/length.js

@@ -5,6 +5,6 @@
  * @returns {Number} length
  * @alias module:modeling/maths/vec2.length
  */
-const length = (vector) => Math.hypot(vector[0], vector[1])
+const length = (vector) => Math.sqrt(vector[0] * vector[0] + vector[1] * vector[1])
 
 module.exports = length

package/src/maths/vec2/length.test.js

@@ -25,15 +25,5 @@ test('vec2: length() should return correct values', (t) => {
   const length5 = length(vec5)
   nearlyEqual(t, length5, 2.23606, EPS)
 
-  // huge vector
-  const vec6 = fromValues(1e200, 1e200)
-  const length6 = length(vec6)
-  nearlyEqual(t, length6, Math.SQRT2 * 1e200, EPS)
-
-  // tiny vector
-  const vec7 = fromValues(1e-200, 1e-200)
-  const length7 = length(vec7)
-  nearlyEqual(t, length7, Math.SQRT2 * 1e-200, EPS)
-
   t.true(true)
 })

package/src/maths/vec2/normal.js

@@ -1,3 +1,5 @@
+const { TAU } = require('../constants')
+
 const create = require('./create')
 const rotate = require('./rotate')
 
@@ -10,6 +12,6 @@ const rotate = require('./rotate')
  * @returns {vec2} out
  * @alias module:modeling/maths/vec2.normal
  */
-const normal = (out, vector) => rotate(out, vector, create(), (Math.PI / 2))
+const normal = (out, vector) => rotate(out, vector, create(), (TAU / 4))
 
 module.exports = normal

package/src/maths/vec2/rotate.test.js

@@ -1,10 +1,13 @@
 const test = require('ava')
+
+const { TAU } = require('../constants')
+
 const { rotate, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
 test('vec2: rotate() called with three parameters should update a vec2 with correct values', (t) => {
-  const radians = 90 * Math.PI / 180
+  const radians = TAU / 4
 
   const obs1 = fromValues(0, 0)
   const ret1 = rotate(obs1, [0, 0], [0, 0], 0)

package/src/maths/vec3/angle.js

@@ -15,8 +15,8 @@ const angle = (a, b) => {
   const bx = b[0]
   const by = b[1]
   const bz = b[2]
-  const mag1 = Math.hypot(ax, ay, az)
-  const mag2 = Math.hypot(bx, by, bz)
+  const mag1 = Math.sqrt(ax * ax + ay * ay + az * az)
+  const mag2 = Math.sqrt(bx * bx + by * by + bz * bz)
   const mag = mag1 * mag2
   const cosine = mag && dot(a, b) / mag
   return Math.acos(Math.min(Math.max(cosine, -1), 1))

package/src/maths/vec3/angle.test.js

@@ -30,17 +30,5 @@ test('vec3: angle() should return correct values', (t) => {
   const angle5 = angle(vec5a, vec5b)
   nearlyEqual(t, angle5, 0.785398, EPS)
 
-  // tiny values
-  const vec6a = fromValues(1, 0, 0)
-  const vec6b = fromValues(1e-200, 1e-200, 0)
-  const angle6 = angle(vec6a, vec6b)
-  nearlyEqual(t, angle6, 0.785398, EPS)
-
-  // huge values
-  const vec7a = fromValues(1, 0, 0)
-  const vec7b = fromValues(1e200, 1e200, 0)
-  const angle7 = angle(vec7a, vec7b)
-  nearlyEqual(t, angle7, 0.785398, EPS)
-
   t.true(true)
 })

package/src/maths/vec3/distance.js

@@ -10,7 +10,7 @@ const distance = (a, b) => {
   const x = b[0] - a[0]
   const y = b[1] - a[1]
   const z = b[2] - a[2]
-  return Math.hypot(x, y, z)
+  return Math.sqrt(x * x + y * y + z * z)
 }
 
 module.exports = distance

package/src/maths/vec3/length.js

@@ -9,7 +9,7 @@ const length = (vector) => {
   const x = vector[0]
   const y = vector[1]
   const z = vector[2]
-  return Math.hypot(x, y, z)
+  return Math.sqrt(x * x + y * y + z * z)
 }
 
 module.exports = length

package/src/maths/vec3/length.test.js

@@ -41,15 +41,5 @@ test('vec3: length() should return correct values', (t) => {
   const length9 = length(vec9)
   nearlyEqual(t, length9, 3.74165, EPS)
 
-  // huge vector
-  const vec10 = fromValues(1e200, 0, 1e200)
-  const length10 = length(vec10)
-  nearlyEqual(t, length10, Math.SQRT2 * 1e200, EPS)
-
-  // tiny vector
-  const vec11 = fromValues(1e-200, 0, 1e-200)
-  const length11 = length(vec11)
-  nearlyEqual(t, length11, Math.SQRT2 * 1e-200, EPS)
-
   t.true(true)
 })

package/src/maths/vec3/rotateX.test.js

@@ -1,10 +1,13 @@
 const test = require('ava')
+
+const { TAU } = require('../constants')
+
 const { rotateX, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
 test('vec3: rotateX() called with four parameters should update a vec3 with correct values', (t) => {
-  const radians = 90 * Math.PI / 180
+  const radians = TAU / 4
 
   const obs1 = fromValues(0, 0, 0)
   const ret1 = rotateX(obs1, [0, 0, 0], [0, 0, 0], 0)

package/src/maths/vec3/rotateY.test.js

@@ -1,10 +1,13 @@
 const test = require('ava')
+
+const { TAU } = require('../constants')
+
 const { rotateY, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
 test('vec3: rotateY() called with three parameters should update a vec3 with correct values', (t) => {
-  const radians = 90 * Math.PI / 180
+  const radians = TAU / 4
 
   const obs1 = fromValues(0, 0, 0)
   const ret1 = rotateY(obs1, [0, 0, 0], [0, 0, 0], 0)

package/src/maths/vec3/rotateZ.test.js

@@ -1,10 +1,13 @@
 const test = require('ava')
+
+const { TAU } = require('../constants')
+
 const { rotateZ, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
 test('vec3: rotateZ() called with four parameters should update a vec3 with correct values', (t) => {
-  const radians = 90 * Math.PI / 180
+  const radians = TAU / 4
 
   const obs1 = fromValues(0, 0, 0)
   const ret1 = rotateZ(obs1, [0, 0, 0], [0, 0, 0], 0)

package/src/operations/booleans/trees/PolygonTreeNode.js

@@ -132,8 +132,8 @@ class PolygonTreeNode {
     const polygon = this.polygon
     if (polygon) {
       const bound = poly3.measureBoundingSphere(polygon)
-      const sphereradius = bound[1] + EPS // ensure radius is LARGER then polygon
-      const spherecenter = bound[0]
+      const sphereradius = bound[3] + EPS // ensure radius is LARGER then polygon
+      const spherecenter = bound
       const d = vec3.dot(splane, spherecenter) - splane[3]
       if (d > sphereradius) {
         frontnodes.push(this)

package/src/operations/expansions/expand.test.js

@@ -1,9 +1,11 @@
 const test = require('ava')
 
 const { comparePoints, nearlyEqual } = require('../../../test/helpers')
+
 const { geom2, geom3, path2 } = require('../../geometries')
 const measureBoundingBox = require('../../measurements/measureBoundingBox')
 const area = require('../../maths/utils/area')
+const { TAU } = require('../../maths/constants')
 const sphere = require('../../primitives/sphere')
 
 const { expand } = require('./index')
@@ -51,7 +53,7 @@ test('expand: round-expanding a bent line produces expected geometry', (t) => {
   const expandedPoints = geom2.toPoints(expandedPathGeom2)
 
   t.notThrows(() => geom2.validate(expandedPathGeom2))
-  const expectedArea = 56 + 2 * Math.PI * delta * 1.25 // shape will have 1 and 1/4 circles
+  const expectedArea = 56 + TAU  * delta * 1.25 // shape will have 1 and 1/4 circles
   nearlyEqual(t, area(expandedPoints), expectedArea, 0.01, 'Measured area should be pretty close')
   const boundingBox = measureBoundingBox(expandedPathGeom2)
   t.true(comparePoints(boundingBox, [[-7, -2, 0], [2, 12, 0]]), 'Unexpected bounding box: ' + JSON.stringify(boundingBox))

package/src/operations/expansions/expandShell.js

@@ -1,4 +1,4 @@
-const { EPS } = require('../../maths/constants')
+const { EPS, TAU } = require('../../maths/constants')
 
 const mat4 = require('../../maths/mat4')
 const vec3 = require('../../maths/vec3')
@@ -120,7 +120,7 @@ const expandShell = (options, geometry) => {
 
     // first of all equally spaced around the cylinder:
     for (let i = 0; i < segments; i++) {
-      addUniqueAngle(angles, (i * Math.PI * 2 / segments))
+      addUniqueAngle(angles, (i * TAU / segments))
     }
 
     // and also at every normal of all touching planes:
@@ -130,10 +130,10 @@ const expandShell = (options, geometry) => {
       const co = vec3.dot(xbase, planenormal)
       let angle = Math.atan2(si, co)
 
-      if (angle < 0) angle += Math.PI * 2
+      if (angle < 0) angle += TAU
       addUniqueAngle(angles, angle)
       angle = Math.atan2(-si, -co)
-      if (angle < 0) angle += Math.PI * 2
+      if (angle < 0) angle += TAU
       addUniqueAngle(angles, angle)
     }
 

package/src/operations/expansions/offsetFromPoints.js

@@ -1,4 +1,4 @@
-const { EPS } = require('../../maths/constants')
+const { EPS, TAU } = require('../../maths/constants')
 
 const intersect = require('../../maths/utils/intersect')
 const line2 = require('../../maths/line2')
@@ -139,7 +139,7 @@ const offsetFromPoints = (options, points) => {
 
       if (rotation !== 0.0) {
         // generate the segments
-        cornersegments = Math.floor(segments * (Math.abs(rotation) / (2 * Math.PI)))
+        cornersegments = Math.floor(segments * (Math.abs(rotation) / TAU))
         const step = rotation / cornersegments
         const start = vec2.angle(vec2.subtract(v0, corner.s0[1], corner.c))
         const cornerpoints = []

package/src/operations/extrusions/extrudeFromSlices.test.js

@@ -2,6 +2,7 @@ const test = require('ava')
 
 const comparePolygonsAsPoints = require('../../../test/helpers/comparePolygonsAsPoints')
 
+const { TAU } = require('../../maths/constants')
 const mat4 = require('../../maths/mat4')
 
 const { geom2, geom3, poly3 } = require('../../geometries')
@@ -56,10 +57,10 @@ test('extrudeFromSlices (torus)', (t) => {
   hex = poly3.transform(mat4.fromTranslation(mat4.create(), [0, 20, 0]), hex)
   hex = slice.fromPoints(poly3.toPoints(hex))
 
-  const angle = Math.PI / 4
+  const angle = TAU / 8
   const geometry3 = extrudeFromSlices(
     {
-      numberOfSlices: Math.PI * 2 / angle,
+      numberOfSlices: TAU / angle,
       capStart: false,
       capEnd: false,
       close: true,

package/src/operations/extrusions/extrudeLinear.test.js

@@ -2,6 +2,8 @@ const test = require('ava')
 
 const comparePolygonsAsPoints = require('../../../test/helpers/comparePolygonsAsPoints')
 
+const { TAU } = require('../../maths/constants')
+
 const { geom2, geom3, path2 } = require('../../geometries')
 
 const { extrudeLinear } = require('./index')
@@ -77,7 +79,7 @@ test('extrudeLinear (no twist)', (t) => {
 test('extrudeLinear (twist)', (t) => {
   const geometry2 = geom2.fromPoints([[5, 5], [-5, 5], [-5, -5], [5, -5]])
 
-  let geometry3 = extrudeLinear({ height: 15, twistAngle: Math.PI / -4 }, geometry2)
+  let geometry3 = extrudeLinear({ height: 15, twistAngle: -TAU / 8 }, geometry2)
   let pts = geom3.toPoints(geometry3)
   let exp = [
     [[5, -5, 0], [5, 5, 0], [7.0710678118654755, 4.440892098500626e-16, 15]],
@@ -105,7 +107,7 @@ test('extrudeLinear (twist)', (t) => {
   t.is(pts.length, 12)
   t.true(comparePolygonsAsPoints(pts, exp))
 
-  geometry3 = extrudeLinear({ height: 15, twistAngle: Math.PI / 2, twistSteps: 3 }, geometry2)
+  geometry3 = extrudeLinear({ height: 15, twistAngle: TAU / 4, twistSteps: 3 }, geometry2)
   pts = geom3.toPoints(geometry3)
   exp = [
     [[5, -5, 0], [5, 5, 0], [1.830127018922194, 6.830127018922193, 5]],
@@ -140,7 +142,7 @@ test('extrudeLinear (twist)', (t) => {
   t.is(pts.length, 28)
   t.true(comparePolygonsAsPoints(pts, exp))
 
-  geometry3 = extrudeLinear({ height: 15, twistAngle: Math.PI / 2, twistSteps: 30 }, geometry2)
+  geometry3 = extrudeLinear({ height: 15, twistAngle: TAU / 2, twistSteps: 30 }, geometry2)
   pts = geom3.toPoints(geometry3)
   t.notThrows(() => geom3.validate(geometry3))
   t.is(pts.length, 244)

package/src/operations/extrusions/extrudeRectangular.js

@@ -18,7 +18,7 @@ const extrudeRectangularGeom2 = require('./extrudeRectangularGeom2')
  *
  * @example
  * let mywalls = extrudeRectangular({size: 1, height: 3}, square({size: 20}))
- * let mywalls = extrudeRectangular({size: 1, height: 300, twistAngle: Math.PI}, square({size: 20}))
+ * let mywalls = extrudeRectangular({size: 1, height: 300, twistAngle: TAU / 2}, square({size: 20}))
  */
 const extrudeRectangular = (options, ...objects) => {
   const defaults = {

package/src/operations/extrusions/extrudeRectangular.test.js

@@ -1,5 +1,7 @@
 const test = require('ava')
 
+const { TAU } = require('../../maths/constants')
+
 const { geom2, geom3 } = require('../../geometries')
 
 const { arc, rectangle } = require('../../primitives')
@@ -7,7 +9,7 @@ const { arc, rectangle } = require('../../primitives')
 const { extrudeRectangular } = require('./index')
 
 test('extrudeRectangular (defaults)', (t) => {
-  const geometry1 = arc({ radius: 5, endAngle: Math.PI / 2, segments: 16 })
+  const geometry1 = arc({ radius: 5, endAngle: TAU / 4, segments: 16 })
   const geometry2 = rectangle({ size: [5, 5] })
 
   let obs = extrudeRectangular({ }, geometry1)
@@ -22,7 +24,7 @@ test('extrudeRectangular (defaults)', (t) => {
 })
 
 test('extrudeRectangular (chamfer)', (t) => {
-  const geometry1 = arc({ radius: 5, endAngle: Math.PI / 2, segments: 16 })
+  const geometry1 = arc({ radius: 5, endAngle: TAU / 4, segments: 16 })
   const geometry2 = rectangle({ size: [5, 5] })
 
   let obs = extrudeRectangular({ corners: 'chamfer' }, geometry1)
@@ -37,7 +39,7 @@ test('extrudeRectangular (chamfer)', (t) => {
 })
 
 test('extrudeRectangular (segments = 8, round)', (t) => {
-  const geometry1 = arc({ radius: 5, endAngle: Math.PI / 2, segments: 16 })
+  const geometry1 = arc({ radius: 5, endAngle: TAU / 4, segments: 16 })
   const geometry2 = rectangle({ size: [5, 5] })
 
   let obs = extrudeRectangular({ segments: 8, corners: 'round' }, geometry1)