@jscad/modeling 2.8.0 → 2.9.2

package/src/operations/booleans/trees/Node.js

@@ -42,28 +42,32 @@ class Node {
       node = current.node
       polygontreenodes = current.polygontreenodes
 
-      // begin "function"
       if (node.plane) {
+        const plane = node.plane
+
         const backnodes = []
         const frontnodes = []
         const coplanarfrontnodes = alsoRemovecoplanarFront ? backnodes : frontnodes
-        const plane = node.plane
         const numpolygontreenodes = polygontreenodes.length
         for (let i = 0; i < numpolygontreenodes; i++) {
-          const node1 = polygontreenodes[i]
-          if (!node1.isRemoved()) {
-            node1.splitByPlane(plane, coplanarfrontnodes, backnodes, frontnodes, backnodes)
+          const treenode = polygontreenodes[i]
+          if (!treenode.isRemoved()) {
+            // split this polygon tree node using the plane
+            // NOTE: children are added to the tree if there are spanning polygons
+            treenode.splitByPlane(plane, coplanarfrontnodes, backnodes, frontnodes, backnodes)
           }
         }
 
         if (node.front && (frontnodes.length > 0)) {
+          // add front node for further splitting
           stack.push({ node: node.front, polygontreenodes: frontnodes })
         }
         const numbacknodes = backnodes.length
         if (node.back && (numbacknodes > 0)) {
+          // add back node for further splitting
           stack.push({ node: node.back, polygontreenodes: backnodes })
         } else {
-          // there's nothing behind this plane. Delete the nodes behind this plane:
+          // remove all back nodes from processing
           for (let i = 0; i < numbacknodes; i++) {
             backnodes[i].remove()
           }
@@ -135,16 +139,6 @@ class Node {
       current = stack.pop()
     } while (current !== undefined)
   }
-
-  // TODO is this still used?
-  getParentPlaneNormals (normals, maxdepth) {
-    if (maxdepth > 0) {
-      if (this.parent) {
-        normals.push(this.parent.plane.normal)
-        this.parent.getParentPlaneNormals(normals, maxdepth - 1)
-      }
-    }
-  }
 }
 
 module.exports = Node

package/src/operations/booleans/trees/PolygonTreeNode.js

@@ -21,11 +21,11 @@ const splitPolygonByPlane = require('./splitPolygonByPlane')
 // since they are no longer intact.
 class PolygonTreeNode {
   // constructor creates the root node
-  constructor () {
-    this.parent = null
+  constructor (parent, polygon) {
+    this.parent = parent
     this.children = []
-    this.polygon = null
-    this.removed = false
+    this.polygon = polygon
+    this.removed = false  // state of branch or leaf
   }
 
   // fill the tree with polygons. Should be called on the root node only; child nodes must
@@ -47,6 +47,7 @@ class PolygonTreeNode {
   remove () {
     if (!this.removed) {
       this.removed = true
+      this.polygon = null
 
       // remove ourselves from the parent's children list:
       const parentschildren = this.parent.children
@@ -183,9 +184,7 @@ class PolygonTreeNode {
   // a child should be created for every fragment of the split polygon
   // returns the newly created child
   addChild (polygon) {
-    const newchild = new PolygonTreeNode()
-    newchild.parent = this
-    newchild.polygon = polygon
+    const newchild = new PolygonTreeNode(this, polygon)
     this.children.push(newchild)
     return newchild
   }
@@ -206,13 +205,13 @@ class PolygonTreeNode {
     }
   }
 
+  // private method
+  // remove the polygon from the node, and all parent nodes above it
+  // called to invalidate parents of removed nodes
   recursivelyInvalidatePolygon () {
-    let node = this
-    while (node.polygon) {
-      node.polygon = null
-      if (node.parent) {
-        node = node.parent
-      }
+    this.polygon = null
+    if (this.parent) {
+      this.parent.recursivelyInvalidatePolygon()
     }
   }
 
@@ -248,7 +247,7 @@ class PolygonTreeNode {
         node = children[j]
         result += `${prefix}PolygonTreeNode (${node.isRootNode()}): ${node.children.length}`
         if (node.polygon) {
-          result += `\n ${prefix}poly3\n`
+          result += `\n ${prefix}polygon: ${node.polygon.vertices}\n`
         } else {
           result += '\n'
         }

package/src/operations/booleans/trees/Tree.js

@@ -19,8 +19,7 @@ class Tree {
 
   // Remove all polygons in this BSP tree that are inside the other BSP tree
   // `tree`.
-  clipTo (tree, alsoRemovecoplanarFront) {
-    alsoRemovecoplanarFront = !!alsoRemovecoplanarFront
+  clipTo (tree, alsoRemovecoplanarFront = false) {
     this.rootnode.clipTo(tree, alsoRemovecoplanarFront)
   }
 

package/src/operations/booleans/trees/splitPolygonByPlane.js

@@ -36,7 +36,7 @@ const splitPolygonByPlane = (splane, polygon) => {
     const MINEPS = -EPS
     for (let i = 0; i < numvertices; i++) {
       const t = vec3.dot(splane, vertices[i]) - splane[3]
-      const isback = (t < 0)
+      const isback = (t < MINEPS)
       vertexIsBack.push(isback)
       if (t > EPS) hasfront = true
       if (t < MINEPS) hasback = true
@@ -69,9 +69,8 @@ const splitPolygonByPlane = (splane, polygon) => {
           }
         } else {
           // line segment intersects plane:
-          const point = vertex
           const nextpoint = vertices[nextvertexindex]
-          const intersectionpoint = splitLineSegmentByPlane(splane, point, nextpoint)
+          const intersectionpoint = splitLineSegmentByPlane(splane, vertex, nextpoint)
           if (isback) {
             backvertices.push(vertex)
             backvertices.push(intersectionpoint)

package/src/operations/booleans/union.test.js

@@ -9,6 +9,7 @@ const { circle, rectangle, sphere, cuboid } = require('../../primitives')
 const { union } = require('./index')
 
 const { center } = require('../transforms/center')
+const { translate } = require('../transforms/translate')
 
 // test('union: union of a path produces expected changes to points', (t) => {
 //   let geometry = path.fromPoints({}, [[0, 1, 0], [1, 0, 0]])
@@ -36,6 +37,7 @@ test('union of one or more geom2 objects produces expected geometry', (t) => {
     [0, -2],
     [1.4142000000000001, -1.4142000000000001]
   ]
+  t.notThrows(() => geom2.validate(result1))
   t.true(comparePoints(obs, exp))
 
   // union of two non-overlapping objects
@@ -57,6 +59,7 @@ test('union of one or more geom2 objects produces expected geometry', (t) => {
     [12, 12],
     [1.4142000000000001, -1.4142000000000001]
   ]
+  t.notThrows(() => geom2.validate(result2))
   t.true(comparePoints(obs, exp))
 
   // union of two partially overlapping objects
@@ -74,6 +77,7 @@ test('union of one or more geom2 objects produces expected geometry', (t) => {
     [7.999933333333333, 9.000053333333334],
     [11.999973333333333, 7.999933333333333]
   ]
+  t.notThrows(() => geom2.validate(result3))
   t.true(comparePoints(obs, exp))
 
   // union of two completely overlapping objects
@@ -85,7 +89,24 @@ test('union of one or more geom2 objects produces expected geometry', (t) => {
     [9.000046666666666, 9.000046666666666],
     [-9.000046666666666, 9.000046666666666]
   ]
+  t.notThrows(() => geom2.validate(result4))
   t.true(comparePoints(obs, exp))
+
+  // union of unions of non-overlapping objects (BSP gap from #907)
+  const circ = circle({ radius: 1, segments: 32 })
+  const result5 = union(
+    union(
+      translate([17, 21], circ),
+      translate([7, 0], circ),
+    ),
+    union(
+      translate([3, 21], circ),
+      translate([17, 21], circ),
+    )
+  )
+  obs = geom2.toPoints(result5)
+  t.notThrows.skip(() => geom2.validate(result5))
+  t.is(obs.length, 112)
 })
 
 test('union of one or more geom3 objects produces expected geometry', (t) => {
@@ -144,6 +165,7 @@ test('union of one or more geom3 objects produces expected geometry', (t) => {
     [[0.9999999999999998, 1.0000000000000002, -1.414213562373095], [1.4142135623730951, 3.4638242249419736e-16, -1.414213562373095], [8.65956056235493e-17, 8.659560562354935e-17, -2]],
     [[8.65956056235493e-17, 8.659560562354935e-17, 2], [1.4142135623730951, 3.4638242249419736e-16, 1.414213562373095], [0.9999999999999998, 1.0000000000000002, 1.414213562373095]]
   ]
+  t.notThrows.skip(() => geom3.validate(result1))
   t.true(comparePolygonsAsPoints(obs, exp))
 
   // union of two non-overlapping objects
@@ -151,6 +173,7 @@ test('union of one or more geom3 objects produces expected geometry', (t) => {
 
   const result2 = union(geometry1, geometry2)
   obs = geom3.toPoints(result2)
+  t.notThrows.skip(() => geom3.validate(result2))
   t.is(obs.length, 38)
 
   // union of two partially overlapping objects
@@ -178,6 +201,7 @@ test('union of one or more geom3 objects produces expected geometry', (t) => {
     [[-9, 9, 9], [-9, 8, 9], [8, 8, 9], [8, 9, 9]],
     [[-9, 8, 9], [-9, -9, 9], [9, -9, 9], [9, 8, 9]]
   ]
+  t.notThrows.skip(() => geom3.validate(result3))
   t.is(obs.length, 18)
   t.true(comparePolygonsAsPoints(obs, exp))
 
@@ -192,6 +216,7 @@ test('union of one or more geom3 objects produces expected geometry', (t) => {
     [[-9, -9, -9], [-9, 9, -9], [9, 9, -9], [9, -9, -9]],
     [[-9, -9, 9], [9, -9, 9], [9, 9, 9], [-9, 9, 9]]
   ]
+  t.notThrows(() => geom3.validate(result4))
   t.is(obs.length, 6)
   t.true(comparePolygonsAsPoints(obs, exp))
 })
@@ -202,6 +227,7 @@ test('union of geom3 with rounding issues #137', (t) => {
 
   const obs = union(geometry1, geometry2)
   const pts = geom3.toPoints(obs)
+  t.notThrows(() => geom3.validate(obs))
   t.is(pts.length, 6) // number of polygons in union
 })
 
@@ -266,6 +292,7 @@ test('union of geom2 with closing issues #15', (t) => {
     [-49.34040695243976, -15.797284338334542],
     [-45.82121705016925, -16.857333163105647]
   ]
+  t.notThrows(() => geom2.validate(obs))
   t.is(pts.length, 20) // number of sides in union
   t.true(comparePoints(pts, exp))
 })

package/src/operations/expansions/expand.test.js

@@ -14,6 +14,7 @@ test('expand: edge-expanding a straight line produces rectangle', (t) => {
   const expandedPathGeom2 = expand({ delta: 2, corners: 'edge', segments: 8 }, linePath2)
   const expandedPoints = geom2.toPoints(expandedPathGeom2)
 
+  t.notThrows(() => geom2.validate(expandedPathGeom2))
   t.is(area(expandedPoints), 40)
   t.true(comparePoints(measureBoundingBox(expandedPathGeom2), [[-2, 0, 0], [2, 10, 0]]))
 })
@@ -24,6 +25,7 @@ test('expand: edge-expanding a bent line produces expected geometry', (t) => {
   const expandedPathGeom2 = expand({ delta: 2, corners: 'edge', segments: 8 }, linePath2)
   const expandedPoints = geom2.toPoints(expandedPathGeom2)
 
+  t.notThrows(() => geom2.validate(expandedPathGeom2))
   t.is(area(expandedPoints), 60)
   const boundingBox = measureBoundingBox(expandedPathGeom2)
   t.true(comparePoints(boundingBox, [[-5, 0, 0], [2, 12, 0]]), 'Unexpected bounding box: ' + JSON.stringify(boundingBox))
@@ -35,6 +37,7 @@ test('expand: edge-expanding a bent line, reversed points, produces expected geo
   const expandedPathGeom2 = expand({ delta: 2, corners: 'edge', segments: 8 }, linePath2)
   const expandedPoints = geom2.toPoints(expandedPathGeom2)
 
+  t.notThrows(() => geom2.validate(expandedPathGeom2))
   t.is(area(expandedPoints), 60)
   const boundingBox = measureBoundingBox(expandedPathGeom2)
   t.true(comparePoints(boundingBox, [[-5, 0, 0], [2, 12, 0]]), 'Unexpected bounding box: ' + JSON.stringify(boundingBox))
@@ -47,6 +50,7 @@ test('expand: round-expanding a bent line produces expected geometry', (t) => {
   const expandedPathGeom2 = expand({ delta, corners: 'round', segments: 128 }, linePath2)
   const expandedPoints = geom2.toPoints(expandedPathGeom2)
 
+  t.notThrows(() => geom2.validate(expandedPathGeom2))
   const expectedArea = 56 + 2 * Math.PI * delta * 1.25 // shape will have 1 and 1/4 circles
   nearlyEqual(t, area(expandedPoints), expectedArea, 0.01, 'Measured area should be pretty close')
   const boundingBox = measureBoundingBox(expandedPathGeom2)
@@ -60,6 +64,7 @@ test('expand: chamfer-expanding a bent line produces expected geometry', (t) =>
   const expandedPathGeom2 = expand({ delta, corners: 'chamfer', segments: 8 }, linePath2)
   const expandedPoints = geom2.toPoints(expandedPathGeom2)
 
+  t.notThrows(() => geom2.validate(expandedPathGeom2))
   t.is(area(expandedPoints), 58)
   const boundingBox = measureBoundingBox(expandedPathGeom2)
   t.true(comparePoints(boundingBox, [[-5, 0, 0], [2, 12, 0]]), 'Unexpected bounding box: ' + JSON.stringify(boundingBox))
@@ -84,6 +89,7 @@ test('expand: expanding of a geom2 produces expected changes to points', (t) =>
     [-10, 8],
     [-10, -8]
   ]
+  t.notThrows(() => geom2.validate(obs))
   t.is(pts.length, 12)
   t.true(comparePoints(pts, exp))
 })
@@ -113,6 +119,7 @@ test('expand: expanding of a geom3 produces expected changes to polygons', (t) =
     [16, -6.414213562373095, 16]
   ]
 
+  t.notThrows.skip(() => geom3.validate(obs))
   t.is(pts.length, 62)
   t.true(comparePoints(pts[0], exp0))
   t.true(comparePoints(pts[61], exp61))
@@ -120,31 +127,32 @@ test('expand: expanding of a geom3 produces expected changes to polygons', (t) =
   const geometry2 = sphere({ radius: 5, segments: 8 })
   const obs2 = expand({ delta: 5 }, geometry2)
   const pts2 = geom3.toPoints(obs2)
-  t.is(pts2.length, 1612)
+  t.notThrows.skip(() => geom3.validate(obs2))
+  t.is(pts2.length, 864)
 })
 
 test('expand (options): offsetting of a complex geom2 produces expected offset geom2', (t) => {
   const geometry = geom2.create([
-    [[-75.00000, 75.00000], [-75.00000, -75.00000]],
-    [[-75.00000, -75.00000], [75.00000, -75.00000]],
-    [[75.00000, -75.00000], [75.00000, 75.00000]],
-    [[-40.00000, 75.00000], [-75.00000, 75.00000]],
-    [[75.00000, 75.00000], [40.00000, 75.00000]],
-    [[40.00000, 75.00000], [40.00000, 0.00000]],
-    [[40.00000, 0.00000], [-40.00000, 0.00000]],
-    [[-40.00000, 0.00000], [-40.00000, 75.00000]],
-    [[15.00000, -10.00000], [15.00000, -40.00000]],
-    [[-15.00000, -10.00000], [15.00000, -10.00000]],
-    [[-15.00000, -40.00000], [-15.00000, -10.00000]],
-    [[-8.00000, -40.00000], [-15.00000, -40.00000]],
-    [[15.00000, -40.00000], [8.00000, -40.00000]],
-    [[-8.00000, -25.00000], [-8.00000, -40.00000]],
-    [[8.00000, -25.00000], [-8.00000, -25.00000]],
-    [[8.00000, -40.00000], [8.00000, -25.00000]],
-    [[-2.00000, -15.00000], [-2.00000, -19.00000]],
-    [[-2.00000, -19.00000], [2.00000, -19.00000]],
-    [[2.00000, -19.00000], [2.00000, -15.00000]],
-    [[2.00000, -15.00000], [-2.00000, -15.00000]]
+    [[-75, 75], [-75, -75]],
+    [[-75, -75], [75, -75]],
+    [[75, -75], [75, 75]],
+    [[-40, 75], [-75, 75]],
+    [[75, 75], [40, 75]],
+    [[40, 75], [40, 0]],
+    [[40, 0], [-40, 0]],
+    [[-40, 0], [-40, 75]],
+    [[15, -10], [15, -40]],
+    [[-15, -10], [15, -10]],
+    [[-15, -40], [-15, -10]],
+    [[-8, -40], [-15, -40]],
+    [[15, -40], [8, -40]],
+    [[-8, -25], [-8, -40]],
+    [[8, -25], [-8, -25]],
+    [[8, -40], [8, -25]],
+    [[-2, -15], [-2, -19]],
+    [[-2, -19], [2, -19]],
+    [[2, -19], [2, -15]],
+    [[2, -15], [-2, -15]]
   ])
 
   // expand +
@@ -172,6 +180,7 @@ test('expand (options): offsetting of a complex geom2 produces expected offset g
     [-4, -13],
     [-77, -77]
   ]
+  t.notThrows(() => geom2.validate(obs))
   t.is(pts.length, 20)
   t.true(comparePoints(pts, exp))
 })

package/src/operations/expansions/expandShell.js

@@ -15,7 +15,7 @@ const unionGeom3Sub = require('../booleans/unionGeom3Sub')
 
 const extrudePolygon = require('./extrudePolygon')
 
-/**
+/*
  * Collect all planes adjacent to each vertex
  */
 const mapPlaneToVertex = (map, vertex, plane) => {
@@ -29,7 +29,7 @@ const mapPlaneToVertex = (map, vertex, plane) => {
   }
 }
 
-/**
+/*
  * Collect all planes adjacent to each edge.
  * Combine undirected edges, no need for duplicate cylinders.
  */

package/src/operations/expansions/offset.test.js

@@ -12,6 +12,7 @@ test('offset: offsetting a straight line produces expected geometry', (t) => {
   // offset it by 2.
   let offsetLinePath2 = offset({ delta: 2, corners: 'edge', segments: 8 }, linePath2)
   let offsetPoints = path2.toPoints(offsetLinePath2)
+  t.notThrows(() => path2.validate(offsetLinePath2))
   t.is(offsetPoints.length, 2)
   let boundingBox = measureBoundingBox(offsetLinePath2)
   t.true(comparePoints(boundingBox, [[2, 0, 0], [2, 10, 0]]), 'Unexpected bounding box: ' + JSON.stringify(boundingBox))
@@ -19,6 +20,7 @@ test('offset: offsetting a straight line produces expected geometry', (t) => {
   // offset it by -2.
   offsetLinePath2 = offset({ delta: -2, corners: 'edge', segments: 8 }, linePath2)
   offsetPoints = path2.toPoints(offsetLinePath2)
+  t.notThrows(() => path2.validate(offsetLinePath2))
   t.is(offsetPoints.length, 2)
   boundingBox = measureBoundingBox(offsetLinePath2)
   t.true(comparePoints(boundingBox, [[-2, 0, 0], [-2, 10, 0]]), 'Unexpected bounding box: ' + JSON.stringify(boundingBox))
@@ -27,6 +29,7 @@ test('offset: offsetting a straight line produces expected geometry', (t) => {
   linePath2 = path2.fromPoints({ closed: false }, points.reverse())
   offsetLinePath2 = offset({ delta: 2, corners: 'edge', segments: 8 }, linePath2)
   offsetPoints = path2.toPoints(offsetLinePath2)
+  t.notThrows(() => path2.validate(offsetLinePath2))
   t.is(offsetPoints.length, 2)
   boundingBox = measureBoundingBox(offsetLinePath2)
   t.true(comparePoints(boundingBox, [[-2, 0, 0], [-2, 10, 0]]), 'Unexpected bounding box: ' + JSON.stringify(boundingBox))
@@ -39,6 +42,7 @@ test('offset: offsetting a bent line produces expected geometry', (t) => {
   // offset it by 2.
   let offsetLinePath2 = offset({ delta: 2, corners: 'edge', segments: 8 }, linePath2)
   let offsetPoints = path2.toPoints(offsetLinePath2)
+  t.notThrows(() => path2.validate(offsetLinePath2))
   t.is(offsetPoints.length, 5)
   let boundingBox = measureBoundingBox(offsetLinePath2)
   t.true(comparePoints(boundingBox, [[2, 0, 0], [10, 8, 0]]), 'Unexpected bounding box: ' + JSON.stringify(boundingBox))
@@ -46,6 +50,7 @@ test('offset: offsetting a bent line produces expected geometry', (t) => {
   // offset it by -2.
   offsetLinePath2 = offset({ delta: -2, corners: 'edge', segments: 8 }, linePath2)
   offsetPoints = path2.toPoints(offsetLinePath2)
+  t.notThrows(() => path2.validate(offsetLinePath2))
   t.is(offsetPoints.length, 5)
   boundingBox = measureBoundingBox(offsetLinePath2)
   t.true(comparePoints(boundingBox, [[-2, 0, 0], [10, 12, 0]]), 'Unexpected bounding box: ' + JSON.stringify(boundingBox))
@@ -56,6 +61,7 @@ test('offset: offsetting a 2 segment straight line produces expected geometry',
   const linePath2 = path2.fromPoints({ closed: false }, points)
   const offsetLinePath2 = offset({ delta: 2, corners: 'edge', segments: 8 }, linePath2)
   const offsetPoints = path2.toPoints(offsetLinePath2)
+  t.notThrows(() => path2.validate(offsetLinePath2))
   t.is(offsetPoints.length, 3)
   const boundingBox = measureBoundingBox(offsetLinePath2)
   t.true(comparePoints(boundingBox, [[2, 0, 0], [2, 10, 0]]), 'Unexpected bounding box: ' + JSON.stringify(boundingBox))
@@ -71,6 +77,7 @@ test('offset (corners: chamfer): offset of a path2 produces expected offset path
   let pts = path2.toPoints(obs)
   let exp = [
   ]
+  t.notThrows(() => path2.validate(obs))
   t.true(comparePoints(pts, exp))
 
   // expand +
@@ -82,6 +89,7 @@ test('offset (corners: chamfer): offset of a path2 produces expected offset path
     [5.707106781186548, 0.7071067811865475],
     [0.7071067811865475, 5.707106781186548]
   ]
+  t.notThrows(() => path2.validate(obs))
   t.true(comparePoints(pts, exp))
 
   obs = offset({ delta: 1, corners: 'chamfer' }, closeline)
@@ -94,6 +102,7 @@ test('offset (corners: chamfer): offset of a path2 produces expected offset path
     [-1, 5],
     [-1, 6.123233995736766e-17]
   ]
+  t.notThrows(() => path2.validate(obs))
   t.true(comparePoints(pts, exp))
 
   // contract -
@@ -104,6 +113,7 @@ test('offset (corners: chamfer): offset of a path2 produces expected offset path
     [2.5857864376269046, 1],
     [-0.7071067811865475, 4.292893218813452]
   ]
+  t.notThrows(() => path2.validate(obs))
   t.true(comparePoints(pts, exp))
 
   obs = offset({ delta: -1, corners: 'chamfer' }, closeline)
@@ -113,6 +123,7 @@ test('offset (corners: chamfer): offset of a path2 produces expected offset path
     [2.5857864376269046, 1],
     [0.9999999999999996, 2.585786437626905]
   ]
+  t.notThrows(() => path2.validate(obs))
   t.true(comparePoints(pts, exp))
 })
 
@@ -132,6 +143,7 @@ test('offset (corners: edge): offset of a path2 produces expected offset path2',
     [-1.9999999999999996, 6],
     [-5, 6]
   ]
+  t.notThrows(() => path2.validate(obs))
   t.true(comparePoints(pts, exp))
 
   obs = offset({ delta: 1, corners: 'edge' }, closeline)
@@ -146,6 +158,7 @@ test('offset (corners: edge): offset of a path2 produces expected offset path2',
     [-6, 6],
     [-6, -6]
   ]
+  t.notThrows(() => path2.validate(obs))
   t.true(comparePoints(pts, exp))
 
   obs = offset({ delta: -0.5, corners: 'edge' }, openline)
@@ -160,6 +173,7 @@ test('offset (corners: edge): offset of a path2 produces expected offset path2',
     [-3.5, 4.5],
     [-5, 4.5]
   ]
+  t.notThrows(() => path2.validate(obs))
   t.true(comparePoints(pts, exp))
 
   obs = offset({ delta: -0.5, corners: 'edge' }, closeline)
@@ -174,6 +188,7 @@ test('offset (corners: edge): offset of a path2 produces expected offset path2',
     [-3.5, 4.5],
     [-4.5, 4.5]
   ]
+  t.notThrows(() => path2.validate(obs))
   t.true(comparePoints(pts, exp))
 })
 
@@ -209,6 +224,7 @@ test('offset (corners: round): offset of a path2 produces expected offset path2'
     [-3, 6],
     [-5, 6]
   ]
+  t.notThrows(() => path2.validate(obs))
   t.true(comparePoints(pts, exp))
 
   obs = offset({ delta: 1, corners: 'round', segments: 16 }, closeline)
@@ -247,6 +263,7 @@ test('offset (corners: round): offset of a path2 produces expected offset path2'
     [-6, 5],
     [-6, -5]
   ]
+  t.notThrows(() => path2.validate(obs))
   t.true(comparePoints(pts, exp))
 })
 
@@ -289,6 +306,7 @@ test('offset (corners: round): offset of a CW path2 produces expected offset pat
     [5, -6],
     [-5, -6]
   ]
+  t.notThrows(() => path2.validate(obs))
   t.true(comparePoints(pts, exp))
 })
 
@@ -301,6 +319,7 @@ test('offset (options): offsetting of a simple geom2 produces expected offset ge
   let pts = geom2.toPoints(obs)
   let exp = [
   ]
+  t.notThrows(() => geom2.validate(obs))
   t.true(comparePoints(pts, exp))
 
   // expand +
@@ -322,6 +341,7 @@ test('offset (options): offsetting of a simple geom2 produces expected offset ge
     [-6, 5],
     [-6, -5]
   ]
+  t.notThrows(() => geom2.validate(obs))
   t.true(comparePoints(pts, exp))
 
   // contract -
@@ -339,6 +359,7 @@ test('offset (options): offsetting of a simple geom2 produces expected offset ge
     [-3.5, 4.5],
     [-4.5, 4.5]
   ]
+  t.notThrows(() => geom2.validate(obs))
   t.true(comparePoints(pts, exp))
 
   // segments 1 - sharp points at corner
@@ -354,6 +375,7 @@ test('offset (options): offsetting of a simple geom2 produces expected offset ge
     [-6, 6],
     [-6, -6]
   ]
+  t.notThrows(() => geom2.validate(obs))
   t.true(comparePoints(pts, exp))
 
   // segments 16 - rounded corners
@@ -377,6 +399,7 @@ test('offset (options): offsetting of a simple geom2 produces expected offset ge
     [-3.5, 4.5],
     [-4.5, 4.5]
   ]
+  t.notThrows(() => geom2.validate(obs))
   t.true(comparePoints(pts, exp))
 })
 
@@ -429,6 +452,7 @@ test('offset (options): offsetting of a complex geom2 produces expected offset g
     [-4, -13],
     [-77, -77]
   ]
+  t.notThrows(() => geom2.validate(obs))
   t.is(pts.length, 20)
   t.true(comparePoints(pts, exp))
 })
@@ -473,6 +497,7 @@ test('offset (options): offsetting of round geom2 produces expected offset geom2
     [6.7105900605102855, -6.710590060510285],
     [8.767810140100096, -3.6317399864658024]
   ]
+  t.notThrows(() => geom2.validate(obs))
   t.is(pts.length, 16)
   t.true(comparePoints(pts, exp))
 })

package/src/operations/extrusions/earcut/assignHoles.js

@@ -0,0 +1,91 @@
+const { area } = require('../../../maths/utils')
+const { toOutlines } = require('../../../geometries/geom2')
+const { arePointsInside } = require('../../../geometries/poly2')
+
+/*
+ * Constructs a polygon hierarchy of solids and holes.
+ * The hierarchy is represented as a forest of trees. All trees shall be depth at most 2.
+ * If a solid exists inside the hole of another solid, it will be split out as its own root.
+ *
+ * @param {geom2} geometry
+ * @returns {Array} an array of polygons with associated holes
+ * @alias module:modeling/geometries/geom2.toTree
+ *
+ * @example
+ * const geometry = subtract(rectangle({size: [5, 5]}), rectangle({size: [3, 3]}))
+ * console.log(assignHoles(geometry))
+ * [{
+ *   "solid": [[-2.5,-2.5],[2.5,-2.5],[2.5,2.5],[-2.5,2.5]],
+ *   "holes": [[[-1.5,1.5],[1.5,1.5],[1.5,-1.5],[-1.5,-1.5]]]
+ * }]
+ */
+const assignHoles = (geometry) => {
+  const outlines = toOutlines(geometry)
+  const solids = [] // solid indices
+  const holes = [] // hole indices
+  outlines.forEach((outline, i) => {
+    const a = area(outline)
+    if (a < 0) {
+      holes.push(i)
+    } else if (a > 0) {
+      solids.push(i)
+    }
+  })
+
+  // for each hole, determine what solids it is inside of
+  const children = [] // child holes of solid[i]
+  const parents = [] // parent solids of hole[i]
+  solids.forEach((s, i) => {
+    const solid = outlines[s]
+    children[i] = []
+    holes.forEach((h, j) => {
+      const hole = outlines[h]
+      // check if a point of hole j is inside solid i
+      if (arePointsInside([hole[0]], { vertices: solid })) {
+        children[i].push(h)
+        if (!parents[j]) parents[j] = []
+        parents[j].push(i)
+      }
+    })
+  })
+
+  // check if holes have multiple parents and choose one with fewest children
+  holes.forEach((h, j) => {
+    // ensure at least one parent exists
+    if (parents[j] && parents[j].length > 1) {
+      // the solid directly containing this hole
+      const directParent = minIndex(parents[j], (p) => children[p].length)
+      parents[j].forEach((p, i) => {
+        if (i !== directParent) {
+          // Remove hole from skip level parents
+          children[p] = children[p].filter((c) => c !== h)
+        }
+      })
+    }
+  })
+
+  // map indices back to points
+  return children.map((holes, i) => ({
+    solid: outlines[solids[i]],
+    holes: holes.map((h) => outlines[h])
+  }))
+}
+
+/*
+ * Find the item in the list with smallest score(item).
+ * If the list is empty, return undefined.
+ */
+const minIndex = (list, score) => {
+  let bestIndex
+  let best
+  list.forEach((item, index) => {
+    const value = score(item)
+    if (best === undefined || value < best) {
+      bestIndex = index
+      best = value
+    }
+  })
+  return bestIndex
+}
+
+module.exports = assignHoles