@jscad/modeling 2.7.2 → 2.9.1

package/src/primitives/cylinderElliptic.test.js

@@ -10,6 +10,7 @@ test('cylinderElliptic (defaults)', (t) => {
   const obs = cylinderElliptic()
   const pts = geom3.toPoints(obs)
 
+  t.notThrows(() => geom3.validate(obs))
   t.is(pts.length, 96)
 })
 
@@ -26,48 +27,49 @@ test('cylinderElliptic (options)', (t) => {
     [[0.5000000000000001, 0.8660254037844386, -5], [0.5000000000000001, 0.8660254037844386, 5],
       [0.8660254037844387, 0.49999999999999994, 5], [0.8660254037844387, 0.49999999999999994, -5]],
     [[0, 0, 5], [0.8660254037844387, 0.49999999999999994, 5], [0.5000000000000001, 0.8660254037844386, 5]],
-    [[0, 0, -5], [6.123233995736766e-17, 1, -5], [0.5000000000000001, 0.8660254037844386, -5]],
-    [[6.123233995736766e-17, 1, -5], [6.123233995736766e-17, 1, 5],
+    [[0, 0, -5], [0, 1, -5], [0.5000000000000001, 0.8660254037844386, -5]],
+    [[0, 1, -5], [0, 1, 5],
       [0.5000000000000001, 0.8660254037844386, 5], [0.5000000000000001, 0.8660254037844386, -5]],
-    [[0, 0, 5], [0.5000000000000001, 0.8660254037844386, 5], [6.123233995736766e-17, 1, 5]],
-    [[0, 0, -5], [-0.4999999999999998, 0.8660254037844387, -5], [6.123233995736766e-17, 1, -5]],
+    [[0, 0, 5], [0.5000000000000001, 0.8660254037844386, 5], [0, 1, 5]],
+    [[0, 0, -5], [-0.4999999999999998, 0.8660254037844387, -5], [0, 1, -5]],
     [[-0.4999999999999998, 0.8660254037844387, -5], [-0.4999999999999998, 0.8660254037844387, 5],
-      [6.123233995736766e-17, 1, 5], [6.123233995736766e-17, 1, -5]],
-    [[0, 0, 5], [6.123233995736766e-17, 1, 5], [-0.4999999999999998, 0.8660254037844387, 5]],
+      [0, 1, 5], [0, 1, -5]],
+    [[0, 0, 5], [0, 1, 5], [-0.4999999999999998, 0.8660254037844387, 5]],
     [[0, 0, -5], [-0.8660254037844387, 0.49999999999999994, -5], [-0.4999999999999998, 0.8660254037844387, -5]],
     [[-0.8660254037844387, 0.49999999999999994, -5], [-0.8660254037844387, 0.49999999999999994, 5],
       [-0.4999999999999998, 0.8660254037844387, 5], [-0.4999999999999998, 0.8660254037844387, -5]],
     [[0, 0, 5], [-0.4999999999999998, 0.8660254037844387, 5], [-0.8660254037844387, 0.49999999999999994, 5]],
-    [[0, 0, -5], [-1, 1.2246467991473532e-16, -5], [-0.8660254037844387, 0.49999999999999994, -5]],
-    [[-1, 1.2246467991473532e-16, -5], [-1, 1.2246467991473532e-16, 5],
+    [[0, 0, -5], [-1, 0, -5], [-0.8660254037844387, 0.49999999999999994, -5]],
+    [[-1, 0, -5], [-1, 0, 5],
       [-0.8660254037844387, 0.49999999999999994, 5], [-0.8660254037844387, 0.49999999999999994, -5]],
-    [[0, 0, 5], [-0.8660254037844387, 0.49999999999999994, 5], [-1, 1.2246467991473532e-16, 5]],
-    [[0, 0, -5], [-0.8660254037844386, -0.5000000000000001, -5], [-1, 1.2246467991473532e-16, -5]],
+    [[0, 0, 5], [-0.8660254037844387, 0.49999999999999994, 5], [-1, 0, 5]],
+    [[0, 0, -5], [-0.8660254037844386, -0.5000000000000001, -5], [-1, 0, -5]],
     [[-0.8660254037844386, -0.5000000000000001, -5], [-0.8660254037844386, -0.5000000000000001, 5],
-      [-1, 1.2246467991473532e-16, 5], [-1, 1.2246467991473532e-16, -5]],
-    [[0, 0, 5], [-1, 1.2246467991473532e-16, 5], [-0.8660254037844386, -0.5000000000000001, 5]],
+      [-1, 0, 5], [-1, 0, -5]],
+    [[0, 0, 5], [-1, 0, 5], [-0.8660254037844386, -0.5000000000000001, 5]],
     [[0, 0, -5], [-0.5000000000000004, -0.8660254037844385, -5], [-0.8660254037844386, -0.5000000000000001, -5]],
     [[-0.5000000000000004, -0.8660254037844385, -5], [-0.5000000000000004, -0.8660254037844385, 5],
       [-0.8660254037844386, -0.5000000000000001, 5], [-0.8660254037844386, -0.5000000000000001, -5]],
     [[0, 0, 5], [-0.8660254037844386, -0.5000000000000001, 5], [-0.5000000000000004, -0.8660254037844385, 5]],
-    [[0, 0, -5], [-1.8369701987210297e-16, -1, -5], [-0.5000000000000004, -0.8660254037844385, -5]],
-    [[-1.8369701987210297e-16, -1, -5], [-1.8369701987210297e-16, -1, 5],
+    [[0, 0, -5], [0, -1, -5], [-0.5000000000000004, -0.8660254037844385, -5]],
+    [[0, -1, -5], [0, -1, 5],
       [-0.5000000000000004, -0.8660254037844385, 5], [-0.5000000000000004, -0.8660254037844385, -5]],
-    [[0, 0, 5], [-0.5000000000000004, -0.8660254037844385, 5], [-1.8369701987210297e-16, -1, 5]],
-    [[0, 0, -5], [0.5000000000000001, -0.8660254037844386, -5], [-1.8369701987210297e-16, -1, -5]],
+    [[0, 0, 5], [-0.5000000000000004, -0.8660254037844385, 5], [0, -1, 5]],
+    [[0, 0, -5], [0.5000000000000001, -0.8660254037844386, -5], [0, -1, -5]],
     [[0.5000000000000001, -0.8660254037844386, -5], [0.5000000000000001, -0.8660254037844386, 5],
-      [-1.8369701987210297e-16, -1, 5], [-1.8369701987210297e-16, -1, -5]],
-    [[0, 0, 5], [-1.8369701987210297e-16, -1, 5], [0.5000000000000001, -0.8660254037844386, 5]],
+      [0, -1, 5], [0, -1, -5]],
+    [[0, 0, 5], [0, -1, 5], [0.5000000000000001, -0.8660254037844386, 5]],
     [[0, 0, -5], [0.8660254037844384, -0.5000000000000004, -5], [0.5000000000000001, -0.8660254037844386, -5]],
     [[0.8660254037844384, -0.5000000000000004, -5], [0.8660254037844384, -0.5000000000000004, 5],
       [0.5000000000000001, -0.8660254037844386, 5], [0.5000000000000001, -0.8660254037844386, -5]],
     [[0, 0, 5], [0.5000000000000001, -0.8660254037844386, 5], [0.8660254037844384, -0.5000000000000004, 5]],
-    [[0, 0, -5], [1, -2.4492935982947064e-16, -5], [0.8660254037844384, -0.5000000000000004, -5]],
-    [[1, -2.4492935982947064e-16, -5], [1, -2.4492935982947064e-16, 5],
-      [0.8660254037844384, -0.5000000000000004, 5], [0.8660254037844384, -0.5000000000000004, -5]],
-    [[0, 0, 5], [0.8660254037844384, -0.5000000000000004, 5], [1, -2.4492935982947064e-16, 5]]
+    [[0, 0, -5], [1, 0, -5], [0.8660254037844384, -0.5000000000000004, -5]],
+    [[1, 0, -5], [1, 0, 5], [0.8660254037844384, -0.5000000000000004, 5],
+      [0.8660254037844384, -0.5000000000000004, -5]],
+    [[0, 0, 5], [0.8660254037844384, -0.5000000000000004, 5], [1, 0, 5]]
   ]
 
+  t.notThrows(() => geom3.validate(obs))
   t.is(pts.length, 36)
   t.true(comparePolygonsAsPoints(pts, exp))
 
@@ -83,57 +85,57 @@ test('cylinderElliptic (options)', (t) => {
     [[0.8660254037844387, 0.9999999999999999, -1], [0.5000000000000001, 1.7320508075688772, -1], [1.7320508075688774, 0.49999999999999994, 1]],
     [[0, 0, 1], [1.7320508075688774, 0.49999999999999994, 1], [1.0000000000000002, 0.8660254037844386, 1]],
     [[1.7320508075688774, 0.49999999999999994, 1], [0.5000000000000001, 1.7320508075688772, -1], [1.0000000000000002, 0.8660254037844386, 1]],
-    [[0, 0, -1], [6.123233995736766e-17, 2, -1], [0.5000000000000001, 1.7320508075688772, -1]],
-    [[0.5000000000000001, 1.7320508075688772, -1], [6.123233995736766e-17, 2, -1], [1.0000000000000002, 0.8660254037844386, 1]],
-    [[0, 0, 1], [1.0000000000000002, 0.8660254037844386, 1], [1.2246467991473532e-16, 1, 1]],
-    [[1.0000000000000002, 0.8660254037844386, 1], [6.123233995736766e-17, 2, -1], [1.2246467991473532e-16, 1, 1]],
-    [[0, 0, -1], [-0.4999999999999998, 1.7320508075688774, -1], [6.123233995736766e-17, 2, -1]],
-    [[6.123233995736766e-17, 2, -1], [-0.4999999999999998, 1.7320508075688774, -1], [1.2246467991473532e-16, 1, 1]],
-    [[0, 0, 1], [1.2246467991473532e-16, 1, 1], [-0.9999999999999996, 0.8660254037844387, 1]],
-    [[1.2246467991473532e-16, 1, 1], [-0.4999999999999998, 1.7320508075688774, -1], [-0.9999999999999996, 0.8660254037844387, 1]],
+    [[0, 0, -1], [0, 2, -1], [0.5000000000000001, 1.7320508075688772, -1]],
+    [[0.5000000000000001, 1.7320508075688772, -1], [0, 2, -1], [1.0000000000000002, 0.8660254037844386, 1]],
+    [[0, 0, 1], [1.0000000000000002, 0.8660254037844386, 1], [0, 1, 1]],
+    [[1.0000000000000002, 0.8660254037844386, 1], [0, 2, -1], [0, 1, 1]],
+    [[0, 0, -1], [-0.4999999999999998, 1.7320508075688774, -1], [0, 2, -1]],
+    [[0, 2, -1], [-0.4999999999999998, 1.7320508075688774, -1], [0, 1, 1]],
+    [[0, 0, 1], [0, 1, 1], [-0.9999999999999996, 0.8660254037844387, 1]],
+    [[0, 1, 1], [-0.4999999999999998, 1.7320508075688774, -1], [-0.9999999999999996, 0.8660254037844387, 1]],
     [[0, 0, -1], [-0.8660254037844387, 0.9999999999999999, -1], [-0.4999999999999998, 1.7320508075688774, -1]],
     [[-0.4999999999999998, 1.7320508075688774, -1], [-0.8660254037844387, 0.9999999999999999, -1], [-0.9999999999999996, 0.8660254037844387, 1]],
     [[0, 0, 1], [-0.9999999999999996, 0.8660254037844387, 1], [-1.7320508075688774, 0.49999999999999994, 1]],
     [[-0.9999999999999996, 0.8660254037844387, 1], [-0.8660254037844387, 0.9999999999999999, -1], [-1.7320508075688774, 0.49999999999999994, 1]],
-    [[0, 0, -1], [-1, 2.4492935982947064e-16, -1], [-0.8660254037844387, 0.9999999999999999, -1]],
-    [[-0.8660254037844387, 0.9999999999999999, -1], [-1, 2.4492935982947064e-16, -1], [-1.7320508075688774, 0.49999999999999994, 1]],
-    [[0, 0, 1], [-1.7320508075688774, 0.49999999999999994, 1], [-2, 1.2246467991473532e-16, 1]],
-    [[-1.7320508075688774, 0.49999999999999994, 1], [-1, 2.4492935982947064e-16, -1], [-2, 1.2246467991473532e-16, 1]],
-    [[0, 0, -1], [-0.8660254037844386, -1.0000000000000002, -1], [-1, 2.4492935982947064e-16, -1]],
-    [[-1, 2.4492935982947064e-16, -1], [-0.8660254037844386, -1.0000000000000002, -1], [-2, 1.2246467991473532e-16, 1]],
-    [[0, 0, 1], [-2, 1.2246467991473532e-16, 1], [-1.7320508075688772, -0.5000000000000001, 1]],
-    [[-2, 1.2246467991473532e-16, 1], [-0.8660254037844386, -1.0000000000000002, -1], [-1.7320508075688772, -0.5000000000000001, 1]],
+    [[0, 0, -1], [-1, 0, -1], [-0.8660254037844387, 0.9999999999999999, -1]],
+    [[-0.8660254037844387, 0.9999999999999999, -1], [-1, 0, -1], [-1.7320508075688774, 0.49999999999999994, 1]],
+    [[0, 0, 1], [-1.7320508075688774, 0.49999999999999994, 1], [-2, 0, 1]],
+    [[-1.7320508075688774, 0.49999999999999994, 1], [-1, 0, -1], [-2, 0, 1]],
+    [[0, 0, -1], [-0.8660254037844386, -1.0000000000000002, -1], [-1, 0, -1]],
+    [[-1, 0, -1], [-0.8660254037844386, -1.0000000000000002, -1], [-2, 0, 1]],
+    [[0, 0, 1], [-2, 0, 1], [-1.7320508075688772, -0.5000000000000001, 1]],
+    [[-2, 0, 1], [-0.8660254037844386, -1.0000000000000002, -1], [-1.7320508075688772, -0.5000000000000001, 1]],
     [[0, 0, -1], [-0.5000000000000004, -1.732050807568877, -1], [-0.8660254037844386, -1.0000000000000002, -1]],
     [[-0.8660254037844386, -1.0000000000000002, -1], [-0.5000000000000004, -1.732050807568877, -1], [-1.7320508075688772, -0.5000000000000001, 1]],
     [[0, 0, 1], [-1.7320508075688772, -0.5000000000000001, 1], [-1.0000000000000009, -0.8660254037844385, 1]],
     [[-1.7320508075688772, -0.5000000000000001, 1], [-0.5000000000000004, -1.732050807568877, -1], [-1.0000000000000009, -0.8660254037844385, 1]],
-    [[0, 0, -1], [-1.8369701987210297e-16, -2, -1], [-0.5000000000000004, -1.732050807568877, -1]],
-    [[-0.5000000000000004, -1.732050807568877, -1], [-1.8369701987210297e-16, -2, -1], [-1.0000000000000009, -0.8660254037844385, 1]],
-    [[0, 0, 1], [-1.0000000000000009, -0.8660254037844385, 1], [-3.6739403974420594e-16, -1, 1]],
-    [[-1.0000000000000009, -0.8660254037844385, 1], [-1.8369701987210297e-16, -2, -1], [-3.6739403974420594e-16, -1, 1]],
-    [[0, 0, -1], [0.5000000000000001, -1.7320508075688772, -1], [-1.8369701987210297e-16, -2, -1]],
-    [[-1.8369701987210297e-16, -2, -1], [0.5000000000000001, -1.7320508075688772, -1], [-3.6739403974420594e-16, -1, 1]],
-    [[0, 0, 1], [-3.6739403974420594e-16, -1, 1], [1.0000000000000002, -0.8660254037844386, 1]],
-    [[-3.6739403974420594e-16, -1, 1], [0.5000000000000001, -1.7320508075688772, -1], [1.0000000000000002, -0.8660254037844386, 1]],
+    [[0, 0, -1], [0, -2, -1], [-0.5000000000000004, -1.732050807568877, -1]],
+    [[-0.5000000000000004, -1.732050807568877, -1], [0, -2, -1], [-1.0000000000000009, -0.8660254037844385, 1]],
+    [[0, 0, 1], [-1.0000000000000009, -0.8660254037844385, 1], [0, -1, 1]],
+    [[-1.0000000000000009, -0.8660254037844385, 1], [0, -2, -1], [0, -1, 1]],
+    [[0, 0, -1], [0.5000000000000001, -1.7320508075688772, -1], [0, -2, -1]],
+    [[0, -2, -1], [0.5000000000000001, -1.7320508075688772, -1], [0, -1, 1]],
+    [[0, 0, 1], [0, -1, 1], [1.0000000000000002, -0.8660254037844386, 1]],
+    [[0, -1, 1], [0.5000000000000001, -1.7320508075688772, -1], [1.0000000000000002, -0.8660254037844386, 1]],
     [[0, 0, -1], [0.8660254037844384, -1.0000000000000009, -1], [0.5000000000000001, -1.7320508075688772, -1]],
     [[0.5000000000000001, -1.7320508075688772, -1], [0.8660254037844384, -1.0000000000000009, -1], [1.0000000000000002, -0.8660254037844386, 1]],
     [[0, 0, 1], [1.0000000000000002, -0.8660254037844386, 1], [1.7320508075688767, -0.5000000000000004, 1]],
     [[1.0000000000000002, -0.8660254037844386, 1], [0.8660254037844384, -1.0000000000000009, -1], [1.7320508075688767, -0.5000000000000004, 1]],
-    [[0, 0, -1], [1, -4.898587196589413e-16, -1], [0.8660254037844384, -1.0000000000000009, -1]],
-    [[0.8660254037844384, -1.0000000000000009, -1], [1, -4.898587196589413e-16, -1], [1.7320508075688767, -0.5000000000000004, 1]],
-    [[0, 0, 1], [1.7320508075688767, -0.5000000000000004, 1], [2, -2.4492935982947064e-16, 1]],
-    [[1.7320508075688767, -0.5000000000000004, 1], [1, -4.898587196589413e-16, -1], [2, -2.4492935982947064e-16, 1]]
+    [[0, 0, -1], [1, 0, -1], [0.8660254037844384, -1.0000000000000009, -1]],
+    [[0.8660254037844384, -1.0000000000000009, -1], [1, 0, -1], [1.7320508075688767, -0.5000000000000004, 1]],
+    [[0, 0, 1], [1.7320508075688767, -0.5000000000000004, 1], [2, 0, 1]],
+    [[1.7320508075688767, -0.5000000000000004, 1], [1, 0, -1], [2, 0, 1]]
   ]
 
+  t.notThrows(() => geom3.validate(obs))
   t.is(pts.length, 48)
   t.true(comparePolygonsAsPoints(pts, exp))
 
   // test startAngle and endAngle
   obs = cylinderElliptic({ startRadius: [1, 2], endRadius: [2, 1], startAngle: Math.PI / 2, endAngle: Math.PI * 2 * 0.75, segments: 12 })
   pts = geom3.toPoints(obs)
-  exp = [
-  ]
 
+  t.notThrows(() => geom3.validate(obs))
   t.is(pts.length, 28)
   // t.true(comparePolygonsAsPoints(pts, exp))
 
@@ -141,6 +143,7 @@ test('cylinderElliptic (options)', (t) => {
   obs = cylinderElliptic({ segments: 8 })
   pts = geom3.toPoints(obs)
 
+  t.notThrows(() => geom3.validate(obs))
   t.is(pts.length, 24)
 
   // test center
@@ -181,6 +184,23 @@ test('cylinderElliptic (options)', (t) => {
     [[-5, -5, -3.5], [-4.292893218813453, -5.707106781186548, -3.5], [-4, -5, -3.5]]
   ]
 
+  t.notThrows(() => geom3.validate(obs))
   t.is(pts.length, 24)
   t.true(comparePolygonsAsPoints(pts, exp))
 })
+
+test('cylinderElliptic (cone)', (t) => {
+  const obs = cylinderElliptic({ endRadius: [0, 0] })
+  const pts = geom3.toPoints(obs)
+
+  t.notThrows(() => geom3.validate(obs))
+  t.is(pts.length, 64)
+})
+
+test('cylinderElliptic (squished)', (t) => {
+  const obs = cylinderElliptic({ startRadius: [1, 0], endRadius: [0, 1], segments: 4 })
+  const pts = geom3.toPoints(obs)
+
+  t.notThrows(() => geom3.validate(obs))
+  t.is(pts.length, 8)
+})

package/src/primitives/ellipse.js

@@ -4,6 +4,8 @@ const vec2 = require('../maths/vec2')
 
 const geom2 = require('../geometries/geom2')
 
+const { sin, cos } = require('../utils/trigonometry')
+
 const { isGTE, isNumberArray } = require('./commonChecks')
 
 /**
@@ -62,7 +64,7 @@ const ellipse = (options) => {
   segments = (rotation < Math.PI * 2) ? segments + 1 : segments
   for (let i = 0; i < segments; i++) {
     const angle = (step * i) + startAngle
-    const point = vec2.fromValues(radius[0] * Math.cos(angle), radius[1] * Math.sin(angle))
+    const point = vec2.fromValues(radius[0] * cos(angle), radius[1] * sin(angle))
     vec2.add(point, centerv, point)
     points.push(point)
   }

package/src/primitives/ellipse.test.js

@@ -10,6 +10,7 @@ test('ellipse (defaults)', (t) => {
   const geometry = ellipse()
   const obs = geom2.toPoints(geometry)
 
+  t.notThrows(() => geom2.validate(geometry))
   t.deepEqual(obs.length, 32)
 })
 
@@ -52,6 +53,7 @@ test('ellipse (options)', (t) => {
     [3.9807852804032304, 4.804909677983871]
   ]
 
+  t.notThrows(() => geom2.validate(geometry))
   t.deepEqual(obs.length, 32)
   t.true(comparePoints(obs, exp))
 
@@ -63,20 +65,21 @@ test('ellipse (options)', (t) => {
     [2.77163859753386, 1.913417161825449],
     [2.121320343559643, 3.5355339059327373],
     [1.1480502970952695, 4.619397662556434],
-    [1.8369701987210297e-16, 5],
+    [0, 5],
     [-1.1480502970952693, 4.619397662556434],
     [-2.1213203435596424, 3.5355339059327378],
     [-2.77163859753386, 1.9134171618254494],
-    [-3, 6.123233995736766e-16],
+    [-3, 0],
     [-2.7716385975338604, -1.9134171618254483],
     [-2.121320343559643, -3.5355339059327373],
     [-1.148050297095271, -4.619397662556432],
-    [-5.51091059616309e-16, -5],
+    [0, -5],
     [1.14805029709527, -4.619397662556433],
     [2.121320343559642, -3.5355339059327386],
     [2.7716385975338595, -1.913417161825452]
   ]
 
+  t.notThrows(() => geom2.validate(geometry))
   t.deepEqual(obs.length, 16)
   t.true(comparePoints(obs, exp))
 
@@ -84,22 +87,23 @@ test('ellipse (options)', (t) => {
   geometry = ellipse({ radius: [3, 5], startAngle: Math.PI / 2, segments: 16 })
   obs = geom2.toPoints(geometry)
   exp = [
-    [1.8369701987210297e-16, 5],
+    [0, 5],
     [-1.1480502970952693, 4.619397662556434],
     [-2.1213203435596424, 3.5355339059327378],
     [-2.77163859753386, 1.9134171618254494],
-    [-3, 6.123233995736766e-16],
+    [-3, 0],
     [-2.7716385975338604, -1.9134171618254483],
     [-2.121320343559643, -3.5355339059327373],
     [-1.148050297095271, -4.619397662556432],
-    [-5.51091059616309e-16, -5],
+    [0, -5],
     [1.14805029709527, -4.619397662556433],
     [2.121320343559642, -3.5355339059327386],
     [2.7716385975338595, -1.913417161825452],
-    [3, -1.2246467991473533e-15],
+    [3, 0],
     [0, 0]
   ]
 
+  t.notThrows(() => geom2.validate(geometry))
   t.deepEqual(obs.length, 14)
   t.true(comparePoints(obs, exp))
 
@@ -111,15 +115,17 @@ test('ellipse (options)', (t) => {
     [2.77163859753386, 1.913417161825449],
     [2.121320343559643, 3.5355339059327373],
     [1.1480502970952695, 4.619397662556434],
-    [1.8369701987210297e-16, 5],
+    [0, 5],
     [0, 0]
   ]
 
+  t.notThrows(() => geom2.validate(geometry))
   t.deepEqual(obs.length, 6)
   t.true(comparePoints(obs, exp))
 
   // test segments
   geometry = ellipse({ segments: 72 })
   obs = geom2.toPoints(geometry)
+  t.notThrows(() => geom2.validate(geometry))
   t.deepEqual(obs.length, 72)
 })

package/src/primitives/ellipsoid.js

@@ -3,6 +3,8 @@ const vec3 = require('../maths/vec3')
 const geom3 = require('../geometries/geom3')
 const poly3 = require('../geometries/poly3')
 
+const { sin, cos } = require('../utils/trigonometry')
+
 const { isGTE, isNumberArray } = require('./commonChecks')
 
 /**
@@ -10,7 +12,7 @@ const { isGTE, isNumberArray } = require('./commonChecks')
  * @param {Object} [options] - options for construction
  * @param {Array} [options.center=[0,0,0]] - center of ellipsoid
  * @param {Array} [options.radius=[1,1,1]] - radius of ellipsoid, along X, Y and Z
- * @param {Number} [options.segments=32] - number of segements to create per full rotation
+ * @param {Number} [options.segments=32] - number of segments to create per full rotation
  * @param {Array} [options.axes] -  an array with three vectors for the x, y and z base vectors
  * @returns {geom3} new 3D geometry
  * @alias module:modeling/primitives.ellipsoid
@@ -42,14 +44,14 @@ const ellipsoid = (options) => {
   const p1 = vec3.create()
   const p2 = vec3.create()
   for (let slice1 = 0; slice1 <= segments; slice1++) {
-    const angle = Math.PI * 2.0 * slice1 / segments
-    const cylinderpoint = vec3.add(vec3.create(), vec3.scale(p1, xvector, Math.cos(angle)), vec3.scale(p2, yvector, Math.sin(angle)))
+    const angle = 2 * Math.PI * slice1 / segments
+    const cylinderpoint = vec3.add(vec3.create(), vec3.scale(p1, xvector, cos(angle)), vec3.scale(p2, yvector, sin(angle)))
     if (slice1 > 0) {
       let prevcospitch, prevsinpitch
       for (let slice2 = 0; slice2 <= qsegments; slice2++) {
         const pitch = 0.5 * Math.PI * slice2 / qsegments
-        const cospitch = Math.cos(pitch)
-        const sinpitch = Math.sin(pitch)
+        const cospitch = cos(pitch)
+        const sinpitch = sin(pitch)
         if (slice2 > 0) {
           let points = []
           let point

package/src/primitives/ellipsoid.test.js

@@ -10,6 +10,7 @@ test('ellipsoid (defaults)', (t) => {
   const obs = ellipsoid()
   const pts = geom3.toPoints(obs)
 
+  t.notThrows(() => geom3.validate(obs))
   t.is(pts.length, 512)
 })
 
@@ -26,8 +27,8 @@ test('ellipsoid (options)', (t) => {
       [1.2990381056766582, -1.25, -6.06217782649107], [1.5000000000000004, 0, -6.06217782649107]],
     [[1.5000000000000004, 0, 6.06217782649107], [1.2990381056766582, -1.25, 6.06217782649107],
       [2.25, -2.1650635094610964, 3.4999999999999996], [2.598076211353316, 0, 3.4999999999999996]],
-    [[1.5000000000000004, 0, -6.06217782649107], [1.2990381056766582, -1.25, -6.06217782649107], [1.8369701987210297e-16, 0, -7]],
-    [[1.8369701987210297e-16, 0, 7], [1.2990381056766582, -1.25, 6.06217782649107], [1.5000000000000004, 0, 6.06217782649107]],
+    [[1.5000000000000004, 0, -6.06217782649107], [1.2990381056766582, -1.25, -6.06217782649107], [0, 0, -7]],
+    [[0, 0, 7], [1.2990381056766582, -1.25, 6.06217782649107], [1.5000000000000004, 0, 6.06217782649107]],
     [[2.598076211353316, -2.4999999999999996, 0], [1.5000000000000004, -4.330127018922193, 0],
       [1.2990381056766584, -3.75, -3.4999999999999996], [2.25, -2.1650635094610964, -3.4999999999999996]],
     [[2.25, -2.1650635094610964, 3.4999999999999996], [1.2990381056766584, -3.75, 3.4999999999999996],
@@ -36,28 +37,28 @@ test('ellipsoid (options)', (t) => {
       [0.7500000000000004, -2.165063509461097, -6.06217782649107], [1.2990381056766582, -1.25, -6.06217782649107]],
     [[1.2990381056766582, -1.25, 6.06217782649107], [0.7500000000000004, -2.165063509461097, 6.06217782649107],
       [1.2990381056766584, -3.75, 3.4999999999999996], [2.25, -2.1650635094610964, 3.4999999999999996]],
-    [[1.2990381056766582, -1.25, -6.06217782649107], [0.7500000000000004, -2.165063509461097, -6.06217782649107], [1.5908628580873605e-16, -1.5308084989341913e-16, -7]],
-    [[1.5908628580873605e-16, -1.5308084989341913e-16, 7], [0.7500000000000004, -2.165063509461097, 6.06217782649107], [1.2990381056766582, -1.25, 6.06217782649107]],
-    [[1.5000000000000004, -4.330127018922193, 0], [1.8369701987210297e-16, -5, 0],
-      [1.5908628580873602e-16, -4.330127018922194, -3.4999999999999996], [1.2990381056766584, -3.75, -3.4999999999999996]],
-    [[1.2990381056766584, -3.75, 3.4999999999999996], [1.5908628580873602e-16, -4.330127018922194, 3.4999999999999996],
-      [1.8369701987210297e-16, -5, 0], [1.5000000000000004, -4.330127018922193, 0]],
-    [[1.2990381056766584, -3.75, -3.4999999999999996], [1.5908628580873602e-16, -4.330127018922194, -3.4999999999999996],
-      [9.184850993605151e-17, -2.5000000000000004, -6.06217782649107], [0.7500000000000004, -2.165063509461097, -6.06217782649107]],
-    [[0.7500000000000004, -2.165063509461097, 6.06217782649107], [9.184850993605151e-17, -2.5000000000000004, 6.06217782649107],
-      [1.5908628580873602e-16, -4.330127018922194, 3.4999999999999996], [1.2990381056766584, -3.75, 3.4999999999999996]],
-    [[0.7500000000000004, -2.165063509461097, -6.06217782649107], [9.184850993605151e-17, -2.5000000000000004, -6.06217782649107], [9.184850993605152e-17, -2.651438096812267e-16, -7]],
-    [[9.184850993605152e-17, -2.651438096812267e-16, 7], [9.184850993605151e-17, -2.5000000000000004, 6.06217782649107], [0.7500000000000004, -2.165063509461097, 6.06217782649107]],
-    [[1.8369701987210297e-16, -5, 0], [-1.4999999999999993, -4.330127018922194, 0],
-      [-1.2990381056766576, -3.7500000000000004, -3.4999999999999996], [1.5908628580873602e-16, -4.330127018922194, -3.4999999999999996]],
-    [[1.5908628580873602e-16, -4.330127018922194, 3.4999999999999996], [-1.2990381056766576, -3.7500000000000004, 3.4999999999999996],
-      [-1.4999999999999993, -4.330127018922194, 0], [1.8369701987210297e-16, -5, 0]],
-    [[1.5908628580873602e-16, -4.330127018922194, -3.4999999999999996], [-1.2990381056766576, -3.7500000000000004, -3.4999999999999996],
-      [-0.7499999999999998, -2.1650635094610973, -6.06217782649107], [9.184850993605151e-17, -2.5000000000000004, -6.06217782649107]],
-    [[9.184850993605151e-17, -2.5000000000000004, 6.06217782649107], [-0.7499999999999998, -2.1650635094610973, 6.06217782649107],
-      [-1.2990381056766576, -3.7500000000000004, 3.4999999999999996], [1.5908628580873602e-16, -4.330127018922194, 3.4999999999999996]],
-    [[9.184850993605151e-17, -2.5000000000000004, -6.06217782649107], [-0.7499999999999998, -2.1650635094610973, -6.06217782649107], [1.1248198369963932e-32, -3.061616997868383e-16, -7]],
-    [[1.1248198369963932e-32, -3.061616997868383e-16, 7], [-0.7499999999999998, -2.1650635094610973, 6.06217782649107], [9.184850993605151e-17, -2.5000000000000004, 6.06217782649107]],
+    [[1.2990381056766582, -1.25, -6.06217782649107], [0.7500000000000004, -2.165063509461097, -6.06217782649107], [0, 0, -7]],
+    [[0, 0, 7], [0.7500000000000004, -2.165063509461097, 6.06217782649107], [1.2990381056766582, -1.25, 6.06217782649107]],
+    [[1.5000000000000004, -4.330127018922193, 0], [0, -5, 0],
+      [0, -4.330127018922194, -3.4999999999999996], [1.2990381056766584, -3.75, -3.4999999999999996]],
+    [[1.2990381056766584, -3.75, 3.4999999999999996], [0, -4.330127018922194, 3.4999999999999996],
+      [0, -5, 0], [1.5000000000000004, -4.330127018922193, 0]],
+    [[1.2990381056766584, -3.75, -3.4999999999999996], [0, -4.330127018922194, -3.4999999999999996],
+      [0, -2.5000000000000004, -6.06217782649107], [0.7500000000000004, -2.165063509461097, -6.06217782649107]],
+    [[0.7500000000000004, -2.165063509461097, 6.06217782649107], [0, -2.5000000000000004, 6.06217782649107],
+      [0, -4.330127018922194, 3.4999999999999996], [1.2990381056766584, -3.75, 3.4999999999999996]],
+    [[0.7500000000000004, -2.165063509461097, -6.06217782649107], [0, -2.5000000000000004, -6.06217782649107], [0, 0, -7]],
+    [[0, 0, 7], [0, -2.5000000000000004, 6.06217782649107], [0.7500000000000004, -2.165063509461097, 6.06217782649107]],
+    [[0, -5, 0], [-1.4999999999999993, -4.330127018922194, 0],
+      [-1.2990381056766576, -3.7500000000000004, -3.4999999999999996], [0, -4.330127018922194, -3.4999999999999996]],
+    [[0, -4.330127018922194, 3.4999999999999996], [-1.2990381056766576, -3.7500000000000004, 3.4999999999999996],
+      [-1.4999999999999993, -4.330127018922194, 0], [0, -5, 0]],
+    [[0, -4.330127018922194, -3.4999999999999996], [-1.2990381056766576, -3.7500000000000004, -3.4999999999999996],
+      [-0.7499999999999998, -2.1650635094610973, -6.06217782649107], [0, -2.5000000000000004, -6.06217782649107]],
+    [[0, -2.5000000000000004, 6.06217782649107], [-0.7499999999999998, -2.1650635094610973, 6.06217782649107],
+      [-1.2990381056766576, -3.7500000000000004, 3.4999999999999996], [0, -4.330127018922194, 3.4999999999999996]],
+    [[0, -2.5000000000000004, -6.06217782649107], [-0.7499999999999998, -2.1650635094610973, -6.06217782649107], [0, 0, -7]],
+    [[0, 0, 7], [-0.7499999999999998, -2.1650635094610973, 6.06217782649107], [0, -2.5000000000000004, 6.06217782649107]],
     [[-1.4999999999999993, -4.330127018922194, 0], [-2.598076211353316, -2.4999999999999996, 0],
       [-2.25, -2.1650635094610964, -3.4999999999999996], [-1.2990381056766576, -3.7500000000000004, -3.4999999999999996]],
     [[-1.2990381056766576, -3.7500000000000004, 3.4999999999999996], [-2.25, -2.1650635094610964, 3.4999999999999996],
@@ -66,28 +67,28 @@ test('ellipsoid (options)', (t) => {
       [-1.2990381056766582, -1.25, -6.06217782649107], [-0.7499999999999998, -2.1650635094610973, -6.06217782649107]],
     [[-0.7499999999999998, -2.1650635094610973, 6.06217782649107], [-1.2990381056766582, -1.25, 6.06217782649107],
       [-2.25, -2.1650635094610964, 3.4999999999999996], [-1.2990381056766576, -3.7500000000000004, 3.4999999999999996]],
-    [[-0.7499999999999998, -2.1650635094610973, -6.06217782649107], [-1.2990381056766582, -1.25, -6.06217782649107], [-9.184850993605145e-17, -2.6514380968122674e-16, -7]],
-    [[-9.184850993605145e-17, -2.6514380968122674e-16, 7], [-1.2990381056766582, -1.25, 6.06217782649107], [-0.7499999999999998, -2.1650635094610973, 6.06217782649107]],
-    [[-2.598076211353316, -2.4999999999999996, 0], [-3, -6.123233995736766e-16, 0],
-      [-2.598076211353316, -5.302876193624535e-16, -3.4999999999999996], [-2.25, -2.1650635094610964, -3.4999999999999996]],
-    [[-2.25, -2.1650635094610964, 3.4999999999999996], [-2.598076211353316, -5.302876193624535e-16, 3.4999999999999996],
-      [-3, -6.123233995736766e-16, 0], [-2.598076211353316, -2.4999999999999996, 0]],
-    [[-2.25, -2.1650635094610964, -3.4999999999999996], [-2.598076211353316, -5.302876193624535e-16, -3.4999999999999996],
-      [-1.5000000000000004, -3.0616169978683836e-16, -6.06217782649107], [-1.2990381056766582, -1.25, -6.06217782649107]],
-    [[-1.2990381056766582, -1.25, 6.06217782649107], [-1.5000000000000004, -3.0616169978683836e-16, 6.06217782649107],
-      [-2.598076211353316, -5.302876193624535e-16, 3.4999999999999996], [-2.25, -2.1650635094610964, 3.4999999999999996]],
-    [[-1.2990381056766582, -1.25, -6.06217782649107], [-1.5000000000000004, -3.0616169978683836e-16, -6.06217782649107], [-1.5908628580873605e-16, -1.5308084989341913e-16, -7]],
-    [[-1.5908628580873605e-16, -1.5308084989341913e-16, 7], [-1.5000000000000004, -3.0616169978683836e-16, 6.06217782649107], [-1.2990381056766582, -1.25, 6.06217782649107]],
-    [[-3, -6.123233995736766e-16, 0], [-2.5980762113533165, 2.4999999999999987, 0],
-      [-2.2500000000000004, 2.1650635094610955, -3.4999999999999996], [-2.598076211353316, -5.302876193624535e-16, -3.4999999999999996]],
-    [[-2.598076211353316, -5.302876193624535e-16, 3.4999999999999996], [-2.2500000000000004, 2.1650635094610955, 3.4999999999999996],
-      [-2.5980762113533165, 2.4999999999999987, 0], [-3, -6.123233995736766e-16, 0]],
-    [[-2.598076211353316, -5.302876193624535e-16, -3.4999999999999996], [-2.2500000000000004, 2.1650635094610955, -3.4999999999999996],
-      [-1.2990381056766584, 1.2499999999999996, -6.06217782649107], [-1.5000000000000004, -3.0616169978683836e-16, -6.06217782649107]],
-    [[-1.5000000000000004, -3.0616169978683836e-16, 6.06217782649107], [-1.2990381056766584, 1.2499999999999996, 6.06217782649107],
-      [-2.2500000000000004, 2.1650635094610955, 3.4999999999999996], [-2.598076211353316, -5.302876193624535e-16, 3.4999999999999996]],
-    [[-1.5000000000000004, -3.0616169978683836e-16, -6.06217782649107], [-1.2990381056766584, 1.2499999999999996, -6.06217782649107], [-1.8369701987210297e-16, -3.7493994566546446e-32, -7]],
-    [[-1.8369701987210297e-16, -3.7493994566546446e-32, 7], [-1.2990381056766584, 1.2499999999999996, 6.06217782649107], [-1.5000000000000004, -3.0616169978683836e-16, 6.06217782649107]],
+    [[-0.7499999999999998, -2.1650635094610973, -6.06217782649107], [-1.2990381056766582, -1.25, -6.06217782649107], [0, 0, -7]],
+    [[0, 0, 7], [-1.2990381056766582, -1.25, 6.06217782649107], [-0.7499999999999998, -2.1650635094610973, 6.06217782649107]],
+    [[-2.598076211353316, -2.4999999999999996, 0], [-3, 0, 0],
+      [-2.598076211353316, 0, -3.4999999999999996], [-2.25, -2.1650635094610964, -3.4999999999999996]],
+    [[-2.25, -2.1650635094610964, 3.4999999999999996], [-2.598076211353316, 0, 3.4999999999999996],
+      [-3, 0, 0], [-2.598076211353316, -2.4999999999999996, 0]],
+    [[-2.25, -2.1650635094610964, -3.4999999999999996], [-2.598076211353316, 0, -3.4999999999999996],
+      [-1.5000000000000004, 0, -6.06217782649107], [-1.2990381056766582, -1.25, -6.06217782649107]],
+    [[-1.2990381056766582, -1.25, 6.06217782649107], [-1.5000000000000004, 0, 6.06217782649107],
+      [-2.598076211353316, 0, 3.4999999999999996], [-2.25, -2.1650635094610964, 3.4999999999999996]],
+    [[-1.2990381056766582, -1.25, -6.06217782649107], [-1.5000000000000004, 0, -6.06217782649107], [0, 0, -7]],
+    [[0, 0, 7], [-1.5000000000000004, 0, 6.06217782649107], [-1.2990381056766582, -1.25, 6.06217782649107]],
+    [[-3, 0, 0], [-2.5980762113533165, 2.4999999999999987, 0],
+      [-2.2500000000000004, 2.1650635094610955, -3.4999999999999996], [-2.598076211353316, 0, -3.4999999999999996]],
+    [[-2.598076211353316, 0, 3.4999999999999996], [-2.2500000000000004, 2.1650635094610955, 3.4999999999999996],
+      [-2.5980762113533165, 2.4999999999999987, 0], [-3, 0, 0]],
+    [[-2.598076211353316, 0, -3.4999999999999996], [-2.2500000000000004, 2.1650635094610955, -3.4999999999999996],
+      [-1.2990381056766584, 1.2499999999999996, -6.06217782649107], [-1.5000000000000004, 0, -6.06217782649107]],
+    [[-1.5000000000000004, 0, 6.06217782649107], [-1.2990381056766584, 1.2499999999999996, 6.06217782649107],
+      [-2.2500000000000004, 2.1650635094610955, 3.4999999999999996], [-2.598076211353316, 0, 3.4999999999999996]],
+    [[-1.5000000000000004, 0, -6.06217782649107], [-1.2990381056766584, 1.2499999999999996, -6.06217782649107], [0, 0, -7]],
+    [[0, 0, 7], [-1.2990381056766584, 1.2499999999999996, 6.06217782649107], [-1.5000000000000004, 0, 6.06217782649107]],
     [[-2.5980762113533165, 2.4999999999999987, 0], [-1.5000000000000013, 4.330127018922193, 0],
       [-1.2990381056766591, 3.75, -3.4999999999999996], [-2.2500000000000004, 2.1650635094610955, -3.4999999999999996]],
     [[-2.2500000000000004, 2.1650635094610955, 3.4999999999999996], [-1.2990381056766591, 3.75, 3.4999999999999996],
@@ -96,28 +97,28 @@ test('ellipsoid (options)', (t) => {
       [-0.7500000000000009, 2.165063509461097, -6.06217782649107], [-1.2990381056766584, 1.2499999999999996, -6.06217782649107]],
     [[-1.2990381056766584, 1.2499999999999996, 6.06217782649107], [-0.7500000000000009, 2.165063509461097, 6.06217782649107],
       [-1.2990381056766591, 3.75, 3.4999999999999996], [-2.2500000000000004, 2.1650635094610955, 3.4999999999999996]],
-    [[-1.2990381056766584, 1.2499999999999996, -6.06217782649107], [-0.7500000000000009, 2.165063509461097, -6.06217782649107], [-1.5908628580873607e-16, 1.5308084989341906e-16, -7]],
-    [[-1.5908628580873607e-16, 1.5308084989341906e-16, 7], [-0.7500000000000009, 2.165063509461097, 6.06217782649107], [-1.2990381056766584, 1.2499999999999996, 6.06217782649107]],
-    [[-1.5000000000000013, 4.330127018922193, 0], [-5.51091059616309e-16, 5, 0],
-      [-4.772588574262082e-16, 4.330127018922194, -3.4999999999999996], [-1.2990381056766591, 3.75, -3.4999999999999996]],
-    [[-1.2990381056766591, 3.75, 3.4999999999999996], [-4.772588574262082e-16, 4.330127018922194, 3.4999999999999996],
-      [-5.51091059616309e-16, 5, 0], [-1.5000000000000013, 4.330127018922193, 0]],
-    [[-1.2990381056766591, 3.75, -3.4999999999999996], [-4.772588574262082e-16, 4.330127018922194, -3.4999999999999996],
-      [-2.7554552980815453e-16, 2.5000000000000004, -6.06217782649107], [-0.7500000000000009, 2.165063509461097, -6.06217782649107]],
-    [[-0.7500000000000009, 2.165063509461097, 6.06217782649107], [-2.7554552980815453e-16, 2.5000000000000004, 6.06217782649107],
-      [-4.772588574262082e-16, 4.330127018922194, 3.4999999999999996], [-1.2990381056766591, 3.75, 3.4999999999999996]],
-    [[-0.7500000000000009, 2.165063509461097, -6.06217782649107], [-2.7554552980815453e-16, 2.5000000000000004, -6.06217782649107], [-9.184850993605157e-17, 2.651438096812267e-16, -7]],
-    [[-9.184850993605157e-17, 2.651438096812267e-16, 7], [-2.7554552980815453e-16, 2.5000000000000004, 6.06217782649107], [-0.7500000000000009, 2.165063509461097, 6.06217782649107]],
-    [[-5.51091059616309e-16, 5, 0], [1.5000000000000004, 4.330127018922193, 0],
-      [1.2990381056766584, 3.75, -3.4999999999999996], [-4.772588574262082e-16, 4.330127018922194, -3.4999999999999996]],
-    [[-4.772588574262082e-16, 4.330127018922194, 3.4999999999999996], [1.2990381056766584, 3.75, 3.4999999999999996],
-      [1.5000000000000004, 4.330127018922193, 0], [-5.51091059616309e-16, 5, 0]],
-    [[-4.772588574262082e-16, 4.330127018922194, -3.4999999999999996], [1.2990381056766584, 3.75, -3.4999999999999996],
-      [0.7500000000000004, 2.165063509461097, -6.06217782649107], [-2.7554552980815453e-16, 2.5000000000000004, -6.06217782649107]],
-    [[-2.7554552980815453e-16, 2.5000000000000004, 6.06217782649107], [0.7500000000000004, 2.165063509461097, 6.06217782649107],
-      [1.2990381056766584, 3.75, 3.4999999999999996], [-4.772588574262082e-16, 4.330127018922194, 3.4999999999999996]],
-    [[-2.7554552980815453e-16, 2.5000000000000004, -6.06217782649107], [0.7500000000000004, 2.165063509461097, -6.06217782649107], [-3.3744595109891796e-32, 3.061616997868383e-16, -7]],
-    [[-3.3744595109891796e-32, 3.061616997868383e-16, 7], [0.7500000000000004, 2.165063509461097, 6.06217782649107], [-2.7554552980815453e-16, 2.5000000000000004, 6.06217782649107]],
+    [[-1.2990381056766584, 1.2499999999999996, -6.06217782649107], [-0.7500000000000009, 2.165063509461097, -6.06217782649107], [0, 0, -7]],
+    [[0, 0, 7], [-0.7500000000000009, 2.165063509461097, 6.06217782649107], [-1.2990381056766584, 1.2499999999999996, 6.06217782649107]],
+    [[-1.5000000000000013, 4.330127018922193, 0], [0, 5, 0],
+      [0, 4.330127018922194, -3.4999999999999996], [-1.2990381056766591, 3.75, -3.4999999999999996]],
+    [[-1.2990381056766591, 3.75, 3.4999999999999996], [0, 4.330127018922194, 3.4999999999999996],
+      [0, 5, 0], [-1.5000000000000013, 4.330127018922193, 0]],
+    [[-1.2990381056766591, 3.75, -3.4999999999999996], [0, 4.330127018922194, -3.4999999999999996],
+      [0, 2.5000000000000004, -6.06217782649107], [-0.7500000000000009, 2.165063509461097, -6.06217782649107]],
+    [[-0.7500000000000009, 2.165063509461097, 6.06217782649107], [0, 2.5000000000000004, 6.06217782649107],
+      [0, 4.330127018922194, 3.4999999999999996], [-1.2990381056766591, 3.75, 3.4999999999999996]],
+    [[-0.7500000000000009, 2.165063509461097, -6.06217782649107], [0, 2.5000000000000004, -6.06217782649107], [0, 0, -7]],
+    [[0, 0, 7], [0, 2.5000000000000004, 6.06217782649107], [-0.7500000000000009, 2.165063509461097, 6.06217782649107]],
+    [[0, 5, 0], [1.5000000000000004, 4.330127018922193, 0],
+      [1.2990381056766584, 3.75, -3.4999999999999996], [0, 4.330127018922194, -3.4999999999999996]],
+    [[0, 4.330127018922194, 3.4999999999999996], [1.2990381056766584, 3.75, 3.4999999999999996],
+      [1.5000000000000004, 4.330127018922193, 0], [0, 5, 0]],
+    [[0, 4.330127018922194, -3.4999999999999996], [1.2990381056766584, 3.75, -3.4999999999999996],
+      [0.7500000000000004, 2.165063509461097, -6.06217782649107], [0, 2.5000000000000004, -6.06217782649107]],
+    [[0, 2.5000000000000004, 6.06217782649107], [0.7500000000000004, 2.165063509461097, 6.06217782649107],
+      [1.2990381056766584, 3.75, 3.4999999999999996], [0, 4.330127018922194, 3.4999999999999996]],
+    [[0, 2.5000000000000004, -6.06217782649107], [0.7500000000000004, 2.165063509461097, -6.06217782649107], [0, 0, -7]],
+    [[0, 0, 7], [0.7500000000000004, 2.165063509461097, 6.06217782649107], [0, 2.5000000000000004, 6.06217782649107]],
     [[1.5000000000000004, 4.330127018922193, 0], [2.598076211353315, 2.500000000000002, 0],
       [2.2499999999999996, 2.1650635094610986, -3.4999999999999996], [1.2990381056766584, 3.75, -3.4999999999999996]],
     [[1.2990381056766584, 3.75, 3.4999999999999996], [2.2499999999999996, 2.1650635094610986, 3.4999999999999996],
@@ -126,27 +127,27 @@ test('ellipsoid (options)', (t) => {
       [1.2990381056766578, 1.2500000000000013, -6.06217782649107], [0.7500000000000004, 2.165063509461097, -6.06217782649107]],
     [[0.7500000000000004, 2.165063509461097, 6.06217782649107], [1.2990381056766578, 1.2500000000000013, 6.06217782649107],
       [2.2499999999999996, 2.1650635094610986, 3.4999999999999996], [1.2990381056766584, 3.75, 3.4999999999999996]],
-    [[0.7500000000000004, 2.165063509461097, -6.06217782649107], [1.2990381056766578, 1.2500000000000013, -6.06217782649107], [9.184850993605152e-17, 2.651438096812267e-16, -7]],
-    [[9.184850993605152e-17, 2.651438096812267e-16, 7], [1.2990381056766578, 1.2500000000000013, 6.06217782649107], [0.7500000000000004, 2.165063509461097, 6.06217782649107]],
-    [[2.598076211353315, 2.500000000000002, 0], [3, 1.2246467991473533e-15, 0],
-      [2.598076211353316, 1.060575238724907e-15, -3.4999999999999996], [2.2499999999999996, 2.1650635094610986, -3.4999999999999996]],
-    [[2.2499999999999996, 2.1650635094610986, 3.4999999999999996], [2.598076211353316, 1.060575238724907e-15, 3.4999999999999996],
-      [3, 1.2246467991473533e-15, 0], [2.598076211353315, 2.500000000000002, 0]],
-    [[2.2499999999999996, 2.1650635094610986, -3.4999999999999996], [2.598076211353316, 1.060575238724907e-15, -3.4999999999999996],
-      [1.5000000000000004, 6.123233995736767e-16, -6.06217782649107], [1.2990381056766578, 1.2500000000000013, -6.06217782649107]],
-    [[1.2990381056766578, 1.2500000000000013, 6.06217782649107], [1.5000000000000004, 6.123233995736767e-16, 6.06217782649107],
-      [2.598076211353316, 1.060575238724907e-15, 3.4999999999999996], [2.2499999999999996, 2.1650635094610986, 3.4999999999999996]],
-    [[1.2990381056766578, 1.2500000000000013, -6.06217782649107], [1.5000000000000004, 6.123233995736767e-16, -6.06217782649107], [1.5908628580873598e-16, 1.5308084989341928e-16, -7]],
-    [[1.5908628580873598e-16, 1.5308084989341928e-16, 7], [1.5000000000000004, 6.123233995736767e-16, 6.06217782649107], [1.2990381056766578, 1.2500000000000013, 6.06217782649107]]
+    [[0.7500000000000004, 2.165063509461097, -6.06217782649107], [1.2990381056766578, 1.2500000000000013, -6.06217782649107], [0, 0, -7]],
+    [[0, 0, 7], [1.2990381056766578, 1.2500000000000013, 6.06217782649107], [0.7500000000000004, 2.165063509461097, 6.06217782649107]],
+    [[2.598076211353315, 2.500000000000002, 0], [3, 0, 0],
+      [2.598076211353316, 0, -3.4999999999999996], [2.2499999999999996, 2.1650635094610986, -3.4999999999999996]],
+    [[2.2499999999999996, 2.1650635094610986, 3.4999999999999996], [2.598076211353316, 0, 3.4999999999999996],
+      [3, 0, 0], [2.598076211353315, 2.500000000000002, 0]],
+    [[2.2499999999999996, 2.1650635094610986, -3.4999999999999996], [2.598076211353316, 0, -3.4999999999999996],
+      [1.5000000000000004, 0, -6.06217782649107], [1.2990381056766578, 1.2500000000000013, -6.06217782649107]],
+    [[1.2990381056766578, 1.2500000000000013, 6.06217782649107], [1.5000000000000004, 0, 6.06217782649107],
+      [2.598076211353316, 0, 3.4999999999999996], [2.2499999999999996, 2.1650635094610986, 3.4999999999999996]],
+    [[1.2990381056766578, 1.2500000000000013, -6.06217782649107], [1.5000000000000004, 0, -6.06217782649107], [0, 0, -7]],
+    [[0, 0, 7], [1.5000000000000004, 0, 6.06217782649107], [1.2990381056766578, 1.2500000000000013, 6.06217782649107]]
   ]
+  t.notThrows(() => geom3.validate(obs))
   t.is(pts.length, 72)
   t.true(comparePolygonsAsPoints(pts, exp))
 
   // test segments
   obs = ellipsoid({ segments: 8 })
   pts = geom3.toPoints(obs)
-  exp = [
-  ]
+  t.notThrows(() => geom3.validate(obs))
   t.is(pts.length, 32)
 
   obs = ellipsoid({ center: [-3, 5, 7], segments: 8 })
@@ -202,6 +203,7 @@ test('ellipsoid (options)', (t) => {
     [[-3, 5, 8], [-2.2928932188134525, 5, 7.707106781186548], [-2.5, 5.5, 7.707106781186548]]
   ]
 
+  t.notThrows(() => geom3.validate(obs))
   t.is(pts.length, 32)
   t.true(comparePolygonsAsPoints(pts, exp))
 })

package/src/primitives/geodesicSphere.d.ts

@@ -1,4 +1,3 @@
-import Vec3 from '../maths/vec3/type'
 import Geom3 from '../geometries/geom3/type'
 
 export default geodesicSphere

package/src/primitives/geodesicSphere.test.js

@@ -9,6 +9,7 @@ const comparePolygonsAsPoints = require('../../test/helpers/comparePolygonsAsPoi
 test('geodesicSphere (defaults)', (t) => {
   const obs = geodesicSphere()
   const pts = geom3.toPoints(obs)
+  t.notThrows(() => geom3.validate(obs))
   t.is(pts.length, 20)
 })
 
@@ -39,6 +40,7 @@ test('geodesicSphere (options)', (t) => {
     [[0, -2.628654726407001, -4.253254557317035], [2.628654726407001, -4.253254557317035, 0], [-2.628654726407001, -4.253254557317035, 0]]
   ]
 
+  t.notThrows(() => geom3.validate(obs))
   t.is(pts.length, 20)
   t.true(comparePolygonsAsPoints(pts, exp))
 
@@ -46,5 +48,6 @@ test('geodesicSphere (options)', (t) => {
   obs = geodesicSphere({ radius: 5, frequency: 18 })
   pts = geom3.toPoints(obs)
 
+  t.notThrows.skip(() => geom3.validate(obs))
   t.is(pts.length, 180)
 })

package/src/primitives/line.test.js

@@ -11,6 +11,7 @@ test('line (defaults)', (t) => {
   const geometry = line([[0, 0], [1, 1], [-3, 3]])
   const obs = path2.toPoints(geometry)
 
+  t.notThrows(() => path2.validate(geometry))
   t.deepEqual(obs.length, 3)
   t.true(comparePoints(obs, exp))
 })