@jscad/modeling 2.7.1 → 2.9.0

package/src/maths/line2/intersectPointOfLines.js

@@ -5,7 +5,7 @@ const { solve2Linear } = require('../utils')
  * Return the point of intersection between the given lines.
  *
  * NOTES:
- * The point will have Infinity values if the lines are paralell.
+ * The point will have Infinity values if the lines are parallel.
  * The point will have NaN values if the lines are the same.
  *
  * @param {line2} line1 - line of reference

package/src/maths/line2/intersectPointOfLines.test.js

@@ -15,7 +15,7 @@ test('line2: intersectPointOfLines() should return proper points', (t) => {
   const int3 = intersectPointOfLines(line3, line2)
   t.true(compareVectors(int3, [NaN, NaN]))
 
-  // paralell lines
+  // parallel lines
   const line4 = fromPoints(create(), [0, 6], [6, 0])
   const int4 = intersectPointOfLines(line4, line3)
   t.true(compareVectors(int4, [Infinity, -Infinity]))

package/src/maths/line2/reverse.test.js

@@ -3,7 +3,7 @@ const { reverse, create, fromPoints } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('line2: reverse() called with two paramerters should update a line2 with proper values', (t) => {
+test('line2: reverse() called with two parameters should update a line2 with proper values', (t) => {
   const line1 = create()
   const obs1 = create()
   const ret1 = reverse(obs1, line1)

package/src/maths/line2/transform.test.js

@@ -3,7 +3,7 @@ const { transform, create, fromPoints } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('line2: transform() called with three paramerters should update a line2 with correct values', (t) => {
+test('line2: transform() called with three parameters should update a line2 with correct values', (t) => {
   const line1 = create()
   const line2 = fromPoints(create(), [0, 0], [0, 1])
   const line3 = fromPoints(create(), [-3, -3], [3, 3])

package/src/maths/line3/equals.js

@@ -3,8 +3,8 @@ const vec3 = require('../vec3')
 /**
  * Compare the given lines for equality.
  *
- * @param {line3} a - first line to compare
- * @param {line3} b - second line to compare
+ * @param {line3} line1 - first line to compare
+ * @param {line3} line2 - second line to compare
  * @return {Boolean} true if lines are equal
  * @alias module:modeling/maths/line3.equals
  */

package/src/maths/line3/reverse.test.js

@@ -3,7 +3,7 @@ const { reverse, create, fromPoints } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('line3: reverse() called with two paramerters should update a line3 with proper values', (t) => {
+test('line3: reverse() called with two parameters should update a line3 with proper values', (t) => {
   const line1 = create()
   const out = create()
   let rev = reverse(out, line1)

package/src/maths/line3/transform.test.js

@@ -3,7 +3,7 @@ const { transform, create, fromPoints } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('line3: transform() called with three paramerters should update a line3 with correct values', (t) => {
+test('line3: transform() called with three parameters should update a line3 with correct values', (t) => {
   const line1 = create()
   const line2 = fromPoints(create(), [1, 0, 0], [0, 1, 0])
   const line3 = fromPoints(create(), [-3, -3, -3], [3, 3, 3])

package/src/maths/mat4/fromRotation.js

@@ -19,7 +19,7 @@ const { EPSILON } = require('./constants')
  */
 const fromRotation = (out, rad, axis) => {
   let [x, y, z] = axis
-  let len = Math.sqrt(x * x + y * y + z * z)
+  let len = Math.hypot(x, y, z)
 
   if (Math.abs(len) < EPSILON) {
     // axis is 0,0,0 or almost

package/src/maths/mat4/fromVectorRotation.js

@@ -5,7 +5,7 @@ const fromRotation = require('./fromRotation')
 /**
  * Create a matrix that rotates the given source to the given target vector.
  *
- * Each vector must be a directional vector with a length greater then zero.
+ * Each vector must be a directional vector with a length greater than zero.
  * @see https://gist.github.com/kevinmoran/b45980723e53edeb8a5a43c49f134724
  * @param {mat4} out - receiving matrix
  * @param {vec3} source - source vector

package/src/maths/mat4/fromVectorRotation.test.js

@@ -96,7 +96,7 @@ test('mat4: fromVectorRotation() called with out parameter should return a mat4
   t.is(ret, out)
   t.true(compareVectors(out, [1, 0, 0, 0, 0, -1, 0, 0, 0, 0, -1, 0, 0, 0, 0, 1]))
 
-  // differnt units
+  // different units
   ret = fromVectorRotation(out, [11, 0, 0], [0, 33, 0])
   t.is(ret, out)
   t.true(compareVectors(out, [0, 1, 0, 0, -1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1]))

package/src/maths/mat4/identity.test.js

@@ -3,7 +3,7 @@ const { identity } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('mat4: identity() called with one paramerters should update a mat4 with correct values', (t) => {
+test('mat4: identity() called with one parameters should update a mat4 with correct values', (t) => {
   const obs1 = [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
   const ret1 = identity(obs1)
   t.true(compareVectors(obs1, [1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1]))

package/src/maths/mat4/invert.js

@@ -4,27 +4,27 @@
  * code from https://github.com/jlmakes/rematrix/blob/master/src/index.js
  *
  * @param {mat4} out - receiving matrix
- * @param {mat4} m - matrix to invert
+ * @param {mat4} matrix - matrix to invert
  * @returns {mat4} out
  * @alias module:modeling/maths/mat4.invert
  */
-const invert = (out, a) => {
-  const a00 = a[0]
-  const a01 = a[1]
-  const a02 = a[2]
-  const a03 = a[3]
-  const a10 = a[4]
-  const a11 = a[5]
-  const a12 = a[6]
-  const a13 = a[7]
-  const a20 = a[8]
-  const a21 = a[9]
-  const a22 = a[10]
-  const a23 = a[11]
-  const a30 = a[12]
-  const a31 = a[13]
-  const a32 = a[14]
-  const a33 = a[15]
+const invert = (out, matrix) => {
+  const a00 = matrix[0]
+  const a01 = matrix[1]
+  const a02 = matrix[2]
+  const a03 = matrix[3]
+  const a10 = matrix[4]
+  const a11 = matrix[5]
+  const a12 = matrix[6]
+  const a13 = matrix[7]
+  const a20 = matrix[8]
+  const a21 = matrix[9]
+  const a22 = matrix[10]
+  const a23 = matrix[11]
+  const a30 = matrix[12]
+  const a31 = matrix[13]
+  const a32 = matrix[14]
+  const a33 = matrix[15]
 
   const b00 = a00 * a11 - a01 * a10
   const b01 = a00 * a12 - a02 * a10

package/src/maths/mat4/isIdentity.js

@@ -1,5 +1,5 @@
 /**
- * Determine whether the given matris is the identity transform.
+ * Determine whether the given matrix is the identity transform.
  * This is equivalent to (but much faster than):
  *
  *     mat4.equals(mat4.create(), matrix)

package/src/maths/mat4/isIdentity.test.js

@@ -2,8 +2,6 @@ const test = require('ava')
 
 const { isIdentity, create, fromTranslation } = require('./index')
 
-const { compareVectors } = require('../../../test/helpers/index')
-
 test('mat4: isIdentity() should return correct values', (t) => {
   const identity = create() // identity matrix
   t.true(isIdentity(identity))

package/src/maths/mat4/isMirroring.js

@@ -9,10 +9,10 @@ const fromValues = require('../vec3/fromValues')
  * @returns {Boolean} true if matrix is a mirroring transformation
  * @alias module:modeling/maths/mat4.isMirroring
  */
-const isMirroring = (mat) => {
-  const u = fromValues(mat[0], mat[4], mat[8])
-  const v = fromValues(mat[1], mat[5], mat[9])
-  const w = fromValues(mat[2], mat[6], mat[10])
+const isMirroring = (matrix) => {
+  const u = fromValues(matrix[0], matrix[4], matrix[8])
+  const v = fromValues(matrix[1], matrix[5], matrix[9])
+  const w = fromValues(matrix[2], matrix[6], matrix[10])
 
   // for a true orthogonal, non-mirrored base, u.cross(v) == w
   // If they have an opposite direction then we are mirroring

package/src/maths/mat4/isMirroring.test.js

@@ -4,7 +4,7 @@ const plane = require('../plane')
 
 const { isMirroring, fromScaling, create, mirrorByPlane, rotate, scale, translate } = require('./index')
 
-test('mat4: isMirroring() should determine correctlly', (t) => {
+test('mat4: isMirroring() should determine correctly', (t) => {
   let matrix = create()
   t.false(isMirroring(matrix))
 

package/src/maths/mat4/leftMultiplyVec3.js

@@ -8,7 +8,7 @@ const fromValues = require('../vec3/fromValues')
  * @param {mat4} matrix the input matrix
  * @returns {vec3} output
  */
-const lefttMultiplyVec3 = (vector, matrix) => {
+const leftMultiplyVec3 = (vector, matrix) => {
   const [v0, v1, v2] = vector
   const v3 = 1
   let x = v0 * matrix[0] + v1 * matrix[4] + v2 * matrix[8] + v3 * matrix[12]
@@ -26,4 +26,4 @@ const lefttMultiplyVec3 = (vector, matrix) => {
   return fromValues(x, y, z)
 }
 
-module.exports = lefttMultiplyVec3
+module.exports = leftMultiplyVec3

package/src/maths/mat4/rotate.js

@@ -12,7 +12,7 @@ const copy = require('./copy')
  */
 const rotate = (out, matrix, radians, axis) => {
   let [x, y, z] = axis
-  let len = Math.sqrt(x * x + y * y + z * z)
+  let len = Math.hypot(x, y, z)
 
   if (Math.abs(len) < 0.000001) {
     // axis is 0,0,0 or almost

package/src/maths/mat4/toString.js

@@ -1,10 +1,10 @@
 /**
  * Return a string representing the given matrix.
  *
- * @param {mat4} matrix - matrix of reference
+ * @param {mat4} mat - matrix of reference
  * @returns {String} string representation
  * @alias module:modeling/maths/mat4.toString
  */
-const toString = (mat) => `[${mat[0].toFixed(7)}, ${mat[1].toFixed(7)}, ${mat[2].toFixed(7)}, ${mat[3].toFixed(7)}, ${mat[4].toFixed(7)}, ${mat[5].toFixed(7)}, ${mat[6].toFixed(7)}, ${mat[7].toFixed(7)}, ${mat[8].toFixed(7)}, ${mat[9].toFixed(7)}, ${mat[10].toFixed(7)}, ${mat[11].toFixed(7)}, ${mat[12].toFixed(7)}, ${mat[13].toFixed(7)}, ${mat[14].toFixed(7)}, ${mat[15].toFixed(7)}]`
+const toString = (mat) => mat.map((n) => n.toFixed(7)).toString()
 
 module.exports = toString

package/src/maths/mat4/translate.test.js

@@ -3,7 +3,7 @@ const { translate, create } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('mat4: translate() called with three paramerters should update a mat4 with correct values', (t) => {
+test('mat4: translate() called with three parameters should update a mat4 with correct values', (t) => {
   const identityMatrix = [
     1, 0, 0, 0,
     0, 1, 0, 0,

package/src/maths/plane/flip.test.js

@@ -3,7 +3,7 @@ const { create, flip } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('plane: flip() called with two paramerters should update a plane with correct values', (t) => {
+test('plane: flip() called with two parameters should update a plane with correct values', (t) => {
   const org1 = create()
   const ret1 = flip(org1, [0, 0, 0, 0])
   t.true(compareVectors(org1, [-0, -0, -0, -0]))

package/src/maths/plane/fromPoints.d.ts

@@ -3,4 +3,4 @@ import Vec3 from '../vec3/type'
 
 export default fromPoints
 
-declare function fromPoints(out: Plane, a: Vec3, b: Vec3, c: Vec3): Plane
+declare function fromPoints(out: Plane, ...vertices: Array<Vec3>): Plane

package/src/maths/plane/fromPoints.js

@@ -4,9 +4,7 @@ const vec3 = require('../vec3')
  * Create a plane from the given points.
  *
  * @param {plane} out - receiving plane
- * @param {vec3} a - 3D point
- * @param {vec3} b - 3D point
- * @param {vec3} c - 3D point
+ * @param {Array} vertices - points on the plane
  * @returns {plane} out
  * @alias module:modeling/maths/plane.fromPoints
  */

package/src/maths/plane/signedDistanceToPoint.js

@@ -8,6 +8,6 @@ const vec3 = require('../vec3')
  * @return {Number} signed distance to point
  * @alias module:modeling/maths/plane.signedDistanceToPoint
  */
-const signedDistanceToPoint = (plane, vector) => vec3.dot(plane, vector) - plane[3]
+const signedDistanceToPoint = (plane, point) => vec3.dot(plane, point) - plane[3]
 
 module.exports = signedDistanceToPoint

package/src/maths/plane/transform.test.js

@@ -3,7 +3,7 @@ const { transform, create, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('plane: transform() called with three paramerters should return a plane with correct values', (t) => {
+test('plane: transform() called with three parameters should return a plane with correct values', (t) => {
   const identityMatrix = [
     1, 0, 0, 0,
     0, 1, 0, 0,

package/src/maths/utils/aboutEqualNormals.js

@@ -1,5 +1,5 @@
-// Normals are directional vectors with component values from 0 to 1.0, requiring specialized comparision
-// This EPS is derived from a serieas of tests to determine the optimal precision for comparing coplanar polygons,
+// Normals are directional vectors with component values from 0 to 1.0, requiring specialized comparison
+// This EPS is derived from a series of tests to determine the optimal precision for comparing coplanar polygons,
 // as provided by the sphere primitive at high segmentation
 // This EPS is for 64 bit Number values
 const NEPS = 1e-13

package/src/maths/vec2/abs.d.ts

@@ -2,4 +2,4 @@ import Vec2 from './type'
 
 export default abs
 
-declare function abs(out: Vec2, vec: Vec2): Vec2
+declare function abs(out: Vec2, vector: Vec2): Vec2

package/src/maths/vec2/add.test.js

@@ -3,7 +3,7 @@ const { add, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('vec2: add() called with three paramerters should update a vec2 with correct values', (t) => {
+test('vec2: add() called with three parameters should update a vec2 with correct values', (t) => {
   const obs1 = fromValues(0, 0)
   const ret1 = add(obs1, [0, 0], [0, 0])
   t.true(compareVectors(obs1, [0, 0]))

package/src/maths/vec2/angleDegrees.d.ts

@@ -2,4 +2,4 @@ import Vec2 from './type'
 
 export default angleDegrees
 
-declare function angleDegrees(vec: Vec2): number
+declare function angleDegrees(vector: Vec2): number

package/src/maths/vec2/angleRadians.d.ts

@@ -2,4 +2,4 @@ import Vec2 from './type'
 
 export default angleRadians
 
-declare function angleRadians(vec: Vec2): number
+declare function angleRadians(vector: Vec2): number

package/src/maths/vec2/create.js

@@ -5,7 +5,7 @@
  */
 
 /**
- * Creates a new vector, intialized to [0,0].
+ * Creates a new vector, initialized to [0,0].
  *
  * @returns {vec2} a new vector
  * @alias module:modeling/maths/vec2.create

package/src/maths/vec2/cross.test.js

@@ -3,7 +3,7 @@ const { cross } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('vec2: cross() called with three paramerters should update a vec2 with correct values', (t) => {
+test('vec2: cross() called with three parameters should update a vec2 with correct values', (t) => {
   const obs1 = [0, 0, 0]
   const ret1 = cross(obs1, [0, 0], [0, 0])
   t.true(compareVectors(obs1, [0, 0, 0]))

package/src/maths/vec2/divide.test.js

@@ -3,7 +3,7 @@ const { divide, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('vec2: divide() called with three paramerters should update a vec2 with correct values', (t) => {
+test('vec2: divide() called with three parameters should update a vec2 with correct values', (t) => {
   const obs1 = fromValues(0, 0)
   const ret1 = divide(obs1, [0, 0], [0, 0])
   t.true(compareVectors(obs1, [0 / 0, 0 / 0]))

package/src/maths/vec2/fromAngleDegrees.js

@@ -4,7 +4,7 @@ const fromAngleRadians = require('./fromAngleRadians')
  * Create a new vector in the direction of the given angle.
  *
  * @param {vec2} out - receiving vector
- * @param {Number} angle - angle in degrees
+ * @param {Number} degrees - angle in degrees
  * @returns {vec2} out
  * @alias module:modeling/maths/vec2.fromAngleDegrees
  */

package/src/maths/vec2/fromScalar.js

@@ -3,7 +3,7 @@
  *
  * @param {vec2} out - receiving vector
  * @param {Number} scalar - the scalar value
- * @returns {Vec2} out
+ * @returns {vec2} out
  * @alias module:modeling/maths/vec2.fromScalar
  */
 const fromScalar = (out, scalar) => {

package/src/maths/vec2/length.d.ts

@@ -2,4 +2,4 @@ import Vec2 from './type'
 
 export default length
 
-declare function length(a: Vec2): number
+declare function length(vector: Vec2): number

package/src/maths/vec2/length.js

@@ -5,6 +5,6 @@
  * @returns {Number} length
  * @alias module:modeling/maths/vec2.length
  */
-const length = (a) => Math.hypot(a[0], a[1])
+const length = (vector) => Math.hypot(vector[0], vector[1])
 
 module.exports = length

package/src/maths/vec2/length.test.js

@@ -25,5 +25,15 @@ test('vec2: length() should return correct values', (t) => {
   const length5 = length(vec5)
   nearlyEqual(t, length5, 2.23606, EPS)
 
+  // huge vector
+  const vec6 = fromValues(1e200, 1e200)
+  const length6 = length(vec6)
+  nearlyEqual(t, length6, Math.SQRT2 * 1e200, EPS)
+
+  // tiny vector
+  const vec7 = fromValues(1e-200, 1e-200)
+  const length7 = length(vec7)
+  nearlyEqual(t, length7, Math.SQRT2 * 1e-200, EPS)
+
   t.true(true)
 })

package/src/maths/vec2/lerp.test.js

@@ -3,7 +3,7 @@ const { lerp, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('vec2: lerp() called with three paramerters should update a vec2 with correct values', (t) => {
+test('vec2: lerp() called with three parameters should update a vec2 with correct values', (t) => {
   const obs1 = fromValues(0, 0)
   const ret1 = lerp(obs1, [0, 0], [0, 0], 0)
   t.true(compareVectors(obs1, [0, 0]))

package/src/maths/vec2/multiply.test.js

@@ -3,7 +3,7 @@ const { multiply, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('vec2: multiply() called with three paramerters should update a vec2 with correct values', (t) => {
+test('vec2: multiply() called with three parameters should update a vec2 with correct values', (t) => {
   const obs1 = fromValues(0, 0)
   const ret1 = multiply(obs1, [0, 0], [0, 0])
   t.true(compareVectors(obs1, [0, 0]))

package/src/maths/vec2/negate.test.js

@@ -3,7 +3,7 @@ const { negate, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('vec2: negate() called with two paramerters should update a vec2 with correct values', (t) => {
+test('vec2: negate() called with two parameters should update a vec2 with correct values', (t) => {
   const obs1 = fromValues(0, 0)
   const ret1 = negate(obs1, [0, 0])
   t.true(compareVectors(obs1, [0, 0]))

package/src/maths/vec2/normal.js

@@ -3,7 +3,7 @@ const rotate = require('./rotate')
 
 /**
  * Calculates the normal of the given vector.
- * The normal value is the given vector rotated 90 degress.
+ * The normal value is the given vector rotated 90 degrees.
  *
  * @param {vec2} out - receiving vector
  * @param {vec2} vector - given value

package/src/maths/vec2/normalize.d.ts

@@ -2,4 +2,4 @@ import Vec2 from './type'
 
 export default normalize
 
-declare function normalize(out: Vec2, vec:  Vec2): Vec2
+declare function normalize(out: Vec2, vector: Vec2): Vec2

package/src/maths/vec2/normalize.test.js

@@ -3,7 +3,7 @@ const { normalize, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('vec2: normalize() called with two paramerters should update a vec2 with correct values', (t) => {
+test('vec2: normalize() called with two parameters should update a vec2 with correct values', (t) => {
   const obs1 = fromValues(0, 0)
   const ret1 = normalize(obs1, [0, 0])
   t.true(compareVectors(obs1, [0, 0]))

package/src/maths/vec2/rotate.test.js

@@ -3,7 +3,7 @@ const { rotate, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('vec2: rotate() called with three paramerters should update a vec2 with correct values', (t) => {
+test('vec2: rotate() called with three parameters should update a vec2 with correct values', (t) => {
   const radians = 90 * Math.PI / 180
 
   const obs1 = fromValues(0, 0)

package/src/maths/vec2/squaredLength.d.ts

@@ -2,4 +2,4 @@ import Vec2 from './type'
 
 export default squaredLength
 
-declare function squaredLength(vec: Vec2): number
+declare function squaredLength(vector: Vec2): number

package/src/maths/vec2/squaredLength.js

@@ -5,9 +5,9 @@
  * @returns {Number} squared length
  * @alias module:modeling/maths/vec2.squaredLength
  */
-const squaredLength = (a) => {
-  const x = a[0]
-  const y = a[1]
+const squaredLength = (vector) => {
+  const x = vector[0]
+  const y = vector[1]
   return x * x + y * y
 }
 

package/src/maths/vec2/subtract.test.js

@@ -3,7 +3,7 @@ const { subtract, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('vec2: subtract() called with three paramerters should update a vec2 with correct values', (t) => {
+test('vec2: subtract() called with three parameters should update a vec2 with correct values', (t) => {
   const obs1 = fromValues(0, 0)
   const ret1 = subtract(obs1, [0, 0], [0, 0])
   t.true(compareVectors(obs1, [0, 0]))

package/src/maths/vec2/toString.js

@@ -5,6 +5,6 @@
  * @returns {String} string representation
  * @alias module:modeling/maths/vec2.toString
  */
-const toString = (vec) => `[${vec[0].toFixed(7)}, ${vec[1].toFixed(7)}]`
+const toString = (vector) => `[${vector[0].toFixed(7)}, ${vector[1].toFixed(7)}]`
 
 module.exports = toString

package/src/maths/vec2/transform.test.js

@@ -3,7 +3,7 @@ const { transform, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('vec2: transform() called with three paramerters should update a vec2 with correct values', (t) => {
+test('vec2: transform() called with three parameters should update a vec2 with correct values', (t) => {
   const identityMatrix = [
     1, 0, 0, 0,
     0, 1, 0, 0,

package/src/maths/vec3/abs.d.ts

@@ -2,4 +2,4 @@ import Vec3 from './type'
 
 export default abs
 
-declare function abs(out: Vec3, vec: Vec3): Vec3
+declare function abs(out: Vec3, vector: Vec3): Vec3

package/src/maths/vec3/add.test.js

@@ -3,7 +3,7 @@ const { add, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('vec3: add() called with three paramerters should update a vec3 with correct values', (t) => {
+test('vec3: add() called with three parameters should update a vec3 with correct values', (t) => {
   const obs1 = fromValues(0, 0, 0)
   const ret1 = add(obs1, [0, 0, 0], [0, 0, 0])
   t.true(compareVectors(obs1, [0, 0, 0]))

package/src/maths/vec3/angle.js

@@ -15,8 +15,8 @@ const angle = (a, b) => {
   const bx = b[0]
   const by = b[1]
   const bz = b[2]
-  const mag1 = Math.sqrt(ax * ax + ay * ay + az * az)
-  const mag2 = Math.sqrt(bx * bx + by * by + bz * bz)
+  const mag1 = Math.hypot(ax, ay, az)
+  const mag2 = Math.hypot(bx, by, bz)
   const mag = mag1 * mag2
   const cosine = mag && dot(a, b) / mag
   return Math.acos(Math.min(Math.max(cosine, -1), 1))

package/src/maths/vec3/angle.test.js

@@ -25,5 +25,22 @@ test('vec3: angle() should return correct values', (t) => {
   const angle4 = angle(veca4, vec4)
   nearlyEqual(t, angle4, 3.14159, EPS)
 
+  const vec5a = fromValues(1, 0, 0)
+  const vec5b = fromValues(1, 1, 0)
+  const angle5 = angle(vec5a, vec5b)
+  nearlyEqual(t, angle5, 0.785398, EPS)
+
+  // tiny values
+  const vec6a = fromValues(1, 0, 0)
+  const vec6b = fromValues(1e-200, 1e-200, 0)
+  const angle6 = angle(vec6a, vec6b)
+  nearlyEqual(t, angle6, 0.785398, EPS)
+
+  // huge values
+  const vec7a = fromValues(1, 0, 0)
+  const vec7b = fromValues(1e200, 1e200, 0)
+  const angle7 = angle(vec7a, vec7b)
+  nearlyEqual(t, angle7, 0.785398, EPS)
+
   t.true(true)
 })

package/src/maths/vec3/cross.test.js

@@ -3,7 +3,7 @@ const { cross, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('vec3: cross() called with three paramerters should update a vec3 with correct values', (t) => {
+test('vec3: cross() called with three parameters should update a vec3 with correct values', (t) => {
   const obs1 = fromValues(0, 0, 0)
   const ret1 = cross(obs1, [0, 0, 0], [0, 0, 0])
   t.true(compareVectors(obs1, [0, 0, 0]))

package/src/maths/vec3/divide.test.js

@@ -3,7 +3,7 @@ const { divide, fromValues } = require('./index')
 
 const { compareVectors } = require('../../../test/helpers/index')
 
-test('vec3: divide() called with three paramerters should update a vec3 with correct values', (t) => {
+test('vec3: divide() called with three parameters should update a vec3 with correct values', (t) => {
   const obs1 = fromValues(0, 0, 0)
   const ret1 = divide(obs1, [0, 0, 0], [0, 0, 0])
   t.true(compareVectors(obs1, [0 / 0, 0 / 0, 0 / 0]))