@js-ak/excel-toolbox 1.8.2 → 1.8.3

package/build/cjs/lib/zip/utils/to-bytes.js

@@ -17,21 +17,29 @@ const node_buffer_1 = require("node:buffer");
  * @returns {Buffer} - A new Buffer of exactly `len` bytes containing:
  *        1. The value's bytes in little-endian order (least significant byte first)
  *        2. Zero padding in any remaining higher-order bytes
- * @throws {RangeError} - If the value requires more bytes than `len` to represent
- *        (though this is currently not explicitly checked)
+ *
+ * @throws {RangeError} - If the length is not positive or the value is negative.
  */
 function toBytes(value, len) {
-    // Allocate a new Buffer of the requested length, automatically zero-filled
+    if (len <= 0)
+        throw new RangeError("Length must be a positive integer");
+    if (value < 0)
+        throw new RangeError("Negative values are not supported");
+    if (!Number.isSafeInteger(value))
+        throw new RangeError("Value must be a safe integer");
+    // Use BigInt to correctly handle 53-bit values
+    let bigint = BigInt(value);
     const buf = node_buffer_1.Buffer.alloc(len);
-    // Process each byte position from least significant to most significant
     for (let i = 0; i < len; i++) {
-        // Store the least significant byte of the current value
-        buf[i] = value & 0xff; // Mask to get bottom 8 bits
-        // Right-shift the value by 8 bits to process the next byte
-        // Note: This uses unsigned right shift (>>> would be signed)
-        value >>= 8;
-        // If the loop completes with value != 0, we've overflowed the buffer length,
-        // but this isn't currently checked/handled
+        // Extract the least significant byte and assign to buffer
+        buf[i] = Number(bigint & 0xffn);
+        bigint >>= 8n;
+        // Stop early if all remaining bits are zero
+        if (bigint === 0n)
+            break;
     }
+    // If bigint is still non-zero, it means we overflowed the buffer length
+    if (bigint > 0n)
+        throw new RangeError("Value exceeds the maximum size for the specified length");
     return buf;
 }

package/build/esm/lib/zip/utils/to-bytes.js

@@ -14,21 +14,29 @@ import { Buffer } from "node:buffer";
  * @returns {Buffer} - A new Buffer of exactly `len` bytes containing:
  *        1. The value's bytes in little-endian order (least significant byte first)
  *        2. Zero padding in any remaining higher-order bytes
- * @throws {RangeError} - If the value requires more bytes than `len` to represent
- *        (though this is currently not explicitly checked)
+ *
+ * @throws {RangeError} - If the length is not positive or the value is negative.
  */
 export function toBytes(value, len) {
-    // Allocate a new Buffer of the requested length, automatically zero-filled
+    if (len <= 0)
+        throw new RangeError("Length must be a positive integer");
+    if (value < 0)
+        throw new RangeError("Negative values are not supported");
+    if (!Number.isSafeInteger(value))
+        throw new RangeError("Value must be a safe integer");
+    // Use BigInt to correctly handle 53-bit values
+    let bigint = BigInt(value);
     const buf = Buffer.alloc(len);
-    // Process each byte position from least significant to most significant
     for (let i = 0; i < len; i++) {
-        // Store the least significant byte of the current value
-        buf[i] = value & 0xff; // Mask to get bottom 8 bits
-        // Right-shift the value by 8 bits to process the next byte
-        // Note: This uses unsigned right shift (>>> would be signed)
-        value >>= 8;
-        // If the loop completes with value != 0, we've overflowed the buffer length,
-        // but this isn't currently checked/handled
+        // Extract the least significant byte and assign to buffer
+        buf[i] = Number(bigint & 0xffn);
+        bigint >>= 8n;
+        // Stop early if all remaining bits are zero
+        if (bigint === 0n)
+            break;
     }
+    // If bigint is still non-zero, it means we overflowed the buffer length
+    if (bigint > 0n)
+        throw new RangeError("Value exceeds the maximum size for the specified length");
     return buf;
 }

package/build/types/lib/zip/utils/to-bytes.d.ts

@@ -14,7 +14,7 @@ import { Buffer } from "node:buffer";
  * @returns {Buffer} - A new Buffer of exactly `len` bytes containing:
  *        1. The value's bytes in little-endian order (least significant byte first)
  *        2. Zero padding in any remaining higher-order bytes
- * @throws {RangeError} - If the value requires more bytes than `len` to represent
- *        (though this is currently not explicitly checked)
+ *
+ * @throws {RangeError} - If the length is not positive or the value is negative.
  */
 export declare function toBytes(value: number, len: number): Buffer;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@js-ak/excel-toolbox",
-  "version": "1.8.2",
+  "version": "1.8.3",
   "description": "excel-toolbox",
   "publishConfig": {
     "access": "public",
@@ -44,7 +44,9 @@
     "lint": "eslint . --ext .ts",
     "postbuild:esm": "node scripts/write-esm-package.js",
     "postbuild:cjs": "node scripts/write-cjs-package.js",
-    "test": "vitest run",
+    "test:unit": "vitest run --config vitest.unit.config.js",
+    "test:integration": "vitest run --config vitest.integration.config.js",
+    "test": "npm run test:unit && npm run test:integration",
     "test:watch": "vitest",
     "test:coverage": "vitest run --coverage"
   },