@jrpool/kilotest 61.0.0 → 63.0.0

package/index.ts

@@ -88,6 +88,7 @@ import {response as requestNewTestAPI} from './api/requestNewTest.ts';
 import {response as orderNewTestAPI} from './api/orderNewTest.ts';
 import {response as orderRetestAPI} from './api/orderRetest.ts';
 import {response as awaitTestAPI} from './api/awaitTest.ts';
+import {response as reportDisagreementAPI} from './api/reportDisagreement.ts';
 
 // ENVIRONMENT
 
@@ -190,6 +191,7 @@ const apiRespond: {
   orderNewTest: ApiResponder;
   orderRetest: ApiResponder;
   awaitTest: ApiResponder;
+  reportDisagreement: ApiResponder;
 } = {
   getReport: getReportAPI,
   listDiagnoses: listDiagnosesAPI,
@@ -201,7 +203,8 @@ const apiRespond: {
   requestNewTest: requestNewTestAPI,
   orderNewTest: orderNewTestAPI,
   orderRetest: orderRetestAPI,
-  awaitTest: awaitTestAPI
+  awaitTest: awaitTestAPI,
+  reportDisagreement: reportDisagreementAPI
 };
 
 // CONSTANTS
@@ -1396,6 +1399,16 @@ const handleRequest = async (request: IncomingMessage, response: ServerResponse)
           setHeaders('application/json', null, 'ultra');
           response.end(JSON.stringify(responseBody));
         }
+        // Otherwise, if the service is to receive a disagreement with a diagnosis:
+        else if (segments[0] === 'reportDisagreement') {
+          const {engineID, ruleID, reason} = postData as {engineID: string; ruleID: string; reason: string};
+          // Get the response body.
+          const responseBody = await apiRespond.reportDisagreement(segments.slice(1).concat(engineID, ruleID, reason));
+          await recordPageMetric('apiOperations', 'reportDisagreement');
+          // Send it.
+          setHeaders('application/json', null, 'ultra');
+          response.end(JSON.stringify(responseBody));
+        }
         // Otherwise, if the service is to order an immediate, automatically approved test:
         else if (segments[0] === 'orderNewTest') {
           const {description, URL, reason} = postData as {description: string; URL: string; reason: string};
@@ -1516,7 +1529,19 @@ export {serve};
 
 // Starts the server using the configured protocol and credentials.
 export const startServer = async () => {
+  // Fail fast on missing required environment variables. THIS_KILOTEST_HOST is read raw
+  // by getThisHost and interpolated into URLs in every response; KEY and CERT are
+  // required only for HTTPS. Other env vars have documented defaults or designed
+  // degradation (see env.example and docs/SERVICE.md) and are deliberately not required.
+  const requiredEnvVars = ['THIS_KILOTEST_HOST'];
   const startProtocol = process.env.PROTOCOL || 'http';
+  if (startProtocol === 'https') {
+    requiredEnvVars.push('KEY', 'CERT');
+  }
+  const missingEnvVars = requiredEnvVars.filter(name => !process.env[name]);
+  if (missingEnvVars.length) {
+    throw new Error(`Missing required environment variable(s): ${missingEnvVars.join(', ')}`);
+  }
   if (startProtocol === 'http') {
     console.log('Starting HTTP server');
     return serve(http, {});
@@ -1532,7 +1557,10 @@ export const startServer = async () => {
 // Runs the server if the module was loaded directly (not required by a test). The starter is a parameter so tests can inject a spy, since ESM module exports cannot be monkey-patched.
 export const runIfMain = (mainModule: unknown, currentModule: unknown, starter: () => Promise<unknown> = startServer) => {
   if (mainModule === currentModule) {
-    starter().catch(error => console.log(errorMessage(error)));
+    starter().catch(error => {
+      console.log(errorMessage(error));
+      process.exitCode = 1;
+    });
   }
 };