@jrpool/kilotest 48.0.0 → 50.0.0

package/.claude/scheduled_tasks.lock

@@ -0,0 +1 @@
+{"sessionId":"f44e6b44-375e-4007-879a-19e4e5ed34a0","pid":90042,"procStart":"Sun Sep 20 03:19:03 2026","acquiredAt":1789874948676}

package/api/getReport.ts

@@ -25,7 +25,9 @@ type ResponseContent = z.infer<typeof getReportResponseSchema>['response content
 export const response = async (args: string[]) => {
   const [timeStamp = '', jobID = ''] = args;
   const thisHost = getThisHost();
-  // Get the report size.
+  // Get the report size. A malformed timestamp or job ID resolves to a nonexistent file
+  // path, which getReportStats already reports as unavailable, so no separate syntactic
+  // check is needed here.
   const reportStats = await getReportStats(timeStamp, jobID);
   // Create the response content.
   const responseContent: ResponseContent = reportStats

package/api/requestFeature.test.ts

@@ -32,7 +32,27 @@ test('requestFeature rejects an empty feature request', async () => {
   const body = await response(['']);
   const details = body['response content']['details about your request'] as any;
   assert.ok(details.error);
-  assert.ok(!logged.some(line => line.startsWith('WARNING (MCP feature request received)')));
+  assert.ok(
+    !logged.some(line => line.startsWith('WARNING (Kilotest: MCP feature request received)'))
+  );
+});
+
+test('requestFeature rejects a feature request shorter than 20 characters', async () => {
+  const body = await response(['Too short']);
+  const details = body['response content']['details about your request'] as any;
+  assert.ok(details.error.includes('feature description'));
+  assert.ok(
+    !logged.some(line => line.startsWith('WARNING (Kilotest: MCP feature request received)'))
+  );
+});
+
+test('requestFeature rejects a feature request longer than 1000 characters', async () => {
+  const body = await response(['x'.repeat(1001)]);
+  const details = body['response content']['details about your request'] as any;
+  assert.ok(details.error.includes('feature description'));
+  assert.ok(
+    !logged.some(line => line.startsWith('WARNING (Kilotest: MCP feature request received)'))
+  );
 });
 
 test('requestFeature accepts a non-empty feature request and notifies the manager', async () => {
@@ -42,13 +62,13 @@ test('requestFeature accepts a non-empty feature request and notifies the manage
   assert.ok(details['date and time received']);
   assert.equal(details.disposition, 'received and logged; manager notified');
   assert.ok(logged.some(line =>
-    line.startsWith('WARNING (MCP feature request received)')
+    line.startsWith('WARNING (Kilotest: MCP feature request received)')
     && line.includes('Add a dark mode toggle')
   ));
 });
 
 test('requestFeature includes tool name and metadata', async () => {
-  const body = await response(['Some feature']);
+  const body = await response(['A sufficiently long feature description']);
   assert.equal(body['tool name'], 'requestFeature');
   assert.ok(body['response metadata'].identifier);
 });

package/api/requestFeature.ts

@@ -8,6 +8,7 @@
 import {z} from 'zod';
 import {getResponseMetadata, getThisHost, getToolsFacts} from './util.ts';
 import {sendAlert} from '../alerts.ts';
+import {checkLength} from '../util.ts';
 import {requestFeatureResponseSchema} from './schemas.ts';
 
 // TYPES
@@ -21,20 +22,27 @@ type ResponseContent = z.infer<typeof requestFeatureResponseSchema>['response co
 export const response = async (args: string[]) => {
   const [feature = ''] = args;
   const thisHost = getThisHost();
+  const lengthCheck = checkLength(feature, 20, 1000, 'feature description');
   // Initialize the response content.
-  const responseContent: ResponseContent = {
-    'details about your request': {
-      error: 'request invalid: request is empty'
-    }
-  };
-  // If the requested feature or improvement exists:
-  if (feature) {
+  let responseContent: ResponseContent;
+  // If the feature description is invalid:
+  if (lengthCheck.status === 'error') {
+    responseContent = {
+      'details about your request': {
+        error: `request invalid: ${lengthCheck.message}`
+      }
+    };
+  }
+  // Otherwise, i.e. if it is valid:
+  else {
     // Notify the manager.
-    await sendAlert('MCP feature request received', feature);
+    await sendAlert('Kilotest: MCP feature request received', feature);
     // Add the disposition to the response content.
-    responseContent['details about your request'] = {
-      'date and time received': new Date().toISOString(),
-      disposition: 'received and logged; manager notified'
+    responseContent = {
+      'details about your request': {
+        'date and time received': new Date().toISOString(),
+        disposition: 'received and logged; manager notified'
+      }
     };
   }
   // Create a response body.

package/api/requestRetest.test.ts

@@ -15,11 +15,29 @@ import {fixtureDBDir} from '../test/dbFixture.ts';
 
 const savedDBDir = process.env.DB_DIR;
 const testRequestsPath = path.join(fixtureDBDir, 'jobs', 'testRequests.json');
+// A report added only to this test's disposable copy of the fixture database (never to
+// the tracked test/fixtures/db corpus), so its 3-character job ID satisfies isJobID
+// without perturbing report-count tests elsewhere that copy the whole corpus. Its job ID
+// intentionally differs from the tracked corpus's 2-character 260101T0001-ct.json, which
+// isJobID would reject.
+const retestFixturePath = path.join(fixtureDBDir, 'reports', '260101T0003-ret.json');
+const retestFixtureReport = {
+  id: '260101T0003-ret',
+  what: 'Retest Fixture Page',
+  target: {what: 'Retest Fixture Page', url: 'https://example.com/retestfixture'},
+  sources: {worker: 'test-worker'},
+  acts: [],
+  jobData: {startTime: '26-01-01T00:00', endTime: '26-01-01T00:10', elapsedSeconds: 600, preventions: {}, issuelessRules: []},
+  catalog: {},
+  images: {},
+  checkpoints: []
+};
 let logged: any[] = [];
 const originalLog = console.log;
 
-before(() => {
+before(async () => {
   process.env.DB_DIR = fixtureDBDir;
+  await fs.writeFile(retestFixturePath, JSON.stringify(retestFixtureReport));
 });
 
 // Reset the test-requests file and capture console.log, so the alert that
@@ -32,8 +50,9 @@ beforeEach(async () => {
 
 import {response} from './requestRetest.ts';
 
-after(() => {
+after(async () => {
   console.log = originalLog;
+  await fs.unlink(retestFixturePath);
   if (savedDBDir !== undefined) {
     process.env.DB_DIR = savedDBDir;
   }
@@ -45,12 +64,19 @@ after(() => {
 // TESTS
 
 test('requestRetest rejects a nonexistent report', async () => {
-  const body = await response(['999999T9999', 'xyz', 'A reason that is long enough.']);
+  const body = await response(['251231T0000', 'zzz', 'A reason that is long enough.']);
   const details = body['response content']['details about your request'] as any;
   assert.ok(details.error.includes('does not exist'));
   assert.ok(!logged.some(line => line.includes('new retest request awaits approval')));
 });
 
+test('requestRetest rejects a malformed timestamp or job identifier', async () => {
+  const body = await response(['999999T9999', 'xyz', 'A reason that is long enough.']);
+  const details = body['response content']['details about your request'] as any;
+  assert.ok(details.error.includes('malformed'));
+  assert.ok(!logged.some(line => line.includes('new retest request awaits approval')));
+});
+
 test('requestRetest rejects a superseded report', async () => {
   // 260101T0000-mix is an earlier report of "Mixed Outcomes Page" than 260202T0000-new,
   // so it is superseded and processTestRequest returns 'superseded', reported via the
@@ -66,7 +92,7 @@ test('requestRetest rejects a superseded report', async () => {
 });
 
 test('requestRetest rejects a reason shorter than 20 characters', async () => {
-  const body = await response(['260101T0001', 'ct', 'short']);
+  const body = await response(['260101T0003', 'ret', 'short']);
   const details = body['response content']['details about your request'] as any;
   assert.ok(details.error.includes('reason'));
   assert.ok(!logged.some(line => line.includes('new retest request awaits approval')));
@@ -74,20 +100,20 @@ test('requestRetest rejects a reason shorter than 20 characters', async () => {
 
 test('requestRetest rejects a reason longer than 100 characters', async () => {
   const longReason = 'x'.repeat(101);
-  const body = await response(['260101T0001', 'ct', longReason]);
+  const body = await response(['260101T0003', 'ret', longReason]);
   const details = body['response content']['details about your request'] as any;
   assert.ok(details.error.includes('reason'));
   assert.ok(!logged.some(line => line.includes('new retest request awaits approval')));
 });
 
 test('requestRetest rejects a report matching a claimed job by description', async () => {
-  // 260101T0001-ct is the "All CantTell Page" report.
+  // 260101T0003-ret is the "Retest Fixture Page" report.
   const claimedPath = path.join(fixtureDBDir, 'jobs', 'claimed', 'clm.json');
   await fs.writeFile(claimedPath, JSON.stringify({
-    target: {what: 'All CantTell Page', url: 'https://example.com/unrelated'}
+    target: {what: 'Retest Fixture Page', url: 'https://example.com/unrelated'}
   }));
   try {
-    const body = await response(['260101T0001', 'ct', 'A reason that is long enough.']);
+    const body = await response(['260101T0003', 'ret', 'A reason that is long enough.']);
     const details = body['response content']['details about your request'] as any;
     assert.equal(details.error, undefined);
     const disposition = body['response content']['disposition of your request'] as any;
@@ -102,13 +128,13 @@ test('requestRetest rejects a report matching a claimed job by description', asy
 });
 
 test('requestRetest rejects a report matching a queued job by URL', async () => {
-  // 260101T0001-ct's URL is https://example.com/canttell.
+  // 260101T0003-ret's URL is https://example.com/retestfixture.
   const queuedPath = path.join(fixtureDBDir, 'jobs', 'queue', 'que.json');
   await fs.writeFile(queuedPath, JSON.stringify({
-    target: {what: 'Some Other Page', url: 'https://example.com/canttell'}
+    target: {what: 'Some Other Page', url: 'https://example.com/retestfixture'}
   }));
   try {
-    const body = await response(['260101T0001', 'ct', 'A reason that is long enough.']);
+    const body = await response(['260101T0003', 'ret', 'A reason that is long enough.']);
     const details = body['response content']['details about your request'] as any;
     assert.equal(details.error, undefined);
     const disposition = body['response content']['disposition of your request'] as any;
@@ -123,8 +149,8 @@ test('requestRetest rejects a report matching a queued job by URL', async () =>
 });
 
 test('requestRetest rejects a duplicate request', async () => {
-  await response(['260101T0001', 'ct', 'A reason that is long enough.']);
-  const body = await response(['260101T0001', 'ct', 'A reason that is long enough.']);
+  await response(['260101T0003', 'ret', 'A reason that is long enough.']);
+  const body = await response(['260101T0003', 'ret', 'A reason that is long enough.']);
   const details = body['response content']['details about your request'] as any;
   assert.equal(details.error, undefined);
   const disposition = body['response content']['disposition of your request'] as any;

package/api/requestRetest.ts

@@ -7,7 +7,7 @@
 
 import {z} from 'zod';
 import {getResponseMetadata, getThisHost, getToolsFacts} from './util.ts';
-import {processTestRequest} from '../util.ts';
+import {checkLength, isJobID, isTimeStamp, processTestRequest} from '../util.ts';
 import {requestRetestResponseSchema} from './schemas.ts';
 
 // TYPES
@@ -21,14 +21,20 @@ type ResponseContent = z.infer<typeof requestRetestResponseSchema>['response con
 export const response = async (args: string[]) => {
   const [timeStamp = '', jobID = '', reason = ''] = args;
   const thisHost = getThisHost();
-  const reasonLength = reason.length;
+  const reasonCheck = checkLength(reason, 20, 100, 'reason');
   // Initialize the response-content properties.
   let requestDetails: ResponseContent['details about your request'];
   let requestDisposition: ResponseContent['disposition of your request'] = null;
-  // If the encoded reason is too short or too long:
-  if (reasonLength < 20 || reasonLength > 100) {
+  // If the timestamp or job ID is not syntactically valid:
+  if (!isTimeStamp(timeStamp) || !isJobID(jobID)) {
     requestDetails = {
-      error: 'request invalid: your reason is not between 20 and 100 characters long'
+      error: 'request invalid: the report timestamp or job identifier is malformed'
+    };
+  }
+  // Otherwise, if the encoded reason is too short or too long:
+  else if (reasonCheck.status === 'error') {
+    requestDetails = {
+      error: `request invalid: your ${reasonCheck.message}`
     }
   }
   // Otherwise, i.e. if the request is facially valid:

package/api/requestTest.ts

@@ -7,7 +7,7 @@
 
 import {z} from 'zod';
 import {getResponseMetadata, getThisHost, getToolsFacts} from './util.ts';
-import {isURL, processTestRequest} from '../util.ts';
+import {checkLength, isURL, processTestRequest} from '../util.ts';
 import {requestTestResponseSchema} from './schemas.ts';
 
 // TYPES
@@ -24,14 +24,14 @@ export const response = async (args: string[]) => {
   // Initialize the response-content properties.
   let requestDetails: ResponseContent['details about your request'];
   let requestDisposition: ResponseContent['disposition of your request'] = null;
-  const descriptionLength = description.length;
-  // If the description is empty or too long:
-  if (!descriptionLength || descriptionLength > 100) {
+  const descriptionCheck = checkLength(description, 1, 100, 'description of the page');
+  // If the description is invalid:
+  if (descriptionCheck.status === 'error') {
     requestDetails = {
-      error: 'request invalid: your description of the page is not between 1 and 100 characters long'
+      error: `request invalid: your ${descriptionCheck.message}`
     };
   }
-  // Otherwise, i.e. if the URL is too short or too long::
+  // Otherwise, i.e. if the URL is too short or too long:
   else if (url.length < 12 || url.length > 300) {
     requestDetails = {
       error: 'request invalid: you specified a URL for the page that is not between 12 and 300 characters long'

package/api/schemas.ts

@@ -43,7 +43,7 @@ export const getReportSchema = {
 
 // requestTest: POST /api/requestTest
 export const requestTestSchema = {
-  description: z.string().describe('10- to 100-character description of the page conforming to the naming convention used in the listReports output'),
+  description: z.string().describe('1- to 100-character description of the page conforming to the naming convention used in the listReports output'),
   URL: z.string().describe('12- to 300-character URL of the page, including the https:// scheme and any query'),
   reason: z.string().describe('20- to 100-character reason why the page should be tested')
 };
@@ -57,7 +57,7 @@ export const requestRetestSchema = {
 
 // requestFeature: POST /api/requestFeature
 export const requestFeatureSchema = {
-  feature: z.string().describe('description of requested feature improvement or new feature')
+  feature: z.string().describe('20- to 1000-character description of requested feature improvement or new feature')
 };
 
 // listReports takes no input; omitted (mcp.ts already uses inputSchema: {}).