@jrpool/kilotest 45.0.4 → 45.0.6

package/api/listDiagnoses.js

@@ -6,7 +6,7 @@
 // IMPORTS
 
 const {
-  getIssueClassification,
+  getIssueSpec,
   getReportBasics,
   getResponseMetadata,
   getToolsFacts,
@@ -41,10 +41,10 @@ exports.response = async args => {
     // Add them to the response content.
     responseContent['basics about the report'] = reportBasics;
   }
-  // Get the classification of the issue.
-  const issueClassification = issueID ? getIssueClassification(issueID) : null;
+  // Get the specification of the issue.
+  const issueSpec = issueID ? getIssueSpec(issueID) : null;
   // If the issue is ignorable or not fully classified:
-  if (!issueClassification) {
+  if (!issueSpec) {
     // Add this to the response content.
     responseContent['basics about the issue'] = {
       'error': 'No information about the specified issue is available'
@@ -55,7 +55,7 @@ exports.response = async args => {
   }
   // Otherwise, i.e. if it is non-ignorable and fully classified:
   else {
-    const {summary, wcag, weight, why} = issueClassification;
+    const {summary, wcag, weight, why} = issueSpec;
     // Initialize the basics about it.
     const issueBasics = {
       'identifier': issueID,
@@ -99,7 +99,7 @@ exports.response = async args => {
       // Add them to the response content.
       responseContent['details about the element'] = violatorDetails;
       // If the issue is non-ignorable and fully classified:
-      if (issueClassification) {
+      if (issueSpec) {
         // Initialize data about the diagnoses of the violation of the issue.
         const diagnoses = [];
         // For each act in the report:

package/api/listIssues.js

@@ -6,7 +6,7 @@
 // IMPORTS
 
 const {
-  getIssueClassification,
+  getIssueSpec,
   getReportBasics,
   getResponseMetadata,
   getRuleEngineFacts,
@@ -76,11 +76,11 @@ exports.response = async args => {
           // For each standard instance of the act:
           instances.forEach(instance => {
             const {catalogIndex, issueID} = instance;
-            // Get the classification of its issue.
-            const issueClassification = issueID ? getIssueClassification(issueID) : null;
+            // Get the specification of its issue.
+            const issueSpec = issueID ? getIssueSpec(issueID) : null;
             // If the instance has a non-ignorable and fully classified issue:
-            if (issueClassification) {
-              const {summary, weight, why} = issueClassification;
+            if (issueSpec) {
+              const {summary, weight, why} = issueSpec;
               // Ensure the rule-engine ID is in the reporters data.
               reporterIDs.add(which);
               // If the instance has a catalog index:

package/api/listViolators.js

@@ -6,7 +6,7 @@
 // IMPORTS
 
 const {
-  getIssueClassification,
+  getIssueSpec,
   getReportBasics,
   getResponseMetadata,
   getRuleEnginesFacts,
@@ -41,10 +41,10 @@ exports.response = async args => {
     // Add them to the response content.
     responseContent['basics about the report'] = reportBasics;
   }
-  // Get the classification of the issue.
-  const issueClassification = issueID ? getIssueClassification(issueID) : null;
+  // Get the specification of the issue.
+  const issueSpec = issueID ? getIssueSpec(issueID) : null;
   // If the issue is ignorable or not fully classified:
-  if (!issueClassification) {
+  if (!issueSpec) {
     // Add this to the response content.
     responseContent['basics about the issue'] = {
       'error': 'No information about the specified issue is available'
@@ -52,7 +52,7 @@ exports.response = async args => {
   }
   // Otherwise, i.e. if it is non-ignorable and fully classified:
   else {
-    const {summary, wcag, weight, why} = issueClassification;
+    const {summary, wcag, weight, why} = issueSpec;
     // Initialize the basics and details about it.
     const issueBasics = {
       'identifier': issueID,

package/api/requestRetest.js

@@ -6,7 +6,7 @@
 // IMPORTS
 
 const {getResponseMetadata, getToolsFacts, processTestRequest, thisHost} = require('./util');
-const {getReportsExtract} = require('../util');
+const {getLatestReportExtracts, getReportsExtract} = require('../util');
 
 // FUNCTIONS
 
@@ -35,10 +35,8 @@ exports.response = async args => {
   }
   // Otherwise, if the report has been superseded:
   else if (
-    Object
-    .values(reportsExtract)
-    .filter(extract => extract.what === what && extract.url === url)
-    .length > 1
+    (await getLatestReportExtracts())
+    .every(extract => extract.timeStamp !== timeStamp || extract.jobID !== jobID)
   ) {
     // Add this to the response content.
     responseContent['details about your request'] = {

package/api/testSuite.js

@@ -137,6 +137,8 @@ const requestService = async () => {
   const reportsBasicsIndex = Math.floor(reportsBasics.length * Math.random());
   // Choose one report at random.
   reportBasics = reportsBasics[reportsBasicsIndex];
+  // Get whether the report has been superseded by a later report about the same page.
+  const isSuperseded = reportBasics['whether a later report about the same page exists'];
   [timeStamp, jobID] = reportBasics.identifier?.split('-') || [null, null];
   if (!(timeStamp && jobID)) {
     console.log(`reportBasicsIndex: ${reportsBasicsIndex}`);
@@ -263,13 +265,24 @@ const requestService = async () => {
   responseContent = body?.['response content'] ?? {};
   requestDetails = responseContent['details about your request'] ?? {};
   requestDisposition = responseContent['disposition of your request'] ?? {};
-  if (
-    !requestDetails['reason why the page should be retested']
-    || !requestDisposition['how you can check for completion']
-  ) {
-    console.log(`requestDetails: ${JSON.stringify(requestDetails, null, 2)}`);
-    console.log(`requestDisposition: ${JSON.stringify(requestDisposition, null, 2)}`);
-    return;
+  // If the report has been superseded:
+  if (isSuperseded) {
+    // Expect the request to be rejected.
+    if (!requestDetails.error?.includes('a later report about the page exists')) {
+      console.log(`requestDetails: ${JSON.stringify(requestDetails, null, 2)}`);
+      return;
+    }
+  }
+  // Otherwise, i.e. if the report has not been superseded:
+  else {
+    if (
+      !requestDetails['reason why the page should be retested']
+      || !requestDisposition['how you can check for completion']
+    ) {
+      console.log(`requestDetails: ${JSON.stringify(requestDetails, null, 2)}`);
+      console.log(`requestDisposition: ${JSON.stringify(requestDisposition, null, 2)}`);
+      return;
+    }
   }
   console.log('======================\nRequest: Make a feature request');
   path = '/api/requestFeature';

package/api/util.js

@@ -14,11 +14,11 @@ const {
   getRandomString,
   getReportExtract,
   getReportStats,
-  issuesClassification,
   objectSort,
   ruleEngines,
   updateRecs
 } = require('../util');
+const {issues: issueSpecs} = require('testaro-issues');
 
 // CONSTANTS
 
@@ -107,24 +107,21 @@ exports.getReportBasics = async (timeStamp, jobID) => {
   return basics;
 };
 // Returns the classification of an issue.
-exports.getIssueClassification = issueID => {
-  // Get the issue classification.
-  const issueClassification = issuesClassification[issueID] ?? {};
-  const {summary, wcag, weight, why} = issueClassification;
-  // If the issue is non-ignorable and fully classified:
-  if (
-    issueID
-    && issueID !== 'ignorable'
-    && issueClassification
-    && summary
-    && wcag
-    && [1, 2, 3, 4].includes(weight)
-    && why
-  ) {
-    // Return the classification.
-    return issueClassification;
+exports.getIssueSpec = issueID => {
+  // Get the issue specification.
+  const issueSpec = issueSpecs[issueID];
+  // If it exists:
+  if (issueSpec) {
+    const {summary, wcag, weight, why} = issueSpec;
+    // If the issue is non-ignorable and fully classified:
+    if (issueID !== 'ignorable' && summary && wcag && [1, 2, 3, 4].includes(weight) && why) {
+      // Return its specification.
+      return issueSpec;
+    }
+    // Otherwise, return this.
+    return null;
   }
-  // Otherwise, i.e. if it is ignorable or not fully classified, return this.
+  // Otherwise, i.e. if it does not exist, return this.
   return null;
 };
 // Processes a test or retest request.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jrpool/kilotest",
-  "version": "45.0.4",
+  "version": "45.0.6",
   "description": "Ensemble testing for front-end web quality",
   "main": "index.js",
   "engines": {

package/util.js

@@ -560,9 +560,9 @@ exports.getReportData = async (timeStamp, jobID) => {
       const instances = result?.standardResult?.instances ?? [];
       // For each standard instance of the act:
       instances.forEach(instance => {
-        const {catalogIndex, issueID} = instance;
-        // If it has a non-ignorable classified issue ID:
-        if (issueID && issueSpecs[issueID] && issueID !== 'ignorable') {
+        const {catalogIndex, issueID, outcome} = instance;
+        // If it reports a violation and has a non-ignorable classified issue ID:
+        if (outcome !== 'cantTell' && issueID && issueSpecs[issueID] && issueID !== 'ignorable') {
           // Ensure that the rule engine is in the temporary data.
           reporterIDSet.add(which);
           // Ensure that the issue is in the temporary data.