@jphutchins/code-review 0.1.0-alpha.68 → 0.1.0-alpha.69

package/README.md

@@ -38,10 +38,10 @@ npx @jphutchins/code-review <subcommand>
 | Subcommand | What it does |
 | --- | --- |
 | `post` | Post a complete review from findings + envelope + diff — the one-call path. The findings are listed in the sticky summary; `--inline` renders the in-diff ones as comments on the diff instead. Also renders the review into `$GITHUB_STEP_SUMMARY`: the sticky is overwritten each round, the run summary keeps each round as it stood |
-| `gather` | Resolve the PR from the CI head SHA and gather the review inputs (diff with git-diff fallback, PR context, prior bot review, the implementer's answers (`Review-Response:` lines and verdict tables), the CI run's job logs — the failing jobs' on a failure, the jobs that ran, up to 64, on a pass) into the directory named by `--out-dir` (default: the current directory; the shipped workflows use `$RUNNER_TEMP/gather`) |
+| `gather` | Resolve the PR from the CI head SHA and gather the review inputs (diff with git-diff fallback, PR context, prior bot review, the implementer's answers (`Review-Response:` lines and verdict tables), the CI run's job logs — the failing jobs', up to 20, on a failure, the jobs that ran, up to 64, on a pass) into the directory named by `--out-dir` (default: the current directory; the shipped workflows use `$RUNNER_TEMP/gather`) |
 | `parse-command` | Resolve a PR's head from its number and parse a ChatOps trigger comment (`/code-review [24m] [$1.00] <instructions>`) into review overrides — the on-demand comment trigger |
 | `react` | Add/remove a GitHub comment reaction — the ChatOps acknowledgement (👀 on receipt, 🚀 on completion) |
-| `await-ci` | Wait for a PR head's CI run to conclude and emit its real conclusion + run id — so an on-demand comment review routes on the CI result (success → full, failure → mechanic) instead of reviewing blind |
+| `await-ci` | Wait for a PR head's CI run to conclude and emit its real conclusion, run id and run attempt — so an on-demand comment review routes on the CI result (success → full, failure → mechanic) instead of reviewing blind |
 | `check-scope` | Validate + normalize the workflow's `scope` input (the languages/inputs the project accepts) and print the normalized list for the review prompt, or nothing when empty (the reviewer then infers scope from the README's first paragraph); a structurally malformed value is rejected rather than spliced in as-is |
 | `render` | Render the sticky-comment markdown from findings + usage + prices |
 | `inline` | Build the GitHub reviews `comments[]` payload from findings + diff (in-diff validation; strays demote to the summary) |

package/dist/index.js

@@ -5152,6 +5152,8 @@ stacked=${String(result.stacked)}
 base_sha=${result.baseSha}
 staged_job_logs=${String(result.stagedJobLogs)}
 failing_jobs=${String(result.failingJobs)}
+ci_jobs_passed=${result.passedJobs === null ? "" : String(result.passedJobs.passed)}
+ci_jobs_ran=${result.passedJobs === null ? "" : String(result.passedJobs.ran)}
 `;
   }
 };
@@ -5189,14 +5191,17 @@ var IssueCommentCodec = t.intersection([
     author_association: t.union([t.string, t.null])
   })
 ]);
-var JobCodec = t.type({
-  id: t.number,
-  // A null name (an API edge) degrades to a nameless entry rather than aborting the whole gather —
-  // the identity the reproduction steer needs is best-effort, never load-bearing.
-  name: t.union([t.string, t.null]),
-  conclusion: t.union([t.string, t.null])
-});
-var JOBS_JQ = ".jobs[] | {id: .id, name: .name, conclusion: .conclusion}";
+var JobCodec = t.intersection([
+  t.type({
+    id: t.number,
+    // A null name (an API edge) degrades to a nameless entry rather than aborting the whole gather —
+    // the identity the reproduction steer needs is best-effort, never load-bearing.
+    name: t.union([t.string, t.null]),
+    conclusion: t.union([t.string, t.null])
+  }),
+  t.partial({ steps: t.array(t.string) })
+]);
+var JOBS_JQ = ".jobs[] | {id: .id, name: .name, conclusion: .conclusion, steps: [.steps[]? | .name? | strings]}";
 var parseRunAttempt = (raw) => {
   if (raw === void 0 || raw === "") return void 0;
   if (!/^[1-9][0-9]*$/.test(raw)) {
@@ -5433,6 +5438,7 @@ var stagePassedRun = async (repo, runId, runAttempt, outDir, ghApi) => {
           jobs.map((j) => ({
             name: j.name,
             conclusion: j.conclusion,
+            steps: j.steps ?? [],
             log: logs2.get(j.id) ?? null
           })),
           null,
@@ -5464,13 +5470,19 @@ var stagePassedRun = async (repo, runId, runAttempt, outDir, ghApi) => {
 `
       );
     }
-    return logs.size;
+    return {
+      staged: logs.size,
+      passed: {
+        passed: jobs.filter((j) => j.conclusion === "success").length,
+        ran: ran.length
+      }
+    };
   } catch (err) {
     process.stderr.write(
-      `::warning::${annotationSafe(`the passed CI run's jobs could not be listed (${errMsg(err)}) \u2014 the review knows CI passed, not which jobs ran`)}
+      `::warning::${annotationSafe(`the passed CI run's jobs could not be staged (${errMsg(err)}) \u2014 the review knows CI passed, not what its jobs reported`)}
 `
     );
-    return 0;
+    return { staged: 0, passed: null };
   }
 };
 var gather = async (input, ghApi = runGhApi, gitRun = runGit, readArtifact = ghArtifactReader) => {
@@ -5577,7 +5589,7 @@ var gather = async (input, ghApi = runGhApi, gitRun = runGit, readArtifact = ghA
     })
   );
   const jobLogs = input.conclusion === "failure" ? await downloadFailingJobLogs(input.repo, input.runId, input.runAttempt, input.outDir, ghApi) : { staged: 0, failing: 0 };
-  const passedLogs = input.conclusion === "success" ? await stagePassedRun(input.repo, input.runId, input.runAttempt, input.outDir, ghApi) : 0;
+  const passedRun = input.conclusion === "success" ? await stagePassedRun(input.repo, input.runId, input.runAttempt, input.outDir, ghApi) : { staged: 0, passed: null };
   return {
     kind: "gathered",
     pr: prNumber,
@@ -5585,8 +5597,9 @@ var gather = async (input, ghApi = runGhApi, gitRun = runGit, readArtifact = ghA
     diffSize: Buffer.byteLength(prDiff, "utf8"),
     stacked,
     baseSha: meta.base_sha,
-    stagedJobLogs: jobLogs.staged + passedLogs,
-    failingJobs: jobLogs.failing
+    stagedJobLogs: jobLogs.staged + passedRun.staged,
+    failingJobs: jobLogs.failing,
+    passedJobs: passedRun.passed
   };
 };