@jphutchins/code-review 0.1.0-alpha.66 → 0.1.0-alpha.67

package/dist/index.js

@@ -70,6 +70,11 @@ var LineNumber = t.refinement(
   "LineNumber"
 );
 var Confidence = t.refinement(t.number, (n) => n >= 0 && n <= 1, "Confidence");
+var NonEmptyString = t.refinement(
+  t.string,
+  (s) => s.trim().length > 0,
+  "NonEmptyString"
+);
 var Likelihood = t.refinement(t.number, (n) => n >= 0 && n <= 1, "Likelihood");
 var FiniteNumber = t.refinement(t.number, (n) => Number.isFinite(n), "FiniteNumber");
 var NonNegativePrice = t.refinement(t.number, (n) => n >= 0, "NonNegativePrice");
@@ -236,7 +241,8 @@ var FindingsCodec = t.exact(
       // Pipeline-stamped only (issue #174); see ConvergenceCodec.
       convergence: ConvergenceCodec,
       // Agent-written best-effort (issue #182); see ChangeSizeCodec.
-      change_size: ChangeSizeCodec
+      change_size: ChangeSizeCodec,
+      unfinished: t.array(NonEmptyString)
     })
   ])
 );
@@ -246,8 +252,31 @@ var PIPELINE_STAMPED_FIELDS = /* @__PURE__ */ new Set([
 ]);
 var RECOVERABLE_OPTIONAL_FIELDS = /* @__PURE__ */ new Set([
   ...PIPELINE_STAMPED_FIELDS,
-  "change_size"
+  "change_size",
+  "unfinished"
 ]);
+var withoutBrokenOptionalFields = (doc, accepts) => {
+  const bare = Object.fromEntries(
+    Object.entries(doc).filter(([key2]) => !RECOVERABLE_OPTIONAL_FIELDS.has(key2))
+  );
+  if (!accepts(bare)) return null;
+  const usable = (kept, key2, value) => {
+    if (accepts({ ...kept, [key2]: value })) return value;
+    if (!Array.isArray(value)) return void 0;
+    const entries = value.filter((entry) => accepts({ ...kept, [key2]: [entry] }));
+    return entries.length > 0 && accepts({ ...kept, [key2]: entries }) ? entries : void 0;
+  };
+  const restored = Object.entries(doc).filter(([key2]) => RECOVERABLE_OPTIONAL_FIELDS.has(key2)).reduce((kept, [key2, value]) => {
+    const restoredValue = usable(kept, key2, value);
+    return restoredValue === void 0 ? kept : { ...kept, [key2]: restoredValue };
+  }, bare);
+  return {
+    doc: restored,
+    stripped: Object.keys(doc).filter(
+      (key2) => !Object.hasOwn(restored, key2) || restored[key2] !== doc[key2]
+    )
+  };
+};
 var ID_SHAPE_RE = /^[A-Za-z0-9][A-Za-z0-9_-]*$/;
 var priorIdsFrom = (doc) => {
   if (typeof doc !== "object" || doc === null || Array.isArray(doc)) return [];
@@ -1939,6 +1968,19 @@ var overruledReRaiseNote = (entries, count) => entries.length === 0 ? "" : [
 // src/render.ts
 var escapePipes = (text) => text.replace(/\|/g, "\\|");
 var shedNote = (count, summaryAvailable, runUrl, findingsDocLinked, thisRunArtifact) => count === 0 ? "" : `<sub>**${String(count)} finding${count === 1 ? "" : "s"} left out of this comment**${summaryAvailable && runUrl !== void 0 ? ` \u2014 the [run summary](<${runUrl}>) carries the whole review` : findingsDocLinked && thisRunArtifact ? " \u2014 the machine findings document carries them" : ""}.</sub>`;
+var UNFINISHED_SHOWN = 8;
+var UNFINISHED_CLIP_CHARS = 240;
+var unfinishedLine = (check) => {
+  const escaped = escapeHtml(check.replace(/\s+/g, " ").trim());
+  return escaped.length > UNFINISHED_CLIP_CHARS ? `${escaped.slice(0, UNFINISHED_CLIP_CHARS).replace(/&[#a-z0-9]*$/i, "").replace(/[\uD800-\uDBFF]$/, "")}\u2026` : escaped;
+};
+var shownUnfinished = (doc, fullReviewRound) => {
+  const checks = fullReviewRound ? doc.unfinished ?? [] : [];
+  return [
+    ...checks.slice(0, UNFINISHED_SHOWN).map(unfinishedLine),
+    ...checks.length > UNFINISHED_SHOWN ? [`\u2026 and ${String(checks.length - UNFINISHED_SHOWN)} more`] : []
+  ];
+};
 var terminalNotice = (i) => [
   `## ${i.verdictBadge}`,
   "",
@@ -1950,6 +1992,7 @@ var terminalNotice = (i) => [
   ] : [],
   "",
   `> **The review for \`${escapeCodeBackticks(i.reviewedSha.slice(0, 7))}\` exceeds GitHub's comment-size limit.**` + (i.summaryAvailable ? i.runUrl ? ` The whole review lives in the [run summary](<${i.runUrl}>).` : " The whole review lives in the workflow run's summary." : i.findingsDocLinked && i.thisRunArtifact ? " The whole review lives in the machine findings document." : "") + (i.findingsDocLinked && i.thisRunArtifact ? " The machine findings document is linked above." : ""),
+  ...i.unfinished.length > 0 ? ["", `> **Unfinished checks:** ${i.unfinished.join(" \xB7 ")}`] : [],
   "",
   "> [!WARNING]",
   `> **LLM Disclosure** \u2014 this review was produced by ${i.modelNames || "unknown model"}.`,
@@ -2113,6 +2156,8 @@ var render = (input) => {
   const trajectory = convergence?.rounds ?? input.rounds ?? [];
   const sameRootNotes = input.sameRootNotes ?? computeSameRootNotes(trajectory.slice(0, -1), input.findings.findings);
   const isFullReviewRound = (input.convergenceRound ?? (isConvergenceRound(route, incomplete) && trajectory.length > 0)) && isReviewVerdict(input.findings.verdict);
+  const unfinished = input.findings.unfinished ?? [];
+  const unfinishedSuffix = unfinished.length > 0 ? ` \xB7 ${String(unfinished.length)} unfinished check${unfinished.length === 1 ? "" : "s"}` : "";
   const contestedSuffix = (input.contested ?? []).length > 0 ? ` \xB7 ${String((input.contested ?? []).length)} contested` : "";
   const advisoryAllowed = isFullReviewRound;
   const discussionLinksFor = (id) => input.discussionByFinding !== void 0 && Object.prototype.hasOwnProperty.call(input.discussionByFinding, id) ? input.discussionByFinding[id] ?? [] : [];
@@ -2257,12 +2302,13 @@ var render = (input) => {
       input.jsonUrl !== void 0
     ),
     terminalNotice: terminalNotice({
+      unfinished: shownUnfinished(input.findings, isFullReviewRound),
       reviewedSha: input.reviewedSha ?? "0000000000000000000000000000000000000000",
       verdictBadge: verdictBadge(input.findings.verdict),
       route: route ?? void 0,
       postedAt: input.postedAt ?? "",
       roundsSummary: roundsSummary(trajectory, input.roundCount),
-      convergenceSummary: !isFullReviewRound ? "" : convergence ? convergenceBadge(convergence) + contestedSuffix : "",
+      convergenceSummary: !isFullReviewRound ? "" : convergence ? convergenceBadge(convergence) + contestedSuffix + unfinishedSuffix : "",
       inlinePosted: input.inlineDisposition?.kind === "posted" ? input.inlineDisposition.count : 0,
       runUrl: input.runUrl,
       summaryAvailable: input.summaryAvailable ?? false,
@@ -2289,7 +2335,7 @@ var render = (input) => {
     reviewedSha: input.reviewedSha ?? "0000000000000000000000000000000000000000",
     postedAt: input.postedAt ?? "",
     severityCounts,
-    convergenceSummary: !isFullReviewRound ? "" : (convergence ? convergenceBadge(convergence) : convergenceSummary(input.findings, input.convergenceThreshold)) + contestedSuffix,
+    convergenceSummary: !isFullReviewRound ? "" : (convergence ? convergenceBadge(convergence) : convergenceSummary(input.findings, input.convergenceThreshold)) + contestedSuffix + unfinishedSuffix,
     strays: discussionBudget.kept,
     orphanedLines: orphanedRender.lines,
     orphanedUnresolvable: input.orphanedUnresolvable === true,
@@ -2326,6 +2372,7 @@ var render = (input) => {
     answeredNotes: input.answeredNotes ?? {},
     answeredReRaiseNote: input.answeredReRaiseNote ?? "",
     contested: contestedBudget.kept,
+    unfinished: shownUnfinished(input.findings, isFullReviewRound),
     reviewUrl: input.reviewUrl ?? null,
     formatTokens: (n) => Number.isFinite(n) && n >= 0 ? n.toLocaleString("en-US") : "\u2014",
     // N/A (never a false $0.00) when no real price map was provided — real tokens, no rates to
@@ -2740,8 +2787,8 @@ var spendClause = (i) => i.spentUsd === null ? null : i.budgetUsd !== null && i.
 var timeClause = (i) => i.elapsedMs === null ? null : i.wallMs !== null && i.wallMs > 0 ? `${mins(i.elapsedMs)}/${mins(i.wallMs)} elapsed (${pct(i.elapsedMs / i.wallMs)})` : `${mins(i.elapsedMs)} elapsed`;
 var directive = (phase, draftPath, isSubagent) => {
   if (isSubagent)
-    return phase.kind === "hard" ? `Budget nearly exhausted \u2014 STOP all new investigation now and report the findings you have back to the main agent in your reply. Do not write ${draftPath} yourself; only the main agent writes it.` : `Wind down investigation and report the findings you have back to the main agent in your reply \u2014 do not write ${draftPath} yourself; the main agent writes it, and you may run out of budget otherwise.`;
-  return phase.kind === "hard" ? `Budget nearly exhausted \u2014 STOP all new investigation now. Do not wait for subagents still running in the background. Write your COMPLETE findings from what you already have to ${draftPath} and run \`code-review validate ${draftPath} --explain\` until it passes (--explain prints the exact schema when the shape is wrong). Other tools are blocked until that draft is written.` : `Wind down investigation and write your COMPLETE findings to ${draftPath} now, then run \`code-review validate ${draftPath} --explain\` (it prints the exact schema if the shape is wrong) \u2014 fold in the subagent reports you already have rather than waiting on stragglers; you may run out of budget before you finish otherwise.`;
+    return phase.kind === "hard" ? `Budget nearly exhausted \u2014 STOP all new investigation now and report the findings you have back to the main agent in your reply, naming each check you planned but did not finish. Do not write ${draftPath} yourself; only the main agent writes it.` : `Wind down investigation and report the findings you have back to the main agent in your reply, naming each check you planned but did not finish \u2014 do not write ${draftPath} yourself; the main agent writes it, and you may run out of budget otherwise.`;
+  return phase.kind === "hard" ? `Budget nearly exhausted \u2014 STOP all new investigation now. Do not wait for subagents still running in the background. Write your COMPLETE findings from what you already have to ${draftPath}, listing in its \`unfinished\` field, when its schema has one, every check you or a subagent planned but did not finish, and run \`code-review validate ${draftPath} --explain\` until it passes (--explain prints the exact schema when the shape is wrong). Other tools are blocked until that draft is written.` : `Wind down investigation and write your COMPLETE findings to ${draftPath} now, listing in its \`unfinished\` field, when its schema has one, every check you or a subagent planned but did not finish, then run \`code-review validate ${draftPath} --explain\` (it prints the exact schema if the shape is wrong) \u2014 fold in the subagent reports you already have rather than waiting on stragglers; you may run out of budget before you finish otherwise.`;
 };
 var budgetMessage = (i, phase, draftPath, isSubagent) => {
   const status = [spendClause(i), timeClause(i)].filter((c) => c !== null).join(" \xB7 ");
@@ -3333,15 +3380,16 @@ var loadFindings = (path) => {
   }
   const first = decodeFindings(raw);
   if (first.kind === "invalid-shape" && typeof raw === "object" && raw !== null && !Array.isArray(raw) && Object.keys(raw).some((k) => RECOVERABLE_OPTIONAL_FIELDS.has(k))) {
-    const stripped = Object.fromEntries(
-      Object.entries(raw).filter(([key2]) => !RECOVERABLE_OPTIONAL_FIELDS.has(key2))
+    const recovered = withoutBrokenOptionalFields(
+      raw,
+      (candidate) => decodeFindings(candidate).kind === "ok"
     );
-    const retry = decodeFindings(stripped);
-    if (retry.kind === "ok") {
+    if (recovered !== null) {
       process.stderr.write(
-        "Warning: the review draft carried an invalid best-effort field (convergence/scope_metastasis/change_size) \u2014 stripped it and used the rest; the pipeline re-stamps convergence\n"
+        `Warning: the review draft carried an invalid best-effort field (${recovered.stripped.join("/")}) \u2014 stripped it and used the rest; the pipeline re-stamps convergence
+`
       );
-      return retry;
+      return decodeFindings(recovered.doc);
     }
   }
   return first;
@@ -4304,6 +4352,7 @@ ${findingsPointer2}`
     ] : [],
     "",
     terminalNotice({
+      unfinished: [],
       reviewedSha: input.headSha,
       verdictBadge: verdictBadge(loadedFindings.verdict),
       route: route ?? void 0,
@@ -6619,11 +6668,6 @@ var seedDraftCmd = defineCommand({
     const seededFromPrior = priorFindings === null ? false : (() => {
       try {
         const schemaPath = args.schema ? resolve(args.schema) : schemaPathFor(kind, args["schema-version"]);
-        const barePrior = typeof priorFindings === "object" && !Array.isArray(priorFindings) ? Object.fromEntries(
-          Object.entries(priorFindings).filter(
-            ([key2]) => !RECOVERABLE_OPTIONAL_FIELDS.has(key2)
-          )
-        ) : priorFindings;
         const accepts = (doc) => {
           const resolved = resolvedPriorValue(doc);
           if (resolved === null) return null;
@@ -6631,13 +6675,18 @@ var seedDraftCmd = defineCommand({
           return validateAgainstSchema(carried, schemaPath).valid ? carried : null;
         };
         const seedDoc = accepts(priorFindings) ?? (() => {
-          const bare = accepts(barePrior);
-          if (bare === null) return null;
+          if (typeof priorFindings !== "object" || Array.isArray(priorFindings))
+            return null;
+          const recovered = withoutBrokenOptionalFields(
+            priorFindings,
+            (candidate) => accepts(candidate) !== null
+          );
+          if (recovered === null) return null;
           process.stderr.write(
-            `Note: the in-force schema rejects a carried recoverable field (scope_metastasis/convergence/change_size) \u2014 seeding the prior without it (issue #150 review r2 / #182 review r2)
+            `Note: the in-force schema rejects a carried recoverable field (${recovered.stripped.join("/")}) \u2014 seeding the prior without it (issue #150 review r2 / #182 review r2)
 `
           );
-          return bare;
+          return accepts(recovered.doc);
         })();
         if (seedDoc === null) return false;
         if (isIncompleteFindings(seedDoc)) return false;